this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |6 ++
1 files changed, 2 insertions(+), 4 deletions
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's
registers.
Where does the iounmap() now get done instead of that place?
nowhere, the /proc/iomem still shows that sata_mv uses io mempry
Mmm.. sounds like a bug to me. Possibly two bugs:
1. the ioremap() should fail if the range is already mapped, and
2. we should free the resources on module unload.
I suppose this would be mostly automatic if the code simply
were to use devm_ioremap() instead of ioremap().
my
this fixes crash bug as the iomap table is not valid for integrated controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 04b5717..9c9a5b0
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff
Mark Lord wrote:
Byron Bradley wrote:
I'm having problems getting the sata_mv driver working as a platform
driver on the QNAP TS-209 and the Linkstation/Kurobox (both are Marvell
Orion 88f5182 based devices). First of all it would oops in
mv_port_start() while calling dma_pool_alloc(), the
host-private_data = hpriv;
hpriv-n_ports = n_ports;
-host-iomap = NULL;
hpriv-base = ioremap(res-start, res-end - res-start + 1);
+host-iomap = hpriv-base;
hpriv-base -= MV_SATAHC0_REG_BASE;
rc = mv_create_dma_pools(hpriv, pdev-dev);
..
Well, that's
Unless Paul M objects (pata_platform maintainer), I will rename
linux/pata_platform.h to linux/ata_platform.h, and we can put your
mv_sata_platform_data structure in there.
seems better idea.
now I have a patch for the arm subsystem that depends on this patch,
how can I make sure that the new
From: Saeed Bishara [EMAIL PROTECTED]
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv
driver to support those controllers.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c | 365
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/Kconfig |2 +-
drivers/ata
Hi Jeff,
what is the status of this patch?
I'd like to have this patch, and a second part that adds support for
the SoC devices, to be merged into 2.6.25. please note that my patch
collides with Mark's patches, I don't mind to rebase mine above Mark's
patches, but, in that case I need to wait
ACK the changes; but both git-am(1) and patch(1) report that this is a
corrupt patch. patch(1) says,
[EMAIL PROTECTED] libata-dev]$ patch -sp1 /g/tmp/mbox
patch: malformed patch at line 151: *hpriv, int idx,
(patch is generally more forgiving than git-am)
ok, I'll send the patch
Hi Jeff,
I've the two patches ready and rebased on the version that you have
in the master branch, specifically on the commit libata: convert to
chained sg.
Do you prefer to get those rebased patches?
Saeed
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a
On 1/16/08, Mark Lord [EMAIL PROTECTED] wrote:
saeed bishara wrote:
I attached the new patch
..
Try again, please.
This time, post the patch *inline* in the body of the email,
so that it can more easily be seen, read, and commented on.
Beware of many email clients that mangle inline
On 1/16/08, Jeff Garzik [EMAIL PROTECTED] wrote:
saeed bishara wrote:
- if (unlikely(irq_stat PCI_ERR)) {
+ if (unlikely(irq_stat PCI_ERR) HAS_PCI(host)) {
mv_pci_error(host, mmio);
handled = 1;
goto out_unlock;/* skip all other HC irq
Here is the updated patch according your comments:
From af124a0fd4984db4fbc8638e0af4e6a41561588d Mon Sep 17 00:00:00 2001
From: Saeed Bishara [EMAIL PROTECTED]
Date: Sun, 2 Dec 2007 10:43:10 +0200
Subject: [PATCH] sata_mv: Remove PCI dependency
The integrated SATA controller is connected
Here is the updated patch according your comments:
From af124a0fd4984db4fbc8638e0af4e6a41561588d Mon Sep 17 00:00:00 2001
From: Saeed Bishara [EMAIL PROTECTED]
Date: Sun, 2 Dec 2007 10:43:10 +0200
Subject: [PATCH] sata_mv: Remove PCI dependency
The integrated SATA controller is connected
The mv5_sht and mv6_sht structures are identical. This patch removes one of
those structures and renames the other to mv_sht.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c | 22 ++
1 files changed, 2 insertions(+), 20 deletions(-)
diff --git
On 12/2/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL
On 12/3/07, saeed bishara [EMAIL PROTECTED] wrote:
This patch won't apply, because sata_mv.c was just recently updated
to fix 7042 PCIe support. You'll have to rebase this patch against that.
ok. I'll check that.
Here is the rebased patch:
Marvell's Orion SoC includes SATA controllers
On 12/2/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
rebased the patch with the latest updates:
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL
From: Saeed Bishara [EMAIL PROTECTED]
This patch series adds support for the integrated SATA controller that can be
found in some of Marvell's SoC's. This controller is based on the 88SX7042, but
it connected directly to the internal bus of the SoC and not via PCI.
-
To unsubscribe from
From: Saeed Bishara [EMAIL PROTECTED]
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. The integrated SATA unit is connected
directly to the internal bus of the Orion SoC, and not via PCI.
This patch extends the libATA sata_mv driver to support those
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/Kconfig |2 +-
drivers/ata
From: Saeed Bishara [EMAIL PROTECTED]
Marvell's Orion SoC includes SATA controllers based on Marvell's
PCI-to-SATA 88SX controllers. The integrated SATA unit is connected
directly to the internal bus of the Orion SoC, and not via PCI.
This patch extends the libATA sata_mv driver to support those
From: Saeed Bishara [EMAIL PROTECTED]
The integrated SATA controller is connected directly to the SoC's
internal bus, not via PCI interface. this patch removes the dependency
on the PCI interface.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/Kconfig |2 +-
drivers/ata
From: Saeed Bishara [EMAIL PROTECTED]
This patch series adds support for the integrated SATA controller that can be
found in some of Marvell's SoC's. This controller is based on the 88SX7042, but
it connected directly to the internal bus of the SoC and not via PCI.
-
To unsubscribe from
This patch won't apply, because sata_mv.c was just recently updated
to fix 7042 PCIe support. You'll have to rebase this patch against that.
ok. I'll check that.
Also, I'm not sure I understand why there's a need for the new sata_mv.h file
?
This file contains the definition of the data
From: Saeed Bishara [EMAIL PROTECTED]
use sstatus instead status.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index a43f64d..97c3e11 100644
From: Saeed Bishara [EMAIL PROTECTED]
use sstatus instead status.
Signed-off-by: Saeed Bishara [EMAIL PROTECTED]
---
drivers/ata/sata_mv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index a43f64d..97c3e11 100644
30 matches
Mail list logo
