Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-03 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: On Wednesday 03 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: ACK everything else (that I snipped)... @@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv static int __init qd_testreg(int port) { + static

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index:

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Jeff Garzik
Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: ACK everything else (that I snipped)... @@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv static int __init qd_testreg(int port) { + static DEFINE_SPINLOCK(qd65xx_lock); unsigned long flags; u8 savereg, readreg; At this

[PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 17 + 1