Jeff Garzik wrote:
Two comments:
1) Please split into SHT and ops patches (SHT first, I presume)
Sure.
2) It seems like inheritance would be easier and less error-prone if the
ops were copied, rather than modifying the structures in-place. Comments?
I thought about making per-port copies
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes data structures.
..
diff --git
Mark Lord wrote:
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes data
Tejun Heo wrote:
Mark Lord wrote:
Tejun Heo wrote:
libata lets low level drivers build scsi_host_template and
ata_port_operations tables and register them with upper layers. This
allows low level drivers high level of flexibility but also burdens
them with lots of boilerplate entries in thoes
Mark Lord wrote:
I think this will need to be re-diff'd against the latest sata_mv,
which now has NCQ support.
No problem at all. Just push it into #upstream. :-)
..
Oh, it is/was already there. And I quoted the wrong lines from your patch.
Let's try again:
Is it? I don't see it in