Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-05 Thread Olaf Hering
On Fri, Jan 05, Benjamin Herrenschmidt wrote: Nah, but also set resource-end = 0 too and or-in IORESOURCE_UNSET for flags not (=) (or just set it to 0, I have no problem with completely clearing the resource, that will keep it out of the way) I get this output with the change below: Using

Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-05 Thread Benjamin Herrenschmidt
On Fri, 2007-01-05 at 11:26 +0100, Olaf Hering wrote: On Fri, Jan 05, Benjamin Herrenschmidt wrote: Nah, but also set resource-end = 0 too and or-in IORESOURCE_UNSET for flags not (=) (or just set it to 0, I have no problem with completely clearing the resource, that will keep it out of

Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-04 Thread Olaf Hering
On Wed, Dec 06, Benjamin Herrenschmidt wrote: On Tue, 2006-12-05 at 09:15 +0100, Olaf Hering wrote: On Tue, Dec 05, Benjamin Herrenschmidt wrote: Olaf, can you give me a dump of /proc/ioports ? What is sitting at 0 on that PCI bus ? with IDE=y == /proc/ioports ==

Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-04 Thread Benjamin Herrenschmidt
Add to pseries/pci.c a quirk for that chipset (don't forget to test for machine_is(pseries) in the quirk as they get called for all platforms in a combo kernel. The quirk shall check if resource 6 has a 0 base and clear the size as Alan suggested (possibly setting the UNSET flag as

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Olaf Hering
On Tue, Dec 05, Benjamin Herrenschmidt wrote: Olaf, can you give me a dump of /proc/ioports ? What is sitting at 0 on that PCI bus ? with IDE=y == /proc/ioports == -001f : dma1 0020-0021 : 8259 (master) 0040-005f : timer 0060-006f : i8042 0080-008f

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Gabriel Paubert
On Tue, Dec 05, 2006 at 03:41:19PM +1100, Benjamin Herrenschmidt wrote: On Mon, 2006-12-04 at 14:22 +, Alan wrote: The discussion I was having was about sl82cxx and handling unassigned resources. The zero address isn't relevant to that. Well, actually, it's unclear to me wether the

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Sergei Shtylyov
Hello. Gabriel Paubert wrote: On Mon, 2006-12-04 at 14:22 +, Alan wrote: The discussion I was having was about sl82cxx and handling unassigned resources. The zero address isn't relevant to that. Well, actually, it's unclear to me wether the resource is unassigned or has been assigned

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Grant Grundler
On Tue, Dec 05, 2006 at 03:38:57PM +0300, Sergei Shtylyov wrote: Well, I don't have the PCI specification, but I have a device with the Try googling for pdf21.pdf, pdf22.pdf if you need it. :-) I think you meant pci21.pdf/pci22.pdf/pci23.pdf. And if you find them, trust me when I say

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Sergei Shtylyov
Hello. Grant Grundler wrote: Well, I don't have the PCI specification, but I have a device with the Try googling for pdf21.pdf, pdf22.pdf if you need it. :-) I think you meant pci21.pdf/pci22.pdf/pci23.pdf. And if you find them, trust me when I say whoever is hosting those files can

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: On Tue, Dec 05, Benjamin Herrenschmidt wrote: Olaf, can you give me a dump of /proc/ioports ? What is sitting at 0 on that PCI bus ? with IDE=y == /proc/ioports == -001f : dma1 So it's indeed colliding with the cruft above. I

What is the correct way to indicate an unassigned PCI resource ?

2006-12-04 Thread Alan
On Mon, 04 Dec 2006 16:27:47 +0300 Sergei Shtylyov [EMAIL PROTECTED] wrote: Both PCI core and IDE interpret a zero length resource as unassigned. This is not about 0-length resource, this is about 0-address. Look at ide_hwif_confiure() in drivers/ide/setup-pci.c... The discussion I was

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-04 Thread Sergei Shtylyov
Hello. Alan wrote: When Linus remaps IRQ0 on x86, I'll follow that code as a testament. Until this happens, I consider is just an opinion. Forcing every arch but x86 to remap IRQ0 is an example of the double standards. Yawn.. x86 does not expose IRQ 0 outside of arch specific code.

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-04 Thread Benjamin Herrenschmidt
On Mon, 2006-12-04 at 14:22 +, Alan wrote: The discussion I was having was about sl82cxx and handling unassigned resources. The zero address isn't relevant to that. Well, actually, it's unclear to me wether the resource is unassigned or has been assigned to 0 :-) And in the later case, why

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-04 Thread Benjamin Herrenschmidt
On Mon, 2006-12-04 at 21:53 +0100, Guennadi Liakhovetski wrote: On Mon, 4 Dec 2006, Sergei Shtylyov wrote: When Linus remaps IRQ0 on x86, I'll follow that code as a testament. Until this happens, I consider is just an opinion. Forcing every arch but x86 to remap IRQ0 is an