Re: [PATCH 0/32] ide-tape redux v1

2008-02-01 Thread Borislav Petkov
On Wed, Jan 30, 2008 at 01:29:55AM +0100, Bartlomiej Zolnierkiewicz wrote: On Monday 28 January 2008, Borislav Petkov wrote: Hi Bart, [...] the BKL in idetape_write_release() with finer-grained locking etc, probably also some pipeline improvements, removal of OnStream

Re: About forcing 32bit DMA patch for AMD690G(SB600)

2008-02-01 Thread Tejun Heo
Shane Huang wrote: As Tejun mentioned, the test result on my SB600 engineering board (RS690 A12 +SB600 A21) is a little different from the result of Srihari. But I do not have other SB600 boards especially ASUS M2A-VM to do further debug. So if you can provide us your test result, that's

Re: PROBLEM REMAINS: [sata_nv ADMA breaks ATAPI] Crash on accessing DVD-RAM

2008-02-01 Thread Alexander
Robert Hancock wrote: Can you (or others experiencing this problem) test the latest patch attached to the RH Bugzilla entry here: https://bugzilla.redhat.com/show_bug.cgi?id=351451 and see if it resolves the problem? I have one report of success so far. I'll test it at this weekend. - To

[PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Tejun Heo
This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. For example, you can say use 1.5Gbps for all fan-out ports attached to the second port but allow 3.0Gbps for

Re: libata pm

2008-02-01 Thread Mark Lord
[EMAIL PROTECTED] wrote: Sorry for my late answer, but i had to sort this out first. After replacing the first PSU with a new Corsair 650W the power no longer fluctuated more than 0,01 V (and this only when booting up the drives...) I did a full resync on both raid arrays and got no more errors

AHCI driver preferring nr_ports over port map

2008-02-01 Thread Jan Beulich
Jeff, while I realize that Intel's documentation may not be consistent with anything more generic (which I don't know where to look for), this current behavior seems to contradict what Intel documents for ESB2: 23.3.1.4 PI – Ports Implemented Register (D31:F2) Address Offset: ABAR + 0Ch–0Fh

Re: libata pm

2008-02-01 Thread [EMAIL PROTECTED]
Sorry for my late answer, but i had to sort this out first. After replacing the first PSU with a new Corsair 650W the power no longer fluctuated more than 0,01 V (and this only when booting up the drives...) I did a full resync on both raid arrays and got no more errors or resets, but there

Re: libata pm

2008-02-01 Thread Tejun Heo
Mark Lord wrote: After I got the new PSU and the raid was in full sync without any error for 48h, I thought all problems were gone. Today the sata errors reappeared and whenever the load is high enough I get the following: .. What exact brand/model drives are those again (hdparm --Istdout,

Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers

2008-02-01 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: --- /dev/null +++ b/include/linux/sata_mv.h @@ -0,0 +1,21 @@ +/* + * Marvell integrated SATA platfrom device data definition file. + * + * Saeed Bishara [EMAIL PROTECTED] + * + * This file is licensed under the terms of the GNU General Public + * License version 2. This

Re: [PATCH] pata_sl82c105: dual channel support

2008-02-01 Thread Jeff Garzik
Alan Cox wrote: Use qc_defer to serialize the two channels Signed-off-by: Alan Cox [EMAIL PROTECTED] applied... nice! - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] pata_legacy: multiple updates (rediff as asked)

2008-02-01 Thread Jeff Garzik
Alan Cox wrote: - Fix probe logic to support multiple devices better - Fold in qdi and winbond support - Fix promise 202C30 probe - Restructure hrm, some of this is already in #upstream (and thus -mm, though maybe akpm has not yet regenerated his stuff). patch(1) seems to think I already

Re: [PATCH 1/2 v3] sata_mv: Remove PCI dependency

2008-02-01 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Saeed Bishara [EMAIL PROTECTED] The integrated SATA controller is connected directly to the SoC's internal bus, not via PCI interface. this patch removes the dependency on the PCI interface. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] --- drivers/ata/Kconfig

Re: [PATCH] sata_nv: fix for completion handling

2008-02-01 Thread Jeff Garzik
Robert Hancock wrote: This patch is based on an original patch from Kuan Luo of NVIDIA, posted under subject fixed a bug of adma in rhel4u5 with HDS7250SASUN500G. His description follows. I've reworked it a bit to avoid some unnecessary repeated checks but it should be functionally identical.

Re: [PATCH] pci: allow multiple calls to pcim_enable_device()

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: There's no reason not to allow multiple calls to pcim_enable_device(). Calls after the first one can simply be noop. All PCI resources will be released when the initial pcim_enable_device() resource is released. This allows more flexibility to managed PCI users.

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Feb 1, 2008 6:28 PM, Jeff Garzik [EMAIL PROTECTED] wrote: Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. For example, you can

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-02-01 Thread Kiyoshi Ueda
Hi Boris, On Fri, 1 Feb 2008 08:51:17 +0100, Borislav Petkov wrote: The below fix should be enough. It's perfectly legal to have leftover byte counts when the drive signals completion, happens all the time for eg user issued commands where you don't know an exact byte count.

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. For example, you can say use 1.5Gbps for all fan-out ports attached to the second port

Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers

2008-02-01 Thread Paul Mundt
On Fri, Feb 01, 2008 at 11:53:30AM -0500, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: --- /dev/null +++ b/include/linux/sata_mv.h @@ -0,0 +1,21 @@ +/* + * Marvell integrated SATA platfrom device data definition file. + * + * Saeed Bishara [EMAIL PROTECTED] + * + * This file is licensed

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Sam Ravnborg
On Fri, Feb 01, 2008 at 12:28:35PM -0500, Jeff Garzik wrote: Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. For example, you can say

[git patches] libata updates

2008-02-01 Thread Jeff Garzik
The PCI change was ack'd by Greg... Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/Kconfig |2 +- drivers/ata/ahci.c |2 +

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-02-01 Thread Borislav Petkov
On Fri, Feb 01, 2008 at 12:39:27PM -0500, Kiyoshi Ueda wrote: snip end_that_request_last() is not called when __blk_end_reuqest() returns 1. Then, the issuer isn't waken up. So I think the BUG() or error messages should be there. you mean, end_that_request_last() isn't called when

Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers

2008-02-01 Thread saeed bishara
Unless Paul M objects (pata_platform maintainer), I will rename linux/pata_platform.h to linux/ata_platform.h, and we can put your mv_sata_platform_data structure in there. seems better idea. now I have a patch for the arm subsystem that depends on this patch, how can I make sure that the new

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 -g8561b089

2008-02-01 Thread Kiyoshi Ueda
Hi Boris, On Fri, 1 Feb 2008 19:29:09 +0100, Borislav Petkov wrote: end_that_request_last() is not called when __blk_end_reuqest() returns 1. Then, the issuer isn't waken up. So I think the BUG() or error messages should be there. you mean, end_that_request_last() isn't called

[PATCH RESEND] libata: implement drain buffers

2008-02-01 Thread James Bottomley
From: James Bottomley [EMAIL PROTECTED] Date: Thu, 10 Jan 2008 11:42:50 -0600 Subject: libata: implement drain buffers This just updates the libata slave configure routine to take advantage of the block layer drain buffers. I suspect I should also be checking for AHCI as well as ATA_DEV_ATAPI,

Re: [PATCH RESEND] libata: implement drain buffers

2008-02-01 Thread Jeff Garzik
James Bottomley wrote: From: James Bottomley [EMAIL PROTECTED] Date: Thu, 10 Jan 2008 11:42:50 -0600 Subject: libata: implement drain buffers This just updates the libata slave configure routine to take advantage of the block layer drain buffers. I suspect I should also be checking for AHCI as

Re: [PATCH RESEND number 2] libata: eliminate the home grown dma padding in favour of that provided by the block layer

2008-02-01 Thread Jeff Garzik
James Bottomley wrote: Could we please get this in ... I thought I mentioned several times that it fixes a fatal oops in both aic94xx and ipr. Tejun has a persistent objection... see other email. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCHSET libata-dev#upstream] libata: prefer hardreset

2008-02-01 Thread Jeff Garzik
I'm currently polling various drive manufacturers for comments, so I'm going to delay ack/nak on this patchset until their comments come back. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 07dcaf6..08301ca 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -351,6 +351,8 @@ static const struct ata_port_operations ahci_vt8251_ops = { .port_suspend = ahci_port_suspend,

Re: [PATCH 9/9] libata: make reset related methods proper port operations

2008-02-01 Thread Jeff Garzik
ACK patches 6-9 - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/9] libata: implement and use ata_noop_irq_clear()

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: -irq_clear() is used to clear IRQ bit of a SFF controller and isn't useful for drivers which don't use libata SFF HSM implementation. However, it's a required callback and many drivers implement their own noop version as placeholder. This patch implements ata_noop_irq_clear and

Re: [PATCH 1/9] libata: PCI device should be powered up before being accessed

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c index 7e68edf..5ef6594 100644 --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -597,6 +597,11 @@ static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id) const struct

Re: [PATCH #upstream] libata: make EH fail gracefully if no reset method is available

2008-02-01 Thread Jeff Garzik
Tejun Heo wrote: When no reset method is available, libata currently oopses. Although the condition can't happen unless there's a bug in a low level driver, oopsing isn't the best way to report the error condition. Complain, dump stack and fail reset instead. Signed-off-by: Tejun Heo [EMAIL

Re: [PATCH RESEND] libata: implement drain buffers

2008-02-01 Thread James Bottomley
On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote: James Bottomley wrote: From: James Bottomley [EMAIL PROTECTED] Date: Thu, 10 Jan 2008 11:42:50 -0600 Subject: libata: implement drain buffers This just updates the libata slave configure routine to take advantage of the block

Re: [2.6 patch] unexport ide_dma_on

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: ide_dma_on can be unexported. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] small ide-scan-pci.c cleanup

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: - ide_scan_pcibus() can become static - instead of ide_scan_pci() we can use ide_scan_pcibus() directly in module_init() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [2.6 patch] ide: make wait_drive_not_busy() static again

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: After commit 7267c3377443322588cddaf457cf106839a60463 wait_drive_not_busy() can become static again. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: [2.6 patch] ide/ppc/pmac.c section fixes

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Wednesday 30 January 2008, Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... WARNING: vmlinux.o(.text+0x3b641c): Section mismatch in reference from the function .pmac_ide_setup_device() to the function .init.text:.pmac_ide_setup_dma() ... --

Re: [PATCH 2/2 v3] sata_mv: Support SoC controllers

2008-02-01 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Saeed Bishara [EMAIL PROTECTED] Marvell's Orion SoC includes SATA controllers based on Marvell's PCI-to-SATA 88SX controllers. This patch extends the libATA sata_mv driver to support those controllers. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] ---

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 28 January 2008, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d'

Re: [PATCH] Palmchip BK3710 IDE driver

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 25 January 2008, Anton Salnikov wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Unfortunately some

Re: [PATCH 5/9] libata: implement and use SHT initializers and ops inheritance

2008-02-01 Thread Tejun Heo
Jeff Garzik wrote: Two comments: 1) Please split into SHT and ops patches (SHT first, I presume) Sure. 2) It seems like inheritance would be easier and less error-prone if the ops were copied, rather than modifying the structures in-place. Comments? I thought about making per-port copies

[PATCH 1/5] ide: remove write-only -sata_misc[] from ide_hwif_t

2008-02-01 Thread Bartlomiej Zolnierkiewicz
* Remove write-only -sata_misc[] from ide_hwif_t. * Remove no longer used SATA_{MISC,PHY,IEN}_OFFSET defines. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/siimage.c |3 --- include/linux/ide.h |5 - 2 files changed, 8 deletions(-) Index:

[PATCH 5/5] ide: add ide_read_error() inline helper

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 +- drivers/ide/ide-floppy.c |2 +- drivers/ide/ide-io.c |4 ++-- drivers/ide/ide-iops.c |4 +++- drivers/ide/ide-lib.c |2 +- drivers/ide/ide-tape.c |2 +-

Re: [PATCH 2.6.23.11]: [sata_svw]: Add ATAPI DMA support for HT1x00 SATA controller

2008-02-01 Thread Jeff Garzik
Anantha Subramanyam wrote: This patch adds ATAPI DMA support for HT1000 (aka BCM5785) HT1100 (aka BCM11000) SATA Controller. Signed-off-by: Anantha Subramanyam [EMAIL PROTECTED] Thanks much for your patience. Feedback: Engineering process issues: 1) patch is word-wrapped, and cannot be

Re: SiI 3512 Serial ATA Controller - kernel 2.6.23

2008-02-01 Thread Tejun Heo
Dan Nica wrote: those errors apears only when I use the harddrives with the sii controller and only when I make operation between the onboard sata and the sii sata controller, operations between ide and drives that are on sii works perfectly... Hmm.. Your drive is raising ABRT on writes. It

RE: About forcing 32bit DMA patch for AMD690G(SB600)

2008-02-01 Thread Shane Huang
Dear Tejun: My 5 cents: Just order the board. These stock PC hardware are too cheap these days, it doesn't make any sense to try to debug somewhat difficult problem remotely if the hardware is available on the market. Even if you have to spend your own money, it will be money well

Re: excess timeouts accessing pci-sata card both ports

2008-02-01 Thread Tejun Heo
[EMAIL PROTECTED] wrote: Removed 3 drives. Both data and power. Left only port1 connected It's the drive and power cable that in the first test was port2 failing and in second test was port1 and ok both cards plugged in and initialized. third test it's the port1 alone sda working ok fourth

RE: [PATCH 2.6.23.11]: [sata_svw]: Add ATAPI DMA support for HT1x00 SATA controller

2008-02-01 Thread Anantha Subramanyam
Thanks much for your patience. Feedback: . . . - static int printed_version; + static int printed_version = 0; Thanks for the detailed feedback, will take care of points raised above. 3) we try _very_ hard to avoid all dependencies on the state produced by BIOS. The

Re: 2.6.24 sata_sil Sil3114 drive clicking / restarting?

2008-02-01 Thread Tejun Heo
Andrew Paprocki wrote: Both drives already had PM disabled, visible in hdparm -i: AdvancedPM=yes: disabled (255) WriteCache=enabled Looking at the smart reporting, it is showing both drives have a FAILING_NOW condition for Seek_Error_Rate. I don't know what to believe, because it seems like

Re: PROBLEM: SATA hotplugging not working with nForce MCP61

2008-02-01 Thread Tejun Heo
Tuomas Jormola wrote: Hello, [1.] One line summary of the problem: SATA hotplugging does not seem to work with NVIDIA nForce MCP61. [2.] Full description of the problem/report: I have a machine with ASRock 939NF6G-VSTA motherboard (more info:

Re: ATA Problems: Back in the Land of the Unhappy Camper

2008-02-01 Thread Tejun Heo
rgheck wrote: pata_amd :00:0d.0: version 0.3.10 PCI: Setting latency timer of device :00:0d.0 to 64 scsi6 : pata_amd scsi7 : pata_amd ata7: PATA max UDMA/133 cmd 0x1f0 ctl 0x3f6 bmdma 0xfc00 irq 14 ata8: PATA max UDMA/133 cmd 0x170 ctl 0x376 bmdma 0xfc08 irq 15 ata7.00: ATAPI:

Re: [PATCH] PCI subsystem: AMD SATA IDE mode quirk

2008-02-01 Thread Jeff Garzik
Cai, Crane wrote: From: Crane Cai [EMAIL PROTECTED] PCI: modify SATA IDE mode quirk When initialize and resume, SB600/700/800 need to set SATA mode correctly. Signed-off-by: Crane Cai [EMAIL PROTECTED] --- a/drivers/pci/quirks.c 2007-09-24

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-01 Thread Jeff Garzik
Linux Kernel Mailing List wrote: Commit: 0948391641918b95d8d96c15089eb5ac156850b3 PCI: Remove users of pci_enable_device_bars() This patch converts users of pci_enable_device_bars() to the new pci_enable_device_{io,mem} interface. The new API fits nicely, except

Re: Problem with ata layer in 2.6.24

2008-02-01 Thread Tejun Heo
Kasper Sandberg wrote: to put some timeline perspective into this. i believe it was in 2005 i assembled the system, and when i realized it was faulty, on old ide driver, i stopped using it - that miht have been in beginning of 2006. then for almost a year i werent using it, hoping to somehow

Re: Hitachi 7K1000 1tb drives and sata_sil 3114 chipset

2008-02-01 Thread Tejun Heo
Andrew Paprocki wrote: I've been encountering many, many problems with Hitachi 1tb drives under a Sil3114 chipset and I'm wondering if there could be something wrong with the driver/chipset in relation to these drives. Statistically, I've had 6 out of 7 drives exhibit very strange failure

[PATCH] ide-core: remove conditional compiling with MODULE in ide-core.c

2008-02-01 Thread Denis Cheng
use module_init/module_exit to replace the original cond-compiling, these macros were well designed to deal module/built-in compiling. the original __setup with null string was invalid and not executed, __setup(, ide_setup); however, with the current module_param mechanics, module