[PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Bryan Wu
Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver [try #2] Changelog: - Coding style issues fixed, passed checkpatch.pl - Kill uselss ad7142_used - Move request_irq to probe - Move i2c_check_functionality to probe - Error handling added Signed-off-by: Bryan

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Andrey Panin
On 285, 10 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Subject: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver [try #2] Changelog: - Coding style issues fixed, passed checkpatch.pl - Kill uselss ad7142_used - Move request_irq to probe - Move

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

2007-10-12 Thread Chr
On Thursday, 11. October 2007, Javier Bolaños Molina wrote: Hi all, [...] Well I installed this patch, recompiled my kernel and tried again asusoled application in order to test the oled display. First time everything seemed as usual as it was with a standard (no patched) kernel, asusolded

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Roel Kluin
Bryan Wu wrote: +static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset, + unsigned short *data, unsigned int len) +{ + int ret = -1; + int i; + u8 block_data[32]; + + if (len 1 len 16) { you want || here + printk(KERN_ERR

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
Hi Ahmed, On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's own kthread to call ad7142_decode and process keycodes instead of using a tasklet ?

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Ahmed S. Darwish
On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's own kthread to call ad7142_decode and process keycodes instead of using a tasklet ? Isn't disabling device interrupts from the begining of the ISR

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote: On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: +

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

2007-10-12 Thread Javier Bolaños Molina
On 12/10/2007, Chr [EMAIL PROTECTED] wrote: On Thursday, 11. October 2007, Javier Bolaños Molina wrote: To sum up the patch works fine once I remove and load usbhid once. I tend to think this could be a bootstrap bug as it does work well after a manual reload of usbhid. hmm, sounds

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Bryan Wu
On Fri, 2007-10-12 at 11:50 -0400, Dmitry Torokhov wrote: On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + [snip] + +static void ad7142_close(struct

[PATCH try #4] Blackfin BF54x Input Keypad controller driver

2007-10-12 Thread Bryan Wu
From: Michael Hennerich [EMAIL PROTECTED] Subject: [PATCH try #4] Blackfin BF54x Input Keypad controller driver [try #2] Changelog: - Coding style issue fixes - using a temp variable for bf54x_kpad-input - Other updates according to Dmitry's review [try #3] Changelog: - Coding style cleanups

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + [snip] + +static void ad7142_close(struct input_dev *dev) +{ + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX,

RE: [PATCH try #3] Blackfin BF54x Input Keypad controller driver

2007-10-12 Thread Hennerich, Michael
Hi Dmitry, From: Dmitry Torokhov [mailto:[EMAIL PROTECTED] Sent: Donnerstag, 11. Oktober 2007 21:58 To: Hennerich, Michael Cc: [EMAIL PROTECTED]; linux-input@atrey.karlin.mff.cuni.cz; Linux Kernel; [EMAIL PROTECTED] Subject: Re: [PATCH try #3] Blackfin BF54x Input Keypad controller driver Hi

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Bryan Wu
On Fri, 2007-10-12 at 10:49 -0400, Dmitry Torokhov wrote: Hi Bryan, On 10/12/07, Bryan Wu [EMAIL PROTECTED] wrote: + [snip] + +static void ad7142_close(struct input_dev *dev) +{ + free_irq(CONFIG_BFIN_JOYSTICK_IRQ_PFX, ad7142_interrupt); + kthread_stop(ad7142_task);

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Ahmed S. Darwish
On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: Hi Ahmed, Hi :), On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 03:38:47PM +0800, Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- Hi Bryan, Why creating module's

Re: [PATCH try #2] Input/Joystick Driver: add support AD7142 joystick driver

2007-10-12 Thread Dmitry Torokhov
On 10/12/07, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Fri, Oct 12, 2007 at 01:29:31PM -0400, Dmitry Torokhov wrote: Isn't disabling device interrupts from the begining of the ISR ad7142_interrupt till the kthread ad7142_thread got waked-up and scheduled a long time, espicially