Re: Logitech M705: Thumb button (was Re: [PATCH v4] HID: Add full support for Logitech Unifying receivers)

2013-07-03 Thread Nestor Lopez Casado
Hi all, Sorry it took me some time to answer. I extended the Logitech HIDPP10 specification here: https://drive.google.com/folderview?id=0BxbRzx7vEV7eWmgwazJ3NUFfQ28usp=sharing The document Logitech_hidpp10_specification_draft_Unifying_devices_receivers.doc now contains most of the relevant

Re: [patch 2/3] Input: cyttsp4 - silence NULL dereference warning

2013-07-03 Thread Ferruh Yigit
On 07/03/2013 12:41 AM, Dan Carpenter wrote: If cd were NULL then we would dereference it when we print the error message. Fortunately enough, it can't ever be NULL so we can remove those lines. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: [patch 3/3] Input: cyttsp4 - leak on error path in probe()

2013-07-03 Thread Ferruh Yigit
On 07/03/2013 12:44 AM, Dan Carpenter wrote: We leak cd if the cd-xfer_buf allocation fails. It was weird to goto error_gpio_irq so I changed the label name. (Label names should reflect the label location not the goto location otherwise you get an all roads lead to Rome problem).

Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-03 Thread Ferruh Yigit
On 07/03/2013 12:47 AM, Dan Carpenter wrote: Hello Ferruh Yigit, The patch 67bf12ca50d5: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices from Jun 30, 2013, leads to the following Smatch warning: drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfer() warn:

Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

2013-07-03 Thread Dan Carpenter
On Wed, Jul 03, 2013 at 04:24:18PM +0300, Ferruh Yigit wrote: I have a patch for this, but should I create it against previous patch I have sent or against latest next tree? Latest linux-next. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-input in

Re: [patch 3/3] Input: cyttsp4 - leak on error path in probe()

2013-07-03 Thread Ferruh Yigit
On 07/03/2013 04:50 PM, Dan Carpenter wrote: On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote: On 07/03/2013 12:44 AM, Dan Carpenter wrote: We leak cd if the cd-xfer_buf allocation fails. It was weird to goto error_gpio_irq so I changed the label name. (Label names should reflect

Re: [patch 3/3] Input: cyttsp4 - leak on error path in probe()

2013-07-03 Thread Dan Carpenter
On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote: On 07/03/2013 12:44 AM, Dan Carpenter wrote: We leak cd if the cd-xfer_buf allocation fails. It was weird to goto error_gpio_irq so I changed the label name. (Label names should reflect the label location not the goto location

Re: [PATCH] HID: kye: Add report fixup for Genius Gila Gaming mouse

2013-07-03 Thread Jiri Kosina
On Tue, 2 Jul 2013, Benjamin Tissoires wrote: Genius Gila Gaming Mouse presents an obviously wrong report descriptor. the Consumer control (report ID 3) is the following: 0x05, 0x0c,// Usage Page (Consumer Devices) 105 0x09, 0x01,// Usage

Re: One USB mouse problem with runtime power management enabled

2013-07-03 Thread Alan Stern
On Wed, 3 Jul 2013, Peter Chen wrote: Hi Jiri and Alan, I have run below below at 3.5.7 kernel, but after checking upstream kernel, it may also be existed. 1. evtest /dev/input/event1 2. Let mouse auto suspend, enable mouse as wakeup source, and let the system enters suspend. echo

[PATCH] Input: cyttsp4 - kfree xfer_buf on error path in probe()

2013-07-03 Thread Ferruh Yigit
If probe() fails after cd-xfer_buf allocated, it will not freed. Added kfree(cd-xfer_buf) with and error label. Signed-off-by: Ferruh Yigit f...@cypress.com --- drivers/input/touchscreen/cyttsp4_core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] Input: cyttsp4 - use 16bit address for I2C/SPI communication

2013-07-03 Thread Ferruh Yigit
In TSG4, register map is 512bytes long and to access all of it, one bit from address byte is used (which bit to use differs for I2C and SPI); Since common code used for TSG3 and TSG4 for I2C, this parameter wrongly used as u8. TSG3 does not access beyond 255 bytes but TSG4 may. Signed-off-by: