Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Bruno Prémont
Hi Jiri, Some notes regarding picoLCD part below. On Tue, 09 July 2013 Jiri Kosina jkos...@suse.cz wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Benjamin Tissoires
Hi Jiri, On 07/09/2013 08:44 PM, Jiri Kosina wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary

Re: [PATCH 2/2] Input: Adding DT support for keyreset tuneables

2013-07-10 Thread Grant Likely
On Fri, 28 Jun 2013 07:19:06 -0600, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 13-06-28 12:09 AM, Dmitry Torokhov wrote: I do not agree. We want the binding to be generic and not tied specifically to the keyreset functionality. As such 'input-keyset' or 'input-keychord' are

Re: [PATCH 2/2] Input: Adding DT support for keyreset tuneables

2013-07-10 Thread Dmitry Torokhov
On Wed, Jul 10, 2013 at 04:14:57PM +0100, Grant Likely wrote: On Fri, 28 Jun 2013 07:19:06 -0600, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 13-06-28 12:09 AM, Dmitry Torokhov wrote: I do not agree. We want the binding to be generic and not tied specifically to the keyreset

Re: [PATCH 26/51] Input: atmel_mxt_ts - Move input device init into separate function

2013-07-10 Thread Dmitry Torokhov
On Mon, Jul 08, 2013 at 10:41:33AM +0100, Nick Dyer wrote: Dmitry Torokhov wrote: On Thu, Jun 27, 2013 at 01:49:01PM +0100, Nick Dyer wrote: Signed-off-by: Nick Dyer nick.d...@itdev.co.uk So before we allocated input device before requesting IRQ, now we fo it afterwards so there is

Re: [PATCH 22/51] Input: atmel_mxt_ts - Add shutdown function

2013-07-10 Thread Dmitry Torokhov
On Mon, Jul 08, 2013 at 10:56:06AM +0100, Nick Dyer wrote: Dmitry Torokhov wrote: On Thu, Jun 27, 2013 at 01:48:57PM +0100, Nick Dyer wrote: Signed-off-by: Nick Dyer nick.d...@itdev.co.uk Acked-by: Benson Leung ble...@chromium.org Why is this needed? The patch disables the interrupt

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Jiri Kosina
On Wed, 10 Jul 2013, Benjamin Tissoires wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary

[PATCH v2] HID: fix data access in implement()

2013-07-10 Thread Jiri Kosina
implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary hits a page boundary, pagefault happens when accessing

Re: [PATCH 22/51] Input: atmel_mxt_ts - Add shutdown function

2013-07-10 Thread Nick Dyer
Dmitry Torokhov wrote: The patch disables the interrupt handler on shutdown. One of our customers reported a bug caused by input events being generated during shutdown (for example if the user was touching the device whilst it was turning off), which was solved by putting in this change.

[PATCH 001/001] [Input:] Propagate hardware generated event timestamp to evdev.

2013-07-10 Thread Alexander Levitskiy
From: Sasha Levitskiy sa...@google.com Input: Propagate hardware event timestamp to evdev. Convey hardware generated timestamp associated with the current event packet. The use of these event codes by hardware drivers is optional. Used to reduce jitter and improve velocity tracking in ABS_MT and

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Alan Stern
On Wed, 10 Jul 2013, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `usb_hcd_unmap_urb_setup_for_dma': drivers/usb/core/hcd.c:1361: undefined reference to `dma_unmap_single' ,,, Commit d9ea21a779278da06d0cbe989594bf542ed213d7 (usb: host: make USB_ARCH_HAS_?HCI

Re: [PATCH 2/2] Input: Adding DT support for keyreset tuneables

2013-07-10 Thread Grant Likely
On Wed, Jul 10, 2013 at 5:52 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jul 10, 2013 at 04:14:57PM +0100, Grant Likely wrote: On Fri, 28 Jun 2013 07:19:06 -0600, Mathieu Poirier mathieu.poir...@linaro.org wrote: On 13-06-28 12:09 AM, Dmitry Torokhov wrote: I do not

Re: [PATCH 2/2] Input: Adding DT support for keyreset tuneables

2013-07-10 Thread Dmitry Torokhov
On Wednesday, July 10, 2013 10:50:26 PM Grant Likely wrote: On Wed, Jul 10, 2013 at 5:52 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jul 10, 2013 at 04:14:57PM +0100, Grant Likely wrote: On Fri, 28 Jun 2013 07:19:06 -0600, Mathieu Poirier mathieu.poir...@linaro.org wrote:

Re: [PATCH 2/2] Input: Adding DT support for keyreset tuneables

2013-07-10 Thread Dmitry Torokhov
On Wednesday, July 10, 2013 04:29:00 PM Mathieu Poirier wrote: On 10 July 2013 16:20, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wednesday, July 10, 2013 10:50:26 PM Grant Likely wrote: On Wed, Jul 10, 2013 at 5:52 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Arnd Bergmann
On Wednesday 10 July 2013, Alan Stern wrote: This isn't right. There are USB host controllers that use PIO, not DMA. The HAS_DMA dependency should go with the controller driver, not the USB core. On the other hand, the USB core does call various routines like dma_unmap_single. It ought

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-07-10 Thread Alan Stern
On Thu, 11 Jul 2013, Arnd Bergmann wrote: On Wednesday 10 July 2013, Alan Stern wrote: This isn't right. There are USB host controllers that use PIO, not DMA. The HAS_DMA dependency should go with the controller driver, not the USB core. On the other hand, the USB core does call

[PATCH 2/2] Input: imx_keypad - Simplify devm_kzalloc

2013-07-10 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com According to Documentation/CodingStyle: The preferred form for passing a size of a struct is the following: p = kmalloc(sizeof(*p), ...); Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/input/keyboard/imx_keypad.c |

[PATCH 1/2] Input: imx_keypad - check the return value from clk_prepare_enable()

2013-07-10 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- drivers/input/keyboard/imx_keypad.c | 4 +++- 1 file changed, 3 insertions(+), 1