Re: [RFC 2/8] HID: usbhid: update LED fields unlocked

2013-07-31 Thread Jiri Kosina
On Tue, 16 Jul 2013, Benjamin Tissoires wrote: Report fields can be updated from HID drivers unlocked via hid_set_field(). It is protected by input_lock in HID core so only a single input event is handled at a time. USBHID can thus update the field unlocked and doesn't conflict with any

Re: [RFC 3/8] HID: input: generic hidinput_input_event handler

2013-07-31 Thread Jiri Kosina
On Wed, 17 Jul 2013, David Herrmann wrote: + + /* led_work is spawned by input_dev callbacks, but doesn't access the +* parent input_dev at all. Once all input devices are removed, we +* know that led_work will never get restarted, so we can cancel it +*

Re: [RFC 0/8] HID: Transport Driver Cleanup

2013-07-31 Thread Jiri Kosina
On Wed, 31 Jul 2013, David Herrmann wrote: This series provides some cleanups for HID transport drivers: Hi David, thanks a lot for your work, again. I have now applied all the patches from the series, except for: - 3/8, waiting for v2 Ugh, patches 4-6 use the generic helper

Re: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad.

2013-07-31 Thread Felipe Balbi
On Mon, Jul 29, 2013 at 01:40:28PM -0700, Dmitry Torokhov wrote: On Monday, July 29, 2013 11:36:05 PM Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 12:59:23PM -0700, Dmitry Torokhov wrote: @@ -439,12 +444,50 @@ static const struct of_device_id omap_keypad_dt_match[] = {

Re: [PATCH] HID: i2c-hid: add DT bindings

2013-07-31 Thread Jiri Kosina
On Wed, 24 Jul 2013, Benjamin Tissoires wrote: Add device tree based support for HID over I2C devices. Tested on an Odroid-X board with a Synaptics touchpad. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi guys, well, as the commit message says, this is

[PATCH linux-next] hid/logitech-dj: Fix non-atomic kmalloc in logi_dj_ll_input_event()

2013-07-31 Thread Peter Hurley
The ll_driver's .hidinput_input_event() method is called from atomic context [1]. Use GFP_ATOMIC for allocation of the synthesized hid report. Signed-off-by: Peter Hurley pe...@hurleysoftware.com [1] BUG: sleeping function called from invalid context at

Re: [PATCH linux-next] hid/logitech-dj: Fix non-atomic kmalloc in logi_dj_ll_input_event()

2013-07-31 Thread Jiri Kosina
On Wed, 31 Jul 2013, Peter Hurley wrote: The ll_driver's .hidinput_input_event() method is called from atomic context [1]. Use GFP_ATOMIC for allocation of the synthesized hid report. Signed-off-by: Peter Hurley pe...@hurleysoftware.com Applied, thanks Peter. -- Jiri Kosina SUSE Labs --