Re: [PATCH] Input: cyttsp4 - fix potential NULL pointer dereference in cyttsp4_watchdog_timer()

2013-08-26 Thread Ferruh Yigit
On 08/26/2013 08:26 AM, Dmitry Torokhov wrote: Wei Yongjun weiyj...@gmail.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn The dereference should be moved below the NULL test. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/input/touchscreen/cyttsp4_core.c | 4

[PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer()

2013-08-26 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove useless NULL test from cyttsp4_watchdog_timer(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- v1 - v2: remove NULL test instead. (was: Input: cyttsp4 - fix potential NULL pointer dereference in cyttsp4_watchdog_timer())

Re: [PATCH v2] Input: cyttsp4 - remove useless NULL test from cyttsp4_watchdog_timer()

2013-08-26 Thread Dmitry Torokhov
On Mon, Aug 26, 2013 at 09:28:28AM +0300, Ferruh Yigit wrote: On 08/26/2013 09:00 AM, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove useless NULL test from cyttsp4_watchdog_timer(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- v1 - v2: remove

Re: [PATCH -next] HID: use module_hid_driver() to simplify the code

2013-08-26 Thread Jiri Kosina
On Fri, 23 Aug 2013, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn module_hid_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/hid/hid-xinmo.c | 13 + 1 file changed,

Re: [PATCH v3 0/3] HID: Win 8 multitouch panels detection in core

2013-08-26 Thread Jiri Kosina
On Thu, 22 Aug 2013, Henrik Rydberg wrote: this is the v3 of this patch series. Srinivas, I still did not added your tested-by as I made minors modifications of the patches 1 and 2. Now only the patch 1 will impact sensor_hub, and patch 2 will not impact this. Maybe just wait for

Re: [PATCH v1 23/49] hid: usbhid: prepare for enabling irq in complete()

2013-08-26 Thread Jiri Kosina
On Sun, 18 Aug 2013, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org Signed-off-by: Ming Lei ming@canonical.com Acked-by: Jiri Kosina jkos...@suse.cz ---

Re: [PATCH 1/4] hid-sensor-hub: fix style of comments

2013-08-26 Thread Jiri Kosina
On Wed, 14 Aug 2013, Andy Shevchenko wrote: This patch fixes the style of the comments to be like following /* The commentary */ There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Applied. --- drivers/hid/hid-sensor-hub.c | 2 +-

Re: [PATCH] hid: Fix Speedlink VAD Cezanne support for some devices

2013-08-26 Thread Jiri Kosina
On Sun, 25 Aug 2013, Stefan Kriwanek wrote: Some devices of the Speedlink VAD Cezanne model need more aggressive fixing than already done. Applied, thanks Stefan. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to

Re: [PATCH 1/1] HID: hidraw: Add spinlock in struct hidraw to protect list

2013-08-26 Thread Jiri Kosina
On Thu, 15 Aug 2013, Yonghua Zheng wrote: As hidraw_report_event can be called from interrupt context, it is a mistake to use mutex_lock for protecting the list member in my previous patch, so update the patch which adds a spinlock in struct hidraw to protect the list member from concurrent

Re: kernel Oops: 0003 on usbhid_submit_report

2013-08-26 Thread Andreas Lillebø Holm
On Friday, August 23, 2013 at 2:49 PM, Jiri Kosina wrote: On Fri, 23 Aug 2013, Benjamin Tissoires wrote: IIRC, Jiri fixed some paging requests with the two following patches:

[PATCH 1/3 v2] Input: wacom - Support EMR and MFT sensors of Cintiq Companion Hybrid

2013-08-26 Thread Jason Gerecke
Adds support for the sensors integrated in to the Cintiq Companion Hybrid. These sensors use by-and-large the same protocol as the Cintiq 24HD touch. NOTE: The ExpressKeys on the Cintiq Companion Hybrid are wired to both the EMR controller and CPU GPIO pins. It may be necessary to disable their

[PATCH 3/3] HID: wiimote: add support for Guitar-Hero guitars

2013-08-26 Thread David Herrmann
From: Nicolas Adenis-Lamarre nicolas.adenis.lama...@gmail.com Apart from drums, Guitar-Hero also ships with guitars. Use the recently introduced input ABS/BTN-bits to report this to user-space. Devices are reported as Nintendo Wii Remote Guitar. If I ever get my hands on RockBand guitars, I will

[PATCH 2/3] HID: wiimote: add support for Guitar-Hero drums

2013-08-26 Thread David Herrmann
Guitar-Hero comes with a drums extension. Use the newly introduced input drums-bits to report this back to user-space. This is a usual extension like any other device. Nothing special to take care of. We report this to user-space as Nintendo Wii Remote Drums. There are other drums (like RockBand

[PATCH 1/3] Input: introduce BTN/ABS bits for drums and guitars

2013-08-26 Thread David Herrmann
There are a bunch of guitar and drums devices out there that all report similar data. To avoid reporting this as BTN_MISC or ABS_MISC, we allocate some proper namespace for them. Note that most of these devices are toys and we cannot report any sophisticated physics via this API. I did some

Re: [PATCH 1/1] HID: hidraw: Add spinlock in struct hidraw to protect list

2013-08-26 Thread Jiri Kosina
On Mon, 26 Aug 2013, Yonghua Zheng wrote: Hi Jiri, Fix the conflict and update the patch: From 7c06e1f3a5959e73a5b827bda67e7c1eaed7da67 Mon Sep 17 00:00:00 2001 From: Yonghua Zheng younghua.zh...@gmail.com Date: Wed, 14 Aug 2013 17:43:36 +0800 Subject: [PATCH 1/1] HID: hidraw: Add

Re: [PATCH v3 0/3] HID: Win 8 multitouch panels detection in core

2013-08-26 Thread Srinivas Pandruvada
On 08/26/2013 04:43 AM, Jiri Kosina wrote: On Thu, 22 Aug 2013, Henrik Rydberg wrote: this is the v3 of this patch series. Srinivas, I still did not added your tested-by as I made minors modifications of the patches 1 and 2. Now only the patch 1 will impact sensor_hub, and patch 2 will not

[PATCH] HID: uhid: add devname module alias

2013-08-26 Thread Marcel Holtmann
For simple device node creation, add the devname module alias. Signed-off-by: Marcel Holtmann mar...@holtmann.org --- drivers/hid/uhid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index fc307e0..9ab7dfc 100644 --- a/drivers/hid/uhid.c +++