Re: [PATCH 11/14] HID: multitouch: validate feature report details

2013-08-29 Thread Benjamin Tissoires
Hi Kees, I would be curious to have the HID report descriptors (maybe off list) to understand how things can be that bad. On overall, I'd prefer all those checks to be in hid-core so that we have the guarantee that we don't have to open a new CVE each time a specific hid driver do not check for

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Jiri Kosina
On Wed, 28 Aug 2013, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org The Report ID field of a HID report is used to build indexes of reports. The kernel's index of these is limited to 256 entries, so any malicious device that sets a Report ID greater than 255 will trigger memory

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Benjamin Tissoires
On Thu, Aug 29, 2013 at 11:03 AM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 28 Aug 2013, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org The Report ID field of a HID report is used to build indexes of reports. The kernel's index of these is limited to 256 entries, so any malicious

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Jiri Kosina
On Thu, 29 Aug 2013, Benjamin Tissoires wrote: The Report ID field of a HID report is used to build indexes of reports. The kernel's index of these is limited to 256 entries, so any malicious device that sets a Report ID greater than 255 will trigger memory corruption on the host: [

Re: [PATCH 02/14] HID: provide a helper for validating hid reports

2013-08-29 Thread Benjamin Tissoires
Hi Kees, On Wed, Aug 28, 2013 at 10:30 PM, Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org Many drivers need to validate the characteristics of their HID report during initialization to avoid misusing the reports. This adds a common helper to perform validation of

Re: [PATCH 01/14] HID: validate HID report id size

2013-08-29 Thread Benjamin Tissoires
On Thu, Aug 29, 2013 at 11:36 AM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 29 Aug 2013, Benjamin Tissoires wrote: The Report ID field of a HID report is used to build indexes of reports. The kernel's index of these is limited to 256 entries, so any malicious device that sets a Report ID

Re: [PATCH 04/14] HID: sony: validate HID output report details

2013-08-29 Thread Benjamin Tissoires
On Wed, Aug 28, 2013 at 10:30 PM, Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org This driver must validate the availability of the HID output report and its size before it can write LED states via buzz_set_leds(). This stops a heap overflow that is possible if a

Re: [PATCH 1/1] MAINTAINERS: Change maintainer for cyttsp driver

2013-08-29 Thread Javier Martinez Canillas
On Tue, Jul 16, 2013 at 8:57 AM, Ferruh Yigit f...@cypress.com wrote: On 07/15/2013 12:41 AM, Javier Martinez Canillas wrote: I haven't had time to work on this driver for a long time and Ferruh has been doing a great job making it more generic, adding support for new hardware and providing

Re: [PATCH 12/14] HID: sensor-hub: validate feature report details

2013-08-29 Thread Mika Westerberg
On Wed, Aug 28, 2013 at 10:31:44PM +0200, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org A HID device could send a malicious feature report that would cause the sensor-hub HID driver to read past the end of heap allocation, leaking kernel memory contents to the caller.

[PATCH] HID: roccat: Added support for KonePureOptical

2013-08-29 Thread Stefan Achatz
KonePureOptical is a KonePure with different sensor. Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net --- drivers/hid/hid-ids.h |1 + drivers/hid/hid-roccat-konepure.c |3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/hid/hid-ids.h

Re: [PATCH 04/14] HID: sony: validate HID output report details

2013-08-29 Thread Kees Cook
On Thu, Aug 29, 2013 at 2:48 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Wed, Aug 28, 2013 at 10:30 PM, Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org This driver must validate the availability of the HID output report and its size before it can

Re: [PATCH 04/14] HID: sony: validate HID output report details

2013-08-29 Thread Benjamin Tissoires
On Thu, Aug 29, 2013 at 4:40 PM, Kees Cook keesc...@chromium.org wrote: On Thu, Aug 29, 2013 at 2:48 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Wed, Aug 28, 2013 at 10:30 PM, Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org This driver must validate

Re: [PATCH 2/4] hid-sensor-hub: fix indentation accross the code

2013-08-29 Thread Andy Shevchenko
On Mon, 2013-08-19 at 08:28 -0700, Srinivas Pandruvada wrote: On 08/14/2013 01:07 AM, Andy Shevchenko wrote: Patch just rearranges lines to be more compact and/or readable. Additionally it converts double space to one in several places. There is no functional change. Jiri, anything

Re: [PATCH 10/14] HID: ntrig: validate feature report details

2013-08-29 Thread Rafi Rubin
Signed-off-by: Rafi Rubin r...@seas.upenn.edu Thanks Kees, Rafi On 08/28/13 16:31, Jiri Kosina wrote: From: Kees Cook keesc...@chromium.org A HID device could send a malicious feature report that would cause the ntrig HID driver to trigger a NULL dereference during initialization:

Re: [PATCH 1/1] MAINTAINERS: Change maintainer for cyttsp driver

2013-08-29 Thread Dmitry Torokhov
On Thu, Aug 29, 2013 at 11:48:57AM +0200, Javier Martinez Canillas wrote: On Tue, Jul 16, 2013 at 8:57 AM, Ferruh Yigit f...@cypress.com wrote: On 07/15/2013 12:41 AM, Javier Martinez Canillas wrote: I haven't had time to work on this driver for a long time and Ferruh has been doing a

Re: [PATCH] Input: add driver for Neonode zForce based touchscreens

2013-08-29 Thread Dmitry Torokhov
Hi Heiko, On Fri, Aug 16, 2013 at 01:59:39PM +0200, Heiko Stübner wrote: This adds a driver for touchscreens using the zforce infrared technology from Neonode connected via i2c to the host system. It supports multitouch with up to two fingers and tracking of the contacts in hardware.

Re: [PATCH] input/serio: disable i8042 PC keyboard ctrl for ARC

2013-08-29 Thread Dmitry Torokhov
On Wed, Aug 28, 2013 at 08:46:56PM +0200, Mischa Jonker wrote: It causes crashes when enabled, and we don't have such a peripheral anyway on ARC platforms. Signed-off-by: Mischa Jonker mjon...@synopsys.com --- drivers/input/serio/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v3 0/3] Input: omap-keypad: Wakeup capability and w/a for i689 errata.

2013-08-29 Thread Dmitry Torokhov
Hi Illia, On Tue, Aug 27, 2013 at 01:08:05PM +0300, Illia Smyrnov wrote: Hello Dmitry, could you take reviewed patches from this patchset? Reviewed patches: [PATCH v3 1/3] Input: omap-keypad: Enable wakeup capability for keypad. [PATCH v3 3/3] Input: omap-keypad: Setup irq type from DT

[git pull] Input updates for 3.11-rc7

2013-08-29 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Just a couple of new IDs in Wacom and xpad drivers, i8042 is now

Re: [PATCH 12/14] HID: sensor-hub: validate feature report details

2013-08-29 Thread Srinivas Pandruvada
On 08/28/2013 02:16 PM, Kees Cook wrote: On Wed, Aug 28, 2013 at 1:42 PM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 28 Aug 2013, Srinivas Pandruvada wrote: A HID device could send a malicious feature report that would cause the sensor-hub HID driver to read past the end of heap allocation,

Re: [PATCH 11/14] HID: multitouch: validate feature report details

2013-08-29 Thread Kees Cook
On Thu, Aug 29, 2013 at 1:59 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi Kees, I would be curious to have the HID report descriptors (maybe off list) to understand how things can be that bad. Certainly! I'll send them your way. I did have to get pretty creative to tickle

Re: [PATCH 12/14] HID: sensor-hub: validate feature report details

2013-08-29 Thread Kees Cook
On Thu, Aug 29, 2013 at 11:13 AM, Srinivas Pandruvada srinivas.pandruv...@linux.intel.com wrote: On 08/28/2013 02:16 PM, Kees Cook wrote: On Wed, Aug 28, 2013 at 1:42 PM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 28 Aug 2013, Srinivas Pandruvada wrote: A HID device could send a malicious

Re: [PATCH 02/14] HID: provide a helper for validating hid reports

2013-08-29 Thread Kees Cook
On Thu, Aug 29, 2013 at 2:35 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Kees, On Wed, Aug 28, 2013 at 10:30 PM, Jiri Kosina jkos...@suse.cz wrote: From: Kees Cook keesc...@chromium.org Many drivers need to validate the characteristics of their HID report during

Re: [PATCH] Input: add driver for Neonode zForce based touchscreens

2013-08-29 Thread Heiko Stübner
Hi Dmitry, Am Donnerstag, 29. August 2013, 18:29:04 schrieb Dmitry Torokhov: Hi Heiko, On Fri, Aug 16, 2013 at 01:59:39PM +0200, Heiko Stübner wrote: This adds a driver for touchscreens using the zforce infrared technology from Neonode connected via i2c to the host system. It