Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-24 Thread Jürgen Beisert
Hi Lothar, On Monday 23 September 2013 17:30:18 Lothar Waßmann wrote: [...] @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device *pdev) if (IS_ERR(lradc-base)) return PTR_ERR(lradc-base); + lradc-clk = devm_clk_get(pdev-dev, NULL); +

Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-24 Thread Jürgen Beisert
Hi Fabio, On Monday 23 September 2013 17:13:03 Fabio Estevam wrote: On 09/23/2013 11:36 AM, Juergen Beisert wrote: + lradc-clk = devm_clk_get(pdev-dev, NULL); + clk_prepare_enable(lradc-clk); clk_prepare_enable() may fail, so better check its return value. Thanks for the comment.

Q: weird hidraw behaviour

2013-09-24 Thread Mika Westerberg
Hi, I noticed that after commit 212a871a393 (HID: hidraw: correctly deallocate memory on device disconnect) hidraw doesn't close the underlying hid device when the device node is closed last time. For example I have a touch panel (HID over I2C) device with added debug prints in

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-24 Thread Jiri Kosina
On Mon, 16 Sep 2013, Joseph Salisbury wrote: Can you explain a little further? Mark commit a4a23f6 as bad? An initial bisect already reported that was the first bad commit, so it can't be marked bad. The oops on memcpy() happens after commit a4a23f6 is reverted. The oops on memcpy()

Re: [PATCH 1/3] HID: Delay opening HID device

2013-09-24 Thread Jiri Kosina
On Wed, 18 Sep 2013, Srinivas Pandruvada wrote: Don't call hid_open_device till there is actually an user. This saves power by not opening underlying transport for HID. Also close device if there are no active mfd client using HID sensor hub. Signed-off-by: Srinivas Pandruvada

Re: [PATCH 0/3] Few cleanups

2013-09-24 Thread Jiri Kosina
On Wed, 11 Sep 2013, Benjamin Tissoires wrote: Well, while debugging hid-lenovo-tpkbd, I also cleaned it up a little (so this goes on top of the CVE series): - use devres API - remove usb references (so that the regressions tests through uhid are working) This has also been tested by

Re: [PATCH] hid-elo: some systems cannot stomach work around

2013-09-24 Thread Jiri Kosina
On Mon, 9 Sep 2013, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Some systems although they have firmware class 'M', which usually needs a work around to not crash, must not be subjected to the work around because the work around crashes them. They cannot be told apart by

Re: [PATCH 1/9] Staging/iio/adc/touchscreen/MXS: add proper clock handling

2013-09-24 Thread Fabio Estevam
On Tue, Sep 24, 2013 at 4:50 AM, Jürgen Beisert j...@pengutronix.de wrote: Hi Fabio, On Monday 23 September 2013 17:13:03 Fabio Estevam wrote: On 09/23/2013 11:36 AM, Juergen Beisert wrote: + lradc-clk = devm_clk_get(pdev-dev, NULL); + clk_prepare_enable(lradc-clk);

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-24 Thread Joseph Salisbury
On 09/24/2013 05:29 AM, Jiri Kosina wrote: On Mon, 16 Sep 2013, Joseph Salisbury wrote: Can you explain a little further? Mark commit a4a23f6 as bad? An initial bisect already reported that was the first bad commit, so it can't be marked bad. The oops on memcpy() happens after commit

Re: [PATCH] HID: uhid: allocate static minor

2013-09-24 Thread David Herrmann
Hey Jiri I forgot to put you on CC on the initial patch. Any comments on this? Cheers David On Mon, Sep 9, 2013 at 6:51 PM, Tom Gundersen t...@jklm.no wrote: On Mon, Sep 9, 2013 at 6:33 PM, David Herrmann dh.herrm...@gmail.com wrote: udev has this nice feature of creating dead /dev/node

atmel_mxt_ts driver DTS adoption

2013-09-24 Thread Dan Murphy
All I have been looking around and I am finding numerous patches for the atmel_mxt_ts file to adopt it to DTS. The last status I have seen was we were waiting for some re-write of the file and that was in April. Are there any recent patches for this? And are they ready? I have not followed

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-09-24 Thread Joseph Salisbury
On 09/24/2013 05:29 AM, Jiri Kosina wrote: On Mon, 16 Sep 2013, Joseph Salisbury wrote: Can you explain a little further? Mark commit a4a23f6 as bad? An initial bisect already reported that was the first bad commit, so it can't be marked bad. The oops on memcpy() happens after commit