[PATCH] alps: rushmore and v7 resolution support

2014-07-29 Thread Hans de Goede
Add support for querying the physical size from the touchpad for rushmore and v7 touchpads, and use that to tell userspace the device resolution. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/input/mouse/alps.c | 48 ++

Re: [PATCH] HID: rmi: add additional checks for the existence of optional queries in order to compute the address of Query 12.

2014-07-29 Thread Jiri Kosina
On Tue, 15 Jul 2014, Benjamin Tissoires wrote: On Jul 11 2014 or thereabouts, Andrew Duggan wrote: There are additional queries which are optional and may not be present depending on the configuration of the firmware. Knowing which queries are present is needed to properly compute the

Re: [PATCHES v2] Add support for more Huion tablets

2014-07-29 Thread Jiri Kosina
On Mon, 28 Jul 2014, Benjamin Tissoires wrote: This is the second version of the patch set adding support for more Huion tablets [1]. This version has the hid: huion: Invert in-range on specific product patch removed as requested by Benjamin Tissoires. Tested with Huion H610N.

Re: [PATCH v2] HID: rmi: check that report ids exist in the report_id_hash before accessing their size

2014-07-29 Thread Jiri Kosina
On Thu, 17 Jul 2014, Andrew Duggan wrote: It is possible that the hid-rmi driver could get loaded onto a device which does not have the expected report ids. This should not happen because it would indicate that the hid-rmi driver is not compatible with that device. However, if it does

Re: [PATCH] HID: rmi: only bind the hid-rmi driver to the mouse interface of composite USB devices

2014-07-29 Thread Jiri Kosina
On Thu, 17 Jul 2014, Andrew Duggan wrote: On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi should only bind to the mouse interface. One example is the Dell Venue 11 Pro's keyboard dock which contains a composite USB device with a HID touchpad

Re: [v2] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Mark Rutland
On Mon, Jul 28, 2014 at 05:53:23PM +0100, Dan Murphy wrote: Add the TI drv260x haptics/vibrator driver. This device uses the input force feedback to produce a wave form to driver an ERM or LRA actuator device. The initial driver supports the devices real time playback mode. But the device

Re: [PATCH v2] HID: cp2112: add I2C mode

2014-07-29 Thread Jiri Kosina
On Tue, 8 Jul 2014, Antonio Borneo wrote: cp2112 supports single I2C read/write transactions. It can't combine I2C transactions. Add master_xfer, using similar code flow as for smbus_xfer. Signed-off-by: Antonio Borneo borneo.anto...@gmail.com Reviewed-by: Benjamin Tissoires

Re: Trouble with an HP stylus

2014-07-29 Thread Jiri Kosina
On Thu, 24 Jul 2014, Éric Brunet wrote: I have a HP EliteBook Revolve 810 (which is a hybrid laptop/tablet) with the HP active pen that goes with it. I have installed fedora 20 (kernel 3.15.6-200.fc20.x86_64) on this, and the pen does not work out of the box. Playing with evtest, it appears

Re: [PATCH] fix for jabra gn9350e (hid)

2014-07-29 Thread Jiri Kosina
On Sat, 5 Jul 2014, Patrick Plattes wrote: Ignore Jabra GN9350E HID interface. USB audio is working nicely, but registering as HID blocks USB mouse buttons. Since special userspace programs are needed we will avoid attaching usbhid drivers in general. Applied. -- Jiri Kosina SUSE Labs -- To

Re: [PATCH] hid: usbhid: Use flag HID_DISCONNECTED when a usb device is removed

2014-07-29 Thread Jiri Kosina
On Fri, 25 Jul 2014, Reyad Attiyat wrote: Set disconnected flag in struct usbhid when a usb device is removed. Check for disconnected flag before sending urb requests. This prevents a kernel panic when a hid driver calls hid_hw_request() after removing a usb device. Signed-off-by: Reyad

Re: [PATCH 3/3] driver:gpio remove all usage of gpio_remove retval in driver

2014-07-29 Thread Tomi Valkeinen
On 22/07/14 18:08, Linus Walleij wrote: On Sat, Jul 12, 2014 at 10:30 PM, abdoulaye berthe berthe...@gmail.com wrote: Heads up. Requesting ACKs for this patch or I'm atleast warning that it will be applied. We're getting rid of the return value from gpiochip_remove().

Re: PATCH change for HID_BATTERY_STRENGTH kconfig

2014-07-29 Thread Jiri Kosina
On Mon, 23 Jun 2014, Daniel Nicoletti wrote: 2013-05-23 19:16 GMT-03:00 Jiri Kosina jkos...@suse.cz: On Mon, 13 May 2013, Daniel Nicoletti wrote: Hi, I'd like to propose this patch while removes the need for hid to be compiled build-in, as this is the same behavior that WiiMote and

Re: [v2] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Michal Malý
On Monday 28 of July 2014 21:21:26 Murphy, Dan wrote: Dmitry On 07/28/2014 12:59 PM, si...@mungewell.org wrote: The initial driver supports the devices real time playback mode. But the device has additional wave patterns in ROM. As it presented the device appears to be a memoryless

Re: [PATCH 0/7] Second batch of cleanups for cros_ec

2014-07-29 Thread Andreas Färber
Hi Javier, Am 28.07.2014 14:19, schrieb Javier Martinez Canillas: The patches in this series are authored by different people (all on cc) and consist of the following: Andrew Bresticker (3): mfd: cros_ec: stop calling -cmd_xfer() directly mfd: cros_ec: move locking into

Re: [PATCH 6/7] mfd: cros_ec: Instantiate sub-devices from device tree

2014-07-29 Thread Andreas Färber
Hi Javier, Am 28.07.2014 14:19, schrieb Javier Martinez Canillas: From: Todd Broch tbr...@chromium.org If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch

Re: [PATCH 7/7] Input: cros_ec_keyb: Optimize ghosting algorithm.

2014-07-29 Thread Andreas Färber
Am 28.07.2014 14:19, schrieb Javier Martinez Canillas: From: Todd Broch tbr...@chromium.org Previous algorithm was a bit conservative and complicating with respect to identifying key ghosting. This CL uses the bitops hamming weight function (hweight8) to count the number of matching rows

[PATCH 04/12] HID: uhid: avoid magic-numbers when setting strings

2014-07-29 Thread David Herrmann
Avoid hard-coding the target buffer sizes and use sizeof() instead. This also makes us future-proof to buffer-extensions later on. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/hid/uhid.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 01/12] HID: uhid: simplify report-cb shutdown

2014-07-29 Thread David Herrmann
The report-query is blocking, so when user-space destroys a device we have to wake up any blocking kernel context that is currently in the report-cb. We used some broken correlation between @report_done and @running so far. Replace it by a much more obvious use. We now wake up the report-cb if

[PATCH 00/12] HID: Convert UHID to new HID transport-layer

2014-07-29 Thread David Herrmann
Hi When Benjamin cleanup up the transport layer, he left UHID mostly unconverted due to ABI issues. I promised to take a look, so here're the patches. Most of the patches are fairly straightforward. Comments welcome. I tested an old uhid-sample.c build and it still works, so I think I didn't

[PATCH 03/12] HID: uhid: avoid dangling pointers in uhid context

2014-07-29 Thread David Herrmann
Avoid keeping uhid-rd_data and uhid-rd_size set in case uhid_dev_create2() fails. This is non-critical as we never flip uhid-running and thus never enter uhid_dev_destroy(). However, it's much nicer for debugging if pointers are only set if they point to valid data. Signed-off-by: David Herrmann

[PATCH 06/12] HID: uhid: invert report_done and make non-atomic

2014-07-29 Thread David Herrmann
All accesses to @report_done are protected by qlock (or report-contexts). No need to use an atomic. While at it, invert the logic and call it report_running. This is similar to the uhid-running field and easier to read. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/hid/uhid.c

[PATCH 02/12] HID: uhid: forward create_req to create2_req

2014-07-29 Thread David Herrmann
Instead of hard-coding the uhid_dev_create() function twice, copy any create_req into a create2_req structure and forward it. We allocate uhid_create_req on the stack here, but that should be fine. Unlike uhid_create2_req it is fairly small (1KB) and it's only used temporarily to swap entries.

[PATCH 07/12] HID: uhid: add ABI compatible UHID_GET_REPORT replacing UHID_FEATURE

2014-07-29 Thread David Herrmann
The old hdev-hid_get_raw_report() was broken by design. It was never clear what kind of HW request it should trigger. Benjamin fixed that with the core HID cleanup, though we never really adjusted uhid. Unfortunately, our old UHID_FEATURE command was modelled around the broken

[PATCH 05/12] HID: uhid: turn report_id into u32

2014-07-29 Thread David Herrmann
All accesses to @report_id are protected by @qlock. No need to use an atomic. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/hid/uhid.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 5dee8bd..db4e119

[PATCH 09/12] HID: uhid: rename uhid_raw_request to uhid_hid_raw_request

2014-07-29 Thread David Herrmann
We use strict prefixed in uhid.c: uhid_char_*: implement char-dev callbacks uhid_dev_*: implement uhid device management and runtime uhid_hid_*: implement hid-dev callbacks uhid_raw_request is an hid callback, so rename it to uhid_hid_raw_request. While at it, move it closer to it's

[PATCH 10/12] HID: uhid: implement SET_REPORT

2014-07-29 Thread David Herrmann
We so far lacked support for hid_hw_raw_request(..., HID_REQ_SET_REPORT); Add support for it and simply forward the request to user-space. Note that SET_REPORT is synchronous, just like GET_REPORT, even though it does not provide any data back besides an error code. If a transport layer does

[PATCH 12/12] HID: uhid: update documentation

2014-07-29 Thread David Herrmann
Remove legacy bits, refer people to hid-transport.txt and add descriptions for all new features. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Documentation/hid/uhid.txt | 179 +++-- 1 file changed, 92 insertions(+), 87 deletions(-) diff --git

[PATCH 08/12] HID: uhid: keep legacy definitions at the bottom of uhid.h

2014-07-29 Thread David Herrmann
Instead of inlining the legacy definitions into the main part of uhid.h, keep them at the bottom now. This way, the API is much easier to read and legacy requests can be looked up at a separate place. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- include/uapi/linux/uhid.h | 101

[PATCH 11/12] HID: uhid: report to user-space whether reports are numbered

2014-07-29 Thread David Herrmann
This makes UHID_START include a dev_flags field that describes details of the hid-device in the kernel. The first flags we introduce describe whether a given report-type uses numbered reports. This is useful for transport layers that force report-numbers and therefore might have to prefix

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-29 Thread Stephen Warren
] CPU: 0 PID: 836 Comm: rmmod Not tainted 3.16.0-rc7-next-20140729-00011-gead0778e710c-dirty #7 [ 82.029559] task: e98ba140 ti: e8cc8000 task.ti: e8cc8000 [ 82.034961] PC is at input_unregister_device+0x8/0x70 [ 82.040010] LR is at mxt_remove+0x28/0x44 [atmel_mxt_ts] [ 82.045315] pc

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-29 Thread Nick Dyer
On 29/07/14 00:42, Stephen Warren wrote: Anyway, here's the diff between the two config files: # diff -u mxt-save-after-t9-83-write.xml 224sl.raw --- mxt-save-after-t9-83-write.xml2014-07-25 19:41:45.0 + +++ 224sl.raw2014-07-28 23:25:49.0 + @@ -1,8 +1,7 @@

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-29 Thread Nick Dyer
On 29/07/14 01:10, Yufeng Shen wrote: T37 (0x25) is DEBUG_DIAGNOSTIC object which the host can read debugging info from. It is not useful to have a initial config for it so usually CrOS system would just don't include configuration for this object. Nick, I want to confirm with you that does

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-29 Thread Nick Dyer
On 29/07/14 17:16, Stephen Warren wrote: I then tried updating the firmware. This didn't work at all. First I tried via mxt-app: root@localhost:~# ./obp-utils/mxt-app -d i2c-dev:1-004b --flash 130.1_1.0.170.bin Version:1.16-65-g0a4c Opening firmware file 130.1_1.0.170.bin Registered

Re: [PATCH 2/2] Input - wacom: Remove passing id for wacom_set_report

2014-07-29 Thread Benjamin Tissoires
On Sat, Jul 26, 2014 at 7:59 AM, Przemo Firszt prz...@firszt.eu wrote: Every call of wacom_set_report was passing id as a separate parameter and buffer also passed the same information. We can use first u8 of the buffer instead of id Signed-off-by: Przemo Firszt prz...@firszt.eu --- At

Re: [PATCH 1/2] Input - Wacom: Fix transfer header problem

2014-07-29 Thread Benjamin Tissoires
On Sat, Jul 26, 2014 at 7:59 AM, Przemo Firszt prz...@firszt.eu wrote: Header of transfer of image is different depending on connection type. That patch should be probably merged with 462c52a8cbcc62c Input - wacom: Check for bluetooth protocol while setting OLEDs Signed-off-by: Przemo Firszt

[PATCH v3 1/7] Input - wacom: prepare the driver to include BT devices

2014-07-29 Thread Benjamin Tissoires
Now that wacom is a hid driver, there is no point in having a separate driver for bluetooth devices. This patch prepares the common paths of Bluetooth devices in the common wacom driver. It also adds the sysfs file speed used by Bluetooth devices. Signed-off-by: Benjamin Tissoires

[PATCH v3 7/7] HID: remove hid-wacom Bluetooth driver

2014-07-29 Thread Benjamin Tissoires
Bluetooth Wacom tablets are now handled by the regular wacom.ko driver. Remove the now useless hid-wacom driver. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/Kconfig | 10 +- drivers/hid/Makefile| 3 +- drivers/hid/hid-wacom.c | 971

[PATCH v3 6/7] Input - wacom: add copyright note and bump version to 2.0

2014-07-29 Thread Benjamin Tissoires
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/wacom.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/wacom.h b/drivers/hid/wacom.h index 0b89ee7..03692d7 100644 --- a/drivers/hid/wacom.h +++ b/drivers/hid/wacom.h @@ -12,6 +12,7 @@ *

[PATCH v3 5/7] Input - wacom: Remove passing id for wacom_set_report

2014-07-29 Thread Benjamin Tissoires
From: Przemo Firszt prz...@firszt.eu Every call of wacom_set_report was passing id as a separate parameter and buffer also passed the same information. We can use first u8 of the buffer instead of id Signed-off-by: Przemo Firszt prz...@firszt.eu Signed-off-by: Benjamin Tissoires

[PATCH v3 2/7] Input - wacom: handle Graphire BT tablets in wacom.ko

2014-07-29 Thread Benjamin Tissoires
First, merge the Graphire BT tablet. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-core.c | 1 - drivers/hid/hid-wacom.c | 1 - drivers/hid/wacom_sys.c | 33 + drivers/hid/wacom_wac.c | 95 +++--

[PATCH v3 3/7] Input - wacom: handle Intuos 4 BT in wacom.ko

2014-07-29 Thread Benjamin Tissoires
A good point of this change is that now, the Intuos4 bluetooth can handle the different tools (artpen, airbrush, mice), and we get a common interface between USB and BT for accessing the LEDs/OLEDs. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-core.c | 1

[PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

2014-07-29 Thread Benjamin Tissoires
Bluetooth Intuos 4 use 1-bit definition while the USB ones use a 4-bits definition. This changes the size of the raw image we receive, and thus the kernel will only accept 1-bit images for Bluetooth and 4-bits for USB. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com ---

[PATCH v3 0/7] Bluetooth Wacom merge into the USB driver

2014-07-29 Thread Benjamin Tissoires
Hi guys, so this patch series is intended to be applied on top of Dmitry's wacom branch. This time, I had a closer look at the various moves, and checkpatch does not complained on anything besides the open brace { [which] should be on the previous line. In v3, the difference is that now, no

Re: [PATCH 00/12] HID: Convert UHID to new HID transport-layer

2014-07-29 Thread Jiri Kosina
On Tue, 29 Jul 2014, David Herrmann wrote: Hi When Benjamin cleanup up the transport layer, he left UHID mostly unconverted due to ABI issues. I promised to take a look, so here're the patches. Most of the patches are fairly straightforward. Comments welcome. I tested an old

Re: [PATCH 00/12] HID: Convert UHID to new HID transport-layer

2014-07-29 Thread David Herrmann
Hi On Tue, Jul 29, 2014 at 9:00 PM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 29 Jul 2014, David Herrmann wrote: Hi When Benjamin cleanup up the transport layer, he left UHID mostly unconverted due to ABI issues. I promised to take a look, so here're the patches. Most of the patches are

Re: [PATCH 00/15] atmel_mxt_ts - device tree, bootloader, etc

2014-07-29 Thread Stephen Warren
On 07/29/2014 11:06 AM, Nick Dyer wrote: On 29/07/14 17:16, Stephen Warren wrote: I then tried updating the firmware. This didn't work at all. First I tried via mxt-app: root@localhost:~# ./obp-utils/mxt-app -d i2c-dev:1-004b --flash 130.1_1.0.170.bin Version:1.16-65-g0a4c Opening firmware

[Patch v3] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Dan Murphy
Add the TI drv260x haptics/vibrator driver. This device uses the input force feedback to produce a wave form to driver an ERM or LRA actuator device. The initial driver supports the devices real time playback mode. But the device has additional wave patterns in ROM. This functionality will be

Re: [PATCH] alps: rushmore and v7 resolution support

2014-07-29 Thread Dmitry Torokhov
Hi Hans, On Tue, Jul 29, 2014 at 10:07:32AM +0200, Hans de Goede wrote: Add support for querying the physical size from the touchpad for rushmore and v7 touchpads, and use that to tell userspace the device resolution. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [Patch v3] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Dmitry Torokhov
On Tue, Jul 29, 2014 at 02:32:27PM -0500, Dan Murphy wrote: Add the TI drv260x haptics/vibrator driver. This device uses the input force feedback to produce a wave form to driver an ERM or LRA actuator device. The initial driver supports the devices real time playback mode. But the device

Re: [Patch v3] input: drv260x: Add TI drv260x haptics driver

2014-07-29 Thread Murphy, Dan
Dmitry Thanks for the review. On 07/29/2014 03:01 PM, Dmitry Torokhov wrote: On Tue, Jul 29, 2014 at 02:32:27PM -0500, Dan Murphy wrote: Add the TI drv260x haptics/vibrator driver. This device uses the input force feedback to produce a wave form to driver an ERM or LRA actuator device.

Re: [PATCH v3 4/7] Input - wacom: Check for bluetooth protocol while setting OLEDs

2014-07-29 Thread Przemo Firszt
Dnia 2014-07-29, wto o godzinie 14:43 -0400, Benjamin Tissoires pisze: Bluetooth Intuos 4 use 1-bit definition while the USB ones use a 4-bits definition. This changes the size of the raw image we receive, and thus the kernel will only accept 1-bit images for Bluetooth and 4-bits for USB.

[PATCH] hid: sony: Default initialize all elements of the LED max_brightness array to 1.

2014-07-29 Thread Frank Praznik
Previously only the first element of the array was initialized to 1 leading to potential incorrect max brightness values for the LEDs on the Dualshock 3 and buzzer controllers. Use a designated initializer to initialize the whole array to the correct value. Signed-off-by: Frank Praznik

[PATCH] input: ads7846: Release resources on failure for clean exit

2014-07-29 Thread Pramod Gurav
From: Pramod Gurav pramod.gu...@smartplayin.com Input device must be released(input_free_device) when ads7846_probe_dt fails. This fixes the same by releasing resources on failure. CC: Dmitry Torokhov dmitry.torok...@gmail.com CC: Lejun Zhu lejun@linux.intel.com CC: Sachin Kamat