Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Sjoerd Simons
Hey Lee, On Wed, 2014-09-10 at 10:28 +0100, Lee Jones wrote: On Tue, 09 Sep 2014, Javier Martinez Canillas wrote: [adding Lee Jones to cc list since I'm referring on a series he posted] Hello Sjoerd, On 09/09/2014 09:52 AM, Sjoerd Simons wrote: For i2c devices in OF the modalias

Re: [PATCH 1/4 v2] HID: wacom - Add default permission defines for sysfs attributes

2014-09-11 Thread Jiri Kosina
I have applied the whole series to hid.git#for-3.18/wacom. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Javier Martinez Canillas
Hello Lee, On 09/11/2014 10:00 AM, Sjoerd Simons wrote: -static const struct of_device_id mxt_of_match[] = { -{ .compatible = atmel,maxtouch, }, -{}, -}; -MODULE_DEVICE_TABLE(of, mxt_of_match); - static const struct i2c_device_id mxt_id[] = {

[PATCH] i8042: Add nomux quirk for Avatar AVIU-145A6

2014-09-11 Thread Hans de Goede
The sys_vendor / product_name are somewhat generic unfortunately, so this may lead to some false positives. But nomux usually does no harm, where as not having it clearly is causing problems on the Avatar AVIU-145A6. https://bugzilla.kernel.org/show_bug.cgi?id=77391 Cc: sta...@vger.kernel.org

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-11 Thread Fredrik Hallenberg
The nicest fix, obviously, is to blacklist keys that are not physically present on the keyboard. But I assume the keyboard reports Hmm, somebody could still load keymap with duplicate keycodes though... The HID mapping is hardcoded, so only key code 43 will have this problem regardless of

[PATCH 1/3] i8042: Also store the aux firmware id in multi-plexed aux ports

2014-09-11 Thread Hans de Goede
So that firmware-id matching can be used with multiplexed aux ports too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/input/serio/i8042.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 3807c3e..f5a98af 100644

[PATCH 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

2014-09-11 Thread Hans de Goede
The Asus X450 and X550 laptops use a PS/2 touchpad from a new manufacturer called FocalTech: https://bugzilla.kernel.org/show_bug.cgi?id=77391 https://bugzilla.redhat.com/show_bug.cgi?id=1110011 The protocol for these devices is not known at this time, but even without knowing the protocol they

[PATCH 2/3] psmouse: Add psmouse_matches_pnp_id helper function

2014-09-11 Thread Hans de Goede
The matches_pnp_id function from the synaptics driver is useful for other drivers too. Make it a generic psmouse helper function. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/input/mouse/psmouse-base.c | 14 ++ drivers/input/mouse/psmouse.h | 1 +

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Nick Dyer
On 11/09/14 09:38, Javier Martinez Canillas wrote: To expand on what Sjoerd already said and just to be sure everyone is on the same page. The problem is that right now the driver reports the following modalias: # cat /sys/class/i2c-adapter/i2c-8/8-004b/modalias i2c:maxtouch but if you

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Javier Martinez Canillas
Hello Nick, On 09/11/2014 11:19 AM, Nick Dyer wrote: Thanks for the clear explanation. The i2c aliases are a bit confusing. The original device the driver was written for was called qt602240, which was renamed by Atmel to mXT224 when the chip series was called maXTouch. The driver now

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Wolfram Sang
Funny timing. I am just reviewing the series from Lee and also stumbled over modaliases, too... On Thu, Sep 11, 2014 at 10:19:54AM +0100, Nick Dyer wrote: On 11/09/14 09:38, Javier Martinez Canillas wrote: To expand on what Sjoerd already said and just to be sure everyone is on the same

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Javier Martinez Canillas
Hello Wolfram, On 09/11/2014 01:08 PM, Wolfram Sang wrote: Funny timing. I am just reviewing the series from Lee and also stumbled over modaliases, too... On Thu, Sep 11, 2014 at 10:19:54AM +0100, Nick Dyer wrote: On 11/09/14 09:38, Javier Martinez Canillas wrote: To expand on what

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Wolfram Sang
This is a workaround. It would make sense, however, to add it because we want to support i2c_board_info structures. I think it really depends if an IP block can be used on non-DT platforms (which I think is true for this trackpad) but if a driver is for an IP block that can only be

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Javier Martinez Canillas
Hello Wolfram, On 09/11/2014 01:35 PM, Wolfram Sang wrote: This is a workaround. It would make sense, however, to add it because we want to support i2c_board_info structures. I think it really depends if an IP block can be used on non-DT platforms (which I think is true for this

Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

2014-09-11 Thread Nishanth Menon
Hi Dimtry, On 14:13-20140910, Dmitry Torokhov wrote: On Thu, Aug 21, 2014 at 02:01:43PM -0500, Nishanth Menon wrote: On 08/21/2014 01:03 PM, Dmitry Torokhov wrote: I believe I have taken care of other concerns on v2, but..Arrgh.. I did not reply to this comment.. BTW, I do not think

Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

2014-09-11 Thread Nick Dyer
On 11/09/14 12:41, Javier Martinez Canillas wrote: On 09/11/2014 01:35 PM, Wolfram Sang wrote: This is a workaround. It would make sense, however, to add it because we want to support i2c_board_info structures. I think it really depends if an IP block can be used on non-DT platforms (which

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-11 Thread David Herrmann
Hi On Thu, Sep 11, 2014 at 10:50 AM, Fredrik Hallenberg megahal...@gmail.com wrote: The nicest fix, obviously, is to blacklist keys that are not physically present on the keyboard. But I assume the keyboard reports Hmm, somebody could still load keymap with duplicate keycodes though... The

[PATCH v4 1/4] mfd: max77693: Initialize haptic register map

2014-09-11 Thread Jaewon Kim
This patch add regmap_haptic initialization to use haptic register map in haptic device driver. Signed-off-by: Jaewon Kim jaewon02@samsung.com Acked-by: Chanwoo Choi cw00.c...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/max77693.c | 21 ++--- 1 file

[PATCH v4 3/4] mfd: max77693: add haptic of_compatible in mfd_cell

2014-09-11 Thread Jaewon Kim
This patch add haptic of_compatible in order to use the haptic device driver using Devicetree. Signed-off-by: Jaewon Kim jaewon02@samsung.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/mfd/max77693.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v4 4/4] mfd: max77693: Update DT binding to support haptic

2014-09-11 Thread Jaewon Kim
This patch add haptic DT binding documentation and example to support haptic driver in max77693 Multifunction device. Signed-off-by: Jaewon Kim jaewon02@samsung.com Acked-by: Chanwoo Choi cw00.c...@samsung.com --- Documentation/devicetree/bindings/mfd/max77693.txt | 18 ++

[PATCH v4 2/4] Input: misc: Add haptic driver on max77693

2014-09-11 Thread Jaewon Kim
This patch add max77693-haptic device driver to support the haptic controller on MAX77693. The MAX77693 is a Multifunction device with PMIC, CHARGER, LED, MUIC, HAPTIC and the patch is haptic device driver in the MAX77693. This driver support external pwm and LRA(Linear Resonant Actuator) motor.

[PATCH v4 0/4] Add max77693 haptic driver

2014-09-11 Thread Jaewon Kim
This series adds max77693 haptic driver. The max77693 is a Multifunction device with PMIC, CHARGER, LED, MUIC, HAPTIC and this series is haptic device driver in MAX77693. The haptic driver use regmap method for i2c communication and support force feedback framework in input device. Changes in v4:

[PATCH] Input: atmel_mxt_ts - fix merge in DT documentation

2014-09-11 Thread Nick Dyer
On 15/08/14 17:13, Stephen Warren wrote: Any comments on this? I would really appreciate if you can expand on how this DT property is supposed to be used so I can re-spin the atmel support patch for Peach boards. The below patch improves the documentation for the gpio-property. That patch

Re: [PATCH] input: atkbd - Fix broken keyboard in another LG laptop

2014-09-11 Thread Jaime Velasco Juan
Dmitry Torokhov dmitry.torok...@gmail.com writes: Hi Jamie, On Wed, Sep 10, 2014 at 07:06:14PM +0100, Jaime Velasco Juan wrote: This model has the same quirk as others, see 3d725caa9dcc Input: atkbd - fix keyboard not working on some LG laptops How about the patch below instead? It

Re: [PATCH] input: atkbd - Fix broken keyboard in another LG laptop

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 05:53:08PM +0100, Jaime Velasco Juan wrote: Dmitry Torokhov dmitry.torok...@gmail.com writes: Hi Jamie, On Wed, Sep 10, 2014 at 07:06:14PM +0100, Jaime Velasco Juan wrote: This model has the same quirk as others, see 3d725caa9dcc Input: atkbd - fix keyboard not

Re: Status of the plan to set i8042.nomux=1 by default ?

2014-09-11 Thread Dmitry Torokhov
On Wed, Sep 10, 2014 at 08:10:09PM +0200, Hans de Goede wrote: Hi Dmitry, I wonder what the status of $subject is ? I'm asking because a user joined the discussion here: https://bugzilla.kernel.org/show_bug.cgi?id=77391 And I ended up debugging his problem a bit, and his laptop needs

Re: [PATCH v4 2/4] Input: misc: Add haptic driver on max77693

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 09:54:20PM +0900, Jaewon Kim wrote: This patch add max77693-haptic device driver to support the haptic controller on MAX77693. The MAX77693 is a Multifunction device with PMIC, CHARGER, LED, MUIC, HAPTIC and the patch is haptic device driver in the MAX77693. This

[PATCH] HID: wacom: make the WL connection friendly for the desktop

2014-09-11 Thread Benjamin Tissoires
Currently, tablets connected to the WL receiver all share the same VID/PID. There is no way for the user space to know which one is which besides parsing the name. We can force the PID to be set to the actual hardware. This way, the input device will have the correct PID which can be match in

Re: [PATCH v2] HID: rmi: check sanity of the incoming report

2014-09-11 Thread Benjamin Tissoires
On Wed, Sep 10, 2014 at 9:02 PM, Andrew Duggan adug...@synaptics.com wrote: From: Benjamin Tissoires benjamin.tissoi...@redhat.com In the Dell XPS 13 9333, it appears that sometimes the bus get confused and corrupts the incoming data. It fills the input report with the sentinel value ff.

Re: [PATCH 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

2014-09-11 Thread Dmitry Torokhov
Hi Hans, On Thu, Sep 11, 2014 at 10:50:47AM +0200, Hans de Goede wrote: @@ -722,6 +723,13 @@ static int psmouse_extensions(struct psmouse *psmouse, { bool synaptics_hardware = false; +/* Always check for focaltech, this is safe as it uses pnp-id matching */ + if

Re: [PATCH 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

2014-09-11 Thread Hans de Goede
Hi, On 09/11/2014 07:26 PM, Dmitry Torokhov wrote: Hi Hans, On Thu, Sep 11, 2014 at 10:50:47AM +0200, Hans de Goede wrote: @@ -722,6 +723,13 @@ static int psmouse_extensions(struct psmouse *psmouse, { bool synaptics_hardware = false; +/* Always check for focaltech, this is safe

Re: [PATCH] Input: atmel_mxt_ts - fix merge in DT documentation

2014-09-11 Thread Dmitry Torokhov
On Thu, Sep 11, 2014 at 03:52:46PM +0100, Nick Dyer wrote: On 15/08/14 17:13, Stephen Warren wrote: Any comments on this? I would really appreciate if you can expand on how this DT property is supposed to be used so I can re-spin the atmel support patch for Peach boards. The below patch

Fwd: [PATCH] HID: wacom: make the WL connection friendly for the desktop

2014-09-11 Thread Ping Cheng
On Thu, Sep 11, 2014 at 10:14 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Currently, tablets connected to the WL receiver all share the same VID/PID. There is no way for the user space to know which one is which besides parsing the name. We can force the PID to be set to the

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-11 Thread Fredrik Hallenberg
Thanks I had no idea about the hwdb but I have tried it now, it works if I use KEYBOARD_KEY_70031=reserved on my nordic keyboard, but a US keyboard user would have to use scancode 70032 instead. If you chose the wrong one the backslash key will be disabled. I don't think this is good solution

Re: [PATCH v4 2/4] Input: misc: Add haptic driver on max77693

2014-09-11 Thread Jaewon Kim
Hello Dmity Torokhov. 2014년 09월 12일 02:10에 Dmitry Torokhov 이(가) 쓴 글: On Thu, Sep 11, 2014 at 09:54:20PM +0900, Jaewon Kim wrote: This patch add max77693-haptic device driver to support the haptic controller on MAX77693. The MAX77693 is a Multifunction device with PMIC, CHARGER, LED, MUIC,