Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread Fredrik Hallenberg
FYI I just got a lsusb -v dump from a US version of my keyboard, and it is exactly the same as the one from my nordic version. On Mon, Sep 15, 2014 at 12:53 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Thank you for this, I felt that it would be difficult to do a good solution with hwdb

Re: [PATCH 1/2] hid: sony: Corrections for the DualShock 4 HID descriptor

2014-09-15 Thread Jiri Kosina
On Sun, 14 Sep 2014, Frank Praznik wrote: Fix a few minor issues in the HID descriptor: - A 6 bit entry had a logical maximum of 255 when the largest it can be is 63. - A logical max value was incorrectly being set to -1 instead of 255. - Set the min/max of the gyroscopes to -8192/8191

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread Benjamin Tissoires
On Sun, Sep 14, 2014 at 12:45 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Aug 10, 2014 at 11:56 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Here is my attempt on a fix for bug 70181, please review it. It is tested on my nordic Corsair K70, if this solution is deemed

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread Benjamin Tissoires
On Mon, Sep 15, 2014 at 10:39 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Sun, Sep 14, 2014 at 12:45 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Aug 10, 2014 at 11:56 AM, Fredrik Hallenberg megahal...@gmail.com wrote: Here is my attempt on a fix for bug

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 4:47 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Sep 15, 2014 at 10:39 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Sun, Sep 14, 2014 at 12:45 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Aug 10, 2014 at

Re: [PATCH] Handle spurious backslash key repeats on some keyboards

2014-09-15 Thread Benjamin Tissoires
On Mon, Sep 15, 2014 at 10:52 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Mon, Sep 15, 2014 at 4:47 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Sep 15, 2014 at 10:39 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Sun, Sep 14, 2014 at 12:45 PM,

Re: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c

2014-09-15 Thread Nishanth Menon
On 09/15/2014 09:40 AM, Jim Davis wrote: Building with the attached random configuration file, FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister' make[1]: *** [__modpost] Error 1 For some reason, I was unable to reproduce this

Re: [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

2014-09-15 Thread Dmitry Torokhov
On Sat, Sep 13, 2014 at 10:10:23AM +0200, Hans de Goede wrote: Hi, On 09/13/2014 02:26 AM, Dmitry Torokhov wrote: Hi Hans, On Fri, Sep 12, 2014 at 11:08:32AM +0200, Hans de Goede wrote: +/* Always check for focaltech, this is safe as it uses pnp-id matching */ + if

Re: [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

2014-09-15 Thread Hans de Goede
Hi, On 09/15/2014 07:39 PM, Dmitry Torokhov wrote: On Sat, Sep 13, 2014 at 10:10:23AM +0200, Hans de Goede wrote: Hi, On 09/13/2014 02:26 AM, Dmitry Torokhov wrote: Hi Hans, On Fri, Sep 12, 2014 at 11:08:32AM +0200, Hans de Goede wrote: +/* Always check for focaltech, this is safe as it

[PATCH] Input: palmas-pwrbutton: Fix IRQ flags for using threaded handler alone.

2014-09-15 Thread Nishanth Menon
make C=2 CHECK=scripts/coccicheck MODE=report COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci ./drivers/input/misc/palmas-pwrbutton.o Reports: drivers/input/misc/palmas-pwrbutton.c:213:9-29: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Palmas powerbutton just

[PATCH] Input: palmas-pwrbutton: Fix typo in License

2014-09-15 Thread Nishanth Menon
Follow the license string convention indicated in include/linux/module.h (don't capitalize v). This fixes following randconfig warning: FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister' Cc: Stephen Rothwell s...@canb.auug.org.au

Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License

2014-09-15 Thread Nishanth Menon
On 09/15/2014 12:58 PM, Nishanth Menon wrote: Follow the license string convention indicated in include/linux/module.h (don't capitalize v). This fixes following randconfig warning: FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Michael Wright
Why not introduce all 8 player LEDs as described in the document? You should be safe increasing LED_MAX to 0x1f. Wasn't sure if it was safe to bump it since it could potentially break apps until they recompile against the new API. I'll send another patchset with all of them. On Sun, Sep 14,

H

2014-09-15 Thread Diana
Please Revert back, your assistance is needed. --- The Exhibitor at innoTrans, Berlin 2014 Hall : 15.1 / Stand no : 109 http://www.virtualmarket.innotrans.de/?Action=showCompanyid=346242 -- To unsubscribe from this list: send the line unsubscribe linux-input in

Re: randconfig build error with next-20140915, in drivers/input/misc/palmas-pwrbutton.c

2014-09-15 Thread Nishanth Menon
On 09/15/2014 12:30 PM, Nishanth Menon wrote: On 09/15/2014 09:40 AM, Jim Davis wrote: Building with the attached random configuration file, FATAL: modpost: GPL-incompatible module palmas-pwrbutton.ko uses GPL-only symbol 'platform_driver_unregister' make[1]: *** [__modpost] Error 1 For

Re: [PATCH] Input: palmas-pwrbutton: Fix typo in License

2014-09-15 Thread Dmitry Torokhov
On Mon, Sep 15, 2014 at 01:00:44PM -0500, Nishanth Menon wrote: On 09/15/2014 12:58 PM, Nishanth Menon wrote: Follow the license string convention indicated in include/linux/module.h (don't capitalize v). This fixes following randconfig warning: FATAL: modpost: GPL-incompatible module

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Dmitry Torokhov
On Mon, Sep 15, 2014 at 11:03:47AM -0700, Michael Wright wrote: Why not introduce all 8 player LEDs as described in the document? You should be safe increasing LED_MAX to 0x1f. Wasn't sure if it was safe to bump it since it could potentially break apps until they recompile against the new

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread David Herrmann
Hi On Mon, Sep 15, 2014 at 11:57 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Sep 15, 2014 at 11:03:47AM -0700, Michael Wright wrote: Why not introduce all 8 player LEDs as described in the document? You should be safe increasing LED_MAX to 0x1f. Wasn't sure if it was safe

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Dmitry Torokhov
Hi David, On Tue, Sep 16, 2014 at 12:15:08AM +0200, David Herrmann wrote: Hi On Mon, Sep 15, 2014 at 11:57 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Sep 15, 2014 at 11:03:47AM -0700, Michael Wright wrote: Why not introduce all 8 player LEDs as described in the

Re: [PATCH v4 4/4] mfd: max77693: Update DT binding to support haptic

2014-09-15 Thread Lee Jones
On Thu, 11 Sep 2014, Jaewon Kim wrote: This patch add haptic DT binding documentation and example to support haptic driver in max77693 Multifunction device. Signed-off-by: Jaewon Kim jaewon02@samsung.com Acked-by: Chanwoo Choi cw00.c...@samsung.com ---

Re: [PATCH v3 2/4] Input: misc: Add haptic driver on max77693

2014-09-15 Thread Lee Jones
On Fri, 05 Sep 2014, Jaewon Kim wrote: This patch add max77693-haptic device driver to support the haptic controller on MAX77693. The MAX77693 is a Multifunction device with PMIC, CHARGER, LED, MUIC, HAPTIC and the patch is haptic device driver in the MAX77693. This driver support external

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Michael Wright
LEDs should be controlled via LED subsystem. The fact that they happen to be located on a given device does not mean they belong to input subsystem. The same as LEds on network card are not part of network stack, etc. I think the fundamental difference for me is that the primary input

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Dmitry Torokhov
On Mon, Sep 15, 2014 at 04:41:42PM -0700, Michael Wright wrote: LEDs should be controlled via LED subsystem. The fact that they happen to be located on a given device does not mean they belong to input subsystem. The same as LEds on network card are not part of network stack, etc. I

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread Michael Wright
On Mon, Sep 15, 2014 at 5:54 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: ... That predates LED subsystem. When we saw that it is not flexible enough LED subsystem was created. Input, for better or worse, has sound support as well, but I do not think anyone would want to to enhance

Re: [PATCH] HID: add new gamepad LED constants

2014-09-15 Thread simon
Even if I did add the plumbing for HID over into the LED subsystem, is there an easy way to correlate input devices and their LEDs from userspace? You can follow the symlinks through the '/sys' filesystem. For example the following all point to the same LED. -- simon@womble:~$ ls