Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Hi, Am 15.01.2015 um 15:38 schrieb Sebastian Reichel s...@kernel.org: Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual drivers. I think we should allocate a new bitmaps for some transformations and have

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Wolfram Sang
On Thu, Jan 15, 2015 at 04:54:14PM +0200, Laurent Pinchart wrote: DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes must list both adi,adxl346 and adi,adxl345, in that order.

Re: [PATCH] rotary encoder: Add wake up support

2015-01-15 Thread Dmitry Torokhov
On Tue, Jan 13, 2015 at 04:51:02PM +0100, Sylvain Rochet wrote: This patch add wake up support for rotary encoders. New DT property: rotary-encoder,wakeup Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- .../devicetree/bindings/input/rotary-encoder.txt | 1 +

Re: [RESEND PATCH] Input:Evdev Flush pending events on clk change

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 07:07:50AM -0800, Anshul Garg wrote: From: Anshul Garg aksgarg1...@gmail.com If client clk_type is changed , flush pending events from client buffer as events time would be incorrect and queue SYN_DROPPED event. Added check for duplicate clk_type change request.

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 06:45:33PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 3:54 PM, Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com wrote: The I2C subsystem can match devices without explicit OF support based on the part of their compatible property after the

Re: [PATCH v8 4/6] input: misc: Add ABI docs for AXP20x PEK

2015-01-15 Thread Dmitry Torokhov
Hi Chen-Yu, On Fri, Jan 16, 2015 at 12:00:31AM +0800, Chen-Yu Tsai wrote: On Tue, Dec 23, 2014 at 10:53 AM, Chen-Yu Tsai w...@csie.org wrote: From: Carlo Caione ca...@caione.org Add ABI entries for the PEK found on PMU X-Powers AXP202 and AXP209. Hi Dmitry, Would it be possible to

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Wolfram Sang
On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang w...@the-dreams.de wrote: --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -18,8 +18,7 @@

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 6:43 PM, Wolfram Sang w...@the-dreams.de wrote: On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang w...@the-dreams.de wrote: --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov wrote: Hi Pali, This series try to address the issue you brought regarding trackstick initialization on Dell Latitudes in a different way than the patches you proposed.

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: Am 15.01.2015 um 15:38 schrieb Sebastian Reichel s...@kernel.org: Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 3:54 PM, Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com wrote: DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes must list both adi,adxl346 and

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Am 15.01.2015 um 19:16 schrieb Dmitry Torokhov dmitry.torok...@gmail.com: On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: Am 15.01.2015 um 15:38 schrieb Sebastian Reichel s...@kernel.org: Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 3:54 PM, Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com wrote: The I2C subsystem can match devices without explicit OF support based on the part of their compatible property after the comma. However, this mechanism uses the first compatible value only. For

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Wolfram Sang
On Thu, Jan 15, 2015 at 04:54:15PM +0200, Laurent Pinchart wrote: The I2C subsystem can match devices without explicit OF support based on the part of their compatible property after the comma. However, this mechanism uses the first compatible value only. For adxl34x OF device nodes the

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 06:02:09PM +0100, Wolfram Sang wrote: On Thu, Jan 15, 2015 at 04:54:14PM +0200, Laurent Pinchart wrote: DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Sebastian Reichel
Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual drivers. I think we should allocate a new bitmaps for some transformations and have the code do X/Y flip/clip of the coordinates. Do you have a

[PATCH v2 0/2] Fix OF match for adxl34x driver

2015-01-15 Thread Laurent Pinchart
Hello, This patch set fixes OF matching for the adxl34x driver when the DT node lists a device-specific adi,adxl345 or adi,adxl346 compatible value first. The first version (see http://www.spinics.net/lists/linux-i2c/msg18107.html) added an OF match entry for the adi,adxl34x compatible string.

[PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Laurent Pinchart
The I2C subsystem can match devices without explicit OF support based on the part of their compatible property after the comma. However, this mechanism uses the first compatible value only. For adxl34x OF device nodes the compatible property will contain the more specific adi,adxl345 or

[RESEND PATCH] Input:Evdev Flush pending events on clk change

2015-01-15 Thread Anshul Garg
From: Anshul Garg aksgarg1...@gmail.com If client clk_type is changed , flush pending events from client buffer as events time would be incorrect and queue SYN_DROPPED event. Added check for duplicate clk_type change request. Signed-off-by: Anshul Garg anshu...@samsung.com ---

Re: [PATCH v8 4/6] input: misc: Add ABI docs for AXP20x PEK

2015-01-15 Thread Chen-Yu Tsai
On Tue, Dec 23, 2014 at 10:53 AM, Chen-Yu Tsai w...@csie.org wrote: From: Carlo Caione ca...@caione.org Add ABI entries for the PEK found on PMU X-Powers AXP202 and AXP209. Hi Dmitry, Would it be possible to take this patch through your tree? Thanks ChenYu Signed-off-by: Carlo Caione

[PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Laurent Pinchart
DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes must list both adi,adxl346 and adi,adxl345, in that order. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Am 15.01.2015 um 15:38 schrieb Sebastian Reichel s...@kernel.org: Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual drivers. I think we should allocate a new bitmaps for some transformations and have

Re: [PATCH 6/6] Input: ALPS - mix trackstick and external PS/2 mouse data

2015-01-15 Thread Pali Rohár
On Wednesday 14 January 2015 23:55:54 Dmitry Torokhov wrote: From: Pali Rohár pali.ro...@gmail.com Previously dev2 device was used for both external PS/2 mouse and internal trackstick device (if available). This change introduces dev3 device which is used for external PS/2 mouse data and

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Laurent Pinchart
On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote: I still do not understand what we are trying to fix here. Why is adi,adxl34x compatible string no good anymore? If we start using exact models and the physical device does

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
Hi Dmitry, On 15-01-14 10:07 PM, Dmitry Torokhov wrote: On Wed, Jan 14, 2015 at 09:44:39PM -0800, Scott Branden wrote: On 15-01-14 05:02 PM, Dmitry Torokhov wrote: Hi Jonathan, On Fri, Dec 19, 2014 at 02:17:49PM -0800, Jonathan Richardson wrote: + if (of_property_read_u32(np,

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 09:28:41PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 20:38:18 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Laurent Pinchart
On Thursday 15 January 2015 13:06:32 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote: I still do not understand what we are

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov wrote: Hi Pali, This series try to address

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Laurent Pinchart
Hi Wolfram, On Thursday 15 January 2015 18:43:33 Wolfram Sang wrote: On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang w...@the-dreams.de wrote: --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2015-01-15 Thread Jonathan Richardson
On 15-01-14 05:08 PM, Florian Fainelli wrote: On 19/12/14 15:03, Jonathan Richardson wrote: On 14-12-19 02:26 PM, Joe Perches wrote: On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: Add initial version of the Broadcom touchscreen driver. more trivia: diff --git

Re: [PATCH 6/6] Input: ALPS - mix trackstick and external PS/2 mouse data

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 09:34:51PM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:54 Dmitry Torokhov wrote: From: Pali Rohár pali.ro...@gmail.com Previously dev2 device was used for both external PS/2 mouse and internal trackstick device (if available). This change

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote: I still do not understand what we are trying to fix here. Why is adi,adxl34x compatible string no good

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
On Thursday 15 January 2015 20:38:18 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 11:34:00PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 13:06:32 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM,

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Sergei Shtylyov
Hello. On 01/15/2015 11:34 PM, Laurent Pinchart wrote: I still do not understand what we are trying to fix here. Why is adi,adxl34x compatible string no good anymore? If we start using exact models and the physical device does not match do we abort probe? What is the problem that we are

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov wrote: Hi Pali, This series try to address the issue you brought regarding trackstick initialization on Dell

Re: [PATCH 5/6] Input: ALPS - fix trackstick detection on some Dell Latitudes

2015-01-15 Thread Dmitry Torokhov
On Thu, Jan 15, 2015 at 09:21:34PM +0100, Pali Rohár wrote: On Wednesday 14 January 2015 23:55:53 Dmitry Torokhov wrote: + /* +* Reset the device to make sure it is fully operational: +* on some laptops, like certain Dell Latitudes, we may +* fail to properly detect presence

lan

2015-01-15 Thread YesGrowth Loans
God dag, Jeg er Rose Butler, den udøvende agent på et generelt anerkendt legitimt långivende selskab kaldet YesGrowth Lån, der ligger i Det Forenede Kongerige. Vi låner penge til enkeltpersoner og virksomheder, der har brug finansiel bistand. Har du har en dårlig kredit, eller du har brug

Re: [PATCH v8 0/6] mfd: AXP20x: Add support for AXP202 and AXP209

2015-01-15 Thread Chen-Yu Tsai
On Tue, Dec 23, 2014 at 10:53 AM, Chen-Yu Tsai w...@csie.org wrote: Hi everyone, This is v8 of the AXP20x PMIC patches. These are the remaining patches of the original series: PEK (power button) input driver, binding docs, and defconfig updates. Mark raised some questions during v7 about

Re: [PATCH v8 4/6] input: misc: Add ABI docs for AXP20x PEK

2015-01-15 Thread Chen-Yu Tsai
On Fri, Jan 16, 2015 at 1:39 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Chen-Yu, On Fri, Jan 16, 2015 at 12:00:31AM +0800, Chen-Yu Tsai wrote: On Tue, Dec 23, 2014 at 10:53 AM, Chen-Yu Tsai w...@csie.org wrote: From: Carlo Caione ca...@caione.org Add ABI entries for the PEK

[PATCH v18 00/12] input: cyapa: instruction of cyapa patches

2015-01-15 Thread Dudley Du
V18 patches have below updates, details of other updates see history list: 1) Fix 'cyapa_runtime_suspend' undeclared compiling issue in latest kernel-next source code. Verified on next-20150114 with make C=1. 2) Optimize enter bootloader failed for some chipset takes longer time issue. This

[PATCH v18 05/12] input: cyapa: add sysfs interfaces support in the cyapa driver

2015-01-15 Thread Dudley Du
Add device's basic control and features supported in cyapa driver through sysfs file system interfaces. These interfaces are commonly used in pre- and after production, for trackpad device state checking, managing and firmware image updating. These interfaces including mode, firmware_version and

[PATCH v18 10/12] input: cyapa: add gen5 trackpad device read baseline function support

2015-01-15 Thread Dudley Du
Add read baseline function supported for gen5 trackpad device, it can be used through sysfs baseline interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa.h | 2 + drivers/input/mouse/cyapa_gen5.c | 640

[PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

2015-01-15 Thread Dudley Du
Add firmware image update function supported for gen5 trackpad device, it can be used through sysfs update_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/Kconfig | 1 + drivers/input/mouse/cyapa_gen5.c | 391

[PATCH v18 12/12] input: cyapa: add acpi device id support

2015-01-15 Thread Dudley Du
Add acpi device tree support. acpi device id CYAP is for old gen3 trackpad devices. acpi device id CYAP0001 is for new gen5 trackpad devices. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa.c | 13 + 1 file changed, 13

[PATCH v18 07/12] input: cyapa: add gen3 trackpad device read baseline function support

2015-01-15 Thread Dudley Du
Add read baseline function supported for gen3 trackpad device, it can be used through sysfs baseline interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa_gen3.c | 72 1 file changed, 72 insertions(+)

[PATCH v18 06/12] input: cyapa: add gen3 trackpad device firmware update function support

2015-01-15 Thread Dudley Du
Add firmware image update function supported for gen3 trackpad device, it can be used through sysfs update_fw interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa_gen3.c | 309 +++ 1 file changed, 309

[PATCH v18 04/12] input: cyapa: add runtime power management interfaces support for the device

2015-01-15 Thread Dudley Du
Add runtime_suspend_scanrate_ms power management interfaces in device's power group, so users or applications can control the runtime power management strategy of trackpad device as their requirements. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com ---

[PATCH v18 11/12] input: cyapa: add gen5 trackpad device force re-calibrate function support

2015-01-15 Thread Dudley Du
Add force re-calibrate function supported for gen5 trackpad device, it can be used through sysfs calibrate interface. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa_gen5.c | 65 1 file changed, 65

[PATCH v18 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver

2015-01-15 Thread Dudley Du
In order to support multiple different chipsets and communication protocols trackpad devices in one cyapa driver, the new cyapa driver is re-designed with one cyapa driver core and multiple device specific functions component. The cyapa driver core is contained in this patch, it supplies basic

[PATCH v18 03/12] input: cyapa: add power management interfaces support for the device

2015-01-15 Thread Dudley Du
Add suspend_scanrate_ms power management interfaces in device's power group, so users or applications can control the power management strategy of trackpad device as their requirements. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com --- drivers/input/mouse/cyapa.c | 127

[PATCH v18 02/12] input: cyapa: add gen5 trackpad device basic functions support

2015-01-15 Thread Dudley Du
Based on the cyapa core, add the gen5 trackpad device's basic functions supported, so gen5 trackpad device can work with kernel input system. And also based on the state parse interface, the cyapa driver can automatically determine the attached is gen3 or gen5 protocol trackpad device, then set

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-15 Thread Pali Rohár
On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov wrote: Hi Pali, This series try to address the issue you brought regarding trackstick initialization on Dell Latitudes in a different way than the patches you proposed. Basically in this series we move resetting and all detection in

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 1:53 PM, Wolfram Sang w...@the-dreams.de wrote: There are three compatible strings defined for the ADXL345 and ADXL346 in Documentation/devicetree/bindings/i2c/trivial-devices.txt: adi,adxl345, adi,adxl346, adi,adxl34x. Given that the last one is a fallback for the

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: I still do not understand what we are trying to fix here. Why is adi,adxl34x compatible string no good anymore? If we start using exact models and the physical device does not match do we abort probe? What is the

Re: [PATCH 5/6] Input: ALPS - fix trackstick detection on some Dell Latitudes

2015-01-15 Thread Pali Rohár
On Wednesday 14 January 2015 23:55:53 Dmitry Torokhov wrote: + /* + * Reset the device to make sure it is fully operational: + * on some laptops, like certain Dell Latitudes, we may + * fail to properly detect presence of trackstick if device + * has not been reset. +

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Laurent Pinchart
On Thursday 15 January 2015 16:19:19 Laurent Pinchart wrote: On Thursday 15 January 2015 13:53:22 Wolfram Sang wrote: On Thu, Dec 18, 2014 at 02:49:28PM +0200, Laurent Pinchart wrote: On Thursday 18 December 2014 09:21:51 Wolfram Sang wrote: On Thu, Dec 18, 2014 at 04:15:23AM +0200, Laurent

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 3:19 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: An option would be to remove adi,adxl34x from Documentation/devicetree/bindings/i2c/trivial-devices.txt, in which case the driver should match explicitly on adi,adxl345 and adi,adxl346. That might

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Laurent Pinchart
On Thursday 15 January 2015 15:36:37 Wolfram Sang wrote: Been there, got bitten. We only found out too late, because one driver was in i2c and the other in GPIO (or LED even?), both using 953x :( That seems like a development, review and/or merge process failure to me, I wouldn't avoid