Re: [PATCH v4 2/5] ARM:sunxi:drivers:input Add support for A10/A20 PS2

2015-01-18 Thread Vishnu Patekar
Hello Dmitry, Thank you for review comments. Please see in-lined. On Sun, Jan 18, 2015 at 3:55 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Vishnu, On Fri, Jan 16, 2015 at 07:33:38PM +0530, Vishnu Patekar wrote: Signed-off-by: VishnuPatekar vishnupatekar0...@gmail.com ---

[PATCH 1/2] HID: hid-lg4ff: fix sysfs attribute permission

2015-01-18 Thread Vivien Didelot
There is no reason to set the range attribute executable to the user and group, and writable to the group. Fix the permission to 0644. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/hid/hid-lg4ff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] HID: hid-lg4ff: use DEVICE_ATTR_RW macro

2015-01-18 Thread Vivien Didelot
Use the DEVICE_ATTR_RW macro to reduce boiler plate and move the attribute declaration to get rid of function signatures. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/hid/hid-lg4ff.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v1 4/4] leds: no longer use unnamed gpios

2015-01-18 Thread Alexandre Courbot
On Wed, Jan 14, 2015 at 10:20 PM, Olliver Schinagl oli...@schinagl.nl wrote: On 14-01-15 13:45, Linus Walleij wrote: On Thu, Jan 8, 2015 at 11:12 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Jan 08, 2015 at 08:40:20AM -0600, Rob Herring wrote: On Thu, Jan 8, 2015 at 2:45

RE: [PATCH v18 00/12] input: cyapa: instruction of cyapa patches

2015-01-18 Thread Dudley Du
Jeremiah, Thanks. If there is something that I could do, please let me know. Thanks, Dudley -Original Message- From: Jeremiah Mahler [mailto:jmmah...@gmail.com] Sent: 2015?1?18? 6:46 To: David Solda Cc: Dudley Du; dmitry.torok...@gmail.com; rydb...@euromail.se; ble...@google.com;

RE: [PATCH v18 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver

2015-01-18 Thread Dudley Du
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 2015?1?18? 16:27 To: Dudley Du Cc: jmmah...@gmail.com; rydb...@euromail.se; ble...@google.com; linux-input@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH v18 01/12] input: cyapa:

RE: [PATCH v18 04/12] input: cyapa: add runtime power management interfaces support for the device

2015-01-18 Thread Dudley Du
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 2015?1?18? 16:32 To: Dudley Du Cc: jmmah...@gmail.com; rydb...@euromail.se; ble...@google.com; linux-input@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH v18 04/12] input: cyapa:

Re: [PATCH v1 2/4] gpio: add parameter to allow the use named gpios

2015-01-18 Thread Alexandre Courbot
On Wed, Jan 7, 2015 at 6:08 PM, Olliver Schinagl oliver+l...@schinagl.nl wrote: From: Olliver Schinagl oli...@schinagl.nl The gpio binding document says that new code should always use named gpios. Patch 40b73183 added support to parse a list of gpios from child nodes, but does not make it

RE: [PATCH v18 00/12] input: cyapa: instruction of cyapa patches

2015-01-18 Thread Dudley Du
Dmitry, Thank you very much. Thanks, Dudley -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 2015?1?18? 16:35 To: Jeremiah Mahler; Dudley Du; rydb...@euromail.se; ble...@google.com; David Solda; linux-input@vger.kernel.org;

[git pull] Input updates for 3.19-rc4

2015-01-18 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Changelog: - Dmitry Torokhov (2): MAINTAINERS:

Re: [PATCH v18 04/12] input: cyapa: add runtime power management interfaces support for the device

2015-01-18 Thread Dmitry Torokhov
Hi Dudley, On Fri, Jan 16, 2015 at 02:34:07PM +0800, Dudley Du wrote: +#ifdef CONFIG_PM_RUNTIME +static ssize_t cyapa_show_rt_suspend_scanrate(struct device *dev, + struct device_attribute *attr, + char

Re: [PATCH v18 01/12] input: cyapa: re-design driver to support multi-trackpad in one driver

2015-01-18 Thread Dmitry Torokhov
Hi Dudley, On Fri, Jan 16, 2015 at 02:34:04PM +0800, Dudley Du wrote: In order to support multiple different chipsets and communication protocols trackpad devices in one cyapa driver, the new cyapa driver is re-designed with one cyapa driver core and multiple device specific functions

Re: [PATCH v18 12/12] input: cyapa: add acpi device id support

2015-01-18 Thread Dmitry Torokhov
On Fri, Jan 16, 2015 at 02:34:15PM +0800, Dudley Du wrote: Add acpi device tree support. acpi device id CYAP is for old gen3 trackpad devices. acpi device id CYAP0001 is for new gen5 trackpad devices. TEST=test on Chromebooks. Signed-off-by: Dudley Du d...@cypress.com ---

Re: [PATCH v18 00/12] input: cyapa: instruction of cyapa patches

2015-01-18 Thread Dmitry Torokhov
On Sat, Jan 17, 2015 at 03:39:04AM -0800, Jeremiah Mahler wrote: Dudley, On Sat, Jan 17, 2015 at 02:44:15AM -0800, Jeremiah Mahler wrote: Dudley, Your patch series applies without issue but unfortunately I could not test them because I ran in to a bug created by someone elses patch

Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

2015-01-18 Thread Dmitry Torokhov
On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote: + /* APP_INTEGRITY row is always the last row block, + * and the row id must be 0x01ff */ + row_num = get_unaligned_be16( + image-records[flash_records_count - 1].row_number); + if

RE: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware update function support

2015-01-18 Thread Dudley Du
-Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: 2015?1?19? 8:27 To: Dudley Du Cc: jmmah...@gmail.com; rydb...@euromail.se; ble...@google.com; linux-input@vger.kernel.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH v18 09/12] input: cyapa:

Re: [PATCH 6/6] Input: ALPS - mix trackstick and external PS/2 mouse data

2015-01-18 Thread Pali Rohár
On Wednesday 14 January 2015 23:55:54 Dmitry Torokhov wrote: + dev3 = input_allocate_device(); + if (!dev3) { + psmouse_err(psmouse, failed to alolocate secondary device\n); allocate + error =

[PATCH v2 2/3] dt-bindings: Add vendor-prefix for Goodix

2015-01-18 Thread Aleksei Mamlin
Signed-off-by: Aleksei Mamlin mamli...@gmail.com --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index b1df0ad..72136f1

[PATCH v2 3/3] input: goodix: Add bindings documentation

2015-01-18 Thread Aleksei Mamlin
Signed-off-by: Aleksei Mamlin mamli...@gmail.com --- .../bindings/input/touchscreen/gt9xx.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/gt9xx.txt diff --git

Re: [PATCH 1/3] input: goodix: Add device tree support

2015-01-18 Thread Antonio Ospite
On Sun, 18 Jan 2015 16:25:35 +0400 Алексей Мамлин mamli...@gmail.com wrote: Look at include/linux/of.h #ifdef CONFIG_OF ... #define of_match_ptr(_ptr)(_ptr) ... #else /* CONFIG_OF */ ... #define of_match_ptr(_ptr)NULL ... #endif /* CONFIG_OF */ So it would be compiled.

Re: [PATCH 1/3] input: goodix: Add device tree support

2015-01-18 Thread Aleksei Mamlin
Do you mean that I should use #ifdef CONFIG_ACPI and ACPI_PTR? #ifdef CONFIG_ACPI static const struct acpi_device_id goodix_acpi_match[] = { { GDIX1001, 0 }, { } }; MODULE_DEVICE_TABLE(acpi, goodix_acpi_match); #endif #ifdef CONFIG_OF static struct of_device_id goodix_of_match[]

[PATCH v2 0/3] Add device tree support for Goodix GT9xx series touchscreen controller

2015-01-18 Thread Aleksei Mamlin
This patch set adds device tree support and binding information for Goodix GT9xx series touchscreen controller. Support was tested on Wexler Tab 7200 tablet pc and also should work on other devices. Changes since v1: Added Kconfig entry, which enable CONFIG_OF Aleksei Mamlin (3): input:

[PATCH] Input: da9052_tsi: remove unnecessary worker

2015-01-18 Thread Michael Grzeschik
With the datardy irq we get the information if the pen got pulled from the screen. This patch changes the irq by checking this condition every time instead of triggering the worker. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/input/touchscreen/da9052_tsi.c | 68

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-01-18 Thread Pali Rohár
On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár wrote: On Thursday 15 January 2015 22:02:16 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 09:28:41PM +0100, Pali Rohár wrote: On Thursday 15 January 2015 20:38:18 Dmitry

Re: [PATCH 1/3] input: goodix: Add device tree support

2015-01-18 Thread Алексей Мамлин
Look at include/linux/of.h #ifdef CONFIG_OF ... #define of_match_ptr(_ptr) (_ptr) ... #else /* CONFIG_OF */ ... #define of_match_ptr(_ptr) NULL ... #endif /* CONFIG_OF */ So it would be compiled. Similarly in other touchscreen drivers. But Kconfig should be fixed to enable

Re: [PATCH 2/5] mfd: tps65218: make INT1 our status_base register

2015-01-18 Thread Lee Jones
On Fri, 26 Dec 2014, Felipe Balbi wrote: If we don't tell regmap-irq that our first status register is at offset 1, it will try to read offset zero, which is the chipid register. Fixes: 44b4dc6 mfd: tps65218: Add driver for the TPS65218 PMIC Cc: sta...@vger.kernel.org # v3.15+ Cc: Keerthy

Re: [PATCH 1/5] mfd: tps65218: make INT[12] and STATUS registers volatile

2015-01-18 Thread Lee Jones
On Fri, 26 Dec 2014, Felipe Balbi wrote: STATUS register can be modified by the HW, so we should bypass cache because of that. In the case of INT[12] registers, they are the ones that actually clear the IRQ source at the time they are read. If we rely on the cache for them, we will never

[PATCH 001/001] usbhid: Fix initialisation and force effect modifications for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-18 Thread Jim Keir
From: Jim Keir jimk...@yahoo.co.uk Signed-off-by: Jim Keir jimk...@yahoo.co.uk Currently the SWFF2 driver fails during initialisation, making the force capability of the joystick unusable. Further, there is a long-standing bug in the same driver where commands to update force parameters are