[RFT/PATCH] Input: bfin_rotary - introduce open and close methods

2015-02-05 Thread Dmitry Torokhov
Introduce open and close methods for the input device to postpone enabling the device until it is needed. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Hi Sonic, Could you please tell me if the driver still works with this parch? Thanks! drivers/input/misc/bfin_rotary.c | 70

Re: [PATCH v2] bfin_rotary: convert to use managed resources

2015-02-05 Thread Dmitry Torokhov
On Thu, Feb 05, 2015 at 04:29:13PM +0800, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com - remap rotary register physical address into kernel space in probe - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from

[PATCH] Input: bfin_rotary - mark suspend and resume code as __maybe_unused

2015-02-05 Thread Dmitry Torokhov
Instead of using #ifdef to guard potentially unused suspend and resume code let's mark them as __maybe_unused so they still get discarded if they are not used but we do not get warning. This allows for better compile coverage. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com ---

[PATCH] Input: soc_button_array - Use Windows key for Home

2015-02-05 Thread Bastien Nocera
KEY_HOME is the key to go back to the beginning of the line, not the key to get into an overview mode, as Windows does. GNOME can already make use of the Windows key on multiple form factors, and other desktop environments can use it depending on the form factor. Using Windows as the emitted key

[PATCH v2] Input: soc_button_array - Use Windows key for Home

2015-02-05 Thread Bastien Nocera
KEY_HOME is the key to go back to the beginning of the line, not the key to get into an overview mode, as Windows does. GNOME can already make use of the Windows key on multiple form factors, and other desktop environments can use it depending on the form factor. Using Windows as the emitted key

Re: [PATCH] Input: soc_button_array - Use Windows key for Home

2015-02-05 Thread Bastien Nocera
On Thu, 2015-02-05 at 14:31 +0100, Bastien Nocera wrote: KEY_HOME is the key to go back to the beginning of the line, not the key to get into an overview mode, as Windows does. GNOME can already make use of the Windows key on multiple form factors, and other desktop environments can use it

Re: [PATCH v2 4/5] Input: synaptics - Skip quirks when post-2013 dimensions

2015-02-05 Thread Benjamin Tissoires
On Sat, Jan 31, 2015 at 3:18 AM, Daniel Martin consume.no...@gmail.com wrote: On Fri, Jan 30, 2015 at 10:34:22AM -0500, Benjamin Tissoires wrote: On Fri, Jan 30, 2015 at 4:59 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 01/29/2015 08:50 PM, Benjamin Tissoires wrote: On Thu, Jan

[PATCH v2] bfin_rotary: convert to use managed resources

2015-02-05 Thread Sonic Zhang
From: Sonic Zhang sonic.zh...@analog.com - remap rotary register physical address into kernel space in probe - replace kzalloc with devm_kzalloc - replace request_irq with devm_request_irq - remove memory free and irq free from the device remove function - use devm_input_allocate_device

Re: i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Yani Ioannou
Well, this is embarrassing. Turns out I'm just looking in the wrong place for them. Looks like they are all there under /sys/bus/iio/devices/, but I read somewhere to check /proc/bus/input/devices. When I saw all the errors (even without debug) from i2c_hid in the kernel log, I assumed too

Regression in dtor/input.git/next - flush pending events on clock type change

2015-02-05 Thread Benjamin Tissoires
Hi Anshul, The commit 0c3e99437a66e4c869c60c2398449e6d98f3a988 in dtor/input.git/next tree introduce an interesting regression in libinput. The tests fail :) Actually, evemu-record and libinput switch the clock to monotonic when opening an input node, and the first thing that gets queued is a

Re: Regression in dtor/input.git/next - flush pending events on clock type change

2015-02-05 Thread Dmitry Torokhov
Hi Benjamin, On Thu, Feb 05, 2015 at 06:06:29PM -0500, Benjamin Tissoires wrote: Hi Anshul, The commit 0c3e99437a66e4c869c60c2398449e6d98f3a988 in dtor/input.git/next tree introduce an interesting regression in libinput. The tests fail :) Actually, evemu-record and libinput switch the

i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Yani Ioannou
Hi, I've been trying to debug why the sensor hub on a Surface pro 3 isn't detected in the latest mainline kernel (3.19-rc6). When I enable debug I get the following output showing a bunch of errors trying to communicate with the device MSHW0030, which seems to be the sensor hub. I've looked into

[PATCH] Input: Delete an unnecessary check before the function call input_free_device

2015-02-05 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 5 Feb 2015 17:35:35 +0100 The input_free_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: Regression in dtor/input.git/next - flush pending events on clock type change

2015-02-05 Thread Dmitry Torokhov
On Thu, Feb 05, 2015 at 08:28:28PM -0500, Benjamin Tissoires wrote: On Feb 5, 2015 7:04 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Benjamin, On Thu, Feb 05, 2015 at 06:06:29PM -0500, Benjamin Tissoires wrote: Hi Anshul, The commit

Re: [PATCH 2/4] Input - synaptics: do not release extra buttons once they are pressed

2015-02-05 Thread Andrew Duggan
On 02/04/2015 01:29 PM, Benjamin Tissoires wrote: On Feb 02 2015 or thereabouts, Benjamin Tissoires wrote: On Mon, Feb 2, 2015 at 4:46 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jan 28, 2015 at 03:10:05PM -0500, Benjamin Tissoires wrote: The current code releases the extra

Re: [RFC] Input - synaptics: re-route tracksticks buttons on the Lenovo 2015 series

2015-02-05 Thread Andrew Duggan
On 02/05/2015 12:38 PM, Benjamin Tissoires wrote: Lenovos 2015 series has the physical tracktick buttons wired through the touchpad. The kernel should re-route them through the pass-through interface. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi Dmitry, Well, in one

Re: [RFC] Input - synaptics: re-route tracksticks buttons on the Lenovo 2015 series

2015-02-05 Thread Dmitry Torokhov
On Thu, Feb 05, 2015 at 05:33:07PM -0800, Andrew Duggan wrote: On 02/05/2015 12:38 PM, Benjamin Tissoires wrote: Lenovos 2015 series has the physical tracktick buttons wired through the touchpad. The kernel should re-route them through the pass-through interface. Signed-off-by: Benjamin

Re: [PATCH 0/6] Fixes for ALPS trackstick

2015-02-05 Thread Pali Rohár
On Monday 02 February 2015 06:49:31 Dmitry Torokhov wrote: On Sun, Jan 18, 2015 at 10:47:06AM +0100, Pali Rohár wrote: On Sunday 18 January 2015 08:22:45 Dmitry Torokhov wrote: On Sat, Jan 17, 2015 at 11:01:56AM +0100, Pali Rohár wrote: On Thursday 15 January 2015 22:02:16 Dmitry

Re: Regression in dtor/input.git/next - flush pending events on clock type change

2015-02-05 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 8:28 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Feb 5, 2015 7:04 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Benjamin, On Thu, Feb 05, 2015 at 06:06:29PM -0500, Benjamin Tissoires wrote: Hi Anshul, The commit

Re: [RFC] Input - synaptics: re-route tracksticks buttons on the Lenovo 2015 series

2015-02-05 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 8:49 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Feb 05, 2015 at 05:33:07PM -0800, Andrew Duggan wrote: On 02/05/2015 12:38 PM, Benjamin Tissoires wrote: Lenovos 2015 series has the physical tracktick buttons wired through the touchpad. The kernel should

EPERM instead of EINVAL?

2015-02-05 Thread simon
Hi all, Michal is working on another round of changes for the Logitech wheel (hid-lg4ff), and we are including code to switch between different modes - thus allowing a G27 wheel (for example) to emulate a simpler wheel. At present we automatically 'upgrade' wheel to the best mode they can handle,

Re: i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Yani Ioannou
Indeed you are correct, looks like one of the devices listed there is the sensor hub - so I'm barking up the wrong tree. Will have to move on to the sensor drivers themselves I guess. Thanks for your help! Yani On Thu, Feb 5, 2015 at 6:10 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com

Re: i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 1:44 PM, Yani Ioannou yani.ioan...@gmail.com wrote: Indeed you are correct, looks like one of the devices listed there is the sensor hub - so I'm barking up the wrong tree. Not quite actually. If the i2c-hid driver works but the hid-sensor-hub does not pick up, there is

Re: i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 12:56 PM, Yani Ioannou yani.ioan...@gmail.com wrote: Hi Benjamin, As far as I'm aware the sensor hub didn't show up under any kernel (I'll try an earlier kernel to figure out if this is true) I didn't mean to say this is a regression, sorry. Oh, my bad. The errors

Re: i2c_hid issues with sensor hub on Surface Pro 3

2015-02-05 Thread Benjamin Tissoires
On Thu, Feb 5, 2015 at 2:18 PM, Yani Ioannou yani.ioan...@gmail.com wrote: Well, this is embarrassing. Turns out I'm just looking in the wrong place for them. Looks like they are all there under /sys/bus/iio/devices/, but I read somewhere to check /proc/bus/input/devices. Yes, now the hid

[RFC] Input - synaptics: re-route tracksticks buttons on the Lenovo 2015 series

2015-02-05 Thread Benjamin Tissoires
Lenovos 2015 series has the physical tracktick buttons wired through the touchpad. The kernel should re-route them through the pass-through interface. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- Hi Dmitry, Well, in one of your replies regarding the Synaptics Lenovo 2015