Re: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-16 Thread Antonio Ospite
On Mon, 16 Feb 2015 15:06:59 +0200 Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines

Re: [PATCH] Input: ALPS: Move v7 packet info to Documentation and v6 packet info

2015-02-16 Thread Pali Rohár
On Monday 16 February 2015 18:28:30 Jonathan Corbet wrote: On Tue, 10 Feb 2015 13:43:33 +0100 Pali Rohár pali.ro...@gmail.com wrote: This patch move all packet info from driver source code to documentation and adds info about v6 packet format (from driver source code). I tried to

[PATCH 3/5] HID: sony: Don't use magic numbers in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Remove the magic numbers used in sixaxis_set_operational_usb(): - use the already defined SIXAXIS_REPORT_0xF2_SIZE; - define and use SIXAXIS_REPORT_0xF5_SIZE; - set the dummy buffer size to accommodate any report that is going to be requested. Signed-off-by: Antonio Ospite a...@ao2.it

[PATCH 4/5] HID: sony: Use __u8 * for the buffer in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Use the same type declared in the prototypes of functions that are going to accept the buffer as parameter. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c

[PATCH 5/5] HID: sony: Coding style cleanups in sixaxis_set_operational_usb()

2015-02-16 Thread Antonio Ospite
Don't mix declaration and allocation, remove some useless newlines between calling a function and checking its return value. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-sony.c

[PATCH 0/5] HID: sony: misc fixes and cleanups

2015-02-16 Thread Antonio Ospite
Hi, here are a few cleanups for hid-sony. Changes are meant to follow the patch titled: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Frank, hi, I'd like to have your explicit ack at least for patch 1 and 2. Thanks, Antonio Antonio Ospite (5): HID: sony: Fix a WARNING

[PATCH 2/5] HID: sony: Use the minimum accepted size for feature report 0xf2

2015-02-16 Thread Antonio Ospite
Sixaxis devices accept feature report 0xf2 when size is = 17, not 18. Use the minimum accepted size. The change is mainly for documentation purposes, the code worked fine even before this change. Signed-off-by: Antonio Ospite a...@ao2.it --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1

Re: [PATCH 0/5] HID: sony: misc fixes and cleanups

2015-02-16 Thread Frank Praznik
On 2/16/2015 12:12, Antonio Ospite wrote: Hi, here are a few cleanups for hid-sony. Changes are meant to follow the patch titled: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Frank, hi, I'd like to have your explicit ack at least for patch 1 and 2. Thanks, Antonio

[PATCH 1/5] HID: sony: Fix a WARNING shown when rmmod-ing the driver

2015-02-16 Thread Antonio Ospite
ida_destroy() must be called _after_ all the devices have been unregistered; otherwise, when calling rmmod hid_sony with devices still plugged in, the following warning would show up because of calls to ida_simple_remove() on a destroyed ID allocator: [ cut here ] WARNING:

Re: [PATCH v2 0/4] HID: hid-lg4ff: Improve handling of Logitech multimode gaming wheels

2015-02-16 Thread Elias Vanderstuyft
On Sun, Feb 15, 2015 at 3:03 AM, Michal Malý madcatxs...@devoid-pointer.net wrote: This patch series improves handling of various Logitech gaming wheels and allows switching between various compatibility modes which might be useful to improve compatibility with very old games and testing

Re: [PATCH 0/5] HID: sony: misc fixes and cleanups

2015-02-16 Thread Antonio Ospite
On Mon, 16 Feb 2015 16:48:53 -0500 Frank Praznik frank.praz...@gmail.com wrote: On 2/16/2015 12:12, Antonio Ospite wrote: Hi, here are a few cleanups for hid-sony. Changes are meant to follow the patch titled: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Frank,

Re: [PATCH 1/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Thu, 2015-02-12 at 14:07 +0800, 曾婷葳 (tammy_tseng) wrote: Hi, I've checked the coding style and modified the i2c and hid touch driver for sis touch controller. Please help review them. Thanks a lot. Sorry, I accidentally reviewed the old version first. Tammy - Here is the

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-02-16 Thread Benjamin Tissoires
On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi, This is the second episode of the Lenovo 2015 party :) Thanks to Andrew, we now have an idea within the driver of what are the extra buttons aimed for, and the patch series looks cleaner. Many thanks

[PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-16 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com ---

Re: [PATCH 2/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Oliver Neukum
On Thu, 2015-02-12 at 15:24 +0800, 曾婷葳 (tammy_tseng) wrote: Sorry. Re-send the code diff again. Here is the hid touch driver for sis touch controller. Thanks. This driver does very strange things. It looks like you are simulating a disconnect() to the usbhid driver currently driving the

Re: [PATCH 2/2] INPUT/HID: add touch support for SiS touch driver

2015-02-16 Thread Benjamin Tissoires
On Mon, Feb 16, 2015 at 10:10 AM, Oliver Neukum oneu...@suse.de wrote: On Thu, 2015-02-12 at 15:24 +0800, 曾婷葳 (tammy_tseng) wrote: Sorry. Re-send the code diff again. Here is the hid touch driver for sis touch controller. Thanks. This driver does very strange things. It looks like you are

Re: [DIGImend-devel] [PATCH] Fix report descriptor for Genius PenSketch M912

2015-02-16 Thread Nikolai Kondrashov
On 02/14/2015 10:48 AM, milan.pl...@gmail.com wrote: From: Milan Plzik milan.pl...@gmail.com Genius PenSketch M912 digitizer tablet sends incorrect report descriptor by default. This patch replaces it with a corrected one. Signed-off-by: Milan Plzik milan.pl...@gmail.com I reviewed this on

Re: [PATCH v2 0/2] Qualcomm PM8941 power key driver

2015-02-16 Thread Ivan T. Ivanov
On Fri, 2015-01-23 at 16:19 -0800, Bjorn Andersson wrote: These patches add dt bindings and a device driver for the power key block in the Qualcomm PM8941 pmic. Changes since v1: * Use a reboot_notifier to set power off/reboot mode * Use irq flags from devicetree * Some style fixes

Re: [PATCH v3][RFC] add raw video stream support for Samsung SUR40

2015-02-16 Thread Hans Verkuil
On 02/11/2015 12:52 PM, Florian Echtler wrote: Hello again, does anyone have any suggestions why USERPTR still fails with dma-sg? Could I just disable the corresponding capability for the moment so that the patch could perhaps be merged, and investigate this separately? I prefer to dig