Re: [PATCH 3/3] HID: rmi: disable palm detect gesture when present

2015-02-25 Thread Jiri Kosina
On Wed, 25 Feb 2015, Gabriele Mazzotta wrote: On Tuesday 24 February 2015 17:36:50 Andrew Duggan wrote: A touchpad may have firmware based palm detection code enabled which suppresses 2D data from being reported when the firmware believes a palm is on the touchpad. This functionality is

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-02-25 Thread Benjamin Tissoires
On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi, This is the second episode of the Lenovo 2015 party :) Thanks to Andrew, we now have an idea within the driver

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-02-25 Thread Hans de Goede
Hi, On 25-02-15 15:36, Benjamin Tissoires wrote: On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Fri, Feb 6, 2015 at 3:04 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi, This is the second episode of the Lenovo 2015 party :) Thanks

[PATCH v2 0/2] HID: wacom: add support of Bamboo PAD

2015-02-25 Thread Benjamin Tissoires
So here is the v2 of the patch set to support the Bamboo PAD. It has been tested by Josep (thanks!) on the wired version and I developped it on the wireless version. I guess it should be good to go if the reviews goes well. Cheers, Benjamin Benjamin Tissoires (2): HID: wacom: store the

[PATCH v2 1/2] HID: wacom: store the hid_device pointers of the sibling devices

2015-02-25 Thread Benjamin Tissoires
The Bamboo PAD in debug mode needs to re-route events from the debug interface to the Pen interface. This can be easily done with hid_input_report(), but that means that we need to keep a reference to the various hid_devices. There should be only one touch and one pen interface per physical

[PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-25 Thread Benjamin Tissoires
The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless and the wired version have slightly different firmwares, but the debug mode 2 on the feature 2 is common to the 2 devices. In this mode, all the

Re: [PATCH v6 1/5] mfd: max77843: Add max77843 MFD driver core driver

2015-02-25 Thread Lee Jones
On Tue, 24 Feb 2015, Jaewon Kim wrote: This patch adds MAX77843 core/irq driver to support PMIC, MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, LED and Haptic device. Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Jaewon Kim jaewon02@samsung.com Signed-off-by: Beomho

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-25 Thread Mario Limonciello
On 02/23/2015 06:51 PM, Dmitry Torokhov wrote: On Sun, Feb 22, 2015 at 05:55:05PM +0100, Pali Rohár wrote: I am not sure what exactly the issue is... We do need to have the break code to know when the key is released. We can't go and say that we will release old key when we detect another key

Re: [SUSPECT SPAM] Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-25 Thread Mario Limonciello
On 02/23/2015 06:01 PM, Pali Rohár wrote: On Tuesday 24 February 2015 00:31:52 Mario Limonciello wrote: For older dell models (some old inspirions and maybe also latitude) it was possible to use undocumented DELLDIAG interface (which enter into SMM mode and call some functions) to enable that

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-25 Thread Mario Limonciello
On 02/20/2015 02:41 PM, Pali Rohár wrote: On Friday 20 February 2015 20:56:23 Mario Limonciello wrote: resetafter=0 means to never reset (even if driver receive e.g thousand invalid packets). I think this is very dangerous if there will be other bugs either in linux driver or some other HW

Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT for the third interface to not create more than needed input nodes. Signed-off-by: Benjamin Tissoires

Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: We append Pen, Pad, Mouse or Keyboard suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. As I said before, this is a very welcome change. Thanks, Benjamin!

Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.

2015-02-25 Thread Pali Rohár
On Wednesday 25 February 2015 19:48:55 Mario Limonciello wrote: On 02/20/2015 02:41 PM, Pali Rohár wrote: On Friday 20 February 2015 20:56:23 Mario Limonciello wrote: resetafter=0 means to never reset (even if driver receive e.g thousand invalid packets). I think this is very dangerous

Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Based on a patch from: Nikolai Kondrashov nikolai.kondras...@redhat.com Most of the tablets handled by hid-uclogic already uses MULTI_INPUT. *use Fot the ones which are not quirked in usbhid/hidquirks, they have a *For custom report

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: From: Nikolai Kondrashov nikolai.kondras...@redhat.com Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices. Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com ---

Re: [PATCH 1/4] HID: uclogic: Set quirks from inside the driver

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Based on a patch from: Nikolai Kondrashov nikolai.kondras...@redhat.com Most of the tablets handled by hid-uclogic already uses MULTI_INPUT. *use Fot the ones which are not quirked

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: From: Nikolai Kondrashov nikolai.kondras...@redhat.com Merge the hid-huion driver into hid-uclogic as all the devices supported by hid-huion are in fact UC-Logic devices.

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-25 Thread Ping Cheng
On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless and the wired version have slightly different

Re: [PATCH 3/4] HID: uclogic: present only the working interfaces on the Huion tablets

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: The Huion tablets show 3 interfaces. Only the first and the third are currently used. Also remove HID_QUIRK_MULTI_INPUT for the third interface to not create more than needed input

Re: [PATCH 4/4] HID: uclogic: name the input nodes based on their tool

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: We append Pen, Pad, Mouse or Keyboard suffix to the appropriate input node to match what the Wacom driver does and be more convenient for the user to know which one is which. As I said

Re: [PATCH v2 2/2] HID: wacom: add full support of the Wacom Bamboo PAD

2015-02-25 Thread Benjamin Tissoires
On Feb 25 2015 or thereabouts, Ping Cheng wrote: On Wed, Feb 25, 2015 at 8:43 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: The stylus of this device works just fine out of the box. The touch is seen by default as a mouse with relative events and some gestures. The wireless

Re: [PATCH 2/4] HID: uclogic: merge hid-huion driver in hid-uclogic

2015-02-25 Thread Nikolai Kondrashov
On 02/25/2015 11:28 PM, Benjamin Tissoires wrote: On Feb 25 2015 or thereabouts, Nikolai Kondrashov wrote: On 02/25/2015 02:05 AM, Benjamin Tissoires wrote: Reviewed-by: Nikolai Kondrashov spbn...@gmail.com Could I have your Signed-off-by here, it's mainly your patch, and so I kept your

Re: [PATCH v4 11/20] power_supply: Change ownership from driver to core

2015-02-25 Thread Sebastian Reichel
Hi, On Mon, Feb 23, 2015 at 12:47:32PM +0100, Krzysztof Kozlowski wrote: Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are

[PATCH] Input: mma8450 - convert to using managed resources

2015-02-25 Thread Dmitry Torokhov
This simplifies error handling and device removal code. Also let's get rid of setting driver's owner since i2c core does it for us. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Note that the following removal was intentional as devm_input_allocate_polled_device() does this for

Re: [PATCH v4 02/20] power_supply: Move run-time configuration to separate structure

2015-02-25 Thread Sebastian Reichel
On Wed, Feb 25, 2015 at 05:10:07PM -0800, Dmitry Torokhov wrote: On Thu, Feb 26, 2015 at 01:34:09AM +0100, Sebastian Reichel wrote: Hi, On Mon, Feb 23, 2015 at 12:47:23PM +0100, Krzysztof Kozlowski wrote: Add new structure 'power_supply_config' for holding run-time initialization

Re: [PATCH v6 4/5] Input: add haptic drvier on max77843

2015-02-25 Thread Jaewon Kim
Hi Dmitry, On 26/02/2015 10:23, Dmitry Torokhov wrote: Hi Jaewon, On Tue, Feb 24, 2015 at 10:29:07AM +0900, Jaewon Kim wrote: +static void max77843_haptic_play_work(struct work_struct *work) +{ + struct max77843_haptic *haptic = + container_of(work, struct

[PATCH] HID: hid-sensor-hub: fix attribute read for logical usage id

2015-02-25 Thread Srinivas Pandruvada
For defining enumeration values like report or power status events, the enumeration usage ids are enclosed in a logical collection. In this case we need to match logical usage id for pending read on this usage id. For example, in the below field, when read is requested for 0319, the report will

Re: [PATCH v6 1/5] mfd: max77843: Add max77843 MFD driver core driver

2015-02-25 Thread Jaewon Kim
Hi Lee Jones, On 26/02/2015 01:47, Lee Jones wrote: On Tue, 24 Feb 2015, Jaewon Kim wrote: This patch adds MAX77843 core/irq driver to support PMIC, MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, LED and Haptic device. Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Jaewon Kim

[PATCH 2/2] HID: HID Sensor: Update document for custom sensor

2015-02-25 Thread Srinivas Pandruvada
Added custom sensor documentation Signed-off-by: Srinivas Pandruvada srinivas.pandruv...@linux.intel.com --- Documentation/hid/hid-sensor.txt | 79 1 file changed, 79 insertions(+) diff --git a/Documentation/hid/hid-sensor.txt

[PATCH 1/2] HID: HID Sensor: Custom and Generic sensor support

2015-02-25 Thread Srinivas Pandruvada
HID Sensor Spec defines two usage ids for custom sensors HID_USAGE_SENSOR_TYPE_OTHER_CUSTOM (0x09, 0xE1) HID_USAGE_SENSOR_TYPE_OTHER_GENERIC(0x09, 0xE2) The purpose of these sensors is to extend the functionality or provide a way to obfuscate the data being communicated by a sensor. Without

[PATCH] Input: pwm-beeper - remove unneeded PWM_BEEPER_PM_OPS define

2015-02-25 Thread Dmitry Torokhov
The device-pm pointer is always present so there is no need to do tricks with conditionally defining the pointer. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/misc/pwm-beeper.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

Re: [PATCH v4 02/20] power_supply: Move run-time configuration to separate structure

2015-02-25 Thread Sebastian Reichel
Hi, On Mon, Feb 23, 2015 at 12:47:23PM +0100, Krzysztof Kozlowski wrote: Add new structure 'power_supply_config' for holding run-time initialization data like of_node, supplies and private driver data. The power_supply_register() function is changed so all power supply drivers need

Re: [PATCH v6 4/5] Input: add haptic drvier on max77843

2015-02-25 Thread Dmitry Torokhov
Hi Jaewon, On Tue, Feb 24, 2015 at 10:29:07AM +0900, Jaewon Kim wrote: +static void max77843_haptic_play_work(struct work_struct *work) +{ + struct max77843_haptic *haptic = + container_of(work, struct max77843_haptic, work); + int error; + +

Re: [PATCH v2] Input: sun4i-ts: add thermal driver dependency

2015-02-25 Thread Dmitry Torokhov
On Thu, Feb 12, 2015 at 04:00:11PM +0800, Chen-Yu Tsai wrote: From: Arnd Bergmann a...@arndb.de The sun4i-ts driver has had a dependency on the thermal code with the addition of the thermal zone sensor support, but this is not currently enforced in Kconfig, so with TOUCHSCREEN_SUN4I=y,

Re: [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-25 Thread Darren Hart
On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Bastien, am I awaiting another version of this from you to address comments from Henrique?

Re: [PATCH v4 11/20] power_supply: Change ownership from driver to core

2015-02-25 Thread Darren Hart
On Thu, Feb 26, 2015 at 01:45:22AM +0100, Sebastian Reichel wrote: Hi, On Mon, Feb 23, 2015 at 12:47:32PM +0100, Krzysztof Kozlowski wrote: Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes

Re: [PATCH 3/3] HID: rmi: disable palm detect gesture when present

2015-02-25 Thread Gabriele Mazzotta
On Tuesday 24 February 2015 17:36:50 Andrew Duggan wrote: A touchpad may have firmware based palm detection code enabled which suppresses 2D data from being reported when the firmware believes a palm is on the touchpad. This functionality is meant to be used in mouse mode without a driver.

Re: [PATCH 3/3] HID: i2c-hid: Add support for ACPI GPIO interrupts

2015-02-25 Thread Mika Westerberg
On Tue, Feb 24, 2015 at 10:27:05PM +0100, Antonio Ospite wrote: On Mon, 23 Feb 2015 15:52:45 +0200 Mika Westerberg mika.westerb...@linux.intel.com wrote: The HID over I2C specification allows to have the interrupt for a HID device to be GPIO instead of directly connected to the IO-APIC.