Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-05 Thread Dmitry Torokhov
On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote: On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: Hi Pali, On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: This patch fixes commit 61579ba83934 (Input: atkbd - expand Latitude's force release quirk to other

Re: [PATCH 9/16] HID: logitech-hidpp: fix error return code

2015-04-05 Thread Jiri Kosina
On Sun, 5 Apr 2015, Julia Lawall wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-05 Thread Dmitry Torokhov
Hi Pali, On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: This patch fixes commit 61579ba83934 (Input: atkbd - expand Latitude's force release quirk to other Dells). Before that commit release quirks were called for all Dell Latitude models. After that commit only for Portable Dell

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-05 Thread Dmitry Torokhov
On Sun, Apr 05, 2015 at 06:04:24PM +0200, Bastien Nocera wrote: On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: This patch implements GT801x2 touchscreen support. Unfortunately, there is a big difference between GT801 and GT9xx series chips, therefore some advice is needed on how to

Re: [PATCH] Input: atkbd: Fix release quirk for Dell models

2015-04-05 Thread Pali Rohár
On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: Hi Pali, On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: This patch fixes commit 61579ba83934 (Input: atkbd - expand Latitude's force release quirk to other Dells). Before that commit release quirks were called for all

[PATCH 9/16] HID: logitech-hidpp: fix error return code

2015-04-05 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=

[PATCH 0/16] fix error return code

2015-04-05 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ...

Re: [PATCH 9/16] HID: logitech-hidpp: fix error return code

2015-04-05 Thread Benjamin Tissoires
On Sun, Apr 5, 2015 at 8:06 AM, Julia Lawall julia.law...@lip6.fr wrote: Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ identifier ret; expression e1,e2; @@ ( if (\(ret

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-05 Thread Dmitry Torokhov
On Sun, Apr 05, 2015 at 08:06:16PM +0300, Priit Laes wrote: On Sun, 2015-04-05 at 18:04 +0200, Bastien Nocera wrote: On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: This patch implements GT801x2 touchscreen support. Unfortunately, there is a big difference between GT801 and GT9xx

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-05 Thread Bastien Nocera
On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: This patch implements GT801x2 touchscreen support. Unfortunately, there is a big difference between GT801 and GT9xx series chips, therefore some advice is needed on how to proceed. Differences between GT801x2 and GT9xx series: 1. I2C

Re: [PATCH] Input: goodix - preliminary support for GT801-2+1

2015-04-05 Thread Priit Laes
On Sun, 2015-04-05 at 18:04 +0200, Bastien Nocera wrote: On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: This patch implements GT801x2 touchscreen support. Unfortunately, there is a big difference between GT801 and GT9xx series chips, therefore some advice is needed on how to

Re: [PATCH] alps: Document that Protocol V2 uses standard PS/2 mouse packets for the stick

2015-04-05 Thread Dmitry Torokhov
On Fri, Apr 03, 2015 at 08:21:29AM +0200, Pali Rohár wrote: On Thursday 02 April 2015 10:08:54 Hans de Goede wrote: Document that Protocol V2 uses standard (bare) PS/2 mouse packets for the DualPoint stick. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [PATCH v2 0/3] Balanced slots, attempt #2

2015-04-05 Thread Dmitry Torokhov
On Tue, Mar 31, 2015 at 05:26:31PM +0200, Henrik Rydberg wrote: On 03/31/2015 05:07 PM, Benjamin Tissoires wrote: Hi, so this is the v2 with Hans' ack and Henrik's respin of the first patch. The whole series looks good, thank you Benjamin. Acked-by: Henrik Rydberg rydb...@bitmath.org