On Tue, Apr 7, 2015 at 5:42 , Dmitry Torokhov
dmitry.torok...@gmail.com wrote:
Without commenting on validity of making this decision based on
presence or absence of LEDs the proper test would be:
if (!test_bit(EV_LED, hi-input-evbit)) {
Thanks, that's much cleaner. I'll also test for
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
When I play KDE kpatience, a card game, card stick to my mousepointer: left
mouse button down
Hi,
On 08-04-15 12:59, Hans de Bruin wrote:
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
When I play KDE kpatience, a card game, card
Set flags INPUT_PROP_POINTER and INPUT_PROP_POINTING_STICK for the
trackpoint integrated in Lenovo USB and Bluetooth keyboards. Libinput
checks
these flags to enable features such as middle-button-scrolling by
default.
Signed-off-by: Andreas Fleig andreasfl...@gmail.com
diff --git
On Thu, 2015-04-02 at 14:26 +0200, Jiri Kosina wrote:
On Wed, 1 Apr 2015, Oliver Neukum wrote:
I am postponing all these before it is clarified that this is indeed a
case reporter is able to reproduce on different system as well to rule
out
the possibility of hub being the actual
On Wed, Apr 08, 2015 at 06:04:52PM +0200, Hans de Goede wrote:
Non interleaved V2 dualpoint touchpad / stick combos have separate stick
button bits in the touchpad packets, if we do not check these then the
trackpoint buttons will not work when using the touchpad, and when pressed
when the
Hi Linus, Dmitry,
Sorry for the last minute regression fix, but the existence of this regression
was not entirely clear until Hans de Bruin send a very clear reproducer this
morning.
I'm not sure if this is 4.0 material, it does fix a real regression, the fix
is pretty simple and safe (*), and
Hi,
On 08-04-15 18:24, Dmitry Torokhov wrote:
On Wed, Apr 08, 2015 at 06:04:52PM +0200, Hans de Goede wrote:
Non interleaved V2 dualpoint touchpad / stick combos have separate stick
button bits in the touchpad packets, if we do not check these then the
trackpoint buttons will not work when
On Wed, Apr 08, 2015 at 07:05:17PM +0200, Hans de Goede wrote:
Hi,
On 08-04-15 18:24, Dmitry Torokhov wrote:
On Wed, Apr 08, 2015 at 06:04:52PM +0200, Hans de Goede wrote:
Non interleaved V2 dualpoint touchpad / stick combos have separate stick
button bits in the touchpad packets, if we do
On Sun, 2015-04-05 at 20:06 +0300, Priit Laes wrote:
On Sun, 2015-04-05 at 18:04 +0200, Bastien Nocera wrote:
On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote:
This patch implements GT801x2 touchscreen support.
Unfortunately, there is a big difference between GT801 and GT9xx
series
On Sun, 2015-04-05 at 16:56 -0700, Dmitry Torokhov wrote:
On Sun, Apr 05, 2015 at 06:04:24PM +0200, Bastien Nocera wrote:
On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote:
This patch implements GT801x2 touchscreen support.
Unfortunately, there is a big difference between GT801 and
From: Steve Twiss stwiss.opensou...@diasemi.com
Add device tree bindings for the DA9063 OnKey driver
This patch is dependent on PATCH V1 1/2
Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com
---
This patch applies against linux-next and v4.0-rc6
From: Steve Twiss stwiss.opensou...@diasemi.com
Add OnKey driver support for DA9063
This patch is dependent on PATCH V1 2/2
Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com
---
This patch applies against linux-next and v4.0-rc6
MAINTAINERS | 2 +-
Hi,
On 08-04-15 12:59, Hans de Bruin wrote:
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
When I play KDE kpatience, a card game, card
On 04/08/2015 05:29 PM, Hans de Goede wrote:
Hi,
On 08-04-15 12:59, Hans de Bruin wrote:
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl
wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
On 04/08/2015 06:04 PM, Hans de Goede wrote:
Hi,
On 08-04-15 12:59, Hans de Bruin wrote:
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl
wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
When the left touchpad button gets pressed, and then the trackpoint is moved,
and then the button is released, the following happens:
1) touchpad packet is received, touchpad evdev node reports BTN_LEFT 1
2) pointingstick packet is received, the hw will report a BTN_LEFT 1 in this
packet
Non interleaved V2 dualpoint touchpad / stick combos have separate stick
button bits in the touchpad packets, if we do not check these then the
trackpoint buttons will not work when using the touchpad, and when pressed
when the user starts using the touchpad will report a release event even
though
Hi,
On 08-04-15 12:59, Hans de Bruin wrote:
On 04/06/2015 11:23 PM, Dmitry Torokhov wrote:
Hi Hans,
On Mon, Apr 6, 2015 at 11:39 AM, Hans de Bruin jmdebr...@xmsnet.nl wrote:
Since 4.0.0-rc something mu laptop has some mouse /keyboard problems.
When I play KDE kpatience, a card game, card
On Wednesday 08 April 2015 17:38:52 Hans de Goede wrote:
When the left touchpad button gets pressed, and then the
trackpoint is moved, and then the button is released, the
following happens:
1) touchpad packet is received, touchpad evdev node reports
BTN_LEFT 1 2) pointingstick packet is
Remove unused variable from the lg4ff_device_entry struct. This is a leftover
from times where hid_get|set_drvdata() was not available to hid-lg4ff so it had
to keep track of the devices it managed by itself.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c |
Explicit casts from void * are not necessary.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index d1d5d45..5a3b3be 100644
---
Only one of LG_FF flags can be set for a given device.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c3981da..f1e92bf 100644
---
Make lg4ff_wheel_data a separate structure stored within lg4ff_device_entry.
Adjust the initialization process accordingly.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 166 +---
1 file changed, 88
Update a warning message for a case where device is incorrectly flagged to be
handled by hid-lg4ff in hid-lg. The original warning message was highly
misleading. This warning can be triggered only if a device is flagged to be
handled by hid-lg4ff in hid-lg but hid-lg4ff lacks support for such
Remove double underscore prefix from numeric types. This code will never be used
outside the kernel so the prefixes are unnecessary.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 52 -
Check return values from lg[N]ff_init(). hid-lg did not check return values from
the lg[N]_init() functions, possibly trying to work with a device whose
initialization has failed.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg.c | 11 +++
1 file changed,
Replace DEVICE_ATTR_RW with DEVICE_ATTR to have all internal functions prefixed
with lg4ff_. All internal functions should be prefixed with just lg4ff_.
Usage of DEVICE_ATTR_RW breaks this scheme because it expects the functions'
names to match the name of the respective sysfs entry.
This
Stop the hid device from lg4ff. Originally hid-lg was responsible for
stopping of the device.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg.c| 4 ++--
drivers/hid/hid-lg4ff.c | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git
Remove hid_ prefix from some functions' names. All internal functions
of hid-lg4ff should be prefixed with just lg4ff_
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff
Update respective sysfs interface documentation
- Refer to the sysfs interface for range using /sys/bus/...
- Update contact email address
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
Documentation/ABI/testing/sysfs-driver-hid-logitech-lg4ff | 8
1 file changed, 4
Protect concurrent access to output HID report with a spinlock. The HID report
structure used to submit commands to wheels is shared amongst all functions that
need to do so and some of these functions can be executed in parallel.
Additionally, lg4ff_play() can be called from interrupt context by
Allow the driver to continue without sysfs interface. Instead of bailing out
allow the driver to continue in a degraded mode.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Constify those members of lg4ff_device_entry struct whose value is not
supposed to change.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 54 +++--
1 file changed, 39 insertions(+), 15 deletions(-)
diff --git
Store pointer to the output HID report struct in the device entry struct.
This eliminates the need to look the HID report struct up every time it is
needed.
Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net
---
drivers/hid/hid-lg4ff.c | 67
Hello everyone,
this is a mostly boring series that deals with a few inconsistencies in the
code that have accumulated over the years. Besides that it patches up a handful
of problems such a return values not being checked etc.
The only significant change comes in patches 8 through 10 which
On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote:
On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Rohár wrote:
On Monday 06 April 2015 01:53:43 Dmitry Torokhov wrote:
On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote:
On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote:
37 matches
Mail list logo
