[PATCH v2] alps: Document separate pointstick button bits for V2 alps devices

2015-04-15 Thread Hans de Goede
Non interleaved dualpoint v2 devices have separate pointstick button bits, document this. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Document that the pointingstick packet button bits give the combined button status of both the stick and the touchpad buttons ---

[PATCH] usbhid: correct PM failure with closed devices

2015-04-15 Thread Oliver Neukum
When usbhid closes a device which was awake only because remote wakeup was required but not provided, the interface must go through a get/put cycle or the core will never reattempt to suspend the device. This brakes runtime PM for all joysticks. Signed-off-by: Oliver Neukum oneu...@suse.de ---

Re: [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks

2015-04-15 Thread Ulf Hansson
[...] Had I not noticed your message, you would have probably ended up removing a driver which is very much in use, is functional, and therefore is not as broken as Ulf claims. I claimed the system PM needed to be fixed, nothing else. :-) The other lesson to come away from this is that

Re: need to get the interface cycled with autopm_get/_put() to let a device sleep

2015-04-15 Thread Alan Stern
On Wed, 15 Apr 2015, Oliver Neukum wrote: Hi, I found a problem with the close() function of usbhid. It fails to properly suspend device that don't support remote wake-up. The power core does not retry an autosuspend that failed due to a lack of support for remote wake-up. So there

need to get the interface cycled with autopm_get/_put() to let a device sleep

2015-04-15 Thread Oliver Neukum
Hi, I found a problem with the close() function of usbhid. It fails to properly suspend device that don't support remote wake-up. The power core does not retry an autosuspend that failed due to a lack of support for remote wake-up. So there needs to be a _put() if the need for remote wake-up is

[PATCH -next] input/touchscreen: fix sur40.c build errors

2015-04-15 Thread Randy Dunlap
changed, 1 insertion(+) --- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig +++ linux-next-20150415/drivers/input/touchscreen/Kconfig @@ -981,6 +981,7 @@ config TOUCHSCREEN_SUR40 tristate Samsung SUR40 (Surface 2.0/PixelSense) touchscreen depends on USB depends

Re: [PATCH -next] input/touchscreen: fix sur40.c build errors

2015-04-15 Thread Florian Echtler
Hello Randy, On 15.04.2015 17:54, Randy Dunlap wrote: --- drivers/input/touchscreen/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20150415.orig/drivers/input/touchscreen/Kconfig +++ linux-next-20150415/drivers/input/touchscreen/Kconfig @@ -981,6 +981,7 @@ config

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Javier Martinez Canillas
Hello Dmitry, On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in Google Pixel 2 (2015). While newer version of ACPI standard allow use of device-tree-like properties in device descriptions, the version of ACPI implemented in

Re: [PATCH 2/2] Input: atmel_mxt_ts - allow specifying device-specific configs

2015-04-15 Thread Javier Martinez Canillas
Hello Dmitry, On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: Atmel controolers are very flexible and to function optimally require device-specific configuration to be loaded. While the configuration is stored in NVRAM and is normally persistent, sometimes it gets corrupted and needs to be

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Dmitry Torokhov
On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote: On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: @@ -724,15 +726,15 @@ static void mxt_input_button(struct mxt_data *data, u8 *message) { struct input_dev *input = data-input_dev; const struct

Re: [PATCH v2] alps: Document separate pointstick button bits for V2 alps devices

2015-04-15 Thread Dmitry Torokhov
On Wed, Apr 15, 2015 at 04:08:47PM +0200, Hans de Goede wrote: Non interleaved dualpoint v2 devices have separate pointstick button bits, document this. Signed-off-by: Hans de Goede hdego...@redhat.com Applied, thank you. --- Changes in v2: -Document that the pointingstick packet button

Re: [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks

2015-04-15 Thread Dmitry Torokhov
On Wed, Apr 15, 2015 at 10:32:45AM +0100, Russell King - ARM Linux wrote: On Tue, Apr 14, 2015 at 04:58:22PM -0700, Dmitry Torokhov wrote: On Tue, Apr 14, 2015 at 11:30:29PM +0100, Russell King - ARM Linux wrote: On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote: On Tue,

Re: [PATCH 5/5] Input: elan_i2c - Correct the x and y trace number.

2015-04-15 Thread 'Dmitry Torokhov'
On Wed, Apr 15, 2015 at 09:55:43AM +0800, DusonLin wrote: The trace number does not need to subtract 1 now. Could you provide a bit more of background for this change? Why don't we need to decrement the number returned by the firmware anymore? We have been running with the old numbers for many

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Dmitry Torokhov
On Thu, Apr 16, 2015 at 12:23:03AM +0200, Javier Martinez Canillas wrote: Hello Benjamin, On 04/15/2015 11:20 PM, Benjamin Tissoires wrote: Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Dmitry, On 04/08/2015

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Benjamin Tissoires
On Wed, Apr 15, 2015 at 6:43 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Apr 16, 2015 at 12:23:03AM +0200, Javier Martinez Canillas wrote: Hello Benjamin, On 04/15/2015 11:20 PM, Benjamin Tissoires wrote: Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Javier Martinez Canillas
Hello Dmitry, On Wednesday, April 15, 2015 18:35 BST, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Apr 15, 2015 at 05:58:04PM +0200, Javier Martinez Canillas wrote: This is an unrelated cleanup so probably should had been a separate patch? Fair enough. -- Dmitry

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Javier Martinez Canillas
Hello Benjamin, On 04/15/2015 11:20 PM, Benjamin Tissoires wrote: Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Dmitry, On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: This change allows atmel_mxt_ts to bind to

[PATCH 2/4] HID: wacom: move all quirks to wacom_setup_device_quirks

2015-04-15 Thread Ping Cheng
It makes probe routine easy to follow. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom.h | 2 +- drivers/hid/wacom_sys.c | 39 +-- drivers/hid/wacom_wac.c | 30 +- 3 files changed, 31 insertions(+), 40

[PATCH 1/4] HID: wacom: retrieve name from HID descriptor for generic devices

2015-04-15 Thread Ping Cheng
HID generic devices share the same default name, Wacom HID. This causes userland programs to show same device names for different devices, which would confuse end users with same device names for different devices too. This patch uses name retrieved from HID descriptor, if a meaningful name is

[PATCH 3/4] HID: wacom: move unit and unitExpo initialization to wacom_calculate_res

2015-04-15 Thread Ping Cheng
That is where they belong... Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_sys.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index ca30eab..855f3b3 100644 --- a/drivers/hid/wacom_sys.c +++

[PATCH 4/4] HID: wacom: remove unused packet lengths

2015-04-15 Thread Ping Cheng
We use generic hid_report_len() to get individual packet length now. Signed-off-by: Ping Cheng pi...@wacom.com --- drivers/hid/wacom_wac.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h index 4700ac9..f5a5f68 100644 ---

[PATCH v1] HID: bug fixes in hid-cp2112 driver

2015-04-15 Thread Ellen Wang
1. cp2112_xfer() byte swaps smbus words incorrectly: While i2c is by and large big endian, smbus transactions are little endian. This only affects word operands. Essentially, all occurences of be16 in cp2112_xfer() are now le16. 2. I2C_SMBUS_BYTE write in cp2112_xfer() should pass command as

[PATCH] HID: wacom: Simplify check for presence of single-finger touch

2015-04-15 Thread Jason Gerecke
To determine if a touch is present in the single-touch case, we can simply check if the BTN_TOUCH key is active or not. This will work for both HID_GENERIC and other device types. Signed-off-by: Jason Gerecke jason.gere...@wacom.com --- drivers/hid/wacom_wac.c | 5 ++--- 1 file changed, 2

Re: [PATCH 5/5] Input: elan_i2c - Correct the x and y trace number.

2015-04-15 Thread duson
Hi Dmitry, I double check with our firmware team and the SPEC, it looks like the subtract 1 just a misunderstanding. So, the correct should not subtract 1. For example, if the touchpad x resolution is 2800 and x trace number is 20, the pitch size of x should be 2800/20 = 140, not 2800/19 =

Re: [PATCH 1/2] Input: atmel_mxt_ts - add support for Google Pixel 2

2015-04-15 Thread Benjamin Tissoires
Hi guys, On Wed, Apr 15, 2015 at 11:58 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Dmitry, On 04/08/2015 02:26 AM, Dmitry Torokhov wrote: This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in Google Pixel 2 (2015). While newer version of ACPI

Re: [PATCH] input: ambakmi: Fix system PM by converting to modern callbacks

2015-04-15 Thread Russell King - ARM Linux
On Tue, Apr 14, 2015 at 04:58:22PM -0700, Dmitry Torokhov wrote: On Tue, Apr 14, 2015 at 11:30:29PM +0100, Russell King - ARM Linux wrote: On Tue, Apr 14, 2015 at 09:22:10AM -0700, Dmitry Torokhov wrote: On Tue, Apr 14, 2015 at 12:41:48PM +0200, Ulf Hansson wrote: The legacy system PM