Re: [PATCH v1] HID: cp2112: support i2c write-read transfers in hid-cp2112

2015-07-08 Thread Jiri Kosina
On Sat, 20 Jun 2015, Antonio Borneo wrote: Signed-off-by: Ellen Wang el...@cumulusnetworks.com --- drivers/hid/hid-cp2112.c | 74 ++ 1 file changed, 55 insertions(+), 19 deletions(-) diff --git a/drivers/hid/hid-cp2112.c

[PATCH v3 1/9] mfd/extcon: max77693: Remove unused extern declarations and max77693_dev members

2015-07-08 Thread Krzysztof Kozlowski
Clean up the max77693 private header file by removing: 1. Left-overs from previous way of interrupt handling (driver uses regmap_irq_chip). 2. Unused members of struct 'max77693_dev' related to interrupts in extcon driver. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by:

[PATCH v3 4/9] extcon/input/mfd/power/regulator: max77693: Move state container to common header

2015-07-08 Thread Krzysztof Kozlowski
This prepares for merging some of the drivers between max77693 and max77843 so the child MFD driver can be attached to any parent MFD main driver. Move the state container to common header file. Additionally add consistent 'i2c' prefixes to its members (of 'struct i2c_client' type).

[PATCH v3 3/9] regulator: max77693: Support different register configurations

2015-07-08 Thread Krzysztof Kozlowski
Add support for different configurations of charger's registers so the same driver could be used on other devices (e.g. MAX77843). Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by: Mark Brown broo...@kernel.org --- drivers/regulator/max77693.c | 39

[PATCH v3 0/9] regulator: Merge max77843 into max77693

2015-07-08 Thread Krzysztof Kozlowski
Dear Mark, The patchset merges max77843 regulator driver into max77693. It touches multiple subsystems so I think the best way would be to merge it through one tree. I already got acks from extcon, input mfd and power maintainers. If there are no objections then everything could go through

[PATCH v3 7/9] mfd/extcon: max77843: Rename defines to allow inclusion with max77693

2015-07-08 Thread Krzysztof Kozlowski
Add MAX77843_MUIC prefix to some of the defines used in max77843 extcon driver so the max77693-private.h can be included simultaneously with max77843-private.h. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Chanwoo Choi

[PATCH v3 9/9] regulator: Remove the max77843 driver

2015-07-08 Thread Krzysztof Kozlowski
The max77693 regulator driver supports Maxim 77843 device so remove the max77843 driver. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com --- drivers/regulator/Kconfig| 8 -- drivers/regulator/Makefile | 1 - drivers/regulator/max77843.c | 203

[PATCH v3 5/9] extcon/input/mfd/regulator: max77843: Switch to common max77693 state container

2015-07-08 Thread Krzysztof Kozlowski
Switch to the same definition of state container as in MAX77693 drivers. This will allow usage of one regulator driver in both devices: MAX77693 and MAX77843. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Acked-by: Lee Jones

[PATCH v3 8/9] regulator: max77693: Add support for MAX77843 device

2015-07-08 Thread Krzysztof Kozlowski
The charger and safeout part of MAX77843 is almost the same as MAX77693. From regulator point of view the only differences are the constraints and register values related to these constraints. Now the max77693 regulator driver can be used for MAX77843. Signed-off-by: Krzysztof Kozlowski

[PATCH v3 6/9] mfd/extcon: max77693: Rename defines to allow inclusion with max77843

2015-07-08 Thread Krzysztof Kozlowski
Add MAX77693 prefix to some of the defines used in max77693 extcon driver so the max77693-private.h can be included simultaneously with max77843-private.h. Additionally use BIT() macro in header. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by: Lee Jones lee.jo...@linaro.org

[PATCH v3 2/9] mfd: max77693: Store I2C device type as enum and add default unknown

2015-07-08 Thread Krzysztof Kozlowski
Store the device type (obtained from i2c_device_id) as an enum and add a default type of unknown to distinguish from case when this is not set at all. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Acked-by: Lee Jones lee.jo...@linaro.org --- include/linux/mfd/max77693-private.h | 11

Re: [PATCH v2] HID: cp2112: support large i2c transfers in hid-cp2112

2015-07-08 Thread Vaibhav Hiremath
On Wednesday 08 July 2015 03:55 PM, Ellen Wang wrote: cp2112_i2c_xfer() only reads up to 61 bytes, returning EIO on longers reads. The fix is to wrap a loop around cp2112_read() to pick up all the returned data. Signed-off-by: Ellen Wang el...@cumulusnetworks.com --- This is the updated

Re: [PATCH v1] HID: cp2112: support i2c write-read transfers in hid-cp2112

2015-07-08 Thread Ellen Wang
On 07/08/2015 02:34 AM, Jiri Kosina wrote: On Sat, 20 Jun 2015, Antonio Borneo wrote: Signed-off-by: Ellen Wang el...@cumulusnetworks.com --- drivers/hid/hid-cp2112.c | 74 ++ 1 file changed, 55 insertions(+), 19 deletions(-) diff --git

Re: [PATCH] HID: wacom: Enable pad device for older Bamboo Touch tablets

2015-07-08 Thread Jiri Kosina
On Wed, 1 Jul 2015, Jason Gerecke wrote: Commit 862cf55 neglected to set the WACOM_DEVICETYPE_PAD flag for older two-finger Bamboo Touch tablets. Not only does this result in the pad device not appearing when such a tablet is plugged in, but also causes a segfault when 'wacom_bpt_touch' tries

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-08 Thread Jiri Kosina
On Wed, 8 Jul 2015, Ellen Wang wrote: Works as described. Thank you! By the way, I tested the code with and without your fix on my rev 2 chip, and it behaved the same way as you describe on your rev 1 chip. Ellen, are you okay with me applying the patch with

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-08 Thread Jiri Kosina
On Wed, 8 Jul 2015, Gabriele Mazzotta wrote: i2c-hid takes care of requesting and handling IRQs for HID devices which in turns might expect them to be always active when working in normal conditions. Hence, disabling IRQs before calling the suspend callbacks can potentially cause problems

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-08 Thread Roger Quadros
Dmitry, On 07/07/15 19:25, Dmitry Torokhov wrote: Hi Roger, On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote: Hi Dmitry, On 07/07/15 03:27, Dmitry Torokhov wrote: The binding specification says that touchscreen-size-x and -y specify horizontal and vertical resolution of the

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-08 Thread Jiri Kosina
On Wed, 1 Jul 2015, Ellen Wang wrote: Works as described. Thank you! By the way, I tested the code with and without your fix on my rev 2 chip, and it behaved the same way as you describe on your rev 1 chip. Ellen, are you okay with me applying the patch with Tested-by: Ellen Wang

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-08 Thread Gabriele Mazzotta
On Tuesday 07 July 2015 22:49:30 Jiri Kosina wrote: On Tue, 7 Jul 2015, Gabriele Mazzotta wrote: The irq is most likely required by the suspend callback, so disable it only after the callback had been executed. It would be nice to have a more verbose changelog here -- i.e. why we want

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-08 Thread Ellen Wang
On 07/08/2015 02:15 AM, Jiri Kosina wrote: On Wed, 1 Jul 2015, Ellen Wang wrote: Works as described. Thank you! By the way, I tested the code with and without your fix on my rev 2 chip, and it behaved the same way as you describe on your rev 1 chip. Ellen, are you okay with me applying the

[PATCH v2] HID: cp2112: support large i2c transfers in hid-cp2112

2015-07-08 Thread Ellen Wang
cp2112_i2c_xfer() only reads up to 61 bytes, returning EIO on longers reads. The fix is to wrap a loop around cp2112_read() to pick up all the returned data. Signed-off-by: Ellen Wang el...@cumulusnetworks.com --- This is the updated patch with a check for 0 return from cp2112_read(). I tested

Re: [PATCH] Input: drv260x/drv2665/drv2667 - Constify reg_default tables

2015-07-08 Thread Dmitry Torokhov
On Tue, Jul 07, 2015 at 09:01:39AM +0800, Axel Lin wrote: These reg_default tables are not modified after initialized, so make them const. Signed-off-by: Axel Lin axel@ingics.com Applied, thank you. --- drivers/input/misc/drv260x.c | 2 +- drivers/input/misc/drv2665.c | 2 +-

Re: [PATCH 2/3] Input: of_touchscreen - fix setting max values on X/Y axis

2015-07-08 Thread Dmitry Torokhov
On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote: Dmitry, On 07/07/15 19:25, Dmitry Torokhov wrote: Hi Roger, On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote: Hi Dmitry, On 07/07/15 03:27, Dmitry Torokhov wrote: The binding specification says that

Re: [PATCH v2] HID: cp2112: support large i2c transfers in hid-cp2112

2015-07-08 Thread Ellen Wang
On 07/08/2015 05:07 AM, Vaibhav Hiremath wrote: On Wednesday 08 July 2015 03:55 PM, Ellen Wang wrote: cp2112_i2c_xfer() only reads up to 61 bytes, returning EIO on longers reads. The fix is to wrap a loop around cp2112_read() to pick up all the returned data. Signed-off-by: Ellen Wang

[PATCH] Input: Use for_each_set_bit where appropriate

2015-07-08 Thread Anshul Garg
Use for_each_set_bit to check for set bits in bitmap as it is more efficient than checking individual bits. Signed-off-by: Anshul Garg aksgarg1...@gmail.com --- drivers/input/ff-core.c |5 ++--- drivers/input/joydev.c | 11 +-- 2 files changed, 7 insertions(+), 9 deletions(-)

[PATCH v3] HID: cp2112: support large i2c transfers in hid-cp2112

2015-07-08 Thread Ellen Wang
cp2112_i2c_xfer() only reads up to 61 bytes, returning EIO on longers reads. The fix is to wrap a loop around cp2112_read() to pick up all the returned data. Signed-off-by: Ellen Wang el...@cumulusnetworks.com --- This is the updated patch with a check for 0 return from cp2112_read(). I tested

[PATCH] i2c-HID: Delete unnecessary checks before the function call gpiod_put

2015-07-08 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 8 Jul 2015 22:12:25 +0200 The gpiod_put() function performs also input parameter validation by forwarding its single input pointer to the gpiod_free() function. Thus the test around the calls is not needed. This issue was detected by

Re: [PATCH] Input: elan_i2c - Change the hover event from MT to ST

2015-07-08 Thread Benjamin Tissoires
On Wed, Jul 8, 2015 at 7:11 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Jul 08, 2015 at 06:58:36PM -0400, Benjamin Tissoires wrote: On Tue, Jul 7, 2015 at 2:06 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Jul 07, 2015 at 01:37:14PM +0800, duson wrote: We

Re: [PATCH] Input: elan_i2c - Change the hover event from MT to ST

2015-07-08 Thread Dmitry Torokhov
On Wed, Jul 08, 2015 at 06:58:36PM -0400, Benjamin Tissoires wrote: On Tue, Jul 7, 2015 at 2:06 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Jul 07, 2015 at 01:37:14PM +0800, duson wrote: We want the hover event like BTN_LEFT, even no contract object, it still can be