Re: [PATCH v2 3/4] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50

2015-07-21 Thread Stefan Agner
Hi Dmitry, As the original author of the driver I have some remarks to your review On 2015-07-18 01:42, Dmitry Torokhov wrote: +/* + * If touch pressure is too low, stop measuring and reenable + * touch detection + */ +if (val_p

Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt

2015-07-21 Thread Vignesh R
Hi Dmitry, On 07/20/2015 11:54 AM, Dmitry Torokhov wrote: On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150719 21:53]: @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, %s: x %d, y

Re: [PATCH v2 3/4] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50

2015-07-21 Thread Dmitry Torokhov
Hi Stefan, On Tue, Jul 21, 2015 at 04:43:36PM +0200, Stefan Agner wrote: Hi Dmitry, As the original author of the driver I have some remarks to your review On 2015-07-18 01:42, Dmitry Torokhov wrote: + /* + * If touch pressure is too low, stop measuring and reenable

Re: ALPS DualPoint double click bug

2015-07-21 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 11:00:27PM -0400, Douglas Christman wrote: On Mon, Jul 20, 2015 at 3:25 AM, Pali Rohár pali.ro...@gmail.com wrote: Hi! Please recompile psmouse.ko with dev_dbg() debug information and send new dmesg output. We need to know type of ALPS device. Thanks! I recompiled

[PATCH 2/3] HID: wacom: Ignore contacts in excess of declared contact count

2015-07-21 Thread Jason Gerecke
The reports sent from some touch devices (e.g. the Cintiq 24HDT) contain junk data in the contact slots which follow the final valid contact. To avoid forwarding it to usrspace, we store the reported contact count during the pre-process phase and then only process that many contacts. If a device

[PATCH 3/3] HID: wacom: Report touch width/height/orientation for GENERIC devices

2015-07-21 Thread Jason Gerecke
The HID_DG_WIDTH and HID_DG_HEIGHT usages report with width and height of contacts. From this information, a crude determination of orientation is also possible. This patch reports all three to userspace if a device reports this usage. Signed-off-by: Jason Gerecke jason.gere...@wacom.com ---

[PATCH 1/3] HID: wacom: Perform all event processing as part of report processing

2015-07-21 Thread Jason Gerecke
In some cases, we need access to information before it becomes available to the 'event' handler. In particular, for some devices we cannot properly process the finger data without first knowing the contact count at the very end of the report (e.g. the Cintiq 24HDT touch screen, when forced through

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-21 Thread Dmitry Torokhov
On Tue, Jul 21, 2015 at 01:14:39PM +0200, Vlastimil Babka wrote: On 06/09/2015 07:42 PM, Dmitry Torokhov wrote: From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input handler called leds that exports LEDs on input devices as standard LED class devices in

Re: [PATCH] hid: Drop owner assignment from i2c_driver

2015-07-21 Thread Benjamin Tissoires
On Jul 10 2015 or thereabouts, Krzysztof Kozlowski wrote: i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- BTW, Dmitry took the same in his tree, so I think we are safe here too. Acked-by:

Re: [PATCH v2 3/4] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50

2015-07-21 Thread maitysanchayan
On 15-07-21 10:20:44, Dmitry Torokhov wrote: Hi Stefan, On Tue, Jul 21, 2015 at 04:43:36PM +0200, Stefan Agner wrote: Hi Dmitry, As the original author of the driver I have some remarks to your review On 2015-07-18 01:42, Dmitry Torokhov wrote: +/* +

[RFC] ps2emu - PS/2 emulation module

2015-07-21 Thread Stephen Chandler Paul
Hi! So, following this is a patch to add the ps2emu module to the kernel. This module basically allows for us to create virtual PS/2 devices and control them from userspace. With this, we can do useful things such as playing back recordings of PS/2 devices in a similar manner to evemu-replay and

[RFC] Input: Add ps2emu module

2015-07-21 Thread Stephen Chandler Paul
Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device provided by the kernel, and simulate any PS/2 device. In combination with

[RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Stephen Chandler Paul
Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device provided by the kernel, and simulate any PS/2 device. In combination with

Re: [RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:47:17PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device

Re: [RFC] Input: Add ps2emu module

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:07:14PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device

Re: [RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Dmitry Torokhov
Hi Stephen, On Tue, Jul 21, 2015 at 03:47:17PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character

Re: [RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Stephen Chandler Paul
On Tue, 2015-07-21 at 13:46 -0700, Dmitry Torokhov wrote: Hi Stephen, On Tue, Jul 21, 2015 at 03:47:17PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that

Re: [RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Dmitry Torokhov
On Tue, Jul 21, 2015 at 05:42:17PM -0400, Stephen Chandler Paul wrote: On Tue, 2015-07-21 at 13:46 -0700, Dmitry Torokhov wrote: Hi Stephen, On Tue, Jul 21, 2015 at 03:47:17PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be

Re: [RFC] ps2emu - PS/2 emulation module

2015-07-21 Thread Dmitry Torokhov
On Tue, Jul 21, 2015 at 03:07:13PM -0400, Stephen Chandler Paul wrote: Right now we make use of this module with the ps2emu userland tools[2] that I've wrote recently. Recording of PS/2 devices is done by enabling the debugging output from i8042, triggering a rescan of the PS/2 ports, and

Re: ALPS DualPoint double click bug

2015-07-21 Thread Douglas Christman
On Tue, Jul 21, 2015 at 3:12 AM, Pali Rohár pali.ro...@gmail.com wrote: It is not enough. If do not want to recompile full kernel, but just only psmouse.ko I think that the easiest way is to change this define #define psmouse_dbg in file drivers/input/mouse/psmouse.h to call dev_warn

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Opensource [Steve Twiss]
Hi Alexandre, Thank you for your quick responses on these patches. I will probably need your further advice on the of_compatible issue with the DA9063 RTC ... I've made some quick replies below. On 20 July 2015 22:51 Alexandre Belloni wrote: On 20/07/2015 at 17:57:50 +, Opensource [Steve

Re: ALPS DualPoint double click bug

2015-07-21 Thread Pali Rohár
On Monday 20 July 2015 23:00:27 Douglas Christman wrote: On Mon, Jul 20, 2015 at 3:25 AM, Pali Rohár pali.ro...@gmail.com wrote: Hi! Please recompile psmouse.ko with dev_dbg() debug information and send new dmesg output. We need to know type of ALPS device. Thanks! I recompiled with

Re: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Alexandre Belloni
Hi Steve, it looks mostly good, a few more comments: On 21/07/2015 at 10:43:10 +0100, S Twiss wrote : - if (val (DA9063_E_ALARM)) + if (val (config-rtc_event_alarm_mask)) unneeded parenthesis here + if (of_device_is_compatible(pdev-dev.of_node, dlg,da9063-rtc)) { +

RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Opensource [Steve Twiss]
On 21 July 2015 11:02, Alexandre Belloni wrote: Hi Alexandre, Thanks for your help on this I will send patch v3 with the following changes ... On 21/07/2015 at 10:43:10 +0100, S Twiss wrote : - if (val (DA9063_E_ALARM)) + if (val (config-rtc_event_alarm_mask)) unneeded parenthesis

[PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add DA9062 RTC support into the existing DA9063 RTC driver component by using generic access tables for common register and bit mask definitions. The following change will add generic register and bit mask support to the DA9063 RTC. The changes are

[PATCH acer-switch12-keyboard] hid core: Enable support for Fn+ controls keys on Acer Aspire Switch 12 keyboard

2015-07-21 Thread Николай Кудрявцев
Acer Aspire Switch 12 keyboard Chicony's controller reports too big usage index on the 1st interface. The patch fixes the report. The work based on solution from drivers/hid/hid-holtek-mouse.c Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=101721 Signed-off-by: Nicholas Kudriavtsev

[PATCH V3 1/3] mfd: da9062: Support for the DA9063 RTC in the DA9062 core

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add MFD core driver support for a RTC component - MFD core adds the RTC resources da9062_rtc_resources[] for the RTC alarm and tick timer IRQ - An appropriate mfd_cell has been added into da9062_devs[] to support a component .name = da9062-rtc and

[PATCH V3 2/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add device tree bindings for the DA9062 RTC driver component Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com --- Checks performed with linux-next/next-20150708/scripts/checkpatch.pl da9062.txttotal: 0 errors, 0 warnings, 88

[PATCH V3 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com This patch set adds RTC support for the Dialog DA9062 Power Management IC. Changes are made to the existing DA9063 RTC component so that functionality in this device driver can be re-used to support the DA9062 RTC. This following patch set is the

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 20/07/2015 23:59, Greg KH a écrit : On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: diff --git a/Documentation/ABI/testing/sysfs-driver-ebeam b/Documentation/ABI/testing/sysfs-driver-ebeam +++ b/Documentation/ABI/testing/sysfs-driver-ebeam @@ -0,0 +1,53 @@ +What:

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-21 Thread Vlastimil Babka
On 06/09/2015 07:42 PM, Dmitry Torokhov wrote: From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input handler called leds that exports LEDs on input devices as standard LED class devices in sysfs and allows controlling their ptate via sysfs or via any of the

[PATCH V2 2/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add device tree bindings for the DA9062 RTC driver component Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com --- Checks performed with linux-next/next-20150708/scripts/checkpatch.pl da9062.txttotal: 0 errors, 0 warnings, 88

Re: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread Alexandre Belloni
Hi, On 21/07/2015 at 08:05:32 +, Opensource [Steve Twiss] wrote : + + rtc = devm_kzalloc(pdev-dev, sizeof(*rtc), GFP_KERNEL); + if (!rtc) + return -ENOMEM; + + if (strncmp(match-name, dlg,da9063-rtc, 14) == 0) { + struct

Re: [PATCH 4/4 v2] Input: zforce - enable irq only if we are ready to process it

2015-07-21 Thread Dirk Behme
On 20.07.2015 14:56, Dirk Behme wrote: From: Oleksij Rempel external.oleksij.rem...@de.bosch.com If zforce is not ready to process the interrupt, the touchscreen will be lost forever. Make sure we enable the interrupt only if processing is ready. Talking with Oleksij about the discussion in

[PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add DA9062 RTC support into the existing DA9063 RTC driver component by using generic access tables for common register and bit mask definitions. The following change will add generic register and bit mask support to the DA9063 RTC. The changes are

[PATCH V2 1/3] mfd: da9062: Support for the DA9063 RTC in the DA9062 core

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com Add MFD core driver support for a RTC component - MFD core adds the RTC resources da9062_rtc_resources[] for the RTC alarm and tick timer IRQ - An appropriate mfd_cell has been added into da9062_devs[] to support a component .name = da9062-rtc and

[PATCH V2 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

2015-07-21 Thread S Twiss
From: S Twiss stwiss.opensou...@diasemi.com This patch set adds RTC support for the Dialog DA9062 Power Management IC. Changes are made to the existing DA9063 RTC component so that functionality in this device driver can be re-used to support the DA9062 RTC. This following patch set is the

[PATCH] Input: synaptics: dump ext10 capabilities as well

2015-07-21 Thread Jiri Kosina
Make extended capabilities obtained through $10 query also available in touchpad identification. Signed-off-by: Jiri Kosina jkos...@suse.com --- drivers/input/mouse/synaptics.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 21/07/2015 00:40, Greg KH a écrit : On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net + + /*

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Oliver Neukum
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 + drivers/input/misc/Makefile | 1 +

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 21/07/2015 10:19, Oliver Neukum a écrit : On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote: diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c new file mode 100644 index 000..79cac51 --- /dev/null +++ b/drivers/input/misc/ebeam.c +/* Electronics For

Re: [PATCH] Input: ads7846 - correct the value get from SPI

2015-07-21 Thread Igor Grinberg
Hi, On 05/22/15 10:02, Haibo Chen wrote: According to the touch controller SPEC, SPI return a 16 bit value, only 12 bits are valid, they are bit[14-3]. The value of MISO and MOSI can be configed when SPI in idle mode. Currently this touch driver consider the SPI bus set the MOSI and MISO

Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver

2015-07-21 Thread Marek Szyprowski
Hello, On 2015-07-16 15:09, Hans Verkuil wrote: Marek, Kamil, On 06/29/15 12:14, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h -

Re: [PATCH] Add generic driver for Silead tochscreens

2015-07-21 Thread Gregor Riepl
Hi Robert For the existing devices you can override the ACPI tables using initrd. https://www.kernel.org/doc/Documentation/acpi/initrd_table_override.txt There is some work being done that will allow to amend (no need to completely override) the ACPI tables with custom data.

Re: [PATCH] Input: synaptics: dump ext10 capabilities as well

2015-07-21 Thread Benjamin Tissoires
On Jul 21 2015 or thereabouts, Jiri Kosina wrote: Make extended capabilities obtained through $10 query also available in touchpad identification. Signed-off-by: Jiri Kosina jkos...@suse.com --- Works for me. Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cheers, Benjamin