Re: [PATCH v2 3/4] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50

2015-08-03 Thread maitysanchayan
Hello Dmitry, On 15-07-21 10:20:44, Dmitry Torokhov wrote: Hi Stefan, On Tue, Jul 21, 2015 at 04:43:36PM +0200, Stefan Agner wrote: Hi Dmitry, As the original author of the driver I have some remarks to your review On 2015-07-18 01:42, Dmitry Torokhov wrote: +/*

[PATCH 8/9] Input: atmel_mxt_ts - initialise input slots with INPUT_MT_DIRECT

2015-08-03 Thread Nick Dyer
This indicates the device coordinates should be directly mapped to screen. This is valid since scaling/flipping/rotation should be done by configuring the MXT device. It also flags to Android using INPUT_PROP_DIRECT that the device should be treated as a touch screen by default, and removes the

[PATCH 1/9] MAINTAINERS: Add maintainer for atmel_mxt_ts

2015-08-03 Thread Nick Dyer
Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a226416..d2409bf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1915,6 +1915,12 @@ W: http://atmelwlandriver.sourceforge.net/ S:

[PATCH 3/9] Input: atmel_mxt_ts - remove unused defines

2015-08-03 Thread Nick Dyer
Many of these values are out of date and they aren't used in the driver - all they do is increase the size of the kernel source. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk Acked-by: Benson Leung ble...@chromium.org Acked-by: Yufeng Shen mile...@chromium.org ---

[PATCH 6/9] Input: atmel_mxt_ts - improve device tree parsing

2015-08-03 Thread Nick Dyer
Use function rather than loop, define np to reduce wrapping. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- drivers/input/touchscreen/atmel_mxt_ts.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c

[PATCH 2/9] Input: atmel_mxt_ts - use deep sleep mode when stopped

2015-08-03 Thread Nick Dyer
The hardcoded 0x83 CTRL setting overrides other settings in that byte, enabling extra reporting that may not be useful on a particular platform. Implement improved suspend mechanism via deep sleep. By writing zero to both the active and idle cycle times the maXTouch device can be put into a deep

atmel_mxt_ts - suspend patch and minor fixes

2015-08-03 Thread Nick Dyer
Hi Dmitry- Here is the suspend patch for atmel_mxt_ts, again. I've tested it on Pixel 2 today. The code for T7 deep sleep has been widely used for years in our github version of the driver. Also, several minor (but useful) fixes. And I've added myself to MAINTAINERS because checkpatch. best

[PATCH 5/9] Input: atmel_mxt_ts - suspend/resume causes panic if input_dev fails to init

2015-08-03 Thread Nick Dyer
From: Pan Xinhui xinhuix@intel.com input_dev may be NULL if mxt_initialize_input_device fails. But pm ops is still available and suspend/resume assume input_dev is not NULL. To fix this issue, we add a check if (!input_dev). Signed-off-by: Pan Xinhui xinhuix@intel.com Signed-off-by: Nick

[PATCH 4/9] Input: atmel_mxt_ts - move mxt_initialize after sysfs init

2015-08-03 Thread Nick Dyer
An error in the sysfs init may otherwise interfere with the async return from the firmware loader Add guards for sysfs functions Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- drivers/input/touchscreen/atmel_mxt_ts.c | 24 1 file changed, 16 insertions(+), 8

[PATCH 7/9] Input: atmel_mxt_ts - disable interrupt for 50ms after reset

2015-08-03 Thread Nick Dyer
The CHG/interrupt line is momentarily set (approximately 100 ms) as an input after power-up or reset for diagnostic purposes. This may cause spurious interrupts, so disable interrupt handler during this period. Signed-off-by: Nick Dyer nick.d...@itdev.co.uk ---

[PATCH 9/9] Input: atmel_mxt_ts - remove warning on zero T44 count

2015-08-03 Thread Nick Dyer
Signed-off-by: Nick Dyer nick.d...@itdev.co.uk --- drivers/input/touchscreen/atmel_mxt_ts.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 2aa44dc..c874008 100644 ---

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-08-03 Thread Linus Walleij
On Thu, Jul 30, 2015 at 7:28 PM, Alban Bedel al...@free.fr wrote: Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS machines, and each machine type provides its own gpio.h. However only a handful really implement the GPIO API, most just forward everythings to gpiolib. The

[PATCH] hid-multitouch: add support for CJTouch panels

2015-08-03 Thread linuxsea
From: Yang Bo linux...@163.com This patch introduce support for CJTouch panels. This device has not been optimized in term of kernel processing operations (default class), but it will work. Signed-off-by: Yang Bo linux...@163.com --- drivers/hid/Kconfig |1 + drivers/hid/hid-ids.h

Re: [PATCH v4 0/8] Goodix touchscreen enhancements

2015-08-03 Thread Bastien Nocera
On Fri, 2015-07-31 at 20:42 +0300, Irina Tirdea wrote: Add several enhancements to the Goodix touchscreen driver. It's going to be a couple of weeks before I have the time to sit down and test most of those. Also note that I'll be using a different device (WinBook TW100), though the new owner of

[PATCHv v2] Input: zforce - make the interrupt GPIO optional

2015-08-03 Thread Dirk Behme
Add support for hardware which uses an I2C Serializer / Deserializer (SerDes) to communicate with the zFroce touch driver. In this case the SerDes will be configured as an interrupt controller and the zForce driver will have no access to poll the GPIO line. To support this, we add two dedicated

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

2015-08-03 Thread Carlo Caione
On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai w...@csie.org wrote: Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its cells. Signed-off-by: Chen-Yu Tsai w...@csie.org Acked-by: Carlo Caione ca...@caione.org Thanks, -- Carlo Caione -- To

[PATCH] Input: axp20x-pek: Add module alias

2015-08-03 Thread Chen-Yu Tsai
Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its cells. Signed-off-by: Chen-Yu Tsai w...@csie.org --- drivers/input/misc/axp20x-pek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/misc/axp20x-pek.c

Re: [PATCHv v2] Input: zforce - make the interrupt GPIO optional

2015-08-03 Thread Heiko Stübner
Hi Dirk, Am Montag, 3. August 2015, 08:34:06 schrieb Dirk Behme: Add support for hardware which uses an I2C Serializer / Deserializer (SerDes) to communicate with the zFroce touch driver. In this case the SerDes will be configured as an interrupt controller and the zForce driver will have no

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Sudip Mukherjee
On Fri, Jul 31, 2015 at 01:43:06PM -0700, Dmitry Torokhov wrote: Converting to the new api is the end goal here, no need to keep the old one around anymore. OK, then I guess we can do the conversion right (dropping db9_base module-global) and see if anyone screams at us. Hi Dmitry, It

Re: [PATCH] HID: use generic driver for ThingM blink(1) if !CONFIG_HID_THINGM

2015-08-03 Thread Reilly Grant
If the software is using usbdevice_fs, no, it can simply detach the kernel driver. If the software is using hidraw then this blacklist becomes the issue because even if you unload the special driver the generic HID driver won't load. Is there a mechanism in the HID subsystem for drivers to build

[PATCH] HID: wacom: Simplify 'wacom_pl_irq'

2015-08-03 Thread Jason Gerecke
Unlike other IRQ functions, 'wacom_pl_irq' uses the second element of the 'tool' array to store information about its single pen. This makes the function more difficult to understand (since it doesn't follow the general pattern of other IRQ functions) and prevents the possibility of refactoring

[PATCH 1/3] HID: wacom: Use calculated pkglen for wireless touch interface

2015-08-03 Thread Jason Gerecke
Commit 01c846f introduced the 'wacom_compute_pktlen' function which automatically determines the correct value for an interface's pkglen by scanning the HID descriptor. This function returns the correct value for the wireless receiver's touch interface, removing the need for us to set it manually

[PATCH 2/3] HID: wacom: Replace WACOM_QUIRK_MONITOR with WACOM_DEVICETYPE_WL_MONITOR

2015-08-03 Thread Jason Gerecke
The monitor interface on the wireless receiver is more logically expressed as a type of device instead of a quirk. Signed-off-by: Jason Gerecke jason.gere...@wacom.com --- drivers/hid/wacom_sys.c | 6 +++--- drivers/hid/wacom_wac.c | 4 +--- drivers/hid/wacom_wac.h | 2 +- 3 files changed, 5

[PATCH 3/3] HID: wacom: Remove WACOM_QUIRK_NO_INPUT

2015-08-03 Thread Jason Gerecke
WACOM_QUIRK_NO_INPUT is a signal to the driver that input devices should not be created for a particular device. This quirk was used by the wireless receiver to prevent any devices from being created during the initial probe (defering it instead until we got a tablet connection event in

Re: [PATCH 3/3] HID: wacom: Remove WACOM_QUIRK_NO_INPUT

2015-08-03 Thread Benjamin Tissoires
On Aug 03 2015 or thereabouts, Jason Gerecke wrote: WACOM_QUIRK_NO_INPUT is a signal to the driver that input devices should not be created for a particular device. This quirk was used by the wireless receiver to prevent any devices from being created during the initial probe (defering it

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Sudip Mukherjee
On Mon, Aug 03, 2015 at 02:26:48PM +0200, Pali Rohár wrote: On Saturday 01 August 2015 18:13:48 Sudip Mukherjee wrote: snip Hey! I believe you are not going to break my Atari joystick connected to my desktop PC via special homemade reduction for parallel port... :-) That Atari joystick

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-08-03 Thread Linus Walleij
On Mon, Aug 3, 2015 at 9:23 AM, Ralf Baechle r...@linux-mips.org wrote: On Mon, Aug 03, 2015 at 09:13:27AM +0200, Linus Walleij wrote: Very good job being done here. Reviewed-by: Linus Walleij linus.wall...@linaro.org I guess this better go in through the MIPS tree. Given all the OpenWRT

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Pali Rohár
On Saturday 01 August 2015 18:13:48 Sudip Mukherjee wrote: On Fri, Jul 31, 2015 at 01:43:06PM -0700, Dmitry Torokhov wrote: On Fri, Jul 31, 2015 at 01:36:18PM -0700, Greg KH wrote: On Fri, Jul 31, 2015 at 11:04:26PM +0530, Sudip Mukherjee wrote: On Fri, Jul 31, 2015 at 09:54:27AM -0700,

Re: [PATCH] Input: drivers/joystick: use parallel port device model

2015-08-03 Thread Pali Rohár
On Monday 03 August 2015 18:06:26 Sudip Mukherjee wrote: On Mon, Aug 03, 2015 at 02:26:48PM +0200, Pali Rohár wrote: On Saturday 01 August 2015 18:13:48 Sudip Mukherjee wrote: snip Hey! I believe you are not going to break my Atari joystick connected to my desktop PC via special

Re: [linux-sunxi] [PATCH] Input: axp20x-pek: Add module alias

2015-08-03 Thread Dmitry Torokhov
On Mon, Aug 03, 2015 at 09:56:09AM +0200, Carlo Caione wrote: On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai w...@csie.org wrote: Add a proper module alias so the driver can be autoloaded when the parent axp20x mfd driver registers its cells. Signed-off-by: Chen-Yu Tsai w...@csie.org

Re: [PATCH v2 3/4] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50

2015-08-03 Thread Dmitry Torokhov
Hi Sanchayan, On Mon, Aug 03, 2015 at 08:55:44PM +0530, maitysancha...@gmail.com wrote: Hello Dmitry, On 15-07-21 10:20:44, Dmitry Torokhov wrote: Hi Stefan, On Tue, Jul 21, 2015 at 04:43:36PM +0200, Stefan Agner wrote: Hi Dmitry, As the original author of the driver I have

Re: [PATCHv v2] Input: zforce - make the interrupt GPIO optional

2015-08-03 Thread Dmitry Torokhov
On Mon, Aug 03, 2015 at 09:54:49AM +0200, Heiko Stübner wrote: Hi Dirk, Am Montag, 3. August 2015, 08:34:06 schrieb Dirk Behme: Add support for hardware which uses an I2C Serializer / Deserializer (SerDes) to communicate with the zFroce touch driver. In this case the SerDes will be

Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during device disconnect

2015-08-03 Thread Dmitry Torokhov
On Mon, Aug 03, 2015 at 02:57:30PM +0900, Krzysztof Kozlowski wrote: During unbinding the driver was dereferencing a pointer to memory already freed by power_supply_unregister(). Driver was freeing its internal description of battery through pointers stored in power_supply structure.