Re: [PATCH] Input: evdev - add event-mask API

2014-04-22 Thread David Herrmann
Hi On Sat, Apr 19, 2014 at 11:16 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: +static size_t evdev_get_mask_cnt(unsigned int type) +{ + switch (type) { + case 0: + /* 0 is special (EV-bits instead of EV_SYN) like EVIOCGBIT */ + return EV_CNT; +

Re: [PATCH] Input: evdev - add event-mask API

2014-04-22 Thread David Herrmann
Hi On Tue, Apr 22, 2014 at 6:29 AM, Peter Hutterer peter.hutte...@who-t.net wrote: +/* requires the buffer lock to be held */ +static bool __evdev_is_masked(struct evdev_client *client, + unsigned int type, + unsigned int code) +{ +

[PATCH] Input: evdev - add event-mask API

2014-04-15 Thread David Herrmann
or event event-types. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/input/evdev.c | 155 + include/uapi/linux/input.h | 8 +++ 2 files changed, 163 insertions(+) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index

Re: HID vendor access from user space

2014-04-14 Thread David Herrmann
Hi On Mon, Apr 14, 2014 at 12:00 PM, Nestor Lopez Casado nlopezca...@logitech.com wrote: David, Jiri, After considering our discussion here, which is your position on extending the hidraw nodes to include separate nodes for top level vendor collections ? Patches, patches, patches! I am

[PATCH] evdev: flush ABS_* events during EVIOCGABS

2014-04-10 Thread David Herrmann
We currently flush input events in the outgoing client queue on most EVIOCG* ioctls so userspace doesn't get events twice (once during the ioctl and once during a later read()). We introduced this in: commit 483180281f0ac60d1138710eb21f4b9961901294 Author: David Herrmann dh.herrm...@gmail.com

Re: [PATCH] HID: uhid: Add UHID_CREATE2 + UHID_INPUT2

2014-03-23 Thread David Herrmann
uhid_input2_req input2; We change the size of uhid_output_req here, but I think that is fine. But you might wanna note that down in the commit-message. Patch looks fine. If you fix the minor issues, this is: Reviewed-by: David Herrmann dh.herrm...@gmail.com And please always put Jiri on CC for all HID

Re: Suspending access to opened/active /dev/nodes during application runtime

2014-03-11 Thread David Herrmann
Hi On Fri, Mar 7, 2014 at 7:45 PM, Lukasz Pawelczyk hav...@gmail.com wrote: Problem: Has anyone thought about a mechanism to limit/remove an access to a device during an application runtime? Meaning we have an application that has an open file descriptor to some /dev/node and depending on

Re: [PATCH v2 1/4] HID: cp2112: remove various hid_out_raw_report calls

2014-03-07 Thread David Herrmann
Hi On Wed, Mar 5, 2014 at 10:18 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid_out_raw_report is going to be obsoleted as it is not part of the unified HID low level transport documentation (Documentation/hid/hid-transport.txt) hid_output_raw_report(hdev, buf, sizeof(buf),

Re: [PATCH 0/6] HID: sony: More Sony controller fixes and improvements.

2014-03-02 Thread David Herrmann
is that modern systems shouldn't be relying on joydev for this functionality. I'd like to know what David Herrmann and Greg Kroah-Hartman came up with regarding the solution mentioned in the reply as it would be nice to be able to set the LEDs to the proper default values in the driver without

Re: [PATCH] hid: fix bug destroying hidraw device files after parent

2014-02-26 Thread David Herrmann
to destroy the device the sysfs files are already gone and the kernel will print the warning above. Fix this by calling device_destroy() at USB disconnect time. Reviewed-by: David Herrmann dh.herrm...@gmail.com This actually also fixes the issue that the device-node is kept even though the device

Re: [PATCH v2 3/5] HID: sony: Perform a boundry check on the sixaxis battery level index.

2014-02-24 Thread David Herrmann
Hi On Thu, Feb 20, 2014 at 5:36 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Make sure that an out-of-bounds read doesn't occur in the Sixaxis battery level lookup table in the event that the controller sends an invalid battery status value in the report. Signed-off-by: Frank Praznik

Re: [PATCH 0/3] HID: low level transport cleanup, series 3

2014-02-24 Thread David Herrmann
(so 3/3 here). There is only two patches 2 merge after these 3... We are approaching the end! All 3 look good: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks again! David Cheers, Benjamin Benjamin Tissoires (3): HID: input: hid-input remove hid_output_raw_report call HID

Re: is it possible to temporarily not let user mode get hid input event

2014-02-24 Thread David Herrmann
Hi On Mon, Feb 24, 2014 at 1:34 PM, loody milo...@gmail.com wrote: Yes. For instance, you can run ./samples/uhid/uhid-example.c via ssh to emulate a mouse. ssh keyboard input can then be used to generate mouse-movement events. There is one embarrassing question :-) Would you please let me

Re: is it possible to temporarily not let user mode get hid input event

2014-02-23 Thread David Herrmann
Hi On Sun, Feb 23, 2014 at 7:52 AM, loody milo...@gmail.com wrote: hi David: Thanks for your suggestion. 2014-02-23 0:56 GMT+08:00 David Herrmann dh.herrm...@gmail.com: Hi On Sat, Feb 22, 2014 at 5:35 PM, loody milo...@gmail.com wrote: hi all: is there any kernel hid module parameter

Re: is it possible to temporarily not let user mode get hid input event

2014-02-22 Thread David Herrmann
Hi On Sat, Feb 22, 2014 at 5:35 PM, loody milo...@gmail.com wrote: hi all: is there any kernel hid module parameter or test program can temporarily not letting user mode program not receiving hid event? 1. My hid kos are still inserted in. 2. the kernel usb driver is working well; that mean

Re: Mixed HID descriptors

2014-02-22 Thread David Herrmann
Hi CC Jiri, Benjamin and Henrik On Thu, Feb 20, 2014 at 12:12 PM, Nuno Santos nsan...@displax.com wrote: Hi, We are developing an HID multitouch device and we want to make it fully compatible with Linux and Windows. The device descriptor describes a mouse, keyboard and multitouch digitizer

Re: [PATCH 1/3] HID: sony: Enable LED controls and rumble for the Sixaxis on Bluetooth.

2014-02-19 Thread David Herrmann
patches so reverts will not affect them. Anyhow, no need to resend imho, so: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David ret = sixaxis_set_operational_bt(hdev); - else if (sc-quirks DUALSHOCK4_CONTROLLER) { + INIT_WORK(sc-state_worker

Re: [PATCH 03/14] HID: core: implement generic .request()

2014-02-16 Thread David Herrmann
Hi On Thu, Feb 13, 2014 at 4:21 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Wed, Feb 12, 2014 at 5:25 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: .request() can be emulated

Re: [PATCH v2 0/9] HID: spring cleanup v2

2014-02-12 Thread David Herrmann
Hi On Wed, Feb 5, 2014 at 10:33 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi guys, well, here comes the promised v2 of the ll_transport cleanup. As I said, I removed patches which need some more work, and kept only the trivial ones. I also added David's documentation,

Re: [PATCH 01/14] HID: uHID: remove duplicated code

2014-02-12 Thread David Herrmann
UHID_OUTPUT_REPORT .. gnah! I should have named the uhid stuff better.. anyhow, patch looks good: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David } static struct hid_ll_driver uhid_hid_driver = { -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH 03/14] HID: core: implement generic .request()

2014-02-12 Thread David Herrmann
: + kfree(buf); +} +EXPORT_SYMBOL_GPL(__hid_request); + Looks good to me. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David int hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size, int interrupt) { diff --git a/include/linux/hid.h b

Re: [PATCH 04/14] HID: i2c-hid: implement ll_driver transport-layer callbacks

2014-02-12 Thread David Herrmann
(client); + bool data = true; /* SET_REPORT */ + + if (report_type == HID_OUTPUT_REPORT) + data = le16_to_cpu(ihid-hdesc.wMaxOutputLength) == 0; Yepp, thanks for splitting that logic out of the report-handling, makes it much easier to follow. Reviewed-by: David

Re: [PATCH 06/14] HID: usbhid: change return error of usbhid_output_report

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: If there is no urbout when sending a output report, ENOSYS (Function not implemented) is a better error than EIO (I/O error). Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off

Re: [PATCH 11/14] HID: sony: remove hid_output_raw_report calls

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: We can not directly change the underlying struct hid_ll_driver here as we did for hdev-hid_output_raw_report. So allocate a struct ll_driver, and replace the old one when removing the device. To get a

Re: [PATCH 13/14] HID: remove hid_output_raw_report

2014-02-12 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 6:58 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: hid_output_raw_report() is not used anymore, delete it. yippieh! Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com

Re: [PATCH v3 0/6] HID: sony: Add full Bluetooth support for the Dualshock 4

2014-02-12 Thread David Herrmann
to me. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] drivers: hid: hid-wiimote-modules: fixed code style errors

2014-02-04 Thread David Herrmann
to add my Reviewed-by: David Herrmann dh.herrm...@gmail.com. Thanks David } ret = wiimote_cmd_write(wdata, 0xb00033, format, sizeof(format)); if (ret) -- 1.8.5.3 -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] Bluetooth: hidp: make sure input buffers are big enough

2014-02-03 Thread David Herrmann
Hi Jiri On Mon, Feb 3, 2014 at 11:08 AM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 29 Jan 2014, David Herrmann wrote: Due to various reasons I will not have access to any testing HW for the upcoming 2-3 days, so if you can cook something up in that timeframe, it'd be appreciated

Re: [PATCH 07/11] HID: HIDp: remove duplicated coded

2014-02-03 Thread David Herrmann
Hi On Mon, Feb 3, 2014 at 4:11 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Feb 3, 2014 at 10:02 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: - Move hidp_output_report() above

Re: [PATCH 03/11] HID: add inliners for ll_driver transport-layer callbacks

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Those callbacks are not mandatory, so it's better to add inliners to use them safely. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin Tissoires benjamin.tissoi

Re: [PATCH 02/11] HID: i2c-hid: implement ll_driver transport-layer callbacks

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Add output_report and raw_request to i2c-hid. Hopefully, we will manage to have the same transport level between all the transport drivers. Signed-off-by: Benjamin Tissoires

Re: [PATCH 08/11] HID: usbhid: remove duplicated code

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Well, no use to keep twice the same code. Yepp, I actually copied the code from that, so this is fine. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin Tissoires

Re: [PATCH 10/11] HID: introduce helper to access hid_output_raw_report()

2014-02-03 Thread David Herrmann
(/hid_output_raw_report(/g $i done Then manually fix for checkpatch.pl Looks all good. I guess you didn't use the hid_hw_* prefix as it's not a hdrv but hdev callback? But we hopefully can remove this soon, anyway. So: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin

Re: [PATCH 09/11] HID: remove hid_get_raw_report in struct hid_device

2014-02-03 Thread David Herrmann
hid_device. Finally we can remove that beast: Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers/hid/hid-input.c | 6 +++--- drivers/hid/hid-sony.c| 3 ++- drivers/hid/hidraw.c | 7

Re: [PATCH 0/6] HID: Add a stable method for retrieving the client MAC address of a HID device

2014-02-03 Thread David Herrmann
Hi On Sat, Feb 1, 2014 at 5:28 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Sat, Feb 1, 2014 at 11:06 AM, Frank Praznik frank.praz...@gmail.com wrote: On 1/31/2014 15:45, Benjamin Tissoires wrote: On Fri, Jan 31, 2014 at 3:04 PM, Frank Praznik frank.praz...@oh.rr.com

Re: [PATCH v2 3/6] HID: sony: Add Bluetooth output report formatting

2014-02-03 Thread David Herrmann
Hi On Thu, Jan 30, 2014 at 6:24 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Add formatting and reporting for Dualshock 4 output reports on Bluetooth. Signed-off-by: Frank Praznik frank.praz...@oh.rr.com --- drivers/hid/hid-sony.c | 29 +++-- 1 file changed, 23

Re: [PATCH v2 6/6] HID: sony: Add conditionals to enable all features in Bluetooth mode

2014-02-03 Thread David Herrmann
Hi On Thu, Jan 30, 2014 at 6:24 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Add the necessary conditionals to enable battery reporting, rumble, LED settings and touchpad parsing. Signed-off-by: Frank Praznik frank.praz...@oh.rr.com --- drivers/hid/hid-sony.c | 20 +---

Re: [PATCH 00/11] HID: spring cleaning

2014-02-03 Thread David Herrmann
Hi On Sun, Feb 2, 2014 at 5:50 AM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Hi guys, This is an attempt to complete the branch for-3.15/ll-driver-new-callbacks: - try to implement as much as possible ll_driver callbacks (some are still missing, but I did not had the time to

Re: [PATCH] HID: Add HID transport driver documentation

2014-02-03 Thread David Herrmann
Hi On Sat, Feb 1, 2014 at 12:18 AM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Wed, Jan 29, 2014 at 10:35 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Wed, Jan 29, 2014 at 4:28 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Add David Herrmann's documentation

Re: [PATCH] HID: Add HID transport driver documentation

2014-02-03 Thread David Herrmann
Hi On Mon, Feb 3, 2014 at 5:52 PM, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: [snip] + - void (*request) (struct hid_device *hdev, struct hid_report *report, +int reqtype) + Send an HID request on the ctrl channel. report contains the report that + should

Re: [PATCH 2/7] Input: xpad: set the LEDs properly on XBox Wireless controllers

2014-02-03 Thread David Herrmann
Hi On Fri, Jan 31, 2014 at 2:03 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: From: Pierre-Loup A. Griffais pgriff...@valvesoftware.com Add the logic to set the LEDs on XBox Wireless controllers. Command sequence found by sniffing the Windows data stream when plugging the device

Re: [PATCH 7/7] Input: xpad: properly name the LED class devices

2014-02-03 Thread David Herrmann
Hi On Fri, Jan 31, 2014 at 2:03 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: Don't just increment the LED device number, but use the joystick id so that you have a chance to associate the LED device to the correct xpad device by the name, instead of having to use the sysfs tree,

Re: [PATCH 0/6] HID: Add a stable method for retrieving the client MAC address of a HID device

2014-02-03 Thread David Herrmann
Hi On Mon, Feb 3, 2014 at 6:57 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Feb 03, 2014 at 06:45:52PM +0100, David Herrmann wrote: Hi Adding Dmitry+Jiri, maybe they can clarify this. [snip] Yes hidp sets it to point to the hci_conn struct from which src address

Re: [PATCH] Bluetooth: hidp: make sure input buffers are big enough

2014-01-29 Thread David Herrmann
Hi On Tue, Jan 28, 2014 at 9:53 PM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 7 Jan 2014, Jiri Kosina wrote: So doing kzalloc(rsize, GFP_ATOMIC) in the HID-core for now, and copying the buffer around, seems like only viable solution for now, with the outlook of removing this ugliness

Re: [PATCH] HID: Add HID transport driver documentation

2014-01-29 Thread David Herrmann
--author, but that's optional. Anyhow, patch is good, thanks for picking it up! Signed-off-by: David Herrmann dh.herrm...@gmail.com Putting Benjamin on CC as he reviewed the patch last time and might have some more comments (or his final reviewed-by). Thanks! David --- Sorry, I forgot

Re: [PATCH 7/7] HID: sony: Prevent devices from being connected twice

2014-01-29 Thread David Herrmann
Hi On Wed, Jan 29, 2014 at 6:33 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Prevent one controller from being connected twice and showing up as two devices if a USB cable is plugged into the controller when it is already connected via Bluetooth. A global list of connected devices is

Re: Can I limit the scope of an input device to specific processes ?

2014-01-28 Thread David Herrmann
Hi On Tue, Jan 28, 2014 at 11:20 AM, Dr. Zimmermann r.zimmerm...@uke.uni-hamburg.de wrote: Hi, we've got a special type of keyboard which should only be available in one specific process and not publicly, as usually keyboards are. Is it possible to limit the scope of a specific keyboard?

Re: [PATCH v4 1/2] input/uinput: replace breaks by goto out in uinput_ioctl_handler

2014-01-23 Thread David Herrmann
. No functional changes. Looks good. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David Signed-off-by: Benjamin Tisssoires benjamin.tissoi...@redhat.com --- changes since v3: - brand new patch :) drivers/input/misc/uinput.c | 56 ++--- 1

Re: [PATCH 0/4] HID: implement new transport-driver callbacks

2014-01-22 Thread David Herrmann
Hi On Wed, Jan 22, 2014 at 7:49 PM, Frank Praznik frank.praz...@oh.rr.com wrote: These patches are originally the work of David Herrmann who suggested that I update and submit them as their functionality is required for some pending patches to the hid-sony driver. These patches implement

Re: [PATCH v2] HID: sony: Cache the output report for the Dualshock 4

2014-01-18 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 8:46 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Retrieve and cache the output report for the Dualshock 4 in sony_probe() instead of repeatedly walking the report list in the worker function. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David

Re: [PATCH v3] input/uinput: add UI_GET_SYSNAME ioctl to retrieve the sysfs path

2014-01-18 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 8:12 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: Evemu [1] uses uinput to replay devices traces it has recorded. However, the way evemu uses uinput is slightly different from how uinput is supposed to be used. Evemu relies on libevdev, which creates

Re: [PATCH 2/4] HID: sony: Use standard output reports instead of raw reports to send data to the Dualshock 4.

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 3:42 AM, Frank Praznik frank.praz...@oh.rr.com wrote: Use regular HID output reports instead of raw reports in the dualshock4_state_worker function. (Thanks Simon Mungewell) This description is actually wrong. hid_output_raw_report() is used for regular HID output

Re: [PATCH 4/4] HID: sony: Map gyroscopes and accelerometers to axes

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 3:43 AM, Frank Praznik frank.praz...@oh.rr.com wrote: Use a modified HID descriptor for the Dualshock 4 to assign the gyroscope sensors and accelerometers to axes. Signed-off-by: Frank Praznik frank.praz...@oh.rr.com --- Apply against

Re: [PATCH 4/4] HID: sony: Map gyroscopes and accelerometers to axes

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 1:21 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 17 Jan 2014, Antonio Ospite wrote: Use a modified HID descriptor for the Dualshock 4 to assign the gyroscope sensors and accelerometers to axes. What about putting the descriptor fixup on hold for now? Jiri,

Re: Patch from down stream which has been forgotten

2014-01-17 Thread David Herrmann
Hi On Tue, Jan 7, 2014 at 2:56 PM, Jonathan Aquilina eagles051...@gmail.com wrote: I have a down stream bug from ubuntu which has been forgotten. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/967399 This fixes multitouch track pads issue where the track pad doesnt work at all. Can I

Re: [PATCH 2/4] HID: sony: Use standard output reports instead of raw reports to send data to the Dualshock 4.

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 6:10 PM, si...@mungewell.org wrote: Use regular HID output reports instead of raw reports in the dualshock4_state_worker function. (Thanks Simon Mungewell) This description is actually wrong. hid_output_raw_report() is used for regular HID output reports. What

Re: [PATCH] drivers/input/mouse/elantech elantech driver for Lenovo L530 trackpoint

2014-01-17 Thread David Herrmann
Hi According to Jonathan this patch is still not applied, would anyone care to resend it as proper git patch so we can review it and eventually apply it? Thanks David On Tue, Jul 30, 2013 at 11:44 PM, Ulrik De Bie ulrik_opensource-ker...@yahoo.com wrote: Hi, I've a new work laptop Lenovo

Re: [PATCH] HID: sony: Cache the output report for the Dualshock 4

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 5:42 PM, Frank Praznik frank.praz...@oh.rr.com wrote: Retrieve and cache the output report for the Dualshock 4 in sony_probe() instead of repeatedly walking the report list in the worker function. Signed-off-by: Frank Praznik frank.praz...@oh.rr.com --- Apply

Re: [PATCH 4/4] HID: sony: Map gyroscopes and accelerometers to axes

2014-01-17 Thread David Herrmann
Hi On Fri, Jan 17, 2014 at 6:19 PM, Frank Praznik frank.praz...@gmail.com wrote: On 1/17/2014 07:21, Jiri Kosina wrote: On Fri, 17 Jan 2014, Antonio Ospite wrote: Use a modified HID descriptor for the Dualshock 4 to assign the gyroscope sensors and accelerometers to axes. What about

Re: [PATCH] Input: gamepad - use independent axes for analog D-Pad buttons

2014-01-09 Thread David Herrmann
Hi Dmitry On Mon, Dec 30, 2013 at 7:50 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Dec 30, 2013 at 12:44:21PM +0100, David Herrmann wrote: Hi On Mon, Dec 30, 2013 at 12:20 PM, Antonio Ospite osp...@studenti.unina.it wrote: On Sun, 29 Dec 2013 16:52:09 -0800 Dmitry

Re: [PATCH] HID: input: fix input sysfs path for hid devices

2014-01-08 Thread David Herrmann
Hi Jiri On Fri, Dec 20, 2013 at 11:36 PM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 19 Dec 2013, David Herrmann wrote: benjamin.tissoi...@redhat.com wrote: we used to set the parent of the input device as the parent of the hid bus. This was introduced when we created hid as a real bus

Re: [PATCH] HID: input: fix input sysfs path for hid devices

2014-01-08 Thread David Herrmann
Hi On Wed, Jan 8, 2014 at 5:26 PM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 8 Jan 2014, David Herrmann wrote: I think this is valuable because it will give a better understanding of the actual mapping hardware/inputs. Like a touchscreen with pen + touch will have the same hid

Re: [PATCH] Bluetooth: hidp: make sure input buffers are big enough

2014-01-07 Thread David Herrmann
Hi Jiri On Tue, Jan 7, 2014 at 1:11 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 27 Dec 2013, David Herrmann wrote: I also haven't figured out a nice way to make HID-core honor the size parameter. hid-input depends on getting the whole input-report. I think this needs clearly fixing

Re: [PATCH] Input: twl6040_vibra - remove unneeded check for CONFIG_OF

2014-01-04 Thread David Herrmann
include/linux/of.h. So no need to depend on DT. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David -#endif - if (!twl6040_core_node) { dev_err(pdev-dev, parent of node is missing?\n); return -EINVAL; -- 1.8.4.2 -- Dmitry

Re: [PATCH] Input: gamepad - use independent axes for analog D-Pad buttons

2013-12-30 Thread David Herrmann
Hi On Mon, Dec 30, 2013 at 12:20 PM, Antonio Ospite osp...@studenti.unina.it wrote: On Sun, 29 Dec 2013 16:52:09 -0800 Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Antonio, On Mon, Dec 23, 2013 at 05:17:43PM +0100, Antonio Ospite wrote: Model this part of the API after the Sony

Re: [PATCH] Bluetooth: hidp: make sure input buffers are big enough

2013-12-27 Thread David Herrmann
-off-by: David Herrmann dh.herrm...@gmail.com --- Hi Any ideas how to improve this patch? I'd like to avoid the extra copy but I have no clue how the skb stuff works exactly. the buffers are coming straight from L2CAP. They might come in fragments. We have to reassemble them and while

Re: [PATCH] Input: gamepad - use independent axes for analog D-Pad buttons

2013-12-25 Thread David Herrmann
individually. Cc: David Herrmann dh.herrm...@gmail.com Signed-off-by: Antonio Ospite osp...@studenti.unina.it --- Hi, as David mentioned no gamepad defines analog D-Pad buttons as mentioned in the gamepad API, so the API change should be OK. And is it OK too to fill the holes in the ABS

Re: Xpad Driver Replacement

2013-12-19 Thread David Herrmann
Hi On Tue, Dec 10, 2013 at 4:27 AM, Zachary Lund ad...@computerquip.com wrote: On 12/08/13 00:18, Zachary Lund wrote: Secondly, the Xbox 360 controllers claim to be HID compliant... this is not an HID driver. That's because the report descriptor is missing and I, unfortunately, do not know

Re: Why does adding HID USB ID allow a keyboard to work?

2013-12-19 Thread David Herrmann
Hi On Sat, Dec 14, 2013 at 8:14 AM, Reyad Attiyat reyad.atti...@gmail.com wrote: I have a basic question about the way the linux kernel handles human input devices. I bought a Surface Pro 2 with a Type cover keyboard. This did not work out of the box with stock linux kernel 3.11. When I added

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-19 Thread David Herrmann
Hi On Mon, Dec 16, 2013 at 2:01 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 27 Sep 2013, Joseph Salisbury wrote: commit b1a1442a23776756b254b69786848a94d92445ba Author: Jiri Kosina jkos...@suse.cz Date: Mon Jun 3 11:27:48 2013 +0200 HID: core: fix reporting of raw events

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-19 Thread David Herrmann
Hi On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 19 Dec 2013, David Herrmann wrote: diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 253fe23..81eacd3 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1334,7 +1334,7

[PATCH] Bluetooth: hidp: make sure input buffers are big enough

2013-12-19 Thread David Herrmann
-core honor the @size argument, though, that sounds easier than it is. So lets just fix the buffer-overflows for now and afterwards look for a faster way for all transport drivers. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Hi Any ideas how to improve this patch? I'd like to avoid

Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup

2013-12-19 Thread David Herrmann
Hi On Thu, Dec 19, 2013 at 11:08 AM, David Herrmann dh.herrm...@gmail.com wrote: Hi On Thu, Dec 19, 2013 at 10:59 AM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 19 Dec 2013, David Herrmann wrote: diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 253fe23..81eacd3 100644

[PATCH] HID: hyperv: make sure input buffer is big enough

2013-12-19 Thread David Herrmann
We need at least HID_MAX_BUFFER_SIZE (4096) bytes as input buffer. HID core depends on this as it requires every input report to be at least as big as advertised. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Hi Same as for the HIDP patch, if there's a way to avoid the extra copy

Re: [PATCH] HID: input: fix input sysfs path for hid devices

2013-12-19 Thread David Herrmann
Hi On Thu, Dec 19, 2013 at 5:05 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: we used to set the parent of the input device as the parent of the hid bus. This was introduced when we created hid as a real bus, and to keep backward compatibility. Now, it's time to proper set the

Re: [PATCH 0/4] Input: ABS2 and friends

2013-12-18 Thread David Herrmann
Hi On Tue, Dec 17, 2013 at 10:28 PM, si...@mungewell.org wrote: Hi This implements the recently discussed ABS2 API. It's working fine on my machine with libevdev. Comments welcome! Just looking at the documentation file, I have a couple of suggestions. 1). Make a note on the direction of

Re: [PATCH 2/4] Input: introduce ABS_MAX2/CNT2 and friends

2013-12-18 Thread David Herrmann
Hi On Wed, Dec 18, 2013 at 3:27 PM, Antonio Ospite osp...@studenti.unina.it wrote: Hi David, thanks for the update. On Tue, 17 Dec 2013 16:48:52 +0100 David Herrmann dh.herrm...@gmail.com wrote: As we painfully noticed during the 3.12 merge-window our EVIOCGABS/EVIOCSABS API is limited

[PATCH 0/4] Input: ABS2 and friends

2013-12-17 Thread David Herrmann
values in the new range Note that I have patches pending which make use of the new ABS values, but I'd like to get this reduced series in first. Thanks David David Herrmann (4): Input: uinput: add full absinfo support Input: introduce ABS_MAX2/CNT2 and friends Input: remove ambigious gamepad

[PATCH 3/4] Input: remove ambigious gamepad comment

2013-12-17 Thread David Herrmann
it is reported. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Documentation/input/gamepad.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/input/gamepad.txt b/Documentation/input/gamepad.txt index 31bb6a4..196dc42 100644 --- a/Documentation/input/gamepad.txt +++ b

[PATCH 2/4] Input: introduce ABS_MAX2/CNT2 and friends

2013-12-17 Thread David Herrmann
. Note that we also need to increase EV_VERSION so user-space can reliably know whether ABS2 is supported. Unfortunately, we return EINVAL instead of ENOSYS for unknown evdev ioctls so it's nearly impossible to catch reliably without EVIOCGVERSION. Signed-off-by: David Herrmann dh.herrm

[PATCH 1/4] Input: uinput: add full absinfo support

2013-12-17 Thread David Herrmann
size from the user-space given size. Thus, we need the version field to allow changing the object and properly detecting it in our write() handler. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/input/misc/uinput.c | 142 include

Re: [PATCH 0/4] Input: ABS2 and friends

2013-12-17 Thread David Herrmann
Hi On Tue, Dec 17, 2013 at 4:48 PM, David Herrmann dh.herrm...@gmail.com wrote: Hi This implements the recently discussed ABS2 API. It's working fine on my machine with libevdev. Comments welcome! * Patch #1 fixes some uinput shortcomings and prepares uinput for ABS2 * Patch #2 adds ABS2

[PATCH] Input: add short note about ABS_MISC+n axes

2013-12-16 Thread David Herrmann
We must not reassign those axes or we will break backwards-compat. Add a small note for that so we don't accidentally some day reuse these. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- include/uapi/linux/input.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi

Re: Sony DualShock4 - basic functions work, but looking to improve support

2013-12-09 Thread David Herrmann
Hi On Mon, Dec 9, 2013 at 1:51 AM, si...@mungewell.org wrote: Following a very useful post on Reddit: http://np.reddit.com/r/PS4/comments/1p9y0l/pairing_your_ds4_controller_via_bluetooth/ I was able to put the DS4 into discoverable mode, pair and connect using the 'hidd --connect

Re: Xpad Driver Replacement

2013-12-08 Thread David Herrmann
Hi On Sun, Dec 8, 2013 at 7:18 AM, Zachary Lund ad...@computerquip.com wrote: I created a new driver to hopefully eventually replace xpad. The driver in its current form can be found on github. Things it provides is cleaner module unload/load, possibly cleaner/more efficient code, and better

Re: Sony DualShock4 - basic functions work, but looking to improve support

2013-12-08 Thread David Herrmann
Hi On Sat, Dec 7, 2013 at 9:43 PM, si...@mungewell.org wrote: Anyone here want to collaborate? I've decoded the majority of the HID stream including the multi-touch. Nice! I already got my hands on one but will probably not find time for it until February. However, I will gladly test any

Re: [PATCH] uhid: Pad short UHID_CREATE writes from compat tasks

2013-11-26 Thread David Herrmann
Hi On Tue, Nov 26, 2013 at 8:02 AM, Ben Hutchings b...@decadent.org.uk wrote: Short event writes are normally padded with zeroes, but the compat fixup for UHID_CREATE didn't ensure this. This appears to allow an information leak. Compile-tested only. Fixes: befde0226a59 ('HID: uhid: make

[PATCH v2] HID: uhid: fix leak for 64/32 UHID_CREATE

2013-11-26 Thread David Herrmann
b...@decadent.org.uk Signed-off-by: David Herrmann dh.herrm...@gmail.com Cc: sta...@vger.kernel.org --- drivers/hid/uhid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 93b00d7..cedc6da 100644 --- a/drivers/hid/uhid.c +++ b/drivers

Re: conflict of wiimote and hid-sony

2013-11-17 Thread David Herrmann
86b84167d4e67372376a57ea9955c5d53dae232f Author: David Herrmann dh.herrm...@gmail.com Date: Fri Oct 18 16:26:22 2013 +0200 HID: wiimote: add LEGO-wiimote VID I will write a bluez-patch to force the official wiimote-id on the device, based on a name-comparison. This should allow us to support both devices. Thanks

Re: [PATCH 04/13] Input: add motion-tracking ABS_* bits and docs

2013-11-16 Thread David Herrmann
Hi On Sat, Nov 16, 2013 at 6:53 PM, Antonio Ospite osp...@studenti.unina.it wrote: On Fri, 15 Nov 2013 11:17:31 +0100 David Herrmann dh.herrm...@gmail.com wrote: Hi Antonio On Fri, Nov 15, 2013 at 11:11 AM, Antonio Ospite osp...@studenti.unina.it wrote: On Fri, 1 Nov 2013 21:16:15 +0100

Re: [PATCH 04/13] Input: add motion-tracking ABS_* bits and docs

2013-11-15 Thread David Herrmann
Hi Antonio On Fri, Nov 15, 2013 at 11:11 AM, Antonio Ospite osp...@studenti.unina.it wrote: On Fri, 1 Nov 2013 21:16:15 +0100 David Herrmann dh.herrm...@gmail.com wrote: Motion sensors are getting quite common in mobile devices. To avoid returning accelerometer data via ABS_X/Y/Z

Re: [PATCH v3] add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)

2013-11-10 Thread David Herrmann
= iface_desc-endpoint[4].desc; Don't you have to test whether iface_desc-desc-bNumEndpoints is 4? Or does usb allocate enough endpoint descriptors, anyway? Other than that, the driver looks really good. Reviewed-by: David Herrmann dh.herrm...@gmail.com Thanks David + if (endpoint-bEndpointAddress

Re: My enable bluetooth hotkey increase brightness instead

2013-11-10 Thread David Herrmann
Hi On Thu, Nov 7, 2013 at 11:15 PM, Gianfranco Costamagna costamagnagianfra...@yahoo.it wrote: - Messaggio originale - Da: David Herrmann dh.herrm...@gmail.com A: Gianfranco Costamagna costamagnagianfra...@yahoo.it Cc: linux-input@vger.kernel.org linux-input@vger.kernel.org Inviato

Re: My enable bluetooth hotkey increase brightness instead

2013-11-07 Thread David Herrmann
Hi On Tue, Oct 29, 2013 at 9:52 AM, Gianfranco Costamagna costamagnagianfra...@yahoo.it wrote: Hi linux-input developers, I write here since suggested on my launchpad bug. The problem is really simple, I have an acer aspire 6930G and when I press enable bluetooth on my keyboard I get the

Re: [PATCH 02/13] Input: introduce ABS_MAX2/CNT2 and friends

2013-11-05 Thread David Herrmann
Hi On Fri, Nov 1, 2013 at 9:16 PM, David Herrmann dh.herrm...@gmail.com wrote: As we painfully noticed during the 3.12 merge-window our EVIOCGABS/EVIOCSABS API is limited to ABS_MAX=0x3f. We tried several hacks to work around it but if we ever decide to increase ABS_MAX, the EVIOCSABS ioctl

[PATCH 07/13] HID: wiimote: map nunchuk as real gamepad

2013-11-01 Thread David Herrmann
The nunchuk device can easily be used as reduced gamepad. Add a new mapping according to linux gamepad rules. Note that we map it as gamepad with: - one analog-stick (left) - two trigger buttons (left upper+lower) - accelerometer Signed-off-by: David Herrmann dh.herrm...@gmail.com

[PATCH 04/13] Input: add motion-tracking ABS_* bits and docs

2013-11-01 Thread David Herrmann
, ABS_X/Y are already used by analog sticks, so need separate definitions, anyway. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Documentation/input/gamepad.txt | 7 ++ Documentation/input/motion-tracking.txt | 149 include/linux/mod_devicetable.h

[PATCH 13/13] HID: wiimote: add support for Guitar-Hero guitars

2013-11-01 Thread David Herrmann
will try to report them via the same interface so user-space does not have to bother which device it deals with. Signed-off-by: Nicolas.Adenis-Lamarre nicolas.adenis.lama...@gmail.com (add commit-msg and adjust to new BTN_* IDs) Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/hid/hid

[PATCH 01/13] Input: uinput: add full absinfo support

2013-11-01 Thread David Herrmann
size from the user-space given size. Thus, we need the version field to allow changing the object and properly detecting it in our write() handler. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- drivers/input/misc/uinput.c | 142 include

[PATCH 03/13] Input: remove ambigious gamepad comment

2013-11-01 Thread David Herrmann
it is reported. Signed-off-by: David Herrmann dh.herrm...@gmail.com --- Documentation/input/gamepad.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/input/gamepad.txt b/Documentation/input/gamepad.txt index 8002c89..c40b109 100644 --- a/Documentation/input/gamepad.txt +++ b

<    1   2   3   4   >