Re: [PATCH] HID: hid-input: fix double-free in cleanup_battery

2015-08-12 Thread Jiri Kosina
will handle freeing the power_supply object for us. Please see commit 0621809e37 (HID: hid-input: Fix accessing freed memory during device disconnect) in Linus' tree. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: wacom: Report correct device resolution when using the wireless adapater

2015-08-10 Thread Jiri Kosina
. Thanks for elaborting on this, Jason. I will be looking into this a little bit more, but am applying to for-4.2/upstream-fixes-devm-fixed in any case (my current plan is to send this to Linus this week due to devm memory corruption fix, and let this patch piggy-back on it). -- Jiri Kosina SUSE

Re: [PATCH] HID: wacom: Simplify 'wacom_pl_irq'

2015-08-10 Thread Jiri Kosina
Nice cleanup. Applied to for-4.3/wacom. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: wacom: Do not repeatedly attempt to set device mode on error

2015-08-10 Thread Jiri Kosina
was returned or repeated attempts at recovering from a soft error all failed. In either case, doing even more retries is not likely to resolve whatever is wrong. Signed-off-by: Jason Gerecke jason.gere...@wacom.com Applied to for-4.3/upstream. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] HID: wacom: Report correct device resolution when using the wireless adapater

2015-08-10 Thread Jiri Kosina
-y_phy, - features-unit, - features-unitExpo); -} - static size_t wacom_compute_pktlen(struct hid_device *hdev) { struct hid_report_enum *report_enum; -- 2.5.0 -- Jiri Kosina

Re: [PATCH 1/3] HID: wacom: Use calculated pkglen for wireless touch interface

2015-08-04 Thread Jiri Kosina
, removing the need for us to set it manually here. Signed-off-by: Jason Gerecke jason.gere...@wacom.com I have applied the series to for-4.3/wacom. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during device disconnect

2015-08-04 Thread Jiri Kosina
mistake. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-08-01 Thread Jiri Kosina
send me properly formatted patch with the above, on top of your previous fix? Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] HID: hid-sony: Fix DS4 controller reporting rate issues

2015-07-31 Thread Jiri Kosina
so that's what ended up being used. Now that we know what it actually does and that 0x80 is a better choice I support this patch. Acked-by: Frank Praznik frank.praz...@gmail.com Thanks. Applied to for-4.3/sony. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: hid-sony: Fix DS4 controller reporting rate issues

2015-07-29 Thread Jiri Kosina
formatting). Adding him to CC to double-check. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] HID: uclogic: fix limit in uclogic_tablet_enable()

2015-07-29 Thread Jiri Kosina
(cpu_to_le32(v), (s32 *)p); p += 4; Argh, that's embarrassing. Thanks, Dan! Good catch Dan, thanks. Applied to for-4.2/upstream-fixes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-07-29 Thread Jiri Kosina
...@samsung.com Reported-by: H.J. Lu hjl.to...@gmail.com Fixes: 297d716f6260 (power_supply: Change ownership from driver to core) Cc: sta...@vger.kernel.org Applied to for-4.2/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: hid-lg: Add USBID for Logitech G29 Wheel

2015-07-29 Thread Jiri Kosina
. Note: There is probably more work required for adjust HID descriptor and handle switching between emulation and native modes. Signed-off-by: Simon Wood si...@mungewell.org I have applied this to for-4.3/logitech (and kept the Note: above in the changelog). -- Jiri Kosina SUSE Labs

Re: [PATCH acer-switch12-keyboard] hid core: Enable support for Fn+ controls keys on Acer Aspire Switch 12 keyboard

2015-07-29 Thread Jiri Kosina
?id=101721 Signed-off-by: Nicholas Kudriavtsev nkudriavt...@gmail.com --- Tested on git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git and it works Applied to for-4.3/chicony (with updates subject so that it makes the usual format used for HID patches). -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: microsoft: Add Surface 3 type cover

2015-07-24 Thread Jiri Kosina
constant and matching code for the Surface 3. Signed-off-by: Stephen Just stephenj...@gmail.com Applied to for-4.3/microsoft branch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] HID:multitouch:add driver for CJTouch MultiTouch

2015-07-24 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: sony: Drop invalid Sixaxis input reports

2015-07-24 Thread Jiri Kosina
+ * events. + */ + if (rd[1] == 0xff) + return -EINVAL; + Given that this is not a regression and given the current development phase, I've applied it to for-4.3/sony. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH 2/3] HID: apple: Add support for the 2015 Macbook Pro

2015-07-24 Thread Jiri Kosina
...@bitmath.org Jiri, do you think I can take all three in through my tree? I think it might be worthwhile to get the changes in 4.2 still. Absolutely. Acked-by: Jiri Kosina jkos...@suse.com for this one. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] HID: wacom: Perform all event processing as part of report processing

2015-07-23 Thread Jiri Kosina
series is now in for-4.3/wacom. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
from the host). Could you please provide contents of /sys/kernel/debug/hid/device/rdesc -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
tolerant to those in the long term. From: Jiri Kosina jkos...@suse.com Subject: [PATCH] Input: leds: don't attempt to deregister unnamed LEDs input_leds_connect() is skipping registration of LEDs for which there is no symbolic name in input_led_info[]. The way how usages are mapped

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Thu, 23 Jul 2015, Vlastimil Babka wrote: On 07/22/2015 08:55 PM, Jiri Kosina wrote: On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ ... snip ... ] The mouse has 3 green leds and one red to indicate battery status, but I think they operate autonomously. It's possible

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
keyboard happens to have 2 usages for caps... Indeed, makes sense generally for all LEDs I think. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Wed, 22 Jul 2015, Pavel Machek wrote: I am however not sure whether input_leds_connect() is not too unkind to unnamed LEDs and shouldn't be more tolerant to those in the long term. Maybe. From: Jiri Kosina jkos...@suse.com Subject: [PATCH] Input: leds: don't attempt to deregister

[PATCH] Input: synaptics: dump ext10 capabilities as well

2015-07-21 Thread Jiri Kosina
Make extended capabilities obtained through $10 query also available in touchpad identification. Signed-off-by: Jiri Kosina jkos...@suse.com --- drivers/input/mouse/synaptics.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers

Re: [PATCH RESENT] Input: elan_i2c - enable ELAN0600 acpi panels

2015-07-20 Thread Jiri Kosina
benjamin.tissoi...@redhat.com Acked-by: Jiri Kosina jkos...@suse.com -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] HID: wacom: Properly free inputs if 'wacom_allocate_inputs' fails

2015-07-17 Thread Jiri Kosina
instead if you would like. The conflict is due to his patch modifying the 'wacom_free_inputs' function; this patch removes the function entirely though so the conflict shouldn't be too difficult to resolve. I resolved this and applied to for-4.3/wacom. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: rmi: Set F01 interrupt enable register when not set

2015-07-17 Thread Jiri Kosina
for the cleared F01 control register and writes the correct value based on interrupt mask computed while scanning the PDT. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91102 Signed-off-by: Andrew Duggan adug...@synaptics.com Applied to for-4.3/rmi. -- Jiri Kosina SUSE Labs -- To unsubscribe

Re: [PATCH v2] HID: cp2112: fix I2C_SMBUS_BYTE write

2015-07-14 Thread Jiri Kosina
use of some other transport). If you want to move it under your wings, please send a patch that moves it and I'll Ack it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2] HID: wacom: remove the extra Pen interface for Wacom Bamboo PAD

2015-07-13 Thread Jiri Kosina
benjamin.tissoi...@redhat.com Applied to for-4.3/wacom. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1] HID: cp2112: fix byte order in SMBUS operations

2015-07-13 Thread Jiri Kosina
terminally broken since the very beginning and noone noticed. Does this mean that those commands are in practice mostly unused anyway? This is important for 4.2 vs 4.3 consideration. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: hid-sony: Navigator Axis for L1 button

2015-07-13 Thread Jiri Kosina
On Fri, 10 Jul 2015, Simon Wood wrote: Patch HID report descriptor to add joystick axis for the L1 button (previously missing). Signed-off-by: Simon Wood si...@mungewell.org Applied to for-4.3/sony. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2] HID: rmi: Write updated F11 control registers after reset

2015-07-13 Thread Jiri Kosina
Tested-by: (please speak up if it doesn't hold for v2). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1] HID: cp2112: fix I2C_SMBUS_BYTE write

2015-07-13 Thread Jiri Kosina
On Thu, 9 Jul 2015, Ellen Wang wrote: When doing an I2C_SMBUS_BYTE write (one byte write, no address), the data to be written is in command not data-byte. This is missing Signoff. How serious is this bug in practice? Is this 4.2 material? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe

Re: [PATCH v2] HID: cp2112: support i2c write-read transfers in hid-cp2112

2015-07-10 Thread Jiri Kosina
). Since the device doesn't support i2c repeated starts in general, but does support a single write-repeated-start-read pair (since hardware rev 1), we recognize the latter case and implement only that. Signed-off-by: Ellen Wang el...@cumulusnetworks.com Applied to for-4.3/cp2112. Thanks, -- Jiri

Re: [PATCH v1] HID: cp2112: support i2c write-read transfers in hid-cp2112

2015-07-09 Thread Jiri Kosina
/ Well, it actually conflicts with it :) The conflict is easy to resolve, but as you might be sending v2 anyway, please rebase it on top of for-4.3/cp2112 when doing so. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: rmi: Disable scanning if the device is not a wake source

2015-07-09 Thread Jiri Kosina
that scanning is disabled if the touchpad is not a wake source and ensures scanning is enabled on resume. Signed-off-by: Andrew Duggan adug...@synaptics.com Applied to for-4.3/rmi. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH v3] HID: cp2112: support large i2c transfers in hid-cp2112

2015-07-09 Thread Jiri Kosina
is fixed). So please send any potential updates as followups on top of this patch. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call gpiod_put

2015-07-09 Thread Jiri Kosina
triggering in case of !ihid-desc. Adding Benjamin. I am not applying this without his Ack. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2] HID: Wacom: Delete unnecessary checks before the function call input_free_device

2015-07-09 Thread Jiri Kosina
was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net This is really on a is it worth it? borderline, but anyway ... applied to for-4.3/upstream. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v1] HID: cp2112: support i2c write-read transfers in hid-cp2112

2015-07-08 Thread Jiri Kosina
, is there any result of your testing? I have put this patch on hold waiting for your word on it, but it has been ~3 weeks already. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] HID: wacom: Enable pad device for older Bamboo Touch tablets

2015-07-08 Thread Jiri Kosina
to send pad events. This patch adds the flag to resolve these issues. Signed-off-by: Jason Gerecke jason.gere...@wacom.com Applied to for-4.2/upstream-fixes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-08 Thread Jiri Kosina
-by: Ellen Wang el...@cumulusnetworks.com ? Thanks, Yes. Thank you. Ammended with Cc: stable tag, and applied to for-4.2/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-08 Thread Jiri Kosina
since device drivers might try to perform operations needing them. Fix this by disabling IRQs only after the suspend callbacks had been executed. That's much nicer changelog, thanks. I've now applied the patch with this changelog to for-4.3/i2c-hid. -- Jiri Kosina SUSE Labs -- To unsubscribe

Re: [PATCH] HID: cp2112: fix to force single data-report reply

2015-07-08 Thread Jiri Kosina
el...@cumulusnetworks.com ? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-07 Thread Jiri Kosina
is disabled too early (i.e. what bug is this exactly fixing). Signed-off-by: Gabriele Mazzotta gabriele@gmail.com I'd see this as a 4.2 material still. Please let me know if you'd rather want to wait for 4.3. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: Re: [PATCH] HID:multitouch:add driver fo CJTouch MultiTouch

2015-07-06 Thread Jiri Kosina
On Sat, 4 Jul 2015, linuxsea wrote: Use real names this is : From: Yang Bo linux...@163.com Signed-off-by: Yang Bo linux...@163.com Please resubmit the whole patch with your real name updated. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] HID:multitouch:add driver fo CJTouch MultiTouch

2015-06-30 Thread Jiri Kosina
On Mon, 29 Jun 2015, linux...@163.com wrote: From: linuxsea linux...@163.com Signed-off-by:linuxsealinux...@163.com Please use your real name for authorship and signoffs. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-29 Thread Jiri Kosina
kernel can do about. I am not saying it doesn't bring the LEDs up to a proper state again once auto-resumed. But I hate the LEDs going off a few seconds after I stop typing (i.e. once the keyboard gets auto-suspended). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-29 Thread Jiri Kosina
-suspended). That is the point. Unless you give the option to override, they shouldn't autosuspend. Ah, you're right, I completely forgot about the logic we've put into hidinput_count_leds() quite some time ago. Sorry for the noise, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH] HID: wacom: remove the extra Pen interface for Wacom Bamboo PAD

2015-06-29 Thread Jiri Kosina
a lot. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID-picoLCD: Deletion of unnecessary checks before three function calls

2015-06-29 Thread Jiri Kosina
long time ago). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] HID: microsoft: Add quirk for MS Surface Type/Touch cover

2015-06-29 Thread Jiri Kosina
Applied to for-4.2/upstream-fixes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices

2015-06-27 Thread Jiri Kosina
this any more, I am afraid we'll have to move the default into the kernel. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] HID: wacom: NULL dereferences on error in probe()

2015-06-26 Thread Jiri Kosina
, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] HID: hid-sony: Add BT support for Navigation Controller

2015-06-18 Thread Jiri Kosina
Simon, I've queued the series in for-4.2/sony(and please be a little bit more verbose in your changelogs next time :) even for such easy stuff). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 1/1 linux-next] HID: use swap() in cp_report_fixup()

2015-06-18 Thread Jiri Kosina
]; - rdesc[i + 1] = tmp; + swap(rdesc[i + 3], rdesc[i + 1]); } return rdesc; } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] HID: roccat: Removing all modules except Kone

2015-06-18 Thread Jiri Kosina
functionality has been moved to userspace using hidraw. 7 months means 2 or 3 major kernel releases, and no depreciation process has happened. Could you please work on more user-friendly depreciation plan for these drivers? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] input: adding Surface Power Cover

2015-06-18 Thread Jiri Kosina
been damaged by your e-mail client. Please fix your workflow and resend. Thanks, -- Jiri Kosina SUSE Labs Damn, missed that, sorry. Signed-off-by Raimund Roth raimundmr...@gmail.com Applied to for-4.2/upstream. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH] HID: rmi: Disable populating F30 when the touchpad has physical buttons

2015-06-16 Thread Jiri Kosina
Hi Andrew, Benjamin, applied to for-4.2/rmi. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] HID: hid-sony: Add quirk for MOTION_CONTROLLER_BT

2015-06-12 Thread Jiri Kosina
On Tue, 9 Jun 2015, Simon Wood wrote: Split quirk for PS Move Controller as it has to be treated differently when connected via BT. I have applied the series. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [RESEND PATCH v2 1/2] HID: hid-plantronics: Update to map volume up/down controls

2015-06-12 Thread Jiri Kosina
devices. Signed-off-by: Terry Junge terry.ju...@plantronics.com Applied to for-4.2/plantronics. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 0/5] HID: wacom: Support tablets with pen and touch on same interface

2015-06-08 Thread Jiri Kosina
refresh. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input: adding Surface Power Cover

2015-06-08 Thread Jiri Kosina
by your e-mail client. Please fix your workflow and resend. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-sony: Support PS3 Move Controller when connected via Bluetooth

2015-06-04 Thread Jiri Kosina
Applied to for-4.2/sony. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: i2c-hid: Do not set the ACPI companion field in the HID device

2015-06-03 Thread Jiri Kosina
the companion ACPI device's wakeup flags to set the device as wake capable. Which results in power/wakeup files in sysfs for the HID device which do not do anything. Signed-off-by: Andrew Duggan adug...@synaptics.com Applied to for-4.2/i2c-hid. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH 2/2] Add driver for mouse logitech M560

2015-06-01 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-06-01 Thread Jiri Kosina
/labq2/ and the LoggerPro for Linux software shown at http://www.vernier.com/downloads/logger-pro-linux/. Signed-off-by: Dennis O'Brien dennis.obr...@eqware.net Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org Applied to hid.git#for-4.2/upstream. Thanks, -- Jiri Kosina SUSE Labs

Re: [hid:for-next 63/64] drivers/hid/hid-logitech-hidpp.c:1504:46: error: 'HIDPP_QUIRK_MULTI_INPUT' undeclared here (not in a function)

2015-06-01 Thread Jiri Kosina
, HID_GROUP_LOGITECH_DJ_DEVICE, :: The code at line 1504 was first introduced by commit :: 3a61e97563d78a2ca10752902449570d8433ce76 HID: logitech-hidpp: support combo keyboard touchpad TK820 :: TO: Benjamin Tissoires benjamin.tissoi...@redhat.com :: CC: Jiri Kosina jkos...@suse.cz Thanks

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-29 Thread Jiri Kosina
On Thu, 28 May 2015, Greg KH wrote: On Thu, May 28, 2015 at 04:58:54PM +0200, Jiri Kosina wrote: On Thu, 21 May 2015, Dennis O'Brien wrote: From: Dennis O'Brien dennis.obr...@eqware.net Removes Vernier Software Technology devices from the ldusb driver and the hid_ignore_list

Re: [PATCH] Add driver for mouse logitech M560

2015-05-29 Thread Jiri Kosina
), + .driver_data = HIDPP_QUIRK_DELAYED_INIT | HIDPP_QUIRK_CLASS_M560 }, Seems like you forgot to add the device id to hid_have_special_driver[]? Otherwise it looks good. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH v1] HID: support multiple and large i2c transfers in hid-cp2112

2015-05-29 Thread Jiri Kosina
as CP2112_DATA_WRITE_READ_REQUEST. Signed-off-by: Ellen Wang el...@cumulusnetworks.com David, could you please provide your Reviewed-by: / Acked-by: for this patch? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] Add driver for mouse logitech M560

2015-05-29 Thread Jiri Kosina
}, Seems like you forgot to add the device id to hid_have_special_driver[]? nope, the device is tagged with HID_GROUP_LOGITECH_DJ_DEVICE, so hid-generic ignores it by default. Gah, I keep forgetting about HID_GROUP_LOGITECH_DJ_DEVICE again and again. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: lenovo: Remove sysfs group on failure path

2015-05-29 Thread Jiri Kosina
On Fri, 29 May 2015, Alexey Khoroshilov wrote: There is no sysfs_group_remove() on failure path in lenovo_probe_tpkbd(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru Applied to for-4.2/upstream. Thanks, -- Jiri

Re: [PATCH 0/3] HID: hid-input: Simplify expression and suppress gcc warning

2015-05-28 Thread Jiri Kosina
On Wed, 27 May 2015, James C Boyd wrote: This patch set simplifies and formats an expression as well as suppress a gcc warning. Applied to for-4.2/upstream. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

RE: [PATCH v2 1/2] HID: hid-plantronics: Update to map volume up/down controls

2015-05-28 Thread Jiri Kosina
to have been converted to spaces. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: Remove Vernier devices from lsusb and hid_ignore_list

2015-05-28 Thread Jiri Kosina
it himself through his tree). Greg ... ? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] HID: hid-plantronics: Update to map volume up/down controls

2015-05-25 Thread Jiri Kosina
The patch is whitespace-damaged and can't really be applied. Could you please fix your mail setup and resubmit? Thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] HID: usbhid: add Chicony/Pixart usb optical mouse that needs QUIRK_ALWAYS_POLL

2015-05-25 Thread Jiri Kosina
(with Benjamin's nit taken into account). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] HID: hid-plantronics: Update Kconfig HID_PLANTRONICS default setting

2015-05-25 Thread Jiri Kosina
on system with the particular device connected. Therefore it's expected that the kernel will have support for that device built-in. We're not putting 'default y' in kernel for non-core drivers. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH v2 1/2] HID: wacom: Have wacom_{get,set}_report retry on -EAGAIN, not -EPIPE

2015-05-21 Thread Jiri Kosina
...@wacom.com I have applied the series to for-4.2/wacom. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] hid:Change vendor id for USB_DEVICE_ID_MS_TYPE_COVER_3 to correct id in hid-ids.h

2015-05-20 Thread Jiri Kosina
or reason why we don't want both (i.e. how come that 0x07dc was initially submitted and all of a sudden it's not needed). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

2015-05-20 Thread Jiri Kosina
, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS }, { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS }, -- 2.1.4 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: usbhid: Add HID_QUIRK_NOGET for Aten DVI KVM switch

2015-05-13 Thread Jiri Kosina
received Add it. Signed-off-by: Laura Abbott labb...@fedoraproject.org Applied for for-4.1/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

RE: [PATCH] HID: hid-plantronics: Update to map volume up/down controls

2015-05-11 Thread Jiri Kosina
non-USB transport, then this is a viable option (not nice, but I can understand the reasons for that) - fall back to PID-based device identification Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: hid-sensor-hub: Fix debug lock warning

2015-05-07 Thread Jiri Kosina
; int end_collection_index; struct mutex mutex; + struct mutex *mutex_ptr; This is quite ugly, isn't it? Is there any reason why you can't just have a pointer in the struct, and allocate the mutex dynamically at the same time you are allocating the struct? -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: lenovo: add support for Lenovo ThinkPad Keyboard Pro unit

2015-05-04 Thread Jiri Kosina
wouldn't be overly careful about the macro names, they are really just for basic orientation ... there have even been people suggesting we just completely drop it, and use just numeric constants directly. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH v3] HID: wacom: retrieve name from HID descriptor for generic devices

2015-04-27 Thread Jiri Kosina
killert...@gmail.com Applied to for-4.2/wacom. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH,v2] usbhid: Add a quirk for raphnet multi-gamepad adapters

2015-04-27 Thread Jiri Kosina
device. With this patch each controller gets its own /dev/input/jsX device, which is more natural and less confusing than having all inputs going to the same place. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH v1] HID: bug fixes in hid-cp2112 driver

2015-04-23 Thread Jiri Kosina
On Thu, 23 Apr 2015, Ellen Wang wrote: I've separated out the cp2112_i2c_xfer() bug fix from the patch. Should I submit it as v2 or a new patch altogether? Please submit this as a completely new series, obsoleting the previous patch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH 2/4] HID: wacom: move all quirks to wacom_setup_device_quirks

2015-04-23 Thread Jiri Kosina
On Thu, 16 Apr 2015, Jason Gerecke wrote: On 4/15/2015 4:53 PM, Ping Cheng wrote: It makes probe routine easy to follow. Signed-off-by: Ping Cheng pi...@wacom.com For patches 2-4, Reviewed-by: Jason Gerecke jason.gere...@wacom.com 2-4 applied to for-4.2/wacom. -- Jiri Kosina SUSE

Re: [PATCH] HID: i2c-hid: Do not fail probing if gpiolib is not enabled

2015-04-23 Thread Jiri Kosina
...@linux.intel.com I have applied this to for-4.1/upstream-fixes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: wacom - Add support for DTU-1141

2015-04-23 Thread Jiri Kosina
) }, { USB_DEVICE_WACOM(0x335) }, + { USB_DEVICE_WACOM(0x336) }, { USB_DEVICE_WACOM(0x4001) }, { USB_DEVICE_WACOM(0x4004) }, { USB_DEVICE_WACOM(0x5000) }, Applied to for-4.2/wacom. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH] HID: hid-plantronics: Update to map volume up/down controls

2015-04-23 Thread Jiri Kosina
, as you as now using USB-isms in the driver, you have to make it dependent on USB availability. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] HID: wacom: Simplify check for presence of single-finger touch

2015-04-23 Thread Jiri Kosina
to for-4.2/wacom. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] Input: set INPUT_PROP_POINTING_STICK in hid-lenovo

2015-04-23 Thread Jiri Kosina
andreasfl...@gmail.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Cc: Jiri Kosina jkos...@suse.cz Andreas, your patch has been severely damaged by your mail client. I have fixed everything by hand for now and applied the patch to for-4.2/lenovo branch, but please fix your

Re: [PATCH v4 0/2] HID: HID Sensor: Custom and Generic sensor support

2015-04-10 Thread Jiri Kosina
of changes Srinivas did compared to v3. Please let me know if you have objections to that. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 00/15] HID: hid-lg, hid-lg4ff: Mostly cleanup patches

2015-04-10 Thread Jiri Kosina
on my radar, but due to its nature and due to the merge window coming, I'll treat it as 4.2 material (IOW, please don't expect my response to this before 4.1-rc1 is released). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

[PATCH] HID: debug: fix error handling in hid_debug_events_read()

2015-04-09 Thread Jiri Kosina
make sense in case hdev doesn't exist any more anyway. Reported-by: Jiri Slaby jsl...@suse.cz Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 8bf61d2

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-07 Thread Jiri Kosina
dmitry.torok...@gmail.com Perfect, thanks. I have now queued it in for-4.1/upstream. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   6   7   8   9   10   >