-by: Andrew Duggan adug...@synaptics.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Here is the v3 version with Benjamin's comments addressed. I also updated it
to
apply to the version of hid-core.c in for-3.19/hid-rmi.
Applied to for-3.20/rmi. Thanks,
--
Jiri Kosina
SUSE
] [8165f107] ? int_signal+0x12/0x17
[ 79.694095] [8165ee69] ? system_call_fastpath+0x12/0x17
Fix this so that we only free buffers when the i2c-hid driver itself is
removed.
Applied to for-3.19/upstream-fixes, thanks for fixing it.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list
be used other than Logitech.
But we can add that later.
Applied to for-3.20/logitech, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Nicoletti dantt...@gmail.com
Sorry for this taking too long. Now applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
returns
an int, but over time non-negative values are ignored by
hid_input_report. This happened in the following change:
--
commit b1a1442a23776756b254b69786848a94d92445ba
Author: Jiri Kosina jkos...@suse.cz
Date: Mon Jun 3 11:27:48 2013 +0200
}: check report length
v2: splitted original report length check patch
Applied to for-3.19/upstream-fixes.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
length
v2: splitted original report length check patch
Applied to for-3.19/upstream-fixes.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
v2: splitted original report length check patch. Restructured code.
v3: renamed var r to ret for consistency, added R-b of Benjamin
Applied to for-3.20/logitech.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
it's doing
covered by HID specification (at least in a does it have HID descriptor
sense)? It's not really completely clear to me at this point.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
On Wed, 10 Dec 2014, Benjamin Tissoires wrote:
With the minors comments I expressed, this patch is:
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Andrew, could you please resend v2 of the patch with Benjamin's comments
addressed?
Thanks,
--
Jiri Kosina
SUSE Labs
. Thanks for the quick respin Jason.
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Applied, thanks to both of you.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo
USB devices (QEMU + USB
passthrough), two of them are powered off and one M525 is active. evbug
registers mouse events.
Good stuff, thanks!
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
as well.
Otherwise it'll be processed in the next cycle.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to hid.git#for-3.19/rmi. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@synaptics.com
Applied to hid.git#for-3.19/rmi as well.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Both applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
at the moment (via the
linux-pm tree).
Please let me know if it is OK to take this one into linux-pm.
Acked-by: Jiri Kosina jkos...@suse.cz
Please take it through linux-pm.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
report-maxfield; i++) {
+for (j = 0; j report-field[i]-report_count; j++) {
+report-field[i]-value[j] = 0x00;
I asked for a comment to be added here why you are zeroing those out.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux
the application usage in such cases causes us to
ignore the field entirely, which may lead to incorrect behavior.
Signed-off-by: Jason Gerecke killert...@gmail.com
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Applied to for-3.19/wacom.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
your e-mail client not to cause whitespace damage to patches (please
see Documentation/email-clients.txt for some hints), attach the patch as
an e-mail attachment.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
according to Documentation/CodingStyle and
resubmit.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 26 Nov 2014, Huang Bo wrote:
On 11/26/2014 09:49 PM, Jiri Kosina wrote:
On Wed, 26 Nov 2014, Huang Bo wrote:
It's unfortunately whitespace damaged again. If it's not possible to set
up your e-mail client not to cause whitespace damage to patches (please
see Documentation
for resubmitting.
This one is reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
force the reading of
the feature in mt_set_input_mode for such devices.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
-core.c, otherwise correct device - driver
binding can't be guaranteed.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 25 Nov 2014, Ping Cheng wrote:
Please don't forget to merge this patch. It fixes a bad pointer issue...
Hi Ping,
yes, it's in my queue for this evening or tomorrow.
I will also add Cc: stable, ok?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
.
Gah, I was sure I did, but looking at the tree, I didn't. Thanks for
pointing that out, I will sort it out.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
this patch.
Thanks for the heads up, I am putting this patch on hold until further
notice from you or Mathieu.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
controllers for PS4 */
{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_PS4_CONTROLLER),
.driver_data = DUALSHOCK4_CONTROLLER_USB },
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
), .driver_info =
+ USB_QUIRK_DEVICE_QUALIFIER },
+
{ USB_DEVICE(0x04f3, 0x016f), .driver_info =
USB_QUIRK_DEVICE_QUALIFIER },
--
1.8.4.5
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
devices, but I don't think it's worth the
hassle splitting it).
Yes, no objection from me:
Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org
Thanks, now applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
Jarrad Whitaker's message which sources
http://winaero.com/blog/how-to-install-linux-on-surface-pro-3/
which he says is sourced from a Russian site
Signed-off-by: Alan Wu alan.c...@gmail.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
On Sun, 9 Nov 2014, Jamie Lentin wrote:
Some small problems that have since been picked up since my patchset that
introduced support for the Thinkpad Compact Keyboards[0]. Both have been
tested
on 3.18-rc1.
Both patches applied.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
) },
{ USB_DEVICE_WACOM(0x4004) },
{ USB_DEVICE_WACOM(0x5000) },
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
the FreeBSD issue reported
by Denis Akiyakov http://www.spinics.net/lists/linux-input/msg33971.html
Reviewed-by: Hans Petter Selasky h...@selasky.org
Tested-by: Denis Akiyakov d.akiya...@gmail.com
Signed-off-by: Ping Cheng pi...@wacom.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
stylized the Kconfig option name to include Mad Catz in the
option name, as (at least some of) the devices are marketed under Mad
Catz brand.
Signed-off-by: Ville Aakko ville.aa...@gmail.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
, USB_DEVICE_ID_MSI_GT683R_LED_PANEL,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
HID_QUIRK_NO_INIT_REPORTS },
--
2.1.0
--
Jiri Kosina
SUSE Labs
benjamin.tissoi...@redhat.com
---
Changes in v2:
- also return if the ret code is negative
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
is connected.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Changes in v2:
none
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, you can even remove the probe function.
hid-core will do open the report and start the hardware for you.
Good catch, thanks. I have removed the superfluous .probe() and applied
(with Dmitry's Reviewed-by: added to patch no .1).
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
,
USB_DEVICE_ID_MS_PRESENTER_8K_BT),
.driver_data = MS_PRESENTER },
--
2.1.0
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
, the only thing it is missing is your Signed-off-by: line
(please see Documentation/SubmittingPatches for explanation of what that
means).
Please resend the patch with it included so that I could apply it.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
to sending to linux-input@ to make sure
that the patch doesn't fall in between cracks.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
for 3.18 still.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
kernel driver for U2F devices using the hid group
mechanism for enumeration. This seems overcomplicated.
Hmmm ... why do you think so? I believe it actually should be really
super-trivial.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
hidraw node, and decides
afterwards whether node permissions need to be altered ... right?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Sun, 2 Nov 2014, Jiri Kosina wrote:
Alternatively, you can just write udev rule which triggers on HID devices,
issues HIDIOCGRDESC ioctl() on the just-created hidraw node, and decides
afterwards whether node permissions need to be altered ... right?
Just to make myself clear here
it :)
It absolutely hasn't been forgotten, I've been just a bit busy during past
weeks.
I am almost done with the review, expect to hear from me in a 1-2 days
timeframe regarding this series.
Thanks for patience,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
;
break;
Apologizes for the delay. I have now queued this for 3.18 still.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
queuing this now.
Thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
descriptor\n);
+ if (!kone)
return -ENOMEM;
- }
hid_set_drvdata(hdev, kone);
retval = kone_init_kone_device_struct(usb_dev, kone);
--
1.9.3 (Apple Git-50)
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list
with the review, expect to hear from me in a 1-2 days
timeframe regarding this series.
Cool, thanks. That is much appreciated.
I have now applied the whole patchset and pushed out.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
.
Dmitry, given your question, I am not applying the patch yet and waiting
for your consideration/Ack.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
times.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Makes sense.
Acked-by: Jiri Kosina jkos...@suse.cz
Thanks.
---
drivers/input/input.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 29ca0bb
and allow activating it through i8042.nomux=0 kernel
option. We'll also keep DMI table where we can record known good models.
Being responsible for introducing a non-trivial portion of
i8042_dmi_nomux_table[] entries:
Acked-by: Jiri Kosina jkos...@suse.cz
If nothing else, it'd make my life
you. Can I use
Tested-by: Andrew de los Reyes andrew-v...@gizmolabs.org
once / if I am merging this patchset?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, 30 Sep 2014, Pramod Gurav wrote:
Get rid of using return value from gpiochip_remove() as it returns
void.
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Jiri Kosina jkos...@suse.cz
Cc: linux-input@vger.kernel.org
Cc: linux-g
,
HID_QUIRK_ALWAYS_POLL },
I don't like the added comment, it makes the list look ugly (as no other
device has such a comment). The details are in the git changelog anyway.
Are you fine with me removing the comment before commiting the patch?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
,
spin_lock_irqsave(uhid-qlock, flags);
*report_id = ++uhid-report_id;
- uhid-report_type = ev-type;
+ uhid-report_type = ev-type + 1;
Nice catch. We always need the *_REPLY type as response:
Reviewed-by: David Herrmann dh.herrm...@gmail.com
Applied, thanks.
--
Jiri Kosina
SUSE
| 184 +
drivers/hid/wacom_wac.c | 299
drivers/hid/wacom_wac.h | 17 +++
include/linux/hid.h | 2 +
6 files changed, 462 insertions(+), 49 deletions(-)
--
2.1.0
--
Jiri Kosina
SUSE Labs
On Fri, 26 Sep 2014, Johan Hovold wrote:
Use mfd_add_hotplug_devices helper to register the subdevices.
Compile-only tested.
Signed-off-by: Johan Hovold jo...@kernel.org
As I expect this to be going through MFD tree together with the rest of
the patchset
Acked-by: Jiri Kosina
On Wed, 24 Sep 2014, Frank Praznik wrote:
The DualShock 4 touchpad has been measured to have a resolution of
44.86 dots/mm which equates to 1920x942.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
, and do we have any idea why it
crashes, and why HID: wacom: fix timeout on probe for some wacoms fixes
it?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
race condition somewhere, or this is a different problem
that still needs to be solved.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
, and then make sure that c64d883476 makes it to the first
3.17-stable.
What do you think?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
by me. It will be easier to include the follow up patches this way.
Ok, applied to for-3.18/wacom, annotated for stable (and made a note about
the need of cherry-picking pre-requisite commit c64d883476) and pushed
out.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
as that is the range of
values which represent the true controller orientation. Any values beyond
those extents are just noise.
Signed-off-by: Frank Praznik frank.praz...@oh.rr.com
Both applied to for-3.18/sony. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
Applied to for-3.18/wacom.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of
it.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1123584
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Andrew Duggan adug...@synaptics.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
I have applied the whole series to hid.git#for-3.18/wacom. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to specific drivers.
So knowing how commong this is could be helpful in deciding how to handle
this.
Thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
it on top of this?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 8 Sep 2014, Oliver Neukum wrote:
This mouse keeps disconnecting in runlevel 3. It needs the
ALWAYS_POLL quirk.
Signed-off-by: Oliver Neukum oneu...@suse.de
Applied to hid.git#for-3.18/always-poll-quirk, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
0xa096
#define USB_VENDOR_ID_IMATION0x0718
--
1.8.5.5
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@dylex.net
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
Queued in hid.git#for-3.18/upstream
drivers/hid/hid-thingm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-thingm.c b/drivers/hid/hid-thingm.c
index 134be89..f206398 100644
--- a/drivers/hid/hid
- incorporated feedback from Benjamin Tissoires
Signed-off-by: Christian Gmeiner christian.gmei...@gmail.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Queued for 3.18, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
(struct thingm_rgb *rgb)
{
- flush_work(rgb-work);
+ cancel_work_sync(rgb-work);
led_classdev_unregister(rgb-red.ldev);
led_classdev_unregister(rgb-green.ldev);
led_classdev_unregister(rgb-blue.ldev);
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
= 0; i tdev-fwinfo-numrgb; ++i)
thingm_remove_rgb(tdev-rgb + i);
-
- hid_hw_stop(hdev);
}
static const struct hid_device_id thingm_table[] = {
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
);
-
- hid_hw_stop(hdev);
}
static const struct hid_device_id thingm_table[] = {
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
)
{
- flush_work(rgb-work);
led_classdev_unregister(rgb-red.ldev);
led_classdev_unregister(rgb-green.ldev);
led_classdev_unregister(rgb-blue.ldev);
+ flush_work(rgb-work);
}
static int thingm_probe(struct hid_device *hdev, const struct hid_device_id
*id)
--
Jiri
tree given that it applies on top of
a
plain 3.17-rcX. It can be scheduled for either 3.17 or 3.18 (no preferences on
my side).
I have now queued it in hid.git#for-3.18/wacom. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
, but if there is anything else that does,
it'll piggy-back. Otherwise it'll go into 3.18. Please shout if it's not
okay.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
cleaned up everything, but that doesn't seem to be the case, as
thingm_remove() - thingm_remove_rgb() seems to be doing the right thing.
Dylan, is there any chance for you to capture more complete backtrace from
the oops? serial console, netconsole, anything?
Thanks,
--
Jiri Kosina
SUSE Labs
.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The report passed to us from transport driver could potentially be
arbitrarily large, therefore we better sanity-check it so that
magicmouse_emit_touch() gets only valid values of raw_id.
Cc: sta...@vger.kernel.org
Reported-by: Steven Vittitoe scvi...@google.com
Signed-off-by: Jiri Kosina jkos
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
drivers/hid/hid-picolcd_core.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c
index acbb0210..020df3c 100644
--- a/drivers/hid/hid-picolcd_core.c
+++ b/drivers/hid/hid
...@vger.kernel.org
Reported-by: Steven Vittitoe scvi...@google.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Acked-by: Bruno Prémont bonb...@linux-vserver.org
Thanks.
---
drivers/hid/hid-picolcd_core.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/hid/hid-picolcd_core.c
On Fri, 22 Aug 2014, Benjamin Tissoires wrote:
We can do once the test of the validity of the dj_device, which removes
some duplicated code in various functions.
Queued for 3.18, thanks Benjamin.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
On Wed, 27 Aug 2014, Jiri Kosina wrote:
Is it worth adding report-id to this hid_warn()?
A valid device is not expected to ever send 64 bytes reports but in
case a firmware update would do so it would help to know for which
report it was.
It definitely wouldn't hurt. Pull request
...@redhat.com
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
DJ_MAX_PAIRED_DEVICES6
#define DJ_MAX_NUMBER_NOTIFICATIONS 8
+#define DJ_RECEIVER_INDEX0
#define DJ_DEVICE_INDEX_MIN 1
#define DJ_DEVICE_INDEX_MAX 6
--
2.1.0
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list
@@ static int logi_dj_raw_event(struct hid_device *hdev,
default:
logi_dj_recv_forward_report(djrcv_dev, dj_report);
}
+
+out:
spin_unlock_irqrestore(djrcv_dev-lock, flags);
return true;
--
2.1.0
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
it to Linus this week.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 29 Jul 2014, David Herrmann wrote:
Hi
When Benjamin cleanup up the transport layer, he left UHID mostly unconverted
due to ABI issues. I promised to take a look, so here're the patches.
Hi David,
now queued for 3.18 in for-3.18/uhid branch.
Thanks,
--
Jiri Kosina
SUSE Labs
?
- where does the infinite loop come from? hid_reset() should error out
properly if usb_clear_halt() fails and HID_IN_RUNNING flag is not set
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
301 - 400 of 909 matches
Mail list logo
