.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-by: line?
Thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
},
+
+ { USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_410, HID_QUIRK_IGNORE
},
+ { USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_510, HID_QUIRK_IGNORE
},
{ 0, 0 }
};
Please do this in hid_ignore_list[] in drivers/hid/hid-core.c instead.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
multitouch devices
hid: remove duplicate ID for D-WAV eGalax 0x7224
drivers/hid/hid-ids.h| 7 +++
drivers/hid/hid-multitouch.c | 29 +
2 files changed, 16 insertions(+), 20 deletions(-)
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
) */
{ .driver_data = MT_CLS_EGALAX,
MT_USB_DEVICE(USB_VENDOR_ID_DWAV,
Applied, thanks Steffen.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
letter
explaining the changes (for example, no changes in patch 1/2, patch
2/2 amended like this and that).
Yes, exactly, please just do a fresh resend of the series with all the
feedback incorporated.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
.
This looks good to me.
Reviewed-by: Dmitry Torokhov dmitry.torok...@gmail.com
On Mon, 6 May 2013, majianpeng wrote:
Reviewed-by: Dmitry Torokhov dmitry.torok...@gmail.com
It's all good for me.
Thanks a lot. I have now queued the patch for 3.10.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
*/
struct dentry *debug_rdesc;
struct dentry *debug_events;
struct list_head debug_list;
- struct mutex debug_list_lock;
+ spinlock_t debug_list_lock;
wait_queue_head_t debug_wait;
};
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
to
`led_classdev_unregister'
--
Patch allows LED control when led-class is built in, or both hid-steelseries
_and_ led-class are both modules.
Reported-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Simon Wood si...@mungewell.org
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
;
wait_queue_head_t debug_wait;
};
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for noticing. Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
),
.driver_data = MS_ERGONOMY | MS_RDESC },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_PRESENTER_8K_USB),
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
it with proper changelog (describing why the old values
are wrong and the new ones are correct), your Signed-off-by: line (as
described in Documentation/SubmittingPatches) and to proper maintainers
ideally.
linux-input@ and Dmitry added to CC.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
ICADE_MAX_USAGE)
return NULL;
return icade_usage_table[from];
}
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Sat, 20 Apr 2013, David King wrote:
The Magic Mouse driver also supports the Magic Trackpad, so mention it
in the KConfig description for the driver.
Signed-off-by: David King amigad...@amigadave.com
Applied, thanks David.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send
that we duplicate the HID Boot Protocol in usbhid
and Bluetooth HID. The Wifi-Display HID also provides some similar protocol.
So
I currently look into creating a hid-boot.c so we have a central place that
implements it.
Makes sense to me as well.
Thanks a lot, David.
--
Jiri Kosina
SUSE
On Wed, 17 Apr 2013, Benjamin Tissoires wrote:
No semantic changes, but hid_dump_report should be in hid-debug.c, not
in hid-core.c
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
I have applied this one independently on the rest.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe
-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
I have now applied the patch, thanks everybody for all the work.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Accesses to hid_device-hid_debug_list are not serialized properly, which
could result in SMP concurrency issues when HID debugfs events are
accessesed by multiple userspace processess.
Serialize all the list operations by a mutex.
Spotted by Al Viro.
Signed-off-by: Jiri Kosina jkos...@suse.cz
,
thanks, I will look into it and see whether I would be able to apply it
still for 3.10 merge window.
I also have a locking fix for HID-debugfs which I am going to apply
shortly, but I am travelling this week, so I am in a bit degraded mode.
For reference, locking fix below.
From: Jiri Kosina
*/
Could you please make this comment in-line with kernel comments coding
style?
Thanks, Benjamin.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Sun, 7 Apr 2013, Stefan Achatz wrote:
Kone now reports media key events through it's chardev to userspace.
Signed-off-by: Stefan Achatz erazor...@users.sourceforge.net
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
On Tue, 2 Apr 2013, David Herrmann wrote:
Battery device names must be unique, otherwise registration fails if
multiple Wii Remotes are connected.
Applied the series, thanks David.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
-and-Tested-By: Clarke Wixon cwi...@usa.net
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
Hi Jiri,
this one can goes to stable (so 3.8) as well.
Applied, and will push for 3.9 still.
Thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
On Thu, 4 Apr 2013, Jiri Slaby wrote:
In pointer_press_speed_show, we do
data_pointer = hid_get_drvdata(hdev);
twice in a row. Remove one of those.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Jiri Kosina jkos...@suse.cz
Cc: linux-input@vger.kernel.org
---
drivers/hid/hid-lenovo
knowledge, no retail product uses this
feature), but it's still a regression in 3.9.
I am queuing this for 3.9 still, thanks.
Benjamin, just please double-check that the patch is ok as-is in my
for-3.9/upstream-fixes branch, as I had to hand-apply it due to
context-related conflicts.
--
Jiri Kosina
-of-tree driver for Acer
Iconia W700?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
-}
-
-module_init(steelseries_srws1_init);
-module_exit(steelseries_srws1_exit);
+module_hid_driver(steelseries_srws1_driver);
MODULE_LICENSE(GPL);
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
On Mon, 18 Mar 2013, Josh Boyer wrote:
This keyboard backlight device causes a 10 second delay to boot. Add it
to the quirk list with HID_QUIRK_NO_INIT_REPORTS.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
a fixed v2. My apologies.
I have already fixed that in my tree, no need to resend.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Just to set my own expectations correctly -- Henrik, are you going to
review this patchset as well, or there is no need for me to wait for your
feedback?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
On Sun, 10 Mar 2013, Stefan Achatz wrote:
Userland-tools now keep track of actual profile themselves.
Spared out Pyra, which is a harder case.
Hi Stefan,
I fail to see how this is not breaking backwards compatibility?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
be a problem.
There used to be a problem in linux-next, but that should be fixed by
4ba25d3f87 (HID: multitouch: remove last usb dependency), which I have
pushed out yesterday.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
else ... ?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
will :) ).
For some reason these two vanished between the cracks of my mailbox.
Thanks for pointing those out, I will process them today and either apply
it, or fix it for -next by adding a config dependency.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux
,
+ int reqtype)
Where does the need for passing the report argument come from please?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
will be taking the patches.
Thanks Benjamin.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 8 Mar 2013, Ming Lei wrote:
If suspend callback fails in system sleep context, usb core will
ignore the failure and let the system sleep go ahead further, so this
patch doesn't recover device under this situation, otherwise
may cause resume() confused.
Cc: Jiri Kosina jkos
/hid-logitech-dj.h | 1 -
include/linux/hid.h | 46 -
4 files changed, 69 insertions(+), 50 deletions(-)
Now queued in my tree. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
I still did not implemented the final usb cleanup for hid-multitouch as it may
required few comments.
I have now taken the series. Thanks Benjamin, thanks Henrik.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
On Sun, 17 Feb 2013, Paul Sbarra wrote:
This is the original report descriptor as reported by lsusb -vd 046d:c294.
I have now applied both patches.
Paul, please try to provide more verbose changelogs in the future even for
such trivial changes as this.
Thanks.
--
Jiri Kosina
SUSE Labs
should be applied with Henrik's authorship, right? (I can do
it after I receive signoffs from Henrik for those).
Thanks a lot for this work.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More
On Sun, 17 Feb 2013, Rafi Rubin wrote:
Looks good, and I can confirm it works fine.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Westerberg mika.westerb...@linux.intel.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Thanks a lot Mika, I have now applied the series for 3.9
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
USB_DEVICE_ID_VELLEMAN_K8061_LAST0x8068
+
#define USB_VENDOR_ID_VERNIER0x08f7
#define USB_DEVICE_ID_VERNIER_LABPRO 0x0001
#define USB_DEVICE_ID_VERNIER_GOTEMP 0x0002
Applied, thanks Ian.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
,
- wiiext_keymap[WIIEXT_KEY_C], !!(payload[5] 0x02));
+ wiiext_keymap[WIIEXT_KEY_C], !(payload[5] 0x02));
}
input_sync(ext-input);
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
() and
hid_device_io_stop() indentation not use tabs?
Also, the functions are currently unused, so I'd rather suggest adding
them together when individual device driver(s) are converted to using it.
Thanks again,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
-off-by: Benjamin Tissoires benjamin.tissoi...@gmail.com
Applied this one on top of the previous hid-multitouch patchset. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo
+multitouch
series this week, or we are too close to the 3.9 opening window?
Please just send the patches, and let's see whether they will make it for
3.8 or I'll queue (some of) them for 3.9.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
driver could make use of this feature during removal.
David,
what use-case exactly are you thinking of here, please?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info
and
t400.
Nestor,
is there anything happening in this area, please?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
callback, in other words.
raw_event() doesn't provide equivalent functionality though; namely, the
report is not parsed.
Or have I missed your point?
Thanks for the extensive review, Henrik, it's really helpful.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
IN
bmAttributes3
Transfer TypeInterrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0008 1x 8 bytes
bInterval 10
Device Status: 0x
(Bus Powered)
--
Jiri Kosina
SUSE
in steelseries_srws1_probe() here:
drv_data-led[SRWS1_NUMBER_LEDS] = led;
From: Jiri Kosina jkos...@suse.cz
Subject: [PATCH] HID: steelseries: fix out of bound array access
The last field of the driver_data-leds[] array is used to store the
special toggle for setting all leds simultaneously, so we need
. Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in-case any more comments come in and re-do
the patch with the file name 'hid-steelseries.c' towards the end of the
week.
Works for me. I have finished the review and don't have any other
comments.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
+++
Is hid-srws1 really the best name? My understanding is that the vendor is
called Steelseries, and we mostly stick to calling the drivers according
to the device vendors (and grouping the quirks accordingly).
So how about hid-steelseries?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
;
+ name_sz = strlen(hdev-uniq) + 16;
+
+ /* 'ALL', for setting all LEDs simultaneously */
+ led = kzalloc(sizeof(struct led_classdev)+name_sz, GFP_KERNEL);
Is this memory ever freed?
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
to this email with a follow-up patch that
I forgot to send the last time around. It is just documentation for the
quirk.
Ok, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Tue, 22 Jan 2013, Fernando Luis Vázquez Cao wrote:
Document what the fix-up is does and make it more robust by ensuring
that it is only applied to the USB interface that corresponds to the
mouse (sony_report_fixup() is called once per interface during probing).
Applied.
--
Jiri Kosina
.
First question before we start any further analysis -- what is the latest
known-good version of the kernel, where this problem didn't happen on this
particular computer?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
by it
currently), let it create /sys/class/leds/blink1...
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
?
Users are attempting to enter the dm-crypt decryption password during
boot so they have not noticed nor complained about mouse failure, only
keyboard failure.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
Keyboard] onusb-:00:1d.0-1.2/input0
i.e. the keyboard gets properly autodeteted, but I have no idea whether
this was before or after dm-crypt password prompt.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
/hid/hid-wiimote-debug.c:69:18: warning: 'size' may be used
uninitialized in this function [-Wmaybe-uninitialized]
Thanks!
Signed-off-by: David Herrmann dh.herrm...@googlemail.com
Applied, thanks!
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux
gamepad.
The pad has been tested to support rumble strengths up to 255, not
just 127.
Signed-off-by: Michael Karcher ker...@mkarcher.dialup.fu-berlin.de
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
in it, it'd be picked for -stable queue automatically. Otherwise, anyone
is free to take it once it's in Linus' tree and sent to to
sta...@vger.kernel.org for inclusion.
Hope this helps,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
.
Add this device to the have-special-driver list and fix up the report
descriptor in the Sony-specific driver which happens to already have a fixup
for a similar firmware bug.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
patches. I
will send you a pm shortly.
So, what is the status of this code now, please?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
been
introduced. Look at hidinput_configure_usage(). I don't think splitting
the lines makes this particular case more readable.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More
__packed__
without breaking ABI.
Signed-off-by: David Herrmann dh.herrm...@googlemail.com
Applied, thanks David.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 18 Dec 2012, Marcelo Ricardo Leitner wrote:
Em 18-12-2012 10:33, Marcelo Ricardo Leitner escreveu:
[ ... snip ... ]
Tested-by: Marcelo Leitner mleit...@redhat.com
Applied, thanks guys.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input
+-
drivers/hid/hid-multitouch.c | 198
+++
include/linux/hid.h | 1 +
4 files changed, 229 insertions(+), 73 deletions(-)
--
1.8.0
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
, USB_DEVICE_ID_MGE_UPS, HID_QUIRK_NOGET },
+ { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER,
HID_QUIRK_NO_INIT_REPORTS },
I have fixed the alphabetical ordering and applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
mleit...@redhat.com
Signed-off-by: Mauro Carvalho Chehab mche...@infradead.org
Yeah, this is the way I'd like to have it fixed.
Waiting for Marcelo's Tested-by: before merging it.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
. If some sensor hubs
stil must be usable as raw devices, a blacklist might be created.
Signed-off-by: Alexander Holler hol...@ahsoftware.de
I like this change and would like to merge it, but I'd appreciate Ack from
Srinivas first.
Srinivas?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
On Wed, 12 Dec 2012, Pandruvada, Srinivas wrote:
I also liked it. You can add my ACK.
Added your Ack and applied, thanks everybody.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More
int i2c_hid_power(struct hid_device *hid, int lvl)
--
1.8.0.2
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in hid.git, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-bufsize = HID_MIN_BUFFER_SIZE;
- i2c_hid_alloc_buffers(ihid);
+ ret = i2c_hid_alloc_buffers(ihid, HID_MIN_BUFFER_SIZE);
+ if (ret 0)
+ goto err;
ret = i2c_hid_fetch_hid_descriptor(ihid);
if (ret 0)
Applied, thank you.
--
Jiri Kosina
SUSE Labs
account for the 2 bytes needed for storing the
reply size.
I have fixed that and applied the patch, thanks everybody!
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
)
goto purge;
}
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
(debug, bool, 0444);
MODULE_PARM_DESC(debug, print a lot of debug information);
Reviewed-by: Jean Delvare kh...@linux-fr.org
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
)
struct i2c_hid_desc {
__le16 wHIDDescLength;
Reviewed-by: Jean Delvare kh...@linux-fr.org
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
), %s %04hX:%04hX,
client-name, hid-vendor, hid-product);
ret = hid_add_device(hid);
Reviewed-by: Jean Delvare kh...@linux-fr.org
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message
attention for now.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
/i2c-hid/i2c-hid.c
@@ -891,6 +891,9 @@ static int __devexit i2c_hid_remove(struct i2c_client
*client)
free_irq(client-irq, ihid);
+ if (ihid-bufsize)
+ i2c_hid_free_buffers(ihid);
+
kfree(ihid);
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from
,
- report-id, buffer, size);
+ report-id, buffer, size))
+ return;
i2c_hid_dbg(ihid, report (len=%d): %*ph\n, size, size, ihid-inbuf);
Applied.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
for spotting that, Jean.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that are needed for initialization of
the device, as all the probing as been finished already.
So they would be 'regular' events sent by the device. And as the
initialization hasn't been finished yet, it really can't be predicted
which events make it and which don't.
Thanks,
--
Jiri Kosina
SUSE Labs
, or explicitly ask me not to include
this driver in pull request that goes to Linus yet.
Once the driver is in Linus' tree, I'd rather not change the name.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord
splitting the lock. So I don't have strong objections at the very moment.
This will also allow us to get rid of what commit 596264082f introduced in
unifying driver, right? (adding Nestor to CC).
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body
://bugs.debian.org/694546
Signed-off-by: Ben Hutchings b...@decadent.org.uk
Thanks for the fix, appiled.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Fri, 23 Nov 2012, Benjamin Tissoires wrote:
This just refactors the allocation of hid_input.
No semantic changes.
As this is a generic cleanup, I am taking this one through
for-3.8/upstream branch.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line
= hidraw_open,
.release = hidraw_release,
.unlocked_ioctl = hidraw_ioctl,
+ .fasync = hidraw_fasync,
#ifdef CONFIG_COMPAT
.compat_ioctl = hidraw_ioctl,
#endif
Right you are!
Applied, thanks.
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list
. There must be some other way in which the same effect can be
achieved?
The changelog doesn't seem to be really verbose enough to me.
What exactly is the scenario you are looking at here, Benjamin, please?
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe
.
Cheers,
Jan-Matthias Braun
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-input in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
701 - 800 of 909 matches
Mail list logo
