Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-29 Thread Jiri Kosina
On Tue, 28 May 2013, Gustavo Padovan wrote: Signed-off-by: David Herrmann dh.herrm...@gmail.com Acked-by: Jiri Kosina jkos...@suse.cz Gustavo, I think I'd like to take this patch together with the ENODATA change for hid-input, as they, in some sense, stick together. If you

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-28 Thread Jiri Kosina
On Thu, 23 May 2013, David Herrmann wrote: While l2cap_user callbacks are running, the whole hci_dev is locked. Even if we would add more fine-grained locking to HCI core, it would still be called from the non-reentrant rx work-queue and thus block the event processing. However, if we want

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-24 Thread David Herrmann
Hi On Fri, May 24, 2013 at 12:46 AM, Daniel Nicoletti dantt...@gmail.com wrote: Ok, just tested with my two Apple mouses (Trackpad MagicMouse), and with the ENODATA patch it now works perfectly, the other mouse doesn't freeze when connecting and the udev signals are also properly emitted, is

[PATCH] Bluetooth: hidp: register HID devices async

2013-05-23 Thread David Herrmann
While l2cap_user callbacks are running, the whole hci_dev is locked. Even if we would add more fine-grained locking to HCI core, it would still be called from the non-reentrant rx work-queue and thus block the event processing. However, if we want to perform synchronous I/O during HID device

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-23 Thread Daniel Nicoletti
This patch alone didn't work: http://privatepaste.com/a3fe0dff0a Should I also apply the one that returns ENODATA? From what I can tell it wouldn't be needed as this power_supply registration would be delayed tho I see nothing in this patch that does that. What am I missing? Thanks, 2013/5/23

Re: [PATCH] Bluetooth: hidp: register HID devices async

2013-05-23 Thread Daniel Nicoletti
Ok, just tested with my two Apple mouses (Trackpad MagicMouse), and with the ENODATA patch it now works perfectly, the other mouse doesn't freeze when connecting and the udev signals are also properly emitted, is there some formal way of adding a tested-by? tested-by: Daniel Nicoletti