Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Bruno Prémont
Hi Jiri, Some notes regarding picoLCD part below. On Tue, 09 July 2013 Jiri Kosina jkos...@suse.cz wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Benjamin Tissoires
Hi Jiri, On 07/09/2013 08:44 PM, Jiri Kosina wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary

Re: [PATCH] HID: fix data access in implement()

2013-07-10 Thread Jiri Kosina
On Wed, 10 Jul 2013, Benjamin Tissoires wrote: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary

[PATCH] HID: fix data access in implement()

2013-07-09 Thread Jiri Kosina
implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read past the boundary hits a page boundary, pagefault happens when accessing

Re: [PATCH] HID: fix data access in implement()

2013-07-09 Thread Gustavo Padovan
Hi Jiri, * Jiri Kosina jkos...@suse.cz [2013-07-09 20:44:27 +0200]: implement() is setting bytes in LE data stream. In case the data is not aligned to 64bits, it reads past the allocated buffer. It doesn't really change any value there (it's properly bitmasked), but in case that this read