On Wed, 8 Jul 2015, Gabriele Mazzotta wrote:
i2c-hid takes care of requesting and handling IRQs for HID devices
which in turns might expect them to be always active when working
in normal conditions. Hence, disabling IRQs before calling the suspend
callbacks can potentially cause problems
On Tuesday 07 July 2015 22:49:30 Jiri Kosina wrote:
On Tue, 7 Jul 2015, Gabriele Mazzotta wrote:
The irq is most likely required by the suspend callback, so disable it
only after the callback had been executed.
It would be nice to have a more verbose changelog here -- i.e. why we want
The irq is most likely required by the suspend callback, so disable it
only after the callback had been executed.
Signed-off-by: Gabriele Mazzotta gabriele@gmail.com
---
drivers/hid/i2c-hid/i2c-hid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On Tue, 7 Jul 2015, Gabriele Mazzotta wrote:
The irq is most likely required by the suspend callback, so disable it
only after the callback had been executed.
It would be nice to have a more verbose changelog here -- i.e. why we want
to do such change and what could go wrong if IRQ is
On Jul 07 2015 or thereabouts, Gabriele Mazzotta wrote:
The irq is most likely required by the suspend callback, so disable it
only after the callback had been executed.
Signed-off-by: Gabriele Mazzotta gabriele@gmail.com
---
Just in case Jiri missed it:
Reviewed-by: Benjamin Tissoires
