Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-29 Thread Jiri Kosina
On Fri, 24 May 2013, David Herrmann wrote: So I hope we can apply this for linux-next (probably after gustavo applied the HIDP fix)? Applied to my tree, together with the hidp fix. Thanks David, thanks Daniel! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-24 Thread David Herrmann
Hi On Mon, May 13, 2013 at 11:17 PM, Daniel Nicoletti dantt...@gmail.com wrote: 2013/5/13 David Herrmann dh.herrm...@gmail.com: Anyway, I'd still like to see this patch applied so we have this annoying bug fixed. I'd be willing to change the power_supply core, too, if one of the maintainers

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-15 Thread David Herrmann
Hi Anton On Tue, May 14, 2013 at 1:20 AM, Anton Vorontsov an...@enomsg.org wrote: On Mon, May 13, 2013 at 05:01:30PM +0200, David Herrmann wrote: [..] I really dislike the way power_supply core calls into the drivers during the add uevent. If a driver holds an I/O mutex (or anything else), it

[PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-13 Thread David Herrmann
power_supply core has the bad habit of calling our battery callbacks from within power_supply_register(). Furthermore, if the callbacks fail with an unhandled error code, it will skip any uevent that it might currently process. So if HID-core registers battery devices, an add uevent is generated

Re: [PATCH] HID: input: return ENODATA if reading battery attrs fails

2013-05-13 Thread Daniel Nicoletti
2013/5/13 David Herrmann dh.herrm...@gmail.com: Anyway, I'd still like to see this patch applied so we have this annoying bug fixed. I'd be willing to change the power_supply core, too, if one of the maintainers agrees on the design (David? Anton?). And, @Daniel, can you check whether this