Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread Oliver Neukum
On Mon, 2015-03-16 at 22:37 +0100, Jiri Kosina wrote: On Mon, 16 Mar 2015, Pavel Machek wrote: Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2, sizeof(buf2), +

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread David Herrmann
Hi On Sat, Feb 7, 2015 at 10:48 PM, Lauri Kasanen c...@gmx.com wrote: Hi, On Sat, 7 Feb 2015 17:31:33 +0100 Antonio Ospite a...@ao2.it wrote: +#include linux/usb/input.h Please don't. HID should be transport agnostic, so please refrain from directly call usb. I agree with

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread Pavel Machek
On Thu 2015-03-19 10:14:21, Oliver Neukum wrote: On Mon, 2015-03-16 at 22:37 +0100, Jiri Kosina wrote: On Mon, 16 Mar 2015, Pavel Machek wrote: Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), +

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread Oliver Neukum
On Thu, 2015-03-19 at 11:12 +0100, Pavel Machek wrote: On Thu 2015-03-19 10:54:22, Oliver Neukum wrote: On Thu, 2015-03-19 at 10:38 +0100, Pavel Machek wrote: On Thu 2015-03-19 10:14:21, Oliver Neukum wrote: On Mon, 2015-03-16 at 22:37 +0100, Jiri Kosina wrote: Are you sure

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread Oliver Neukum
On Thu, 2015-03-19 at 10:38 +0100, Pavel Machek wrote: On Thu 2015-03-19 10:14:21, Oliver Neukum wrote: On Mon, 2015-03-16 at 22:37 +0100, Jiri Kosina wrote: Are you sure CONFIG_DMA_API_DEBUG wouldn't warn here? As far as I can tell, it will not warn. The problem is not in the

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-19 Thread Pavel Machek
On Thu 2015-03-19 10:54:22, Oliver Neukum wrote: On Thu, 2015-03-19 at 10:38 +0100, Pavel Machek wrote: On Thu 2015-03-19 10:14:21, Oliver Neukum wrote: On Mon, 2015-03-16 at 22:37 +0100, Jiri Kosina wrote: Are you sure CONFIG_DMA_API_DEBUG wouldn't warn here? As far as I can

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-16 Thread Pavel Machek
On Tue 2015-02-10 09:14:36, Oliver Neukum wrote: On Mon, 2015-02-09 at 20:44 +0200, Lauri Kasanen wrote: On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2,

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-03-16 Thread Jiri Kosina
On Mon, 16 Mar 2015, Pavel Machek wrote: Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2, sizeof(buf2), + transfered, USB_CTRL_SET_TIMEOUT); You cannot

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-10 Thread Oliver Neukum
On Mon, 2015-02-09 at 20:44 +0200, Lauri Kasanen wrote: On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2, sizeof(buf2), + transfered,

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-10 Thread Antonio Ospite
Hi Lauri, On Sun, 8 Feb 2015 11:11:38 +0200 Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-10 Thread Lauri Kasanen
Hi Antonio, These annotations about the history of a patch are usually added after the '---' marker right before sending the patch, not in the commit message. They are useful for reviewers, but not really interesting anymore after the code is validated and merged. In the subject you can

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-09 Thread Lauri Kasanen
On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2, sizeof(buf2), + transfered, USB_CTRL_SET_TIMEOUT); You cannot do this. Even for a single byte

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-09 Thread Oliver Neukum
On Sat, 2015-02-07 at 15:48 +0200, Lauri Kasanen wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-08 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use output_report cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by:

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com ---

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Benjamin Tissoires
Hi Lauri, On Sat, Feb 7, 2015 at 8:48 AM, Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Antonio Ospite
On Sat, 7 Feb 2015 10:56:49 -0500 Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: Hi Lauri, On Sat, Feb 7, 2015 at 8:48 AM, Lauri Kasanen c...@gmx.com wrote: Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Hi, On Sat, 7 Feb 2015 17:31:33 +0100 Antonio Ospite a...@ao2.it wrote: +#include linux/usb/input.h Please don't. HID should be transport agnostic, so please refrain from directly call usb. I agree with Benjamin here. + + ret = usb_interrupt_msg(dev,