Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-09 Thread Jiri Kosina
On Tue, 6 Aug 2013, Sune Mølgaard wrote: Being affected by this bug, I can confirm that Linux 3.11-rc4 still exhibits the unwanted behaviour for me, but that commenting out the single line from the second patch makes it work. Thus, for requesting a revert on that line, you are most welcome

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-06 Thread Sune Mølgaard
Being affected by this bug, I can confirm that Linux 3.11-rc4 still exhibits the unwanted behaviour for me, but that commenting out the single line from the second patch makes it work. Thus, for requesting a revert on that line, you are most welcome to put me down as a Tested-By. Best regards,

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-05 Thread Jiri Kosina
On Fri, 2 Aug 2013, Benjamin Tissoires wrote: Could you please elaborate? (and put an elaborate description to revert commit log perhaps?) Sure, so here is the revert commit log: -- Commit HID: hid-logitech-dj, querying_devices was never set activate a flag which guarantees that we

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-05 Thread Benjamin Tissoires
On Mon, Aug 5, 2013 at 3:22 PM, Jiri Kosina jkos...@suse.cz wrote: On Fri, 2 Aug 2013, Benjamin Tissoires wrote: Could you please elaborate? (and put an elaborate description to revert commit log perhaps?) Sure, so here is the revert commit log: -- Commit HID: hid-logitech-dj,

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-02 Thread Benjamin Tissoires
On Fri, Aug 2, 2013 at 3:11 AM, Jiri Kosina jkos...@suse.cz wrote: On Thu, 1 Aug 2013, Benjamin Tissoires wrote: Set querying_devices flag to true when we start the enumeration process. This was missing from the original patch. It never produced undesirable effects as it is highly

Re: [PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-08-01 Thread Benjamin Tissoires
On Thu, Jul 18, 2013 at 3:21 PM, Nestor Lopez Casado nlopezca...@logitech.com wrote: Set querying_devices flag to true when we start the enumeration process. This was missing from the original patch. It never produced undesirable effects as it is highly improbable to have a second

[PATCH 2/2] HID: hid-logitech-dj, querying_devices was never set

2013-07-18 Thread Nestor Lopez Casado
Set querying_devices flag to true when we start the enumeration process. This was missing from the original patch. It never produced undesirable effects as it is highly improbable to have a second enumeration triggered while a first one was still in progress. Signed-off-by: Nestor Lopez Casado