Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 20/07/2015 23:59, Greg KH a écrit : On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: diff --git a/Documentation/ABI/testing/sysfs-driver-ebeam b/Documentation/ABI/testing/sysfs-driver-ebeam +++ b/Documentation/ABI/testing/sysfs-driver-ebeam @@ -0,0 +1,53 @@ +What:

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 21/07/2015 00:40, Greg KH a écrit : On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net + + /*

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Oliver Neukum
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 + drivers/input/misc/Makefile | 1 +

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-21 Thread Yann Cantin
Hi, Le 21/07/2015 10:19, Oliver Neukum a écrit : On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote: diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c new file mode 100644 index 000..79cac51 --- /dev/null +++ b/drivers/input/misc/ebeam.c +/* Electronics For

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Greg KH
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net You need some kind of text in the changelog here... --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 +

[RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Yann Cantin
Signed-off-by: Yann Cantin yann.can...@laposte.net --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 + drivers/input/misc/Makefile | 1 + drivers/input/misc/ebeam.c | 777 +++

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Greg KH
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net + + /* sysfs setup */ + err =

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net + + /* sysfs setup */ + err = sysfs_create_group(intf-dev.kobj, ebeam_attr_group); Ick, you just added the

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Dmitry Torokhov
On Mon, Jul 20, 2015 at 03:40:33PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin

Re: [PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-21 Thread Oliver Neukum
On Fri, 2013-08-16 at 22:25 +0200, Yann Cantin wrote: +/* IRQ */ +static int ebeam_read_data(struct ebeam_device *ebeam, unsigned char *pkt) +{ + +/* + * Packet description : 8 bytes + * + * nop packet : FF FF FF FF FF FF FF FF + * + * pkt[0] : Sensors + * bit 1 : ultrasound signal

Re: [PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-21 Thread Yann Cantin
Hi, All issues addressed. Just a point : + +/* input final setup */ +ebeam_setup_input(ebeam, input_dev); + +err = input_register_device(ebeam-input); +if (err) { +dev_dbg(intf-dev, +%s - input_register_device failed, err: %d\n, +

[PATCH 2/2] input: misc: New USB eBeam input driver

2013-08-16 Thread Yann Cantin
Signed-off-by: Yann Cantin yann.can...@laposte.net --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 + drivers/input/misc/Makefile | 1 + drivers/input/misc/ebeam.c | 763 +++

[RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2013-07-24 Thread Yann Cantin
Signed-off-by: Yann Cantin yann.can...@laposte.net --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 + drivers/input/misc/Makefile | 1 + drivers/input/misc/ebeam.c | 763 +++

Re: [eBeam PATCH 2/2] input: misc: New USB eBeam input driver.

2012-09-05 Thread Yann Cantin
Hi, Le 05/09/2012 09:29, Oliver Neukum a écrit : before we add yet another sysfs interface, we should ask whether calibration isn't a problem that should be solved with a common API. Short answer : no. ## Long answer (may be oot) : Existing calibration tools or procedures (in kernel modules

Re: [eBeam PATCH 2/2] input: misc: New USB eBeam input driver.

2012-09-05 Thread Oliver Neukum
On Wednesday 05 September 2012 21:58:06 Yann Cantin wrote: As ebeams are the only devices to my knowledge that work that way, i don't think a common API can be common, unless we mean an in-kernel generic purpose calibration API for input devices (stellar away for me), or a userland one

[eBeam PATCH 2/2] input: misc: New USB eBeam input driver.

2012-09-01 Thread Yann Cantin
Signed-off-by: Yann Cantin yann.can...@laposte.net --- drivers/input/misc/Kconfig | 22 ++ drivers/input/misc/Makefile |1 + drivers/input/misc/ebeam.c | 750 +++ 3 files changed, 773 insertions(+) create mode 100644 drivers/input/misc/ebeam.c