Re: [PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-27 Thread Oliver Neukum
On Thu, 2014-04-24 at 12:32 +0200, Michal Malý wrote: On Wednesday 23 of April 2014 15:41:03 Oliver Neukum wrote: On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote: static int drff_play(struct input_dev *dev, void *data, -struct ff_effect *effect)

Re: [PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-24 Thread Michal Malý
On Wednesday 23 of April 2014 15:41:03 Oliver Neukum wrote: On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote: static int drff_play(struct input_dev *dev, void *data, -struct ff_effect *effect) + const struct mlnx_effect_command

Re: [PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-23 Thread Oliver Neukum
On Tue, 2014-04-22 at 15:59 +0200, Michal Malý wrote: static int drff_play(struct input_dev *dev, void *data, -struct ff_effect *effect) + const struct mlnx_effect_command *command) { struct hid_device *hid =

Re: [PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-23 Thread simon
On Wed, Apr 23, 2014 at 03:14:44PM +, madcatxs...@devoid-pointer.net wrote: This is another case where even the old code was flawed, right? Should I try to stuff the fixes into these patches or would a few extra patches addressing these problems be an easier to review solution? I can

Re: [PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-23 Thread Michal Malý
On Wednesday 23 of April 2014 11:47:05 si...@mungewell.org wrote: On Wed, Apr 23, 2014 at 03:14:44PM +, madcatxs...@devoid-pointer.net wrote: This is another case where even the old code was flawed, right? Should I try to stuff the fixes into these patches or would a few extra

[PATCH v2 09/24] input: Port hid-dr to ff-memless-next

2014-04-22 Thread Michal Malý
Port hid-dr to ff-memless-next Signed-off-by: Michal Malý madcatxs...@devoid-pointer.net --- drivers/hid/Kconfig | 2 +- drivers/hid/hid-dr.c | 59 2 files changed, 37 insertions(+), 24 deletions(-) diff --git a/drivers/hid/Kconfig