Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ ... snip ... ] The mouse has 3 green leds and one red to indicate battery status, but I think they operate autonomously. It's possible that the mouse is presenting them in the report descriptor though (and maybe it's even possible to control them

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ 101.805120] usb 3-4: new low-speed USB device number 3 using xhci_hcd [ 101.979584] usb 3-4: New USB device found, idVendor=046d, idProduct=c50e [ 101.979589] usb 3-4: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 101.979592]

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Vlastimil Babka
On 07/21/2015 11:08 PM, Pavel Machek wrote: On Tue 2015-07-21 10:01:33, Dmitry Torokhov wrote: On Tue, Jul 21, 2015 at 01:14:39PM +0200, Vlastimil Babka wrote: On 06/09/2015 07:42 PM, Dmitry Torokhov wrote: From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Thu, 23 Jul 2015, Vlastimil Babka wrote: On 07/22/2015 08:55 PM, Jiri Kosina wrote: On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ ... snip ... ] The mouse has 3 green leds and one red to indicate battery status, but I think they operate autonomously. It's possible that the

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Pavel Machek
On Wed 2015-07-22 21:49:06, Jiri Kosina wrote: On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ 101.805120] usb 3-4: new low-speed USB device number 3 using xhci_hcd [ 101.979584] usb 3-4: New USB device found, idVendor=046d, idProduct=c50e [ 101.979589] usb 3-4: New USB device strings:

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Dmitry Torokhov
On Wed, Jul 22, 2015 at 09:49:06PM +0200, Jiri Kosina wrote: On Wed, 22 Jul 2015, Vlastimil Babka wrote: [ 101.805120] usb 3-4: new low-speed USB device number 3 using xhci_hcd [ 101.979584] usb 3-4: New USB device found, idVendor=046d, idProduct=c50e [ 101.979589] usb 3-4: New USB

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Wed, 22 Jul 2015, Dmitry Torokhov wrote: Yes, I'll change how we count the leds to skip unnamed, then the patch below won't be needed. Agreed. BTW, maybe we should be using hid_map_usage_clear() in map_led() as it does not make much sense to convert CAPS LOCK into SCROLL LOCK in case

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Jiri Kosina
On Wed, 22 Jul 2015, Pavel Machek wrote: I am however not sure whether input_leds_connect() is not too unkind to unnamed LEDs and shouldn't be more tolerant to those in the long term. Maybe. From: Jiri Kosina jkos...@suse.com Subject: [PATCH] Input: leds: don't attempt to deregister

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-22 Thread Vlastimil Babka
On 07/21/2015 07:01 PM, Dmitry Torokhov wrote: No, this is benign. I guess your keyboard has more LEDs than input system has defined or several usages refer to the same LED. Can you try debug patch below and post the messages? [ 101.805120] usb 3-4: new low-speed USB device number 3 using

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-21 Thread Dmitry Torokhov
On Tue, Jul 21, 2015 at 01:14:39PM +0200, Vlastimil Babka wrote: On 06/09/2015 07:42 PM, Dmitry Torokhov wrote: From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input handler called leds that exports LEDs on input devices as standard LED class devices in

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-07-21 Thread Vlastimil Babka
On 06/09/2015 07:42 PM, Dmitry Torokhov wrote: From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input handler called leds that exports LEDs on input devices as standard LED class devices in sysfs and allows controlling their ptate via sysfs or via any of the

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-15 Thread Pali Rohár
On Monday 15 June 2015 12:03:08 Pavel Machek wrote: On Tue 2015-06-09 18:24:54, Dmitry Torokhov wrote: On Wed, Jun 10, 2015 at 02:32:32AM +0200, Samuel Thibault wrote: Hello, Thanks for the modified version. This all seems to be working as expected with multiple keyboards.

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-15 Thread Pavel Machek
On Tue 2015-06-09 18:24:54, Dmitry Torokhov wrote: On Wed, Jun 10, 2015 at 02:32:32AM +0200, Samuel Thibault wrote: Hello, Thanks for the modified version. This all seems to be working as expected with multiple keyboards. Excellent. Let's give Pavel and Pali chance to test it out and

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-11 Thread Pavel Machek
On Tue 2015-06-09 18:24:54, Dmitry Torokhov wrote: On Wed, Jun 10, 2015 at 02:32:32AM +0200, Samuel Thibault wrote: Hello, Thanks for the modified version. This all seems to be working as expected with multiple keyboards. Excellent. Let's give Pavel and Pali chance to test it out and

[PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Dmitry Torokhov
From: Samuel Thibault samuel.thiba...@ens-lyon.org This change creates a new input handler called leds that exports LEDs on input devices as standard LED class devices in sysfs and allows controlling their ptate via sysfs or via any of the standard LED triggers. This allows to re-purpose and

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Samuel Thibault
Hello, Thanks for the modified version. This all seems to be working as expected with multiple keyboards. Samuel -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Dmitry Torokhov
On Wed, Jun 10, 2015 at 02:32:32AM +0200, Samuel Thibault wrote: Hello, Thanks for the modified version. This all seems to be working as expected with multiple keyboards. Excellent. Let's give Pavel and Pali chance to test it out and let's get it in 4.2. Thanks. -- Dmitry -- To