On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
+static int gt683r_led_probe(struct hid_device *hdev,
+ const struct hid_device_id *id)
+{
+ int i;
+ int ret;
+
On Mon, Jun 23, 2014 at 04:35:13PM +0200, Oliver Neukum wrote:
On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
+static int gt683r_led_probe(struct hid_device *hdev,
+
On Mon, Jun 23, 2014 at 04:42:55PM +0200, Johan Hovold wrote:
On Mon, Jun 23, 2014 at 04:35:13PM +0200, Oliver Neukum wrote:
On Wed, 2014-06-18 at 19:05 +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
+static
Sorry for noticing this thread late.
No problem. Good that you noticed it now! Thank you.
Just move the initialisation of the lock and work to the other private
data initialisations directly after it's allocated.
Can you send a follow up patch, Janne?
Yes I can. Just a moment.
Janne
--
To
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
---
Changes in v2:
- sorted headers to alphabetic order
- using devm_kzalloc
- using BIT(n)
- using usb_control_msg
On Wed, Jun 18, 2014 at 07:05:02PM +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
Reviewed-by: Johan Hovold jo...@kernel.org
Thanks, Janne!
Johan
---
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
Reviewed-by: Johan Hovold jo...@kernel.org
Thanks, Janne!
Johan
Thank you for reviewing my patch :) I sure learnt a
lot from you and if I
On Wed, Jun 18, 2014 at 09:41:35PM +0300, Janne Kanniainen wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
Reviewed-by: Johan Hovold jo...@kernel.org
Thanks, Janne!
Johan
On Wed, 18 Jun 2014, Johan Hovold wrote:
This driver adds support for USB controlled led panels that exists in
MSI GT683R laptop
Signed-off-by: Janne Kanniainen janne.kanniai...@gmail.com
Reviewed-by: Johan Hovold jo...@kernel.org
Thanks, Janne!
Now applied. Thanks Janne for the
