Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dmitry Torokhov
On Tue, Jul 28, 2015 at 10:13:54PM -0500, Rob Herring wrote: On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek marek.beli...@gmail.com wrote: Hi Dmitry, On Thu, Jul 23, 2015 at 10:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Jul 23, 2015 at 10:38:34PM +0200, Marek

Re: [PATCH 0/4] Input: Merge max77843 haptic driver into max77693

2015-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2015 at 03:31:26PM +0900, Krzysztof Kozlowski wrote: Hi, Description === The Maxim 77843 haptic driver differs from 77693 by: 1. Setting the bias. 2. Different configuration register. 3. Not enabling the low-sys DAC. 4. Using same regmap for PMIC and haptic

Re: [PATCH] Input: zforce - make the interrupt GPIO optional

2015-07-29 Thread Dmitry Torokhov
On Tue, Jul 28, 2015 at 11:43:20PM +0200, Heiko Stübner wrote: Hi, it's nice to see that my driver seems to be used somewhere :-) Am Dienstag, 28. Juli 2015, 14:06:21 schrieb Dmitry Torokhov: On Tue, Jul 28, 2015 at 10:26:48AM +0200, Dirk Behme wrote: Add support for hardware which

Re: [PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2015 at 04:45:26PM -0400, cp...@redhat.com wrote: From: Stephen Chandler Paul cp...@redhat.com The data concerning which buttons on the touchpad are held down or not are in the fourth packet we receive from the mouse, not the first. Signed-off-by: Stephen Chandler Paul

[PATCH 1/1] Input - alps: Fix button reporting on the V2 Alps protocol

2015-07-29 Thread cpaul
From: Stephen Chandler Paul cp...@redhat.com The data concerning which buttons on the touchpad are held down or not are in the fourth packet we receive from the mouse, not the first. Signed-off-by: Stephen Chandler Paul cp...@redhat.com --- drivers/input/mouse/alps.c | 6 +++--- 1 file changed,

[PATCH 0/1] Alps button reporting bugfix

2015-07-29 Thread cpaul
From: Stephen Chandler Paul cp...@redhat.com Hi! This was a perfect test case for ps2emu. I managed to reproduce the issue you were having perfectly, and I'm pretty sure I've debugged the issue and written a patch to fix it. Would you mind applying the next patch I'll be sending to a clean build

[PATCH] Input: xpad - Fix double URB submission races

2015-07-29 Thread Laura Abbott
The xpad driver has several races with respect to URB submission which make it easy to end up with submission while active: [ cut here ] WARNING: CPU: 3 PID: 3563 at drivers/usb/core/urb.c:339 usb_submit_urb+0x2ad/0x5a0() URB 8804078ac240 submitted while active Modules

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2015 at 03:07:04PM +0200, Jiri Kosina wrote: On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote: During unbinding the driver was dereferencing a pointer to memory already freed by power_supply_unregister(). Driver was freeing its internal description of battery through

Re: [PATCH] Input: zforce - make the interrupt GPIO optional

2015-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2015 at 08:17:10PM +0200, Heiko Stübner wrote: Hi Dmitry, Am Mittwoch, 29. Juli 2015, 10:53:04 schrieb Dmitry Torokhov: On Tue, Jul 28, 2015 at 11:43:20PM +0200, Heiko Stübner wrote: [snip] @@ -510,7 +511,18 @@ static irqreturn_t zforce_irq_thread(int irq, void

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dr. H. Nikolaus Schaller
Am 29.07.2015 um 19:26 schrieb Dmitry Torokhov dmitry.torok...@gmail.com: On Tue, Jul 28, 2015 at 10:13:54PM -0500, Rob Herring wrote: On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek marek.beli...@gmail.com wrote: Hi Dmitry, On Thu, Jul 23, 2015 at 10:53 PM, Dmitry Torokhov

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dmitry Torokhov
On Wed, Jul 29, 2015 at 07:50:24PM +0200, Dr. H. Nikolaus Schaller wrote: Am 29.07.2015 um 19:26 schrieb Dmitry Torokhov dmitry.torok...@gmail.com: On Tue, Jul 28, 2015 at 10:13:54PM -0500, Rob Herring wrote: On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek marek.beli...@gmail.com wrote:

[PATCH v2 1/4] Input: max77693: Remove a read-only pwm_divisor field

2015-07-29 Thread Krzysztof Kozlowski
Storing a predefined PWM divisor in state container structure is meaningless. The field, after initialization, is only read so this only obfuscates the code. Remove the field and use directly enum value. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Dmitry Torokhov

[PATCH v2 4/4] Input: Remove the max77843 haptic driver

2015-07-29 Thread Krzysztof Kozlowski
The max77693 haptic driver supports Maxim 77843 device so remove the max77843 driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/misc/Kconfig | 12 -- drivers/input/misc/Makefile | 1 -

[PATCH v2 2/4] Input: max77693: Prepare for adding support for Maxim 77843

2015-07-29 Thread Krzysztof Kozlowski
Prepare the driver for supporting two devices: Maxim 77693 and 77843: 1. Add table of device ids and store current device type for later usage. 2. Differentiate the haptic device configuration. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Dmitry Torokhov

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-07-29 Thread Dmitry Torokhov
On Thu, Jul 30, 2015 at 08:42:12AM +0900, Krzysztof Kozlowski wrote: 2015-07-30 2:46 GMT+09:00 Dmitry Torokhov dmitry.torok...@gmail.com: On Wed, Jul 29, 2015 at 03:07:04PM +0200, Jiri Kosina wrote: On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote: During unbinding the driver was

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-07-29 Thread Krzysztof Kozlowski
2015-07-30 2:46 GMT+09:00 Dmitry Torokhov dmitry.torok...@gmail.com: On Wed, Jul 29, 2015 at 03:07:04PM +0200, Jiri Kosina wrote: On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote: During unbinding the driver was dereferencing a pointer to memory already freed by power_supply_unregister().

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dr. H. Nikolaus Schaller
Hi Tomi, Am 29.07.2015 um 07:47 schrieb Dr. H. Nikolaus Schaller h...@goldelico.com: Hi all, Am 29.07.2015 um 05:13 schrieb Rob Herring robherri...@gmail.com: On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek marek.beli...@gmail.com wrote: Hi Dmitry, On Thu, Jul 23, 2015 at 10:53 PM,

[PATCH 1/4] Input: max77693: Remove a read-only pwm_divisor field

2015-07-29 Thread Krzysztof Kozlowski
Storing a predefined PWM divisor in state container structure is meaningless. The field, after initialization, is only read so this only obfuscates the code. Remove the field and use directly enum value. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com ---

[PATCH 0/4] Input: Merge max77843 haptic driver into max77693

2015-07-29 Thread Krzysztof Kozlowski
Hi, Description === The Maxim 77843 haptic driver differs from 77693 by: 1. Setting the bias. 2. Different configuration register. 3. Not enabling the low-sys DAC. 4. Using same regmap for PMIC and haptic blocks. The patchset merges max77843 driver into the max77693. Dependencies

[PATCH 3/4] Input: max77693: Add support for Maxim 77843

2015-07-29 Thread Krzysztof Kozlowski
The Maxim 77843 haptic driver differs from 77693 by: 1. Setting the bias. 2. Different configuration register. 3. Not enabling the low-sys DAC. 4. Using same regmap for PMIC and haptic blocks. Incorporate all differences into max77693 haptic driver so both devices can be supported.

[PATCH 2/4] Input: max77693: Prepare for adding support for Maxim 77843

2015-07-29 Thread Krzysztof Kozlowski
Prepare the driver for supporting two devices: Maxim 77693 and 77843: 1. Add table of device ids and store current device type for later usage. 2. Differentiate the haptic device configuration. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/input/misc/max77693-haptic.c

[PATCH 4/4] Input: Remove the max77843 haptic driver

2015-07-29 Thread Krzysztof Kozlowski
The max77693 haptic driver supports Maxim 77843 device so remove the max77843 driver. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com --- drivers/input/misc/Kconfig | 12 -- drivers/input/misc/Makefile | 1 - drivers/input/misc/max77843-haptic.c | 359

Re: [PATCH 4/4] Input: Remove the max77843 haptic driver

2015-07-29 Thread Krzysztof Kozlowski
2015-07-29 15:31 GMT+09:00 Krzysztof Kozlowski k.kozlow...@samsung.com: The max77693 haptic driver supports Maxim 77843 device so remove the max77843 driver. Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com Crap, wrong signed-off-by. I'll respin. Best regards, Krzysztof -- To

Re: [patch] HID: uclogic: fix limit in uclogic_tablet_enable()

2015-07-29 Thread Nikolai Kondrashov
On 07/29/2015 01:16 PM, Dan Carpenter wrote: The limit should be ARRAY_SIZE(params) (5 elements) here instead of sizeof(params) (20 bytes). Fixes: 08177f40bd00 ('HID: uclogic: merge hid-huion driver in hid-uclogic') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

May close() return any error code?

2015-07-29 Thread Takashi Iwai
Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices returns ENODEV error. The logind in systemd-210 treats this error code as fatal,

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Wei Liu
On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -314,7 +314,7 @@ static

Re: [PATCH 0/8] Use correctly the Xen memory terminologies in Linux

2015-07-29 Thread Julien Grall
On 28/07/15 16:02, Julien Grall wrote: Hi all, This patch series aims to use the memory terminologies described in include/linux/mm.h [1] for Linux xen code. I mistakenly wrote the wrong include here. It should be include/xen/mm.h from the Xen tree:

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Chris, On 28/07/15 20:39, Chris (Christopher) Brand wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some Typo : brought Perhaps resulted in would be better ?

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Wei Liu
On Wed, Jul 29, 2015 at 12:35:54PM +0100, Julien Grall wrote: Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3

Re: [PATCH v2] Input: Add generic driver for Zeitec touchscreens

2015-07-29 Thread Bogdan George Stefan
Dimitry, Please let me know if there is anything I can provide for this driver. Thank you, Bogdan On Thu, Jun 18, 2015 at 11:39 AM, Bogdan George Stefan bogdan.george.ste...@gmail.com wrote: Dimitry, You can control how many fingers work on a device via the firmware that you load. I've

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 --- a/drivers/net/xen-netback/netback.c +++

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread David Vrabel
On 29/07/15 12:35, Julien Grall wrote: Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3 100644 ---

[patch] HID: uclogic: fix limit in uclogic_tablet_enable()

2015-07-29 Thread Dan Carpenter
The limit should be ARRAY_SIZE(params) (5 elements) here instead of sizeof(params) (20 bytes). Fixes: 08177f40bd00 ('HID: uclogic: merge hid-huion driver in hid-uclogic') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/hid/hid-uclogic.c b/drivers/hid/hid-uclogic.c

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
On 28/07/15 18:16, David Vrabel wrote: On 28/07/15 16:02, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This brough some misimplementation of helpers on ARM and make the

Re: Potential data race in psmouse_interrupt

2015-07-29 Thread Pali Rohár
Hi! This log looks like there can be race condition in initialization code, but not in receiving ALPS packets after initialization... On Thursday 23 July 2015 15:31:46 Andrey Konovalov wrote: Hi Pali, There are a few reports in psmouse-base.c/alps.c code as well. Here is a couple of them

Re: [PATCH] HID: hid-sony: Fix DS4 controller reporting rate issues

2015-07-29 Thread Jiri Kosina
On Tue, 28 Jul 2015, Rostislav Pehlivanov wrote: This commit removes the cap on the DualShock 4 controller reporting rate when connected using Bluetooth. The previous value of '0xB0' capped the rate to only 20.83 Hz which many userspace utilities mistook as a sign of a bad signal. Since a

Re: [patch] HID: uclogic: fix limit in uclogic_tablet_enable()

2015-07-29 Thread Jiri Kosina
On Wed, 29 Jul 2015, Nikolai Kondrashov wrote: On 07/29/2015 01:16 PM, Dan Carpenter wrote: The limit should be ARRAY_SIZE(params) (5 elements) here instead of sizeof(params) (20 bytes). Fixes: 08177f40bd00 ('HID: uclogic: merge hid-huion driver in hid-uclogic') Signed-off-by: Dan

Re: [PATCH] HID: hid-input: Fix accessing freed memory during driver unbind

2015-07-29 Thread Jiri Kosina
On Tue, 28 Jul 2015, Krzysztof Kozlowski wrote: During unbinding the driver was dereferencing a pointer to memory already freed by power_supply_unregister(). Driver was freeing its internal description of battery through pointers stored in power_supply structure. However, because the core

Re: [PATCH 0/4] Input: Merge max77843 haptic driver into max77693

2015-07-29 Thread Krzysztof Kozlowski
2015-07-30 2:08 GMT+09:00 Dmitry Torokhov dmitry.torok...@gmail.com: On Wed, Jul 29, 2015 at 03:31:26PM +0900, Krzysztof Kozlowski wrote: Hi, Description === The Maxim 77843 haptic driver differs from 77693 by: 1. Setting the bias. 2. Different configuration register. 3. Not

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Boris Ostrovsky
On 07/29/2015 10:23 AM, Julien Grall wrote: On 29/07/15 15:14, Boris Ostrovsky wrote: static inline unsigned long pfn_to_gfn(unsigned long pfn) { if (xen_feature(XENFEAT_autotranslated_physmap)) return pfn; else return pfn_to_mfn(pfn); } But you'd still say

Re: [PATCH] HID: hid-sony: Fix DS4 controller reporting rate issues

2015-07-29 Thread Frank Praznik
On 7/29/2015 08:19, Jiri Kosina wrote: On Tue, 28 Jul 2015, Rostislav Pehlivanov wrote: This commit removes the cap on the DualShock 4 controller reporting rate when connected using Bluetooth. The previous value of '0xB0' capped the rate to only 20.83 Hz which many userspace utilities

Re: May close() return any error code?

2015-07-29 Thread Dmitry Torokhov
HI Takashi, On Wed, Jul 29, 2015 at 12:46:59PM +0200, Takashi Iwai wrote: Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Boris Ostrovsky
On 07/29/2015 07:25 AM, Julien Grall wrote: Hi Boris, On 28/07/15 20:12, Boris Ostrovsky wrote: On 07/28/2015 11:02 AM, Julien Grall wrote: Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN is meant, I suspect this is because the first support for Xen was for PV. This

Re: [PATCH] HID: hid-lg: Add USBID for Logitech G29 Wheel

2015-07-29 Thread Jiri Kosina
On Thu, 23 Jul 2015, Simon Wood wrote: Since this wheel is now available, and the USBID is listed on their website, this patch adds it to allow the hid-lg4ff force feedback driver to find it. I do not have this wheel to test with, but this should at least get it working in emulation mode.

Re: [PATCH acer-switch12-keyboard] hid core: Enable support for Fn+ controls keys on Acer Aspire Switch 12 keyboard

2015-07-29 Thread Jiri Kosina
On Tue, 21 Jul 2015, Николай Кудрявцев wrote: Acer Aspire Switch 12 keyboard Chicony's controller reports too big usage index on the 1st interface. The patch fixes the report. The work based on solution from drivers/hid/hid-holtek-mouse.c Bug report:

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

2015-07-29 Thread Julien Grall
On 29/07/15 15:14, Boris Ostrovsky wrote: static inline unsigned long pfn_to_gfn(unsigned long pfn) { if (xen_feature(XENFEAT_autotranslated_physmap)) return pfn; else return pfn_to_mfn(pfn); } But you'd still say 'op.arg1.mfn = pfn_to_gfn(pfn);' in xen_do_pin()