Re: [GIT PULL] HID

2014-08-22 Thread Jiri Kosina
+ - DJ_DEVICE_INDEX_MIN]; + DJ_DEVICE_INDEX_MIN + 1]; struct work_struct work; struct kfifo notif_fifo; spinlock_t lock; -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

[PATCH] HID: logitech: fix bounds checking on LED report size

2014-08-21 Thread Jiri Kosina
this properly at all. Fix the check by actually trimming down the report size properly if it is too large. Cc: sta...@vger.kernel.org Reported-by: Ben Hawkes haw...@google.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-logitech

[PATCH] HID: logitech: perform bounds checking on device_id early enough

2014-08-21 Thread Jiri Kosina
...@google.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-logitech-dj.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index

Re: USB reset xhci_hcd for ELAN touchscreen

2014-08-21 Thread Jiri Kosina
, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB reset xhci_hcd for ELAN touchscreen

2014-08-20 Thread Jiri Kosina
for the quirk ... how about something like HID_QUIRK_EARLY_INTERRUPT? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface

2014-08-15 Thread Jiri Kosina
properties not found!\n); - return 0; + return -EINVAL; } Queued for 3.17, thanks Simon. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] HID: rmi: print an error if F11 is not found instead of stopping the device

2014-08-14 Thread Jiri Kosina
firmware on the touchpad. + */ + hid_err(hdev, Device failed to be properly configured\n); Queued for 3.17 still. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCHES] HID: huion: Fix doing dma on the stack

2014-08-12 Thread Jiri Kosina
(-w). Both patches were tested by me with a Huion H610N tablet. Nick Nikolai, thanks, I will be reviewing the patches soon and queuing for 3.17 still eventually. They seem to be missing your signoff though ... is that on purpose? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: Retire gamecon?

2014-08-12 Thread Jiri Kosina
). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hyperv: register as a wakeup source

2014-08-04 Thread Jiri Kosina
); hid_hw_stop(input_dev-hid_device); hid_destroy_device(input_dev-hid_device); -- 1.9.1 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] HID: rmi: add additional checks for the existence of optional queries in order to compute the address of Query 12.

2014-07-29 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHES v2] Add support for more Huion tablets

2014-07-29 Thread Jiri Kosina
series is still: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Queuing for 3.17, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] HID: rmi: check that report ids exist in the report_id_hash before accessing their size

2014-07-29 Thread Jiri Kosina
happen it should return an error from probe instead of dereferencing a null pointer. related bug: https://bugzilla.kernel.org/show_bug.cgi?id=80091 Signed-off-by: Andrew Duggan adug...@synaptics.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] HID: rmi: only bind the hid-rmi driver to the mouse interface of composite USB devices

2014-07-29 Thread Jiri Kosina
Signed-off-by: Andrew Duggan adug...@synaptics.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] HID: cp2112: add I2C mode

2014-07-29 Thread Jiri Kosina
benjamin.tissoi...@redhat.com --- ChangeLog v1-v2: - In cp2112_i2c_xfer() set variable ret directly with the expected return value: either an error number or the number of transferred messages. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: Trouble with an HP stylus

2014-07-29 Thread Jiri Kosina
, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_WP4030U, HID_QUIRK_MULTI_INPUT }, { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_KNA5, HID_QUIRK_MULTI_INPUT }, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH] fix for jabra gn9350e (hid)

2014-07-29 Thread Jiri Kosina
On Sat, 5 Jul 2014, Patrick Plattes wrote: Ignore Jabra GN9350E HID interface. USB audio is working nicely, but registering as HID blocks USB mouse buttons. Since special userspace programs are needed we will avoid attaching usbhid drivers in general. Applied. -- Jiri Kosina SUSE Labs

Re: [PATCH] hid: usbhid: Use flag HID_DISCONNECTED when a usb device is removed

2014-07-29 Thread Jiri Kosina
Attiyat reyad.atti...@gmail.com I've included the full oops output into the changelog and applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: PATCH change for HID_BATTERY_STRENGTH kconfig

2014-07-29 Thread Jiri Kosina
On Mon, 23 Jun 2014, Daniel Nicoletti wrote: 2013-05-23 19:16 GMT-03:00 Jiri Kosina jkos...@suse.cz: On Mon, 13 May 2013, Daniel Nicoletti wrote: Hi, I'd like to propose this patch while removes the need for hid to be compiled build-in, as this is the same behavior that WiiMote

Re: [PATCH 00/12] HID: Convert UHID to new HID transport-layer

2014-07-29 Thread Jiri Kosina
-sample.c build and it still works, so I think I didn't break backwards-compatibility. I will definitely take a look, but I can't promise I will be able to finish a review in time for 3.17. If you find this a severe issue, please let me know. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] HID: cp2112: fix gpio value in gpio_direction_output

2014-07-07 Thread Jiri Kosina
of cp2112_gpio_direction_output(). In both case, this is: Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com I am queuing this for 3.17, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-07-02 Thread Jiri Kosina
that it wouldn't be contained in the for-linus merge window pile. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hid-appleir: Fix kernel panic due to null pointer

2014-07-01 Thread Jiri Kosina
is an array, and you want to count its elements. Third time is the charm perhaps? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2] hid-appleir: Fix kernel panic due to null pointer

2014-07-01 Thread Jiri Kosina
[ARRAY_SIZE(appleir_key_table)]; It's not really equivalent. ARRAY_SIZE counts the number of short-sized elements, sizeof() counts the number of bytes that fit into the data structure (which is twice as much, as sizeof(unsigned short) == 2). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH 1/1] drivers/hid/hid-picolcd_debugfs.c: remove unnecessary NULL test before debugfs_remove

2014-06-30 Thread Jiri Kosina
On Sat, 28 Jun 2014, Fabian Frederick wrote: Fix checkpatch warning: WARNING: debugfs_remove(NULL) is safe this check is probably not required Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/hid/hid

Re: [PATCH 1/1] hid: sensor-hub, fix potential memory leak

2014-06-30 Thread Jiri Kosina
, as this is the only place where this is (and will) be needed. Reported-by: coverity Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: srinivas pandruvada srinivas.pandruv...@intel.com Cc: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-sensor-hub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Jiri Kosina
queued it (please preserve my Signoff from my tree), then I will just not include for-3.17/hid-gt683r branch in pull request to Linus and all is fine. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] Fixes kernel panic with Null pointer in hid-appleir.c

2014-06-30 Thread Jiri Kosina
? input_dev-keycodemax is int, not array. I think you actually want sizeof(appleir-keymap) there. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 00/13] leds: fix attribute-creation races

2014-06-27 Thread Jiri Kosina
to me as well, thanks. The lm8323 change should be Acked by Dmitry though, as it's in his area. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] HID: usbhid: quirk for PM1610 and PM1640 Touchscreen.

2014-06-27 Thread Jiri Kosina
On Fri, 27 Jun 2014, John Sung wrote: These device needs to be added to the quirks list with HID_QUIRK_NOGET, otherwise they will reset upon receiving the get input report requests. Signed-off-by: John Sung penmount.to...@gmail.com Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: roccat: Drop cast

2014-06-26 Thread Jiri Kosina
, command, (void *)buf, real_size); + retval = roccat_common2_send(usb_dev, command, buf, real_size); mutex_unlock(lua-lua_lock); Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

[PATCH] Input: Add Acer Aspire 5710 to nomux blacklist

2014-06-25 Thread Jiri Kosina
Acer Aspire needs to be added to nomux blacklist, otherwise the touchpad misbehaves rather randomly. Signed-off-by: Jiri Kosina jkos...@suse.cz --- Hi Dmitry, I've come across this a few year old patch originating from our internal bugzilla, which was apparently been lost between the cracks

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-25 Thread Jiri Kosina
this. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] HID: sony: Some cleanups

2014-06-25 Thread Jiri Kosina
On Tue, 24 Jun 2014, Antonio Ospite wrote: here are some cleanups for hid-sony. Good stuff. I have queued it for 3.17. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: bad handling of HID input reports for a Delcom foot pedal

2014-06-18 Thread Jiri Kosina
specific input event quirk for this? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v9] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-18 Thread Jiri Kosina
for the driver, and thanks a lot Johan for a very careful review, I really appreciate it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 2/2] Add support for Compact (Bluetooth|USB) keyboard with Trackpoint

2014-06-13 Thread Jiri Kosina
are not risking introducing regression for people who'd have put parameter settings in modprobe.conf or some such. So please go ahead with the rename. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH] HID: rmi: Protect PM-only functions by #ifdef CONFIG_PM

2014-06-12 Thread Jiri Kosina
*/ #define RMI4_MAX_PAGE 0xff #define RMI4_PAGE_SIZE 0x0100 Applied, thanks for spotting it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] HID: drop remove Unicode non-breaking space from Kconfig

2014-06-11 Thread Jiri Kosina
Norris computersforpe...@gmail.com Cc: Jiri Kosina jkos...@suse.cz Cc: linux-input@vger.kernel.org --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 800c8b60f7a2..08c9693e6f83 100644 --- a/drivers/hid

Re: [PATCH] drivers: Kconfig: Add HAS_IOMEM dependency for allmodconfig under score architecture

2014-06-11 Thread Jiri Kosina
^ Oh, sorry, this line above need be removed, it is not for this patch, if still necessary to send patch v2 for it, please let me know, thanks. I have fixed it up (together with adding a proper subject) and applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH v2 0/2] Add support for Lenovo Compact Keyboard

2014-06-11 Thread Jiri Kosina
On Tue, 10 Jun 2014, Jamie Lentin wrote: This patchset follows on from my previous attempt[1] to add support for these keyboards from Lenovo. Jamie, thanks for the driver. Please re-send v3 with Antonio's comments addressed, and I'll be happy to apply it. -- Jiri Kosina SUSE Labs

Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

2014-06-11 Thread Jiri Kosina
be glad to put your Reviewed-by: to the commit before commiting it, if you are going to provide it. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] HID: usbhid: remove unneeded initialization of quirks_param[]

2014-06-10 Thread Jiri Kosina
, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: input - Add two new usages for digitizer

2014-06-03 Thread Jiri Kosina
removes outdated comments in hid.h. Signed-off-by: Ping Cheng pi...@wacom.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: hid-sensor-hub: Set report quirk for Microsoft Surface

2014-05-28 Thread Jiri Kosina
, HID_ANY_ID) }, { } [ Benjamin added to CC] How does this combine with f3b0cbce01 and e24d0d399b2f in Linus' tree? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCHv2] HID: Debug: Add labels for HID Sensor Usages

2014-05-28 Thread Jiri Kosina
On Tue, 27 May 2014, Reyad Attiyat wrote: Add in debugfs report descriptor labels for HID Sensor Usages. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] HID: Debug: Add labels for HID Sensor Usages

2014-05-26 Thread Jiri Kosina
as the HID maintainer - unless he specifically asked not to be). I definitely want (and need) to be CCed on such patches, thanks for letting me know, Jonathan. Reyad, please add you signoff as Jonathan said, and resend the patch properly to me. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH v2] HID: rmi: do not handle touchscreens through hid-rmi

2014-05-22 Thread Jiri Kosina
to hid-multitouch, and which should not go to hid-rmi. related bug: https://bugzilla.kernel.org/show_bug.cgi?id=74241 https://bugzilla.redhat.com/show_bug.cgi?id=1089583 Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi

2014-05-20 Thread Jiri Kosina
to hid_have_special_driver[] is very confusing. If you could update this to be RMI-specific (i.e. create a special HID_GROUP for RMI devices), I'll merge it right away. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH] HID: core: fix validation of report id 0

2014-05-20 Thread Jiri Kosina
On Mon, 19 May 2014, Kees Cook wrote: Pinging on this patch... I don't see it in -next yet. I've had more reports of trouble with logitech devices, and this seems to solve the problem. Apologizes for this taking so long time. I have now queued your patch. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: quirk for Saitek RAT7 and MMO7 mices' mode button

2014-05-20 Thread Jiri Kosina
will work correctly. Please respin the patch with this change and resubmit. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Add VID/PID for HID-type Multi-Touch Module of AFO CO., LTD.

2014-05-20 Thread Jiri Kosina
) }, + { HID_USB_DEVICE(USB_VENDOR_ID_AFO, USB_DEVICE_ID_AFO_THM) }, Is this really necessary? Why doesn't HID_DG_CONTACTID matching work for the to automatically trigger HID_GROUP_MULTITOUCH-based binding? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-05-20 Thread Jiri Kosina
-lenovo-tpkbd driver. Could you please do that and resubmit? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-05-20 Thread Jiri Kosina
support for both. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] HID: quirk for Saitek RAT7 and MMO7 mices' mode button

2014-05-20 Thread Jiri Kosina
a quirk for the R.A.T.7 and M.M.O.7, tracking the mode and generating presses of a single button if it changes. Also the missing release event is generated instantly. Signed-off-by: Harald Brinkmann hbrinkm...@braincalibration.de Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] HID: rmi: fix masks for x and w_x data

2014-05-16 Thread Jiri Kosina
data. Signed-off-by: Andrew Duggan adug...@synaptics.com --- Good catch. I might have considered that 3:0 means 3 bits, not 4. I must have been tired while writing it :) Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs

RE: [PATCH] HID: i2c-hid: hid report descriptor retrieval changes

2014-05-13 Thread Jiri Kosina
On Mon, 12 May 2014, Patni, Archana wrote: The reason I am asking is whether I should rush this in for 3.15 still, but as the patch doesn't have stable annotation anyway, my understanding is that 3.16 is enough? 3.16 is fine. Queued for 3.16, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH v2] HID: rmi: check for the existence of some optional queries before reading query 12

2014-05-13 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: rmi: do not fetch more than 16 bytes in a query

2014-05-13 Thread Jiri Kosina
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: rmi: fix duplicated argument to or ||

2014-05-13 Thread Jiri Kosina
seeing Dan's email. Thanks, good catch! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless

2014-05-12 Thread Jiri Kosina
done as an extension to ff-memless? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: core: fix computation of the report size

2014-05-05 Thread Jiri Kosina
! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid-quirks: Add NO_INIT_REPORTS quirk for Synaptics Touch Pad V 103S

2014-05-05 Thread Jiri Kosina
, HID_QUIRK_NO_INIT_REPORTS }, { 0, 0 } }; Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas

2014-05-05 Thread Jiri Kosina
formatting issues.) Signed-off-by: Peter F. Patel-Schneider pfpschnei...@gmail.com Now applied. Will be pushing it for 3.15. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] HID: multitouch: add support of EliteGroup 05D8 panels

2014-04-24 Thread Jiri Kosina
Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] HID: add missing hid usages

2014-04-24 Thread Jiri Kosina
#define BTN_TRIGGER_HAPPY2 0x2c1 -- 1.9.0 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/7] HID: sony: More Sony controller fixes and improvements.

2014-04-24 Thread Jiri Kosina
On Mon, 14 Apr 2014, Frank Praznik wrote: v5 has the following changes: I finally managed to review this patchset. Now queued for 3.16, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [RESEND PATCH] hid: Add custom driver for Lenovo ThinkPad Compact Bluetooth Keyboard

2014-04-17 Thread Jiri Kosina
don't think there's anything massively contentious, but hasn't been picked up by anyone yet. I've been buried in a lot of other things (travel, merge window, etc.), so this is still sitting in my queue that has to be processed (and hasn't been forgotten). -- Jiri Kosina SUSE Labs

Re: HID vendor access from user space

2014-04-16 Thread Jiri Kosina
existing in parallel, right? Who will be deciding what goes to hidcolX instead of hidrawX? One of the pain points would be -- /dev/hidrawX will have to stay anyway for compatibility reasons, so we can't just divide it to multiple /dev/hidcolX all of a sudden and never look back. -- Jiri Kosina SUSE

Re: HID vendor access from user space

2014-04-15 Thread Jiri Kosina
was simply 'no parsing, raw access'. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] HID: (thingm) introduces blink(1) mk2

2014-04-15 Thread Jiri Kosina
On Mon, 14 Apr 2014, Vivien Didelot wrote: This patchset introduces the support of the blink(1) mk2 device, after a refactoring of the thingm driver. It removes non-standard sysfs attributes and uses work queues to fix the usage of triggers with this device. Queued for 3.16. Thanks, -- Jiri

Re: [PATCH] HID: lg2ff: add rumble magnitude clamping quirk

2014-04-09 Thread Jiri Kosina
On Wed, 9 Apr 2014, Elias Vanderstuyft wrote: Since this patch haven't been applied yet, I withdraw this patch for the following reason: It will get in as a part of the move to ff-memless-next. Okay, I am ignoring it for now. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH] HID: add missing hid usages

2014-04-07 Thread Jiri Kosina
to Maximum */ +#define KEY_BRIGHTNESS_AUTO 0x254 /* Set Auto Brightness */ + #define BTN_TRIGGER_HAPPY0x2c0 #define BTN_TRIGGER_HAPPY1 0x2c0 #define BTN_TRIGGER_HAPPY2 0x2c1 -- 1.9.0 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH 0/2] Microsoft Surface Type/Touch Cover 2 fixes

2014-04-07 Thread Jiri Kosina
still. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/7] HID: sony: Fix cancel_work_sync mismerge

2014-04-03 Thread Jiri Kosina
On Wed, 2 Apr 2014, Frank Praznik wrote: Remove redundant cancel_work_sync() call caused by mismerge. Signed-off-by: Frank Praznik frank.praz...@oh.rr.com Queued for 3.15, thanks for spotting it, Frank. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: HID vendor access from user space

2014-04-03 Thread Jiri Kosina
not sure how much concerned you are about such scenario anyway. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add sensor hub quirk for ThinkPad Helix

2014-04-03 Thread Jiri Kosina
as usual, but they won't output any data. This will also fix the sensors on any other laptops with the same model of sensor hub. Signed-off-by: Stephen Chandler Paul thatsly...@gmail.com Queued for 3.15, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 0/7] HID: sony: More Sony controller fixes and improvements.

2014-04-02 Thread Jiri Kosina
is closed. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] HID: uhid: Add UHID_CREATE2 + UHID_INPUT2

2014-04-01 Thread Jiri Kosina
() API changes and pushed it out. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] HID: Stop hiding options with !EXPERT

2014-03-28 Thread Jiri Kosina
by Linus. That's the history. Now, admittedly, it was quite some time ago, and HID world has matured a lot since then, so the 'quirks' turned out into proper drivers. So maybe there indeed might be a good time to try it again. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

RE: [PATCH] Add VID/PID for HID-type Multi-Touch Module of AFO CO., LTD.

2014-03-28 Thread Jiri Kosina
+1,52 @@ -BEGIN PRIVATE KEY- Again, I don't think you want to be sending this out :) Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] Add VID/PID for HID-type Multi-Touch Module of AFO CO., LTD.

2014-03-25 Thread Jiri Kosina
PRIVATE KEY- I doubt this was intended. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-sensor-hub: fix sleeping function called from invalid context

2014-03-25 Thread Jiri Kosina
[ 1067.021997] [816f4cb7] i2c_hid_request+0x57/0x110 [ 1067.022006] [a02bc61c] sensor_hub_input_attr_get_raw_value+0xbc/0x100 [hid_sensor_hub] Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: uhid: Add UHID_CREATE2 + UHID_INPUT2

2014-03-24 Thread Jiri Kosina
On Sun, 23 Mar 2014, David Herrmann wrote: [ ... snip ... ] Patch looks fine. If you fix the minor issues, this is: Reviewed-by: David Herrmann dh.herrm...@gmail.com And please always put Jiri on CC for all HID patches: Jiri Kosina jkos...@suse.cz Indeed, that helps. Petri, could you

Re: [PATCH] HID: multitouch: add support for Win 8.1 multitouch touchpads

2014-03-20 Thread Jiri Kosina
for touchpads. Signed-off-by: Andrew Duggan adug...@synaptics.com Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] hid: fix bug destroying hidraw device files after parent

2014-03-17 Thread Jiri Kosina
rc. It will be in Linus' 3.14 final -- it went in post-rc7. Thanks for taking care, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v3 0/4] HID: ll transport cleanup: final round

2014-03-14 Thread Jiri Kosina
. Now queued in for-3.15/hid-core-ll-transport-cleanup. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/8] HID: sony: More Sony controller fixes and improvements.

2014-03-14 Thread Jiri Kosina
things clear -- I am waiting for v3 due to baddr changes planned for 6/8. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: hid-lg4ff: Support new version of G27

2014-03-14 Thread Jiri Kosina
, DFP_REV_MIN, native_dfp}, /* Driving Force Pro */ {G25_REV_MAJ, G25_REV_MIN, native_g25}, /* G25 */ {G27_REV_MAJ, G27_REV_MIN, native_g27}, /* G27 */ + {G27_REV_MAJ, G27_2_REV_MIN, native_g27},/* G27 v2 */ }; Applied, thanks. -- Jiri Kosina SUSE Labs

Re: [PATCH 1/2] Revert HID: microsoft: Add ID's for Surface Type/Touch, Cover 2

2014-03-11 Thread Jiri Kosina
), so that I can queue them? Thanks! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] input synaptics-rmi4: rmi_driver.c storage fix

2014-03-05 Thread Jiri Kosina
On Tue, 4 Mar 2014, Christopher Heiny wrote: Do not use kfree() on storage allocated with devm_kfree(), I believe you meant devm_kmalloc() here. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 0/3] HID: multitouch cleanups and support for fancy devices

2014-03-05 Thread Jiri Kosina
-- so please send any followup patches / comments on top of for-3.15/multitouch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/4] HID: cp2112: remove the last hid_output_raw_report() call

2014-03-04 Thread Jiri Kosina
fine, I'll wait for the whole v2 respin. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: fix bug destroying hidraw device files after parent

2014-02-26 Thread Jiri Kosina
+0xca/0x210 [8107fe17] ? task_work_run+0x97/0xd0 [810139a9] ? do_notify_resume+0x69/0xa0 [814dbd22] ? int_signal+0x12/0x17 Applied, thanks. I have slightly modified the patch title to make sure that it's obvious that what it fixes is actually a WARN_ON() splat. -- Jiri

Re: [PATCH 0/3] HID: low level transport cleanup, series 3

2014-02-24 Thread Jiri Kosina
merge after these 3... We are approaching the end! Good stuff, thanks Benjamin. Queued for 3.15. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 0/5] HID: sony: Various fixes and improvements for the Sony driver

2014-02-24 Thread Jiri Kosina
in the Sixaxis battery code and adds a note in hidp/core.c that a device module now depends on the current behavior of the uniq string. Queued in for-3.15/sony, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

[PATCH] HID: cp2112: fix incorrect error propagation in cp2112_xfer()

2014-02-18 Thread Jiri Kosina
Both cp2112_read_req() and cp2112_write_req() are returning negative value in cases of error, but cp2112_xfer() is storing the return value into unsigned size_t-typed 'count'. Fix this by making 'count' signed type. Reported-by: fengguang...@intel.com Signed-off-by: Jiri Kosina jkos...@suse.cz

Re: [PATCH v2 7/9] HID: remove hid_get_raw_report in struct hid_device

2014-02-17 Thread Jiri Kosina
of this that completely removes uhid_hid_get_raw(), as it's unused now. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/6] HID: sony: Add full Bluetooth support for the Dualshock 4

2014-02-17 Thread Jiri Kosina
-by: David Herrmann dh.herrm...@gmail.com I finally made it to reviewing this lot. Now applied, thanks everybody. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 0/9] HID: spring cleanup v2

2014-02-17 Thread Jiri Kosina
of hid_output_report (2/9) - add documentation - I removed the hid_input_event() doc (9/9) Good job, thanks! Now applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

<    1   2   3   4   5   6   7   8   9   10   >