Re: [PATCH] HID: hidraw: fix nonblock read return EAGAIN after device removed

2012-11-26 Thread Jiri Kosina
line-wrapped the patch, please resend so Jiri can apply it. For some reason, the patch has been sent to me twice, once it has been fine and the second time it has been line wrapped. I have now applied the non-broken version. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard

2012-11-26 Thread Jiri Kosina
APPLE_ALU_WIRELESS_* keyboards should be added as well. I think it's likely true, but I prefer to have it actually tested before doing such changes blindly. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 1/2] hid: usbhid: Return -ENOMEM instead of -1 for memory allocation failure

2012-11-26 Thread Jiri Kosina
it... If someone takes time to convert to proper return codes I think it would be a good thing. Fully agree with you. But I'd like to have both sides changed together once someone starts taking care of fixing it. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH 1/2] hid: usbhid: Return -ENOMEM instead of -1 for memory allocation failure

2012-11-22 Thread Jiri Kosina
useful with that return value. But the only check we are performing at callsites is non-zero test ... Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/2] hid: hid-sensor-hub: Move NULL check to beginning

2012-11-22 Thread Jiri Kosina
On Wed, 21 Nov 2012, Srinivas Pandruvada wrote: Please check and merge Alan Cox's patch. I have forwarded this patch to you. I have already applied the patch to my tree. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH 2/2] input: usb: hid: Add quirk for Freescale i.MX28 ROM recovery

2012-11-22 Thread Jiri Kosina
possibly include these changes into -stable releases too ? I'm not exactly sure how it works for linux-input, they might be applied already, if that's the case, sorry for the noise. I have just submitted it for stable, thanks for the reminder. -- Jiri Kosina SUSE Labs -- To unsubscribe from

[PATCH] HID: i2c-hid: fix memory leak during probe

2012-11-20 Thread Jiri Kosina
In case we are returning from i2c_hid_probe() through the 'err' or err_mem_free labels, there is noone freeing the buffers allocated by i2c_hid_alloc_buffers(). Signed-off-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/i2c-hid/i2c-hid.c |1 + 1 files changed, 1 insertions(+), 0 deletions

Re: [PATCH 11/14] HID: hiddev: Remove redundant check on unsigned variable

2012-11-16 Thread Jiri Kosina
On Fri, 16 Nov 2012, Tushar Behera wrote: No need to check whether unsigned variable is less than 0. CC: Jiri Kosina jkos...@suse.cz CC: linux-...@vger.kernel.org CC: linux-input@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/hid/usbhid/hiddev.c |2

Re: HID-generic + HID-ANOTHER interaction problems

2012-11-16 Thread Jiri Kosina
. There are already a lot of udev rules for this you can use for inspiration -- in recent udev releases they are located in /lib/udev/rules.d/keymaps, and are handled by master /lib/udev/rules.d/*keymap* rule. Hope this helps, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: HID-generic + HID-ANOTHER interaction problems

2012-11-16 Thread Jiri Kosina
to udev maintainers instead. Does that work for you? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 00/14] Win 8 support for digitizers

2012-11-15 Thread Jiri Kosina
patch looks good now, me thinks. Thanks! I have now applied everything (with all the gathered Acks/Reviewed-by incorporated) but the patch #14. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: usbhid: add quirk HID_QUIRK_NOGET to TPV optical touchscreen

2012-11-15 Thread Jiri Kosina
Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-11-15 Thread Jiri Kosina
-- has this been tested on a real device (is there any such device available anyway?), or is that just the implementation of the defined protocol? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH] HID: microsoft, do not use compound literal

2012-11-12 Thread Jiri Kosina
linux/string.h was not indirectly included. Still the patch needs string.h include addition, otherwise you still are able to come up with m68k config that doesn't build, do I understand it correctly? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 0/7] HID: roccat: Finishing cleanup and reset support

2012-11-12 Thread Jiri Kosina
. Documenting in ABI/obsolete is the best we can get currently, I think. We are more-or-less safe to do that, as the interfaces have been in testing/ and the only documented user is your userspace program. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [RFC] HID: uhid: Handle LED input events

2012-11-12 Thread Jiri Kosina
some comments on that, too. Adding him to CC. Fully agreed, thanks. Andre, I will happily merge the patch if you resend it with the suggested changes applied. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH v3 01/13] HID: hid-input: export hidinput_calc_abs_res

2012-11-12 Thread Jiri Kosina
-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-input.c | 9 - drivers/hid/hid-multitouch.c | 1 + include/linux/hid.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 10248cf..f5b1d57 100644

Re: [PATCH v2] i2c-hid: introduce HID over i2c specification implementation

2012-11-09 Thread Jiri Kosina
the pointers to NULL here. well spotted, thanks. I'll change it in v3 then. Benjamin, just a quick check -- are you planning on submitting v3 eventually? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH] HID: Ignore D-WAV/eGalax devices handled by usbtouchscreen

2012-11-07 Thread Jiri Kosina
USB_DEVICE_ID_DWAV_TOUCHCONTROLLER 0x0002 #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_480D0x480d #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_480E0x480e #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72070x7207 Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH] hid: usbhid: add quirk for SB arena headset v2

2012-11-06 Thread Jiri Kosina
://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1007575 You should be able to obtain it easily either by running evtest on corresponding /dev/input/eventX node, or by looking into debugfs hid/device/events file. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH v2 03/11] HID: hid-input: add usage_index argument in input_mapping and event.

2012-11-06 Thread Jiri Kosina
index. Yes please, I like that solution more as well. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] HID: roccat: New functionalities and cleanup

2012-11-05 Thread Jiri Kosina
the series. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hid: usbhid: add quirk for SB arena headset v2

2012-11-05 Thread Jiri Kosina
, but wouldn't it make more sense to actually remap the bogus keys it's sending to produce KEY_VOLUMEUP and KEY_VOLUMEDOWN? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] hid-apple.c: Set APPLE_ISO_KEYBOARD at USB_DEVICE_ID_APPLE_GEYSER4_HF_ISO

2012-11-03 Thread Jiri Kosina
| APPLE_RDESC_JIS }, Applied, thanks Johannes. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [BUG v3.6.2, 3.7-rc1] Unable to rmmod any hid special driver

2012-11-01 Thread Jiri Kosina
is not working anymore even if you call modprobe. Hmm, I am not sure I understand this explanation, could you please elaborate? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [BUG v3.6.2, 3.7-rc1] Unable to rmmod any hid special driver

2012-11-01 Thread Jiri Kosina
) + if (hidraw-open) { + hid_hw_close(hidraw-hid); wake_up_interruptible(hidraw-wait); + } } else { --hidraw-open; } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [BUG v3.6.2, 3.7-rc1] Unable to rmmod any hid special driver

2012-11-01 Thread Jiri Kosina
On Thu, 1 Nov 2012, Jiri Kosina wrote: Commit 4fe9f8e203fdad1524c04beb390f3c6099781ed9 upstream Commit 57a38d925e665fcd729cd9ad4a75c84e11bd95c9 linux-stable This commit HID: hidraw: don't deallocate memory when it is in use prevents users to rmmod then insmod any hid special driver

Re: [BUG v3.6.2, 3.7-rc1] Unable to rmmod any hid special driver

2012-11-01 Thread Jiri Kosina
- rmmod hid-cypress while hexdump is still running This triggers the warning immediately. Do you have list debugging truned on in your .config? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [BUG v3.6.2, 3.7-rc1] Unable to rmmod any hid special driver

2012-11-01 Thread Jiri Kosina
hid-cypress while hexdump is still running well, with the very same test (except I'm testing against hid-multitouch), the warning doesn't show up on my configuration... Perhaps it happens when the removed hidraw is actually the last one existing in the system? -- Jiri Kosina SUSE Labs

Re: [PATCH] Add support for the MacBook Pro 10,2 keyboard / touchpad

2012-10-31 Thread Jiri Kosina
By pure luck. I'll take your word for it. Here's an updated patch Thanks! Jiri, do you want me to take it through my tree or yours? Thanks everybody. I have now applied it. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Jiri Kosina
. +config HID_ICADE + tristate ION iCade arcade controller + depends on (BT_HIDP) Why the spurious brackets here? Otherwise the patch looks good, thanks (and thanks Benjamin for review), I apply and remove the brackets. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH] HID: fix incorrect handling of devices with high button count

2012-10-31 Thread Jiri Kosina
dmitry.torok...@gmail.com Good catch indeed. Applied, thanks! -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: Add driver for ION iCade

2012-10-31 Thread Jiri Kosina
On Wed, 31 Oct 2012, Bastien Nocera wrote: Probably because whatever I copy/pasted it from had the brackets. I don't see any such occurence in hid/Kconfig. Anyway, not important at all :) Did you make the typos changes in the commit message itself as well? Yup. Thanks, -- Jiri Kosina

Re: [PATCH 1/1] hid:Fix maxcontacts problem on GeneralTouch multi-touchscreen.

2012-10-29 Thread Jiri Kosina
, - .maxcontacts = 10 + MT_QUIRK_SLOT_IS_CONTACTNUMBER }, { .name = MT_CLS_FLATFROG, -- 1.7.9.5 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] hid: put the case in the right switch statement

2012-10-26 Thread Jiri Kosina
maintainers on such patches. Patches tend to often get lost when sent only to mailinglists unfortunately. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] HID: roccat: Added support for Roccat Lua

2012-10-17 Thread Jiri Kosina
On Tue, 16 Oct 2012, Stefan Achatz wrote: This patch adds support for Roccat Lua gaming mouse. Userland tools can soon be found at http://sourceforge.net/projects/roccat Applied, thanks Stefan. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-16 Thread Jiri Kosina
On Wed, 10 Oct 2012, Dmitry Torokhov wrote: Jiri, Are you OK with this change? Yes, please take it through your tree together with the proper driver and add Acked-by: Jiri Kosina jkos...@suse.cz to the HID blacklist additions. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-08 Thread Jiri Kosina
/busses/usb drivers/hid/busses/i2c drivers/hid/busses/bluetooth Something like that, I would personally like. But I am not going to forcefully take it over without bluetooth guys agreeing on that as well. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-06 Thread Jiri Kosina
the bluetooth-related drivers under net/bluetooth, and I didn't really want to push hard against this, because I don't have really super-strong personal preference either way. But we definitely can use this oportunity to bring this up for discussion again. -- Jiri Kosina SUSE Labs

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-06 Thread Jiri Kosina
On Sat, 6 Oct 2012, Jiri Kosina wrote: My vote is a clear 3. It took me a few years to kick all users (as opposed to implementers) of i2c from drivers/i2c and finding them a proper home, I'm not going to accept new intruders. Grouping drivers according to what they implement makes

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-04 Thread Jiri Kosina
this reset in the actual ll driver callback seems to be cleaner. (if I understand the concern here correctly). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4] HID: Add support for Sony PS3 BD Remote Control

2012-10-01 Thread Jiri Kosina
Dillow d...@thedillows.org Signed-off-by: Antonio Ospite osp...@studenti.unina.it Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/1] hid:Fix problem on GeneralTouch multi-touchscreen

2012-10-01 Thread Jiri Kosina
. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] HID: Add support for Sony PS3 BD Remote Control

2012-10-01 Thread Jiri Kosina
On Mon, 1 Oct 2012, Antonio Ospite wrote: Ping. Jiri, I see that linux-3.6 is out, can we have this in for 3.7-rc1? As replied earlier today, it's in my for-next branch and I'll be pushing that for 3.7-rc1. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: HID: picoLCD: optimize for inactive debugfs

2012-10-01 Thread Jiri Kosina
256 /* Avoid unnecessary overhead if debugfs is disabled */ - if (!hdev-debug_events) + if (list_empty(hdev-debug_list)) return; buff = kmalloc(BUFF_SZ, GFP_ATOMIC); Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [GIT PULL] Input and HID updates for 3.7

2012-10-01 Thread Jiri Kosina
, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: picoLCD: Remove use of deprecated function

2012-10-01 Thread Jiri Kosina
to send out pull request fairly early in the merge window, I'll try to remember to poke Linus about the merge conflict. Linus has just pulled from me, so if you could take care of this merge conflict, that'd be awesome. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH 1/1] hid:Fix problem on GeneralTouch multi-touchscreen

2012-09-27 Thread Jiri Kosina
= MT_CLS_GENERALTOUCH_PWT_TENFINGERS, + MT_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, + USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PWT_TENFINGERS) }, /* Gametel game controller */ { .driver_data = MT_CLS_DEFAULT, And here as well. -- Jiri Kosina SUSE Labs

Re: [PATCH resend] N-Trig: change default value of logical/physical width/height to 1

2012-09-25 Thread Jiri Kosina
it be preferable to use real values. As far as I know these devices all have logical dimensions of 9600x7200. Unfortunately both logical and physical are used as denominators, so 1 for the physicals is probably sensible. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [patch] HID: picoLCD: off by one in dump_buff_as_hex()

2012-09-24 Thread Jiri Kosina
be needed. Sorry for the delay. Looks good to me. I am picking Bruno's patch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/1] HID: Fix missing Unifying device issue

2012-09-22 Thread Jiri Kosina
that comes from an unknown device. Based on a patch originally written by Benjamin Tissoires. Signed-off-by: Nestor Lopez Casado nlopezca...@logitech.com I am now applying it, will be pushing to Linus very soon, and am also marking it for stable 3.2+ Thanks to everyone involved. -- Jiri

Re: [PATCH 1/1] HID: Fix missing Unifying device issue

2012-09-22 Thread Jiri Kosina
On Sat, 22 Sep 2012, Jiri Kosina wrote: This patch fixes an issue introduced after commit 4ea5454203d991ec After that commit, hid-core silently discards any incoming packet that arrives while any hid driver's probe function is being executed. This broke the enumeration process

Re: [PATCH v2] HID: wacom: Fix wacom_probe error handling

2012-09-19 Thread Jiri Kosina
, dev_attr_speed); hid_hw_stop(hdev); -destroy_leds: - wacom_destroy_leds(hdev); err_free: kfree(wdata); return ret; Tested-by: Przemo Firszt prz...@firszt.eu Thanks to both of you. Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH 6/7 v2] HID: picoLCD: drop version check during probe

2012-09-19 Thread Jiri Kosina
with the locking? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 1/2] HID: hid-sensor-hub: Remove setting hdev-claimed before calling hid_hw_start()

2012-09-19 Thread Jiri Kosina
On Tue, 18 Sep 2012, Axel Lin wrote: Current implementation of hid_hw_start() allows connect_mask to be 0. Setting hdev-claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not necessary. Remove it. Signed-off-by: Axel Lin axel@gmail.com Signed-off-by: Jiri Kosina jkos

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Jiri Kosina
; + How do you avoid memory leak on 'start' here? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL] Input and HID updates for 3.7

2012-09-19 Thread Jiri Kosina
4cbe5a555fa58a79b6ecbb6c531b8bab0650778d: Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) are available in the git repository at: git://github.com/rydberg/linux.git for-next Pulled. Thanks Henrik, thanks Dmitry. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: Input and HID updates for 3.7, version 4

2012-09-18 Thread Jiri Kosina
. So if Dmitry has Acked all the input patches and I am going to take it, could you please send me either a proper pull request, or the patch series via e-mail, so that I could apply it? Thanks Henrik, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] HID: lenovo-tpkbd: Fix memory leak in tpkbd_remove_tp()

2012-09-17 Thread Jiri Kosina
@@ -519,6 +519,8 @@ static void tpkbd_remove_tp(struct hid_device *hdev) led_classdev_unregister(data_pointer-led_mute); hid_set_drvdata(hdev, NULL); + kfree(data_pointer-led_micmute.name); + kfree(data_pointer-led_mute.name); kfree(data_pointer); } -- Jiri

RE: [PATCH 3/3] HID: hid-sensor-hub: Call hid_hw_close() before hid_hw_stop()

2012-09-17 Thread Jiri Kosina
Acked-by: Jiri Kosina jkos...@suse.cz and let Jonathan take it. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 1/2] HID: sensors: use GFP_ATOMIC under spinlock

2012-09-17 Thread Jiri Kosina
On Fri, 14 Sep 2012, Dan Carpenter wrote: We're holding a spinlock here so we can't call kmalloc() with GFP_KERNEL. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Jiri Kosina jkos...@suse.cz Jonathan, could you please take this one as well, as it depends

Re: [PATCH] HID: Fix return value in hid-core.c

2012-09-17 Thread Jiri Kosina
with EINVAL. Thanks. } memcpy(collection, parser-device-collection, sizeof(struct hid_collection) * -- 1.7.4.1 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH/RFC] HID: roccat: removing devices from blacklist

2012-09-17 Thread Jiri Kosina
entries which can function also with the generic driver (only with missing features). We are already doing this for logitech and tpkbd. Could you please rather take this aproach and resubmit the patch? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/4] HID: lg: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-lg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH 2/4] HID: lg4ff: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
*entry; int i, value = 0; -- 1.7.9.5 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] HID: prodikeys: Remove unnecessary casts of void pointers

2012-09-17 Thread Jiri Kosina
On Thu, 13 Sep 2012, Axel Lin wrote: Signed-off-by: Axel Lin axel@gmail.com --- drivers/hid/hid-prodikeys.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Applied, thanks Axel. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH Resend] HID: Fix return values in hid-core.c

2012-09-17 Thread Jiri Kosina
) { hid_err(parser-device, collection stack underflow\n); - return -1; + return -EINVAL; } parser-collection_stack_ptr--; return 0; Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH 1/2] HID: wiimote: Add Nintendo Balance-Board support

2012-09-17 Thread Jiri Kosina
On Mon, 17 Sep 2012, Florian Echtler wrote: Tested-by: Florian Echtler f...@butterbrot.org Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/2] HID: wiimote: Parse calibration data of balance boards

2012-09-17 Thread Jiri Kosina
; instead. Please send a followup patch if that's the case, as I have already pushed out the wiimote branch. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2] HID: roccat: conditional blacklisting of Roccat modules

2012-09-17 Thread Jiri Kosina
, thanks Stefan. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: picolcd: Fix build error due to redefinition of 'picolcd_debug_raw_event'

2012-09-11 Thread Jiri Kosina
, - struct hid_device *hdev, struct hid_report *report, - u8 *raw_data, int size) -{ -} #endif /* CONFIG_DEBUG_FS */ -- 1.7.9.5 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-10 Thread Jiri Kosina
. Dmitry, I can pull the whole lot into my tree once you Ack/Signoff the input patches, if you wish. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [patch] HID: picoLCD: fix a NULL test in picolcd_raw_cir()

2012-09-08 Thread Jiri Kosina
(). Reviewed-by: Bruno Prémont bonb...@linux-vserver.org Applied, thanks Dan, thanks Bruno. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Questions about implementing hid driver or input driver

2012-09-07 Thread Jiri Kosina
one, and it's enough to make the device work properly. But that really depends on the protocol that the device is using in the reports. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-07 Thread Jiri Kosina
, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] HID: waltop: Remove waltop_probe() and waltop_remove() functions

2012-09-07 Thread Jiri Kosina
On Fri, 7 Sep 2012, Nikolai Kondrashov wrote: Signed-off-by: Nikolai Kondrashov spbn...@gmail.com Sorry, it should be Acked-by: Nikolai Kondrashov spbn...@gmail.com Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH RESEND #4] dj: memory scribble in logi_dj

2012-09-06 Thread Jiri Kosina
sent directly to me (I would have expected at least the resent patch been sent directly to the maintainer as well), but just to the lists ... so it was lost between the cracks of lkml/linux-input. Linus has just applied it directly today. Thanks everybody, -- Jiri Kosina SUSE Labs

[RFC] [PATCH] HID: remove Paul Walmsley's copyright from places where it shouldn't be

2012-09-04 Thread Jiri Kosina
the tiny drivers, which actually don't contain any of Pauls' copyrighted code. Remove the copyright from those sub-drivers. Signed-off-by: Jiri Kosina jkos...@suse.cz --- Paul, I am sending this out to you as RFC, and am not willing to apply it without your explicit Ack. Thanks. drivers/hid

Re: [PATCH] hid: Remove default m from HID_LOGITECH_DJ

2012-09-03 Thread Jiri Kosina
---help--- Say Y if you want support for Logitech Unifying receivers and devices. Unifying receivers are capable of pairing up to 6 Logitech compliant That was an overlook on my side when merging the driver. Applied, thanks. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-03 Thread Jiri Kosina
. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 16/20] HID: Only dump input if someone is listening

2012-09-02 Thread Jiri Kosina
between the Input and HID ones, and so we can handle them with Dmitry as two independent Input and HID series, right? Thanks a lot, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2] HID: multitouch: Remove the redundant touch state

2012-08-29 Thread Jiri Kosina
haven't unfortunately reviewed the series yet due to kernel summit related events, but I'll get to it shortly. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] hid: Remove duplicate ID for QUANTA 3001 touchscreen

2012-08-27 Thread Jiri Kosina
, USB_DEVICE_ID_SENNHEISER_BTD500USB, HID_QUIRK_NOGET }, { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET }, -- 1.7.11.2 Excellent, thank you Simon. Acked-by: Henrik Rydberg rydb...@euromail.se Applied, thank you guys. -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] HID: hid-debug: Show rdesc for unclaimed devices

2012-08-27 Thread Jiri Kosina
]); seq_printf(f, \n\n); /* dump parsed data and input mappings */ -- 1.7.11.5 -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/1] HID: uclogic: Add support for UC-Logic TWHA60

2012-08-27 Thread Jiri Kosina
On Sun, 26 Aug 2012, Nikolai Kondrashov wrote: Add support for UC-Logic Tablet TWHA60. It is known to be sold as Genius EasyPen M610 and Monoprice MP1060-HA60. Applied, thanks Nikolai. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input

Re: [PATCH -next] HID: picoLCD: Add missing #include linux/uaccess.h

2012-08-22 Thread Jiri Kosina
linux/module.h +#include linux/uaccess.h #include hid-picolcd.h Applied, thanks Geert. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] hid: Remove QUANTA from special drivers list

2012-08-22 Thread Jiri Kosina
this to Linus for 3.6 still. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] input: usb: hid: Bump maximum global item tag report size to 128 bytes

2012-08-15 Thread Jiri Kosina
://www.spinics.net/lists/linux-usb/msg43463.html [3] https://bbs.archlinux.org/viewtopic.php?pid=1141340 [4] http://git.bfuser.eu/?p=marex/mxsldr.git;a=summary Signed-off-by: Marek Vasut ma...@denx.de Cc: Chen Peter b29...@freescale.com Cc: Greg KH g...@kroah.com Cc: Jiri Kosina jkos...@suse.cz I have

Re: [PATCH 2/2] input: usb: hid: Add quirk for Freescale i.MX28 ROM recovery

2012-08-15 Thread Jiri Kosina
, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET }, { 0, 0 } OT: btw. the comment mentioned the list should be sorted, yet it's not so for a while. Maybe a sorting patch would be favored? I have fixed the ordering and applied. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list

Re: [PATCH] HID: multitouch: Add support for eGalax 0x73f7

2012-08-15 Thread Jiri Kosina
, + USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_73F7) }, + { .driver_data = MT_CLS_EGALAX_SERIAL, + MT_USB_DEVICE(USB_VENDOR_ID_DWAV, USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001) }, /* Elo TouchSystems IntelliTouch Plus panel */ Applied, thanks Thierry. -- Jiri

Re: [PATCH v4 1/1] HID:hid-multitouch: Add ELAN production request when resume.

2012-08-15 Thread Jiri Kosina
it device specific. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] HID: picoLCD updates

2012-08-15 Thread Jiri Kosina
short. I don't really understand this explanation. Once usb_kill_urb() returns, the URB should be available for future use (and therefore all queues completely drained). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-13 Thread Jiri Kosina
))=sizeof(ebeam-name)) { // overflowed, closing ) anyway ebeam-name[sizeof(ebeam-name)-2] = ')'; Some variation on that, yes. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord

Re: [PATCH 1/1]hid:hid-multitouch: add mt_resume for ELAN's production

2012-08-03 Thread Jiri Kosina
line is blank, etc). Could you please fix that up and resend? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: Allow drivers without listeners to remain on the bus

2012-07-20 Thread Jiri Kosina
with a revised version of the patch? I like the aproach much more than the previous one, so would like to queue it for 3.6 merge window. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org

Re: [PATCH] HID: roccat: Added sensor bin-sysfs-attr for Savu

2012-07-20 Thread Jiri Kosina
On Wed, 4 Jul 2012, Stefan Achatz wrote: The sensor attr can be used to tweak the optical sensor of the Savu. Applied. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] hid-core : optimize in case of hidraw

2012-07-20 Thread Jiri Kosina
-- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] HID: Make the HID bus visible in the Kconfig options

2012-07-20 Thread Jiri Kosina
moves more and more towards a regular bus, the config options become less and less apt. This patch, for next, only scratches the surface but hopefully in the right direction. Applied, thank you Henrik. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v3] HID: Allow drivers to be their own listener

2012-07-20 Thread Jiri Kosina
queued for 3.6. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] MacBook Pro Retina Keyboard Support

2012-07-10 Thread Jiri Kosina
-wrapping), likely by your mail client, so I can't apply it as-is. Could you please fix that up, and resend? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to majord...@vger.kernel.org More majordomo info at http

<    4   5   6   7   8   9   10   >