Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 89 ++-
1 file changed, 63 insertions
Add support for Pixcir TangoC controller.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
.../devicetree/bindings/input/touchscreen/pixcir_i2c_ts.txt | 2 +-
drivers/input/touchscreen/pixcir_i2c_ts.c | 6 ++
2 files
This is the data that differentiates different pixcir
chips.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +---
include/linux/input/pixcir_ts.h | 11 +++
2 files changed, 16
Get rid of the attb_read_val() platform hook. Instead,
read the ATTB gpio directly from the driver.
Fail if valid ATTB gpio is not provided by patform data.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 19
Some pixcir controllers e.g. tangoC family report finger IDs with
the co-ordinates and are more suitable for Type-B MT protocol.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 202
Use devm_() and friends for allocating memory, input device
and IRQ.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 35 ---
1 file changed, 13 insertions(+), 22 deletions(-)
diff
Add power and interrupt register definitions.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
include/linux/input/pixcir_ts.h | 42 +
1 file changed, 42 insertions(+)
diff --git a/include/linux/input/pixcir_ts.h
Provide device tree support and binding information.
Change platform data parameters from x/y_max to x/y_size..
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
drivers/input/touchscreen
Hi Dmitry,
On 12/18/2013 07:48 PM, Dmitry Torokhov wrote:
On Wed, Dec 18, 2013 at 02:51:18PM +0530, Roger Quadros wrote:
Some pixcir controllers e.g. tangoC family report finger IDs with
the co-ordinates and are more suitable for Type-B MT protocol.
Signed-off-by: Roger Quadros rog...@ti.com
On 12/18/2013 07:50 PM, Dmitry Torokhov wrote:
On Wed, Dec 18, 2013 at 02:51:16PM +0530, Roger Quadros wrote:
Get rid of the attb_read_val() platform hook. Instead,
read the ATTB gpio directly from the driver.
Fail if valid ATTB gpio is not provided by patform data.
Do you also need
Use devm_() and friends for allocating memory, input device
and IRQ.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 34 ---
1 file changed, 13 insertions(+), 21 deletions(-)
diff
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor
Fixup Y resolution and add default pin state. Also update
the compatible id.
CC: Benoit Cousson bcous...@baylibre.com
CC: Tony Lindgren t...@atomide.com
CC: Mugunthan V N mugunthan...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
arch/arm/boot
Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 46 ---
1 file changed, 42 insertions
://article.gmane.org/gmane.linux.kernel/1616417
cheers,
-roger
---
Roger Quadros (8):
Input: pixcir_i2c_ts: Use devres managed resource allocations
Input: pixcir_i2c_ts: Initialize interrupt mode and power mode
Input: pixcir_i2c_ts: Get rid of pdata-attb_read_val()
Input: pixcir_i2c_ts: Use Type-B
Introduce helper functions to configure power and interrupt
registers. Default to IDLE mode on probe as device supports
auto wakeup to ACVIE mode on detecting finger touch.
Configure interrupt mode and polarity on start up.
Power down on device closure or module removal.
Signed-off-by: Roger
Some variants of the Pixcir touch controller support upto 5
simultaneous fingers and hardware tracking IDs. Prepare the driver
for that.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 74 ---
include/linux/input/pixcir_ts.h
Switch to using the Type-B Multi-Touch protocol.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++
1 file changed, 94 insertions(+), 31 deletions(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c
b/drivers
Hi Dmitry,
Gentle reminder to comment on this series. Thanks.
cheers,
-roger
On 02/26/2014 05:27 PM, Roger Quadros wrote:
Hi,
This series does the following
- use devres managed resource allocations
- convert to Type-B multi touch protocol
- support upto 5 fingers with hardware
Hi Henrik,
On 03/08/2014 05:11 PM, Henrik Rydberg wrote:
Hi Roger,
the MT implementation seems mostly fine, just one curiosity:
static irqreturn_t pixcir_ts_isr(int irq, void *dev_id)
{
struct pixcir_i2c_ts_data *tsdata = dev_id;
const struct pixcir_ts_platform_data *pdata =
On 03/10/2014 06:37 PM, Felipe Balbi wrote:
On Mon, Mar 10, 2014 at 10:57:10AM +0200, Roger Quadros wrote:
Hi Henrik,
On 03/08/2014 05:11 PM, Henrik Rydberg wrote:
Hi Roger,
the MT implementation seems mostly fine, just one curiosity:
static irqreturn_t pixcir_ts_isr(int irq, void
Henrik,
On 03/10/2014 06:37 PM, Felipe Balbi wrote:
On Mon, Mar 10, 2014 at 10:57:10AM +0200, Roger Quadros wrote:
Hi Henrik,
On 03/08/2014 05:11 PM, Henrik Rydberg wrote:
Hi Roger,
the MT implementation seems mostly fine, just one curiosity:
static irqreturn_t pixcir_ts_isr(int irq
to 3.15-rc3
- Fixed suspend while touchscreen in use
- Fixed module removal while touchscreen in use
v2:
- Addressed review comments and re-arranged patch order
v1:
- http://article.gmane.org/gmane.linux.kernel/1616417
---
Roger Quadros (7):
Input: pixcir_i2c_ts: Use devres managed resource
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input
Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 53 ---
1 file changed, 49 insertions
Switch to using the Type-B Multi-Touch protocol.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++
1 file changed, 94 insertions(+), 31 deletions(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c
b/drivers
Use devm_() and friends for allocating memory, input device
and IRQ.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 36 +--
1 file changed, 15 insertions(+), 21 deletions(-)
diff
Get rid of the attb_read_val() platform hook. Instead,
read the ATTB gpio directly from the driver.
Fail if valid ATTB gpio is not provided by patform data.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 16
Hi Dmitry,
On 04/30/2014 07:29 PM, Dmitry Torokhov wrote:
Hi Roger,
On Wed, Apr 30, 2014 at 03:36:27PM +0300, Roger Quadros wrote:
+static int pixcir_stop(struct pixcir_i2c_ts_data *ts)
+{
+struct device *dev = ts-client-dev;
+int ret;
+
+/* exit ISR if running, no more
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input
Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 53 ---
1 file changed, 49 insertions
Some variants of the Pixcir touch controller support upto 5
simultaneous fingers and hardware tracking IDs. Prepare the driver
for that.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 74 ---
include/linux/input/pixcir_ts.h
Switch to using the Type-B Multi-Touch protocol.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++
1 file changed, 94 insertions(+), 31 deletions(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c
b/drivers
Introduce helper functions to configure power and interrupt
registers. Default to IDLE mode on probe as device supports
auto wakeup to ACVIE mode on detecting finger touch.
Configure interrupt mode and polarity on start up.
Power down on device closure or module removal.
Signed-off-by: Roger
Get rid of the attb_read_val() platform hook. Instead,
read the ATTB gpio directly from the driver.
Fail if valid ATTB gpio is not provided by patform data.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 16
://article.gmane.org/gmane.linux.kernel/1616417
---
Roger Quadros (7):
Input: pixcir_i2c_ts: Use devres managed resource allocations
Input: pixcir_i2c_ts: Initialize interrupt mode and power mode
Input: pixcir_i2c_ts: Get rid of pdata-attb_read_val()
Input: pixcir_i2c_ts: Use Type-B Multi-Touch
Use devm_() and friends for allocating memory, input device
and IRQ.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 38 ---
1 file changed, 15 insertions(+), 23 deletions(-)
diff
Dmitry,
On 05/06/2014 08:19 AM, Dmitry Torokhov wrote:
Hi Roger,
On Mon, May 05, 2014 at 12:04:33PM +0300, Roger Quadros wrote:
@@ -192,8 +364,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client
*client)
device_init_wakeup(client-dev, 0);
-tsdata-exiting = true
On 05/06/2014 08:21 AM, Dmitry Torokhov wrote:
On Mon, May 05, 2014 at 12:04:37PM +0300, Roger Quadros wrote:
Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
- Fixed module removal while touchscreen in use
v2:
- Addressed review comments and re-arranged patch order
v1:
- http://article.gmane.org/gmane.linux.kernel/1616417
--
Roger Quadros (7):
Input: pixcir_i2c_ts: Use devres managed resource allocations
Input: pixcir_i2c_ts - initialize interrupt
Improve the suspend and resume handlers to allow the device
to wakeup the system from suspend.
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 47 ---
1 file changed, 43 insertions
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input
Some variants of the Pixcir touch controller support upto 5
simultaneous fingers and hardware tracking IDs. Prepare the driver
for that.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 74 ---
include/linux/input/pixcir_ts.h
Introduce helper functions to configure power and interrupt registers.
Default to IDLE mode on probe as device supports auto wakeup to ACVIE mode
on detecting finger touch.
Configure interrupt mode and polarity on start up. Power down on device
closure or module removal.
Signed-off-by: Roger
Hi Henrik,
On 05/19/2014 10:04 AM, Henrik Rydberg wrote:
Hi Roger,
Thanks for the patch series. I think the patch looks great in general. Please
see some minor comments below.
On 05/06/2014 01:06 PM, Roger Quadros wrote:
Switch to using the Type-B Multi-Touch protocol.
Signed-off
On 05/19/2014 08:54 AM, Dmitry Torokhov wrote:
On Tue, May 06, 2014 at 02:06:12PM +0300, Roger Quadros wrote:
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input
From: Roger Quadros rog...@ti.com
Switch to using the Type-B Multi-Touch protocol.
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++
1 file changed, 94 insertions(+), 31
From: Roger Quadros rog...@ti.com
Some variants of the Pixcir touch controller support upto 5
simultaneous fingers and hardware tracking IDs. Prepare the driver
for that.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 74
From: Roger Quadros rog...@ti.com
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor-prefixes.txt
Hi Dmitry,
We're still missing patches 4, 5 and 7 for 3.16, to get device tree and type-B
support.
Do you want me to send them separately?
cheers,
-roger
On 05/19/2014 11:24 AM, Roger Quadros wrote:
From: Roger Quadros rog...@ti.com
Switch to using the Type-B Multi-Touch protocol
module removal while touchscreen in use
v2:
- Addressed review comments and re-arranged patch order
v1:
- http://article.gmane.org/gmane.linux.kernel/1616417
--
Roger Quadros (5):
Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol
Input: pixcir_i2c_ts: support upto 5 fingers and hardware
Some variants of the Pixcir touch controller support upto 5
simultaneous fingers and hardware tracking IDs. Prepare the driver
for that.
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 74 ---
include/linux/input/pixcir_ts.h
Switch to using the Type-B Multi-Touch protocol.
Reviewed-by: Henrik Rydberg rydb...@euromail.se
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 125 ++
1 file changed, 94 insertions(+), 31 deletions(-)
diff --git a/drivers
Provide device tree support and binding information.
Also provide support for a new chip pixcir_tangoc.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 26
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input
Update the bindings for touchscreen size.
CC: Benoit Cousson bcous...@baylibre.com
CC: Tony Lindgren t...@atomide.com
CC: Mugunthan V N mugunthan...@ti.com
Signed-off-by: Roger Quadros rog...@ti.com
---
arch/arm/boot/dts/am437x-gp-evm.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On 06/17/2014 12:51 PM, Tony Lindgren wrote:
* Roger Quadros rog...@ti.com [140617 02:33]:
Hi Dmitry,
These are the pending patches that didn't go through in the 3.16 merge
window.
Please queue them for -next. Thanks.
The series does the following
- convert to Type-B multi touch protocol
Hi Dmitry,
Gentle reminder to pick this series for -next. Thanks :).
cheers,
-roger
On 06/17/2014 12:31 PM, Roger Quadros wrote:
Hi Dmitry,
These are the pending patches that didn't go through in the 3.16 merge window.
Please queue them for -next. Thanks.
The series does the following
Hi Dmitry,
Gentle ping. Would be nice to get these into 3.17. Thanks :).
cheers,
-roger
On 07/03/2014 12:34 PM, Roger Quadros wrote:
Hi Dmitry,
Gentle reminder to pick this series for -next. Thanks :).
cheers,
-roger
On 06/17/2014 12:31 PM, Roger Quadros wrote:
Hi Dmitry
The controller has a RESET pin which is usually controlled over
a GPIO line. If such a GPIO is provided, perform a RESET
during probe.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 3 ++
drivers/input/touchscreen/pixcir_i2c_ts.c
Hi Dmitry,
On 06/02/15 18:54, Dmitry Torokhov wrote:
Hi Roger,
On Fri, Feb 06, 2015 at 02:53:10PM +0200, Roger Quadros wrote:
The controller has a RESET pin which is usually controlled over
a GPIO line. If such a GPIO is provided, perform a RESET
during probe.
Signed-off-by: Roger
The controller has a RESET pin which is usually controlled over
a GPIO line. If such a GPIO is provided, perform a RESET
during probe.
Signed-off-by: Roger Quadros rog...@ti.com
---
.../bindings/input/touchscreen/pixcir_i2c_ts.txt | 3 ++
drivers/input/touchscreen/pixcir_i2c_ts.c
On 28/07/15 00:20, Dmitry Torokhov wrote:
On Mon, Jul 27, 2015 at 04:49:22PM +0530, Vignesh R wrote:
On 07/27/2015 04:19 PM, Roger Quadros wrote:
Hi,
On 23/07/15 17:54, Vignesh R wrote:
On am437x-gp-evm, pixcir touchscreen can wake the system from low power
state by generating wake-up
Hi,
On 23/07/15 17:54, Vignesh R wrote:
On am437x-gp-evm, pixcir touchscreen can wake the system from low power
state by generating wake-up interrupt via pinctrl and IO daisy chain.
Add support for optional wakeup interrupt source by regsitering to
automated wake IRQ framework introduced by
Dmitry,
On 07/07/15 19:25, Dmitry Torokhov wrote:
Hi Roger,
On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote:
Hi Dmitry,
On 07/07/15 03:27, Dmitry Torokhov wrote:
The binding specification says that touchscreen-size-x and -y specify
horizontal and vertical resolution
On 09/07/15 21:16, Dmitry Torokhov wrote:
On Thu, Jul 09, 2015 at 11:32:11AM +0300, Roger Quadros wrote:
Dmitry,
On 08/07/15 18:08, Dmitry Torokhov wrote:
On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote:
Dmitry,
On 07/07/15 19:25, Dmitry Torokhov wrote:
Hi Roger,
On Tue
Hi Dmitry,
On 07/07/15 03:27, Dmitry Torokhov wrote:
The binding specification says that touchscreen-size-x and -y specify
horizontal and vertical resolution of the touchscreen and therefore maximum
absolute coordinates should be reduced by 1 since we are starting with 0.
Signed-off-by: Dmitry
On 07/07/15 03:30, Dmitry Torokhov wrote:
Let's switch to using standard touchscreen device properties parsing module
instead of doing it by hand in the driver.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Roger Quadros rog...@ti.com
cheers,
-roger
---
drivers/input
On 07/07/15 03:30, Dmitry Torokhov wrote:
Let's move driver's platform data definitions from include/linux/input/
into include/linux/platform_data/ so that it stays with the rest of
platform data definitions.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Roger Quadros rog
On 07/07/15 03:30, Dmitry Torokhov wrote:
This allows uniform parsing on legacy, DT and ACPI systems.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Roger Quadros rog...@ti.com
cheers,
-roger
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 26
dmitry.torok...@gmail.com
Acked-by: Roger Quadros rog...@ti.com
cheers,
-roger
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c
b/drivers/input/touchscreen/pixcir_i2c_ts.c
index 9093aa9..8965d7c
On 07/07/15 03:30, Dmitry Torokhov wrote:
input_mt_init_slots() will perform necessary settings for performing
multi-touch to single-touch emulation, we do not need to do that ourselves.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Roger Quadros rog...@ti.com
cheers
Dmitry,
On 08/07/15 18:08, Dmitry Torokhov wrote:
On Wed, Jul 08, 2015 at 10:59:04AM +0300, Roger Quadros wrote:
Dmitry,
On 07/07/15 19:25, Dmitry Torokhov wrote:
Hi Roger,
On Tue, Jul 07, 2015 at 12:37:31PM +0300, Roger Quadros wrote:
Hi Dmitry,
On 07/07/15 03:27, Dmitry Torokhov wrote
72 matches
Mail list logo
