Re: [PATCH v3 2/3] Input: add devicetree binding note for egalax_ts

2012-08-15 Thread Shawn Guo
On Wed, Aug 15, 2012 at 06:31:47PM +0800, Hui Wang wrote: The egalax_ts driver needs to get the gpio number of the irq pin, and use this gpio to wake up the controller. So add a note for this change. Signed-off-by: Hui Wang jason77.w...@gmail.com ---

Re: [PATCH] pwm: Get rid of HAVE_PWM

2012-10-06 Thread Shawn Guo
functionality. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de Cc: Russell King li...@arm.linux.org.uk Cc: Shawn Guo shawn@linaro.org Cc: Eric Miao eric.y.m...@gmail.com Cc: Haojian Zhuang haojian.zhu...@gmail.com Cc: Ralf Baechle r...@linux-mips.org Cc: Dmitry Torokhov

Re: [PATCH 1/3] Input: imx_keypad - Add device tree support

2012-12-30 Thread Shawn Guo
Hi Liu, On Sun, Dec 30, 2012 at 03:28:52PM -0800, Dmitry Torokhov wrote: @@ -473,6 +534,10 @@ static int imx_keypad_probe(struct platform_device *pdev) goto failed_free_priv; } + pinctrl = devm_pinctrl_get_select_default(pdev-dev); + if (IS_ERR(pinctrl)) +

Re: [PATCH 1/3] Input: imx_keypad - Add device tree support

2012-12-30 Thread Shawn Guo
On Sun, Dec 30, 2012 at 09:09:04PM +0800, Liu Ying wrote: +Required SoC Specific Properties: +- compatible: Should be fsl,imx-kpp. We generally use SoC name to specify the version of hardware block in device tree binding. In this case, the compatible string should look like fsl,soc-kpp where

Re: [PATCH 1/3] Input: imx_keypad - Add device tree support

2012-12-31 Thread Shawn Guo
On 31 December 2012 14:45, Liu Ying liu.y.vic...@gmail.com wrote: Hi, Shawn, I plan to remove pinctrl code in the coming next version driver patch first. Do you think this is ok or not? Sure. Just leave the dependency for Dmitry to handle :) Shawn -- To unsubscribe from this list: send the

Re: [PATCH v2 1/3] Input: imx_keypad - Add device tree support

2013-01-02 Thread Shawn Guo
On Tue, Jan 01, 2013 at 11:21:13AM +0800, Liu Ying wrote: +#ifdef CONFIG_OF +static inline int imx_keypad_check_dt(struct platform_device *pdev) +{ + struct device_node *np = pdev-dev.of_node; + + if (!np) + return -ENODEV; + + return 0; +} +#else +static inline

Re: [PATCH v2 2/3] ARM: dts: imx: Add imx51 KPP entry

2013-01-02 Thread Shawn Guo
On Tue, Jan 01, 2013 at 11:21:14AM +0800, Liu Ying wrote: 1) Add KPP device node entry. 2) Add one KPP pinctrl entry. Signed-off-by: Liu Ying ying@freescale.com Patches #2 and #3 look good to me. Will apply them after Dmitry applies the first one. Shawn -- To unsubscribe from this

Re: [PATCH v3 2/3] ARM: dts: imx: Add imx51 KPP entry

2013-01-08 Thread Shawn Guo
On Thu, Jan 03, 2013 at 08:37:33PM +0800, Liu Ying wrote: 1) Add KPP device node entry. 2) Add one KPP pinctrl entry. Signed-off-by: Liu Ying ying@freescale.com Applied #2 and #3, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to

Re: [PATCHv8][ 4/4] ARM: imx_v6_v7_defconfig: Enable tsc2007 support.

2013-10-31 Thread Shawn Guo
-electronics.de Cc: Fabio Estevam fabio.este...@freescale.com Cc: Shawn Guo shawn@linaro.org Cc: Eric Bénard e...@eukrea.com Signed-off-by: Denis Carikli de...@eukrea.com Applied this one. Shawn -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message

Re: [PATCH v5 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver

2015-05-27 Thread Shawn Guo
On Wed, May 27, 2015 at 12:25:56AM +0800, frank...@freescale.com wrote: Frank Li (5): rtc: arm: imx: snvs: change use syscon to access register Document: dt: fsl: snvs: change support syscon ARM: dts: imx: update snvs to use syscon access register Document: devicetree: input: imx:

Re: [PATCH v4 2/6] Document: dt: fsl: snvs: change support syscon

2015-05-25 Thread Shawn Guo
On Fri, May 22, 2015 at 10:36:35PM +0800, frank...@freescale.com wrote: From: Frank Li frank...@freescale.com snvs actually is multi fucntion driver. Change to use syscon to access register. The rationale of 'interrupts' change did not get covered in the commit log. Shawn Signed-off-by:

Re: [PATCH v4 1/6] rtc: arm: imx: snvs: change use syscon to access register

2015-05-25 Thread Shawn Guo
On Fri, May 22, 2015 at 10:36:34PM +0800, frank...@freescale.com wrote: static int snvs_rtc_probe(struct platform_device *pdev) { struct snvs_rtc_data *data; struct resource *res; int ret; + struct device_node *snvs_np; + void __iomem *mmio; data =

Re: [PATCH v3 1/6] rtc: arm: imx: snvs: change use syscon to access register

2015-05-24 Thread Shawn Guo
On Fri, May 22, 2015 at 10:07:49AM +0200, Alexandre Belloni wrote: Hi, This looks good to me, a few nits below On 22/05/2015 at 00:16:47 +0800, frank...@freescale.com wrote : - spin_unlock_irqrestore(data-lock, flags); + regmap_update_bits(data-regmap, data-offset + SNVS_LPCR, +

Re: [PATCH v4 1/6] rtc: arm: imx: snvs: change use syscon to access register

2015-05-25 Thread Shawn Guo
On Fri, May 22, 2015 at 10:36:34PM +0800, frank...@freescale.com wrote: From: Frank Li frank...@freescale.com snvs included rtc, on/off key, power-off module change to syscon to access register Signed-off-by: Frank Li frank...@freescale.com Did you test it with both existing and new DTBs?

Re: [PATCH v4 4/6] input: keyboard: imx: add snvs power key driver

2015-05-25 Thread Shawn Guo
On Fri, May 22, 2015 at 10:36:37PM +0800, frank...@freescale.com wrote: +static int imx_snvs_pwrkey_probe(struct platform_device *pdev) +{ + struct pwrkey_drv_data *pdata = NULL; + struct input_dev *input = NULL; + struct device_node *np, *snvs_np; + int error; + + /*

Re: [PATCH v4 6/6] arm: dts: imx6sx: enable snvs power key

2015-05-25 Thread Shawn Guo
On Fri, May 22, 2015 at 10:36:39PM +0800, frank...@freescale.com wrote: From: Frank Li frank...@freescale.com enable snvs ONOFF power key support Signed-off-by: Frank Li frank...@freescale.com Please use 'ARM: dts: imx6sx: ...' for the patch subject. --- arch/arm/boot/dts/imx6sx.dtsi |

Re: [rtc-linux] [PATCH v5 1/6] rtc: arm: imx: snvs: change use syscon to access register

2015-06-29 Thread Shawn Guo
On Mon, Jun 01, 2015 at 10:25:07PM +0200, Alexandre Belloni wrote: On 27/05/2015 at 00:25:57 +0800, frank...@freescale.com wrote : From: Frank Li frank...@freescale.com snvs included rtc, on/off key, power-off module change to syscon to access register Signed-off-by: Frank Li

Re: [PATCH v5 0/6] Change snvs rtc and poweroff to use syscon add pwrkey driver

2015-06-29 Thread Shawn Guo
On Mon, Jun 01, 2015 at 03:24:11PM -0500, Zhi Li wrote: Shawn: Everyone agree merge through your tree. Please help pick whole patches Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-input in the body of a message to

Re: [PATCH 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support

2015-07-27 Thread Shawn Guo
On Mon, Jul 27, 2015 at 07:26:47PM +0800, Haibo Chen wrote: Add touch screen surpport for i.MX6UL-EVK board. Signed-off-by: Haibo Chen haibo.c...@freescale.com --- arch/arm/boot/dts/imx6ul-14x14-evk.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH v2 1/4] ARM: dts: vfxxx: Add io-channel-cells property for ADC node

2015-07-27 Thread Shawn Guo
On Thu, Jul 16, 2015 at 08:43:19PM +0530, Sanchayan Maity wrote: This commit adds io-channel-cells property to the ADC node. This property is required in order for an IIO consumer driver to work. Especially required for Colibri VF50, as the touchscreen driver uses ADC channels with the ADC

Re: [PATCH v2 2/4] ARM: dts: vf500-colibri: Add device tree node for touchscreen support

2015-07-27 Thread Shawn Guo
On Thu, Jul 16, 2015 at 08:43:20PM +0530, Sanchayan Maity wrote: Add device tree node for touchscreen support on Colibri VF50. The touchscreen functionality on VF50 uses the ADC channels of Vybrid and some GPIOs. Also add pinctrl nodes for proper pinmux. Signed-off-by: Sanchayan Maity

[PATCH] input: snvs_pwrkey: add linux prefix for wakeup property

2015-07-14 Thread Shawn Guo
The wakeup capability is somehow linux specific, and all existing bindings name the property linux,wakeup to reflect that, e.g. Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt. Let's follow the convention. Signed-off-by: Shawn Guo shawn...@kernel.org --- This is a fixup

[PATCH v2] input: snvs_pwrkey: use wakeup-source as deivce tree property name

2015-07-16 Thread Shawn Guo
Instead of inventing a new property name, let's use wakeup-source to be consistent with other driver and subsystem bindings. Signed-off-by: Shawn Guo shawn...@kernel.org --- Changes since v1: - Use wakeup-source rather than linux,wakeup This is a fixup for Frank's patch which is queued on i.MX

Re: [PATCH] input: snvs_pwrkey: add linux prefix for wakeup property

2015-07-16 Thread Shawn Guo
On Thu, Jul 16, 2015 at 11:34:08AM -0700, Dmitry Torokhov wrote: I should have said to use wakeup-source, not simply wakeup so that we'd match with I2C annotation. Yeah, consistency is the real motivation of this patch. I do not like that different properties are invented for the same purpose.

Re: [PATCH v3 3/5] ARM: imx_v6_v7_defconfig: enable imx6ul_tsc

2015-09-06 Thread Shawn Guo
On Fri, Aug 28, 2015 at 05:09:34PM +0800, Haibo Chen wrote: > Enable imx6ul touchscreen controller > > Signed-off-by: Haibo Chen Applied 3 ~ 5, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to

Re: [PATCH v5 1/3] ARM: dts: vf500-colibri: Add device tree node for touchscreen support

2015-09-30 Thread Shawn Guo
On Tue, Sep 01, 2015 at 06:06:53PM +0530, Sanchayan Maity wrote: > Add device tree node for touchscreen support on Colibri VF50. The > touchscreen functionality on VF50 uses the ADC channels of Vybrid > and some GPIOs. Also add pinctrl nodes for proper pinmux. > > Signed-off-by: Sanchayan Maity

Re: [PATCH 6/6] ARM: dts: set up trigger type for edt-ft5x06 interrupts

2015-09-23 Thread Shawn Guo
v <dmitry.torok...@gmail.com> > --- ... > arch/arm/boot/dts/imx28-tx28.dts | 3 ++- > arch/arm/boot/dts/imx53-tx53-x03x.dts | 3 ++- > arch/arm/boot/dts/imx6qdl-tx6.dtsi| 3 ++- Acked-by: Shawn Guo <shawn...@kernel.org> -- To unsubscribe from this list: send the lin