Re: [PATCH] HID: rmi: Write updated F11 control registers after reset

2015-07-10 Thread Gabriele Mazzotta
On Thursday 09 July 2015 17:41:28 Andrew Duggan wrote: On 07/09/2015 03:40 PM, Gabriele Mazzotta wrote: On Thursday 09 July 2015 15:14:17 Andrew Duggan wrote: When a device is reset the values of control registers will be reset to the defaults. This patch reapplies the control register

Re: [PATCH] HID: rmi: Write updated F11 control registers after reset

2015-07-09 Thread Gabriele Mazzotta
here below, but other than that Tested-by: Gabriele Mazzotta gabriele@gmail.com Signed-off-by: Andrew Duggan adug...@synaptics.com --- drivers/hid/hid-rmi.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/drivers/hid/hid

Re: [PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-08 Thread Gabriele Mazzotta
On Tuesday 07 July 2015 22:49:30 Jiri Kosina wrote: On Tue, 7 Jul 2015, Gabriele Mazzotta wrote: The irq is most likely required by the suspend callback, so disable it only after the callback had been executed. It would be nice to have a more verbose changelog here -- i.e. why we want

[PATCH] HID: i2c-hid: Call device suspend callback before disabling irq

2015-07-07 Thread Gabriele Mazzotta
The irq is most likely required by the suspend callback, so disable it only after the callback had been executed. Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/hid/i2c-hid/i2c-hid.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/i2c

Re: hid-rmi: configuration automatically changed after suspend/resume

2015-07-07 Thread Gabriele Mazzotta
On Monday 06 July 2015 16:47:57 Andrew Duggan wrote: Hi Gabriele, On 07/06/2015 03:20 AM, Gabriele Mazzotta wrote: Hi, I recently noticed that there's a minor issue with hid-rmi.c. After a suspend/resume cycle the f11 control register is set to the default configuration, thus undoing

hid-rmi: configuration automatically changed after suspend/resume

2015-07-06 Thread Gabriele Mazzotta
Hi, I recently noticed that there's a minor issue with hid-rmi.c. After a suspend/resume cycle the f11 control register is set to the default configuration, thus undoing the changes performed on init. I made some changes to the driver to prevent this from happening: the configuration is saved on

Re: [PATCH v3 4/5] input: synaptics - make image sensors and cr48 sensors report widths

2015-06-12 Thread Gabriele Mazzotta
On Thursday 11 June 2015 17:40:14 Dmitry Torokhov wrote: HI Gabriele, On Sun, Mar 22, 2015 at 03:43:55PM +0100, Gabriele Mazzotta wrote: The driver was not reporting widths for image sensors and cr48 sensors despite it was calculating them. Link: https://bugzilla.kernel.org

Re: [PATCH v3 0/5] input: synaptics - report correct width and pressure values

2015-04-27 Thread Gabriele Mazzotta
On Sunday 22 March 2015 15:43:51 Gabriele Mazzotta wrote: Hi, I updated the series fixing the error reported by Shunsuke Shimizu that I made when I rebased v1. I've also included a change to make input devices correctly report their capabilities and included a change to make MT devices

Re: Hidden dependency of i2c-hid on GPIOLIB

2015-04-14 Thread Gabriele Mazzotta
On Tuesday 14 April 2015 12:59:24 Mika Westerberg wrote: On Tue, Apr 14, 2015 at 12:55:20AM +0200, Gabriele Mazzotta wrote: Hi, my touchpad stopped working because of a485923efbb8 (HID: i2c-hid: Add support for ACPI GPIO interrupts). It turned out that I need CONFIG_GPIOLIB. I think

Hidden dependency of i2c-hid on GPIOLIB

2015-04-13 Thread Gabriele Mazzotta
Hi, my touchpad stopped working because of a485923efbb8 (HID: i2c-hid: Add support for ACPI GPIO interrupts). It turned out that I need CONFIG_GPIOLIB. I think this dependency should be made explicit or the driver should not depend on it. Regards, Gabriele -- To unsubscribe from this list: send

Re: [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors

2015-03-23 Thread Gabriele Mazzotta
On Monday 23 March 2015 16:48:15 Benjamin Tissoires wrote: On Sun, Mar 22, 2015 at 10:43 AM, Gabriele Mazzotta gabriele@gmail.com wrote: The minimum value these sensors can report is 4, so this should be the value used when W is not reporting the width. Signed-off-by: Gabriele

[PATCH v3 5/5] input: MT - add ABS_TOOL_WIDTH to the legacy pointer emulation

2015-03-22 Thread Gabriele Mazzotta
Userspace might still rely on ABS_TOOL_WIDTH to determine the width of contacts, so add it to the legacy pointer emulation. Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/input/input-mt.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v3 1/5] input: synaptics - fix width values calculation on image sensors

2015-03-22 Thread Gabriele Mazzotta
When multiple fingers are on the touchpad, W holds the finger count rather than the width. Retrieve the correct value that is encoded in X, Y and Z of AGM and SGM packets. The minimum width reported is 8 rather than 4 in this case, while the maximum remains 15. Signed-off-by: Gabriele Mazzotta

[PATCH v3 3/5] input: synaptics - setup devices depending on their capabilities

2015-03-22 Thread Gabriele Mazzotta
ABS_X, ABS_Y and ABS_PRESSURE were defined for all the devices, even if not needed. Fix this by configuring each device depending on its capabilities. Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/input/mouse/synaptics.c | 27 ++- 1 file changed, 14

[PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors

2015-03-22 Thread Gabriele Mazzotta
The minimum value these sensors can report is 4, so this should be the value used when W is not reporting the width. Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse

[PATCH v3 0/5] input: synaptics - report correct width and pressure values

2015-03-22 Thread Gabriele Mazzotta
Hi, I updated the series fixing the error reported by Shunsuke Shimizu that I made when I rebased v1. I've also included a change to make input devices correctly report their capabilities and included a change to make MT devices report widths as ABS_TOOL_WIDTH. Gabriele Mazzotta (5): input

Re: [PATCH v2 0/4] input: synaptics - report correct width and pressure values

2015-03-09 Thread Gabriele Mazzotta
It was pointed out that I made a terrible mistake in 4/4 [1] of this series and I'm going to fix it. But I have a question first. Is there any reason why the pointer emulation takes care of ABS_PRESSURE, but not ABS_TOOL_WIDTH? I know for example that xf86-input-synaptics relies on both (at least

Re: [PATCH 3/3] HID: rmi: disable palm detect gesture when present

2015-02-25 Thread Gabriele Mazzotta
On Tuesday 24 February 2015 17:36:50 Andrew Duggan wrote: A touchpad may have firmware based palm detection code enabled which suppresses 2D data from being reported when the firmware believes a palm is on the touchpad. This functionality is meant to be used in mouse mode without a driver.

Re: [PATCH v2 0/4] input: synaptics - report correct width and pressure values

2015-02-22 Thread Gabriele Mazzotta
On Monday 05 January 2015 23:28:31 Gabriele Mazzotta wrote: Make image sensors and cr48 sensors report widths and fix the calculation of width and pressure values in some cases. Changes since v1: - Rebased on 35393dcb2ed3 - Get widths from AGM packets too - Include support for cr48

Re: NULL pointer dereference in i2c-hid

2015-02-22 Thread Gabriele Mazzotta
On Friday 09 January 2015 16:29:04 Andrew Duggan wrote: On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote: On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote: On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can get the firmware id from your touchpad

Re: NULL pointer dereference in i2c-hid

2015-01-09 Thread Gabriele Mazzotta
On Friday 09 January 2015 16:29:04 Andrew Duggan wrote: On 01/09/2015 12:04 AM, Gabriele Mazzotta wrote: On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote: On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can get the firmware id from your touchpad

Re: NULL pointer dereference in i2c-hid

2015-01-09 Thread Gabriele Mazzotta
On Thursday 08 January 2015 15:58:54 Andrew Duggan wrote: On 12/24/2014 03:53 PM, Gabriele Mazzotta wrote: [...snip...] Also, if you can get the firmware id from your touchpad that would also be useful. $ sudo ./rmihidtool -f /dev/hidraw0 firmware id: 1522295 Thanks, I will see if I

[PATCH v2 2/4] input: synaptics - fix width values calculation on image sensors

2015-01-05 Thread Gabriele Mazzotta
When multiple fingers are on the touchpad, W reports the finger count rather than the width. Retrieve the correct value that is encoded in X, Y and Z of AGM and SGM packets. The minimum width reported is 8 rather than 4 in this case, while the maximum remains 15. Signed-off-by: Gabriele Mazzotta

[PATCH v2 0/4] input: synaptics - report correct width and pressure values

2015-01-05 Thread Gabriele Mazzotta
Make image sensors and cr48 sensors report widths and fix the calculation of width and pressure values in some cases. Changes since v1: - Rebased on 35393dcb2ed3 - Get widths from AGM packets too - Include support for cr48 sensors - Fix pressure values on image sensors Gabriele Mazzotta (4

[PATCH v2 4/4] input: synaptics - make semi-mt touchpads report widths

2015-01-05 Thread Gabriele Mazzotta
Despite claiming to report finger widths, semi-mt touchpads were not doing it. Make them report widths using ABS_MT_TOUCH_MAJOR instead of ABS_TOOL_WIDTH. Link: https://bugzilla.kernel.org/show_bug.cgi?id=77161 Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/input/mouse

[PATCH v2 1/4] input: synaptics - fix pressure values calculation on image sensors

2015-01-05 Thread Gabriele Mazzotta
The pressure values retrieved from secondary packets was incorrectly shifted, making them lower than what they actually were. Since this only happened with secondary packets, the values reported when only one finger was present on the touchpad were correct. Signed-off-by: Gabriele Mazzotta

Re: [PATCH 1/2] input: synaptics - make image sensors report ABS_MT_TOUCH_MAJOR

2015-01-05 Thread Gabriele Mazzotta
On Monday 05 January 2015 14:24:30 Benjamin Tissoires wrote: Hi Gabriele, [Adding Peter and Hans as this change will impact both xf86-input-synaptics and libinput] On Sat, Dec 27, 2014 at 6:31 AM, Gabriele Mazzotta gabriele@gmail.com wrote: Despite claiming to be able to report

Re: [PATCH 1/2] input: synaptics - make image sensors report ABS_MT_TOUCH_MAJOR

2015-01-05 Thread Gabriele Mazzotta
On Monday 05 January 2015 14:24:30 Benjamin Tissoires wrote: Hi Gabriele, [Adding Peter and Hans as this change will impact both xf86-input-synaptics and libinput] On Sat, Dec 27, 2014 at 6:31 AM, Gabriele Mazzotta gabriele@gmail.com wrote: Despite claiming to be able to report

Re: [PATCH 1/2] input: synaptics - make image sensors report ABS_MT_TOUCH_MAJOR

2015-01-05 Thread Gabriele Mazzotta
On Monday 05 January 2015 21:13:09 Gabriele Mazzotta wrote: On Monday 05 January 2015 14:24:30 Benjamin Tissoires wrote: Hi Gabriele, [Adding Peter and Hans as this change will impact both xf86-input-synaptics and libinput] On Sat, Dec 27, 2014 at 6:31 AM, Gabriele Mazzotta

Re: [PATCH 2/2] input: synaptics - fix width calculation on image sensors

2015-01-05 Thread Gabriele Mazzotta
On Monday 05 January 2015 11:04:07 Dmitry Torokhov wrote: On January 5, 2015 10:42:13 AM PST, Benjamin Tissoires benjamin.tissoi...@gmail.com wrote: On Mon, Jan 5, 2015 at 1:37 PM, Gabriele Mazzotta gabriele@gmail.com wrote: On Monday 05 January 2015 13:25:38 Benjamin Tissoires wrote

[PATCH 1/2] input: synaptics - make image sensors report ABS_MT_TOUCH_MAJOR

2014-12-27 Thread Gabriele Mazzotta
values are emitted, i.e. values greater than or equal to 4, and assign the correct range to ABS_MT_TOUCH_MAJOR. Link: https://bugzilla.kernel.org/show_bug.cgi?id=77161 Signed-off-by: Gabriele Mazzotta gabriele@gmail.com --- drivers/input/mouse/synaptics.c | 11 +-- 1 file changed, 9

[PATCH 2/2] input: synaptics - fix width calculation on image sensors

2014-12-27 Thread Gabriele Mazzotta
When two or more fingers are on the touchpad, the 'w' slot holds the finger count rather than the width. Retrieve the correct value encoded in the lower bits of 'x', 'y' and 'z'. The minimum width reported is 8 rather than 4 in this case, while the maximum remains 15. Signed-off-by: Gabriele

Re: NULL pointer dereference in i2c-hid

2014-12-24 Thread Gabriele Mazzotta
On Friday 12 December 2014 11:12:50 Andrew Duggan wrote: On 12/12/2014 12:12 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:26:00 Andrew Duggan wrote: On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote: On 12/11/2014 01

Re: NULL pointer dereference in i2c-hid

2014-12-12 Thread Gabriele Mazzotta
On Thursday 11 December 2014 16:26:00 Andrew Duggan wrote: On 12/11/2014 01:57 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote: On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote: On 12/11/2014

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote: On Wed, Dec 10, 2014 at 06:04:51PM +0100, Gabriele Mazzotta wrote: my laptop uses a touchpad that needs hid-rmi along with i2c-hid to work. i2c-hid and hid-rmi can

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote: On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote: On Wed, Dec 10, 2014 at 06:04:51PM +0100, Gabriele

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 13:41:57 Benjamin Tissoires wrote: On Thu, Dec 11, 2014 at 1:16 PM, Gabriele Mazzotta gabriele@gmail.com wrote: On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec 11, 2014 at 10:58:01AM +0200, Mika Westerberg wrote: On Wed, Dec 10

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote: On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote: On 12/11/2014 10:16 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 16:03:07 Mika Westerberg wrote: On Thu, Dec

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote: On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote: On 12/11/2014 11:11 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 10:40:05 Andrew Duggan wrote: On 12/11/2014

Re: NULL pointer dereference in i2c-hid

2014-12-11 Thread Gabriele Mazzotta
On Thursday 11 December 2014 13:34:02 Andrew Duggan wrote: On 12/11/2014 01:17 PM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 12:46:53 Andrew Duggan wrote: On 12/11/2014 11:40 AM, Gabriele Mazzotta wrote: On Thursday 11 December 2014 11:21:43 Andrew Duggan wrote: On 12/11/2014

NULL pointer dereference in i2c-hid

2014-12-10 Thread Gabriele Mazzotta
Hi, my laptop uses a touchpad that needs hid-rmi along with i2c-hid to work. i2c-hid and hid-rmi can be loaded and unloaded independelty from each other, however since 34f439e4afcd (HID: i2c-hid: add runtime PM support) if I unload hid-rmi and after it I also unload i2c-hid, I get a NULL pointer

Re: Side effect of pressing special keys

2014-12-03 Thread Gabriele Mazzotta
On Wednesday 03 December 2014 14:24:11 Pali Rohár wrote: On Wednesday 03 December 2014 14:12:54 Henrique de Moraes Holschuh wrote: On Wed, 03 Dec 2014, Pali Rohár wrote: Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle keyboard backlight level? Should be this key filtered