Re: [PATCH] Add eGalaxTouch serial touchscreen driver v3

2015-12-16 Thread Dmitry Torokhov
On Wed, Dec 16, 2015 at 01:54:01PM +0100, Boszormenyi Zoltan wrote: > 2015-12-16 13:43 keltezéssel, Zoltán Böszörményi írta: > > Signed-off-by: B�sz�rm�nyi Zolt�n > > this > > > + * Copyright (c) 2015 Zolt�n B�sz�rm�nyi > > this > > > +MODULE_AUTHOR("Zolt�n

Re: [PATCH] Add eGalaxTouch serial touchscreen driver v3

2015-12-16 Thread Boszormenyi Zoltan
2015-12-16 20:28 keltezéssel, Dmitry Torokhov írta: > On Wed, Dec 16, 2015 at 01:54:01PM +0100, Boszormenyi Zoltan wrote: >> 2015-12-16 13:43 keltezéssel, Zoltán Böszörményi írta: >>> Signed-off-by: B�sz�rm�nyi Zolt�n >> this >> >>> + * Copyright (c) 2015 Zolt�n B�sz�rm�nyi

Re: [patch] HID: wacom: bitwise vs logical ORs

2015-12-16 Thread Jason Gerecke
On Wed, Dec 16, 2015 at 6:57 AM, Jiri Kosina wrote: > On Wed, 9 Dec 2015, Dan Carpenter wrote: > >> Smatch complains that these should probably be bitwise ORs instead of >> logical. It doesn't matter for "prox" but it makes a difference for >> "strip1" and "strip2". >> >>

Re: [RESEND] Lenovo Yoga 900 touchpad issues

2015-12-16 Thread Nish Aravamudan
Hi Jiri, On Wed, Dec 16, 2015 at 5:18 AM, Jiri Kosina wrote: > On Wed, 16 Dec 2015, Mika Westerberg wrote: > >> > [Apologies for the resend, didn't realize I hadn't changed my GMail >> > settings >> > to not use HTML.] >> > >> > I have recently purchased a Lenovo Yoga 900 and

[PATCH 1/4] HID: wacom: Limit touchstrip data to 13 bits

2015-12-16 Thread Jason Gerecke
Commit c7f0522 uses sixteen bits of data in the construction of 'strip1' and 'strip2'. This can cause problems in some cases, however, since some tablets store flags in the MSB of data[2] and data[4] that should not be included in these values. This restores the 0x1f mask that used prior to

[PATCH 3/4] HID: wacom: Fix touchring value reporting

2015-12-16 Thread Jason Gerecke
Commit c7f0522 reports incorrect touchring values to userspace. This is due to its incorrect handling of the 'touched' bit present in the 'ring1' and 'ring2' variables. Instead of using this bit when determining if a value should be sent, the ABS_WHEEL and ABS_INPUT check (different?!) portions of

[PATCH 4/4] HID: wacom: Fix pad button range for CINTIQ_COMPANION_2

2015-12-16 Thread Jason Gerecke
Commit c7f0522 incorrectly constructs the 'buttons' variable for the CINTIQ_COMPANION_2 case. The high nybble of data[2] is shifted four bits too far, leaving the bits associated with BTN_7 through BTN_A unset. Signed-off-by: Jason Gerecke --- drivers/hid/wacom_wac.c |

[PATCH 2/4] HID: wacom: Report 'strip2' values in ABS_RY

2015-12-16 Thread Jason Gerecke
Commit c7f0522 accidentally used ABS_RX for reporting both 'strip1' and 'strip2', when the latter should actually be reported through ABS_RY. Signed-off-by: Jason Gerecke --- drivers/hid/wacom_wac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Input: xpad - use LED API when identifying wireless controllers

2015-12-16 Thread Dmitry Torokhov
When lighting up the segment identifying wireless controller, Instead of sending command directly to the controller, let's do it via LED API (usinf led_set_brightness) so that LED object state is in sync with controller state and we'll light up the correct segment on resume as well.

Re: [RESEND] Lenovo Yoga 900 touchpad issues

2015-12-16 Thread Nish Aravamudan
On Wed, Dec 16, 2015 at 1:28 AM, Mika Westerberg wrote: > On Tue, Dec 15, 2015 at 11:14:32AM -0800, Nish Aravamudan wrote: >> [Apologies for the resend, didn't realize I hadn't changed my GMail settings >> to not use HTML.] >> >> I have recently purchased a Lenovo

Re: [PATCH 2/2] Input: add touchscreen support for TS-4800

2015-12-16 Thread Dmitry Torokhov
Hi Damien, On Thu, Dec 10, 2015 at 11:11:12AM -0500, Damien Riegel wrote: > On this board, the touchscreen, an ads7843, is not handled directly by > Linux but by a companion FPGA. This FPGA is memory-mapped and the IP > design is very similar to the mk712. > > This commit adds the support for

Re: [PATCH 4/5] Input: xpad: workaround dead irq_out after suspend/ resume

2015-12-16 Thread Dmitry Torokhov
On Wed, Dec 09, 2015 at 10:41:31PM -0800, Dmitry Torokhov wrote: > On Sun, Nov 01, 2015 at 04:31:38PM +0100, Pavel Rojtberg wrote: > > From: Pavel Rojtberg ... > > + > > +static int xpad_resume(struct usb_interface *intf) > > +{ > > + usb_queue_reset_device(intf); > > Why

[PATCH] Add eGalaxTouch serial touchscreen driver v3

2015-12-16 Thread Zoltán Böszörményi
From: Böszörményi Zoltán There are two EETI touchscreen drivers in the kernel (eeti_ts and egalax_ts) but both are for I2C-connected panels. This is for a different, serial and not multi-touch touchscreen panel. The protocol documentation is at

Re: [PATCH] input/touchscreen: New EETI eGalaxTouch serial touchscreen driver

2015-12-16 Thread Boszormenyi Zoltan
2015-12-15 22:21 keltezéssel, Dmitry Torokhov írta: > Hi Zoltán, > > On Tue, Dec 15, 2015 at 12:22:07PM +0100, Böszörményi Zoltán wrote: >> From: Böszörményi Zoltán >> >> There are two EETI touchscreen drivers in the kernel (eeti_ts and egalax_ts) >> but both are for I2C-connected

Re: [PATCH] Add eGalaxTouch serial touchscreen driver v3

2015-12-16 Thread Boszormenyi Zoltan
2015-12-16 13:43 keltezéssel, Zoltán Böszörményi írta: > Signed-off-by: B�sz�rm�nyi Zolt�n this > + * Copyright (c) 2015 Zolt�n B�sz�rm�nyi this > +MODULE_AUTHOR("Zolt�n B�sz�rm�nyi "); and this were in Latin-2 after you sent the patch back to

Re: [PATCH 1/1] Support for CMedia CM6533 HID audio jack controls.

2015-12-16 Thread Jiri Kosina
On Tue, 15 Dec 2015, Ben Chen wrote: > Signed-off-by: Ben Chen Please provide a changelog. At least a description of the device and overview of changes that are needed on top of generic HID should be provided. Thanks. > --- > drivers/hid/Kconfig | 6 ++ >

Re: [RESEND] Lenovo Yoga 900 touchpad issues

2015-12-16 Thread Jiri Kosina
On Wed, 16 Dec 2015, Mika Westerberg wrote: > > [Apologies for the resend, didn't realize I hadn't changed my GMail settings > > to not use HTML.] > > > > I have recently purchased a Lenovo Yoga 900 and most everything is working > > with a slightly modified 4.4-rc5

Re: [patch] HID: wacom: bitwise vs logical ORs

2015-12-16 Thread Jiri Kosina
On Wed, 9 Dec 2015, Dan Carpenter wrote: > Smatch complains that these should probably be bitwise ORs instead of > logical. It doesn't matter for "prox" but it makes a difference for > "strip1" and "strip2". > > Fixes: c7f0522a1ad1 ('HID: wacom: Slim down wacom_intuos_pad processing') >

Re: Fake KEY_5 continuous keydown events with Logitech wireless keyboard on Kernel 4.2

2015-12-16 Thread Clément VUCHENER
2015-11-06 17:37 GMT+01:00 Benjamin Tissoires : > I also experienced such problems from time to time and always thought > it was either a firmware problem or a low battery issue. When > recharging my keyboard, the issue disappeared. Unfortunately, I was > never able

Re: [RESEND] Lenovo Yoga 900 touchpad issues

2015-12-16 Thread Mika Westerberg
On Tue, Dec 15, 2015 at 11:14:32AM -0800, Nish Aravamudan wrote: > [Apologies for the resend, didn't realize I hadn't changed my GMail settings > to not use HTML.] > > I have recently purchased a Lenovo Yoga 900 and most everything is working > with a slightly modified 4.4-rc5

[PATCH] HID: corsair: Convert to use module_hid_driver

2015-12-16 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/hid/hid-corsair.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c index bcefb9e..5855196 100644 --- a/drivers/hid/hid-corsair.c +++