Re: Linux header change breaks linux-atm userspace build

2007-02-08 Thread Andrew Walrond
On Friday 09 February 2007 00:01, David Miller wrote: > From: Andrew Walrond <[EMAIL PROTECTED]> > Date: Thu, 8 Feb 2007 21:31:25 + > > > Sometime between 2.6.18.3 and 2.6.20, this change... > > > > --- /include/linux/atmarp.h 2007-01-10 16:32:05.0 + > > +++

Re: [patch] i386/x86_64: smp_call_function locking inconsistency

2007-02-08 Thread Andi Kleen
On Thursday 08 February 2007 21:32, Heiko Carstens wrote: > On i386/x86_64 smp_call_function_single() takes call_lock with > spin_lock_bh(). To me this would imply that it is legal to call > smp_call_function_single() from softirq context. > It's not since smp_call_function() takes call_lock with

Re: genirq: Add a set_irq_handler_locked() function

2007-02-08 Thread Russell King
On Fri, Feb 09, 2007 at 02:48:42PM +1100, David Gibson wrote: > At present set_irq_handler() and all the existing variants take the > desc->lock for the irq in question before adjusting the irq's flow > handler. This can cause problems for irq chips for which a given > interrupt can be either

Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c

2007-02-08 Thread hui
On Thu, Feb 08, 2007 at 11:14:04PM -0800, Bill Huey wrote: > I have an adaptive lock implementation in my tree that eliminates > the contention between what looks like the IDE layer, work queues and > the anticipatory scheduler, but that's not a real problem unlike what > I've mentioned above. I

[PATCH] Convert pci_module_init() to pci_register_driver()

2007-02-08 Thread Richard Knutsson
Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with "allyes", "allmod" & "allno" on i386 Diff'ed against the unpatched object-files, no difference Has previously been sent to the maintainers, without respons

Re: Direct IO for fat

2007-02-08 Thread Jan Kara
On Fri 09-02-07 04:53:02, OGAWA Hirofumi wrote: > Jan Kara <[EMAIL PROTECTED]> writes: > > >> > -> blockdev_direct_IO() > >> > -> direct_io_worker() > >> > -> do_direct_IO() > >> > -> get_more_blocks() > >> > > >> > create = dio->rw & WRITE; > >> Here, create == 1. > >> >

Re: [md] RAID6: clean up CPUID and FPU enter/exit code

2007-02-08 Thread H. Peter Anvin
My apologies for the screwed-up 'To:' line in the previous email... I did -s `head -1 file` instead of -s "`head -1 file`" by mistake [:^O -hpa (who is going to bed now...) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] remove sb->s_files and file_list_lock usage in dquot.c

2007-02-08 Thread hui
On Thu, Feb 08, 2007 at 01:01:21AM -0800, Bill Huey wrote: > Christoph, > > The i_mutex lock the inode structure is also a source of contention > heavy when running a lot of parallel "find"s. I'm sure that folks > would be open to hearing suggestions regarding how to fix that. Christoph, And

Re: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Suparna Bhattacharya
On Fri, Feb 09, 2007 at 08:41:41AM +0300, Ananiev, Leonid I wrote: > > invalidate_inode_pages2() has other callers. I suspect with this > change > > we'll end up leaking EIOCBRETRY back to userspace. > > EIOCBRETRY is used and caught already in do_sync_read() and > do_sync_readv_writev(). > >

Re: [PATCH 2/2] x86_64 irq: Handle irqs pending in IRR during irq migration.

2007-02-08 Thread Eric W. Biederman
> > The version I would up testing is below, and it doesn't work. > I still get "No irq handler for vector" warnings as well as > a couple of complaints from lock/irq debugging.The debugging > doesn't worry me. The fact that I don't have a good way to ensure > I have no more irqs in flight

[BUG] at drivers/char/vt.c:3332 do_blank_screen() on resume

2007-02-08 Thread S.Çağlar Onur
Hi; With 2.6.20, resuming from disk sometimes cannot returns on vt7 where X runs but everything seems working, so just changing to vt1 and returning to vt7 solves the problem. But dmesg shows some BUG() output like [1] whenever this problem occurs I'm using 20070207 snapshot of suspend,

[no subject]

2007-02-08 Thread Priyanka Sharma
unsubscribe linux-kernel -- Priyanka 202.141.151.80/~priyanka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: Re : [PATCH] Compressed ia32 ELF file generation for loading by Gujin 1/3

2007-02-08 Thread Vivek Goyal
On Thu, Feb 08, 2007 at 01:10:58PM +, Etienne Lorrain wrote: > > > I assume you care about this ELF header because you are also a user of > > > the ELF file vmlinux, aren't you? > > > > Yes I am. I use kexec boot loader which has capability to load ELF kernel > > images (vmlinux). That's why

Re: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Andrew Morton
On Fri, 9 Feb 2007 08:41:41 +0300 "Ananiev, Leonid I" <[EMAIL PROTECTED]> wrote: > > > invalidate_inode_pages2() has other callers. I suspect with this > change > > we'll end up leaking EIOCBRETRY back to userspace. > > EIOCBRETRY is used and caught already in do_sync_read() and >

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Ananiev, Leonid I
> invalidate_inode_pages2() has other callers. I suspect with this change > we'll end up leaking EIOCBRETRY back to userspace. EIOCBRETRY is used and caught already in do_sync_read() and do_sync_readv_writev(). Below fixed patch against kernel 2.6.20. >From Leonid Ananiev Fix kernel bug when

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Bharata B Rao
Andrew, On 2/9/07, Andrew Morton <[EMAIL PROTECTED]> wrote: fsaio-add-a-wait-queue-arg-to-the-wait_bit-action-routine.patch fsaio-add-a-wait-queue-arg-to-the-wait_bit-action-routine-gfs2-fix.patch fsaio-rename-__lock_page-to-lock_page_blocking.patch

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: [] > - printf has other side effects, instead stop pretending we support > something else than bash More on printf, `sh', tmpfiles. As we know original problem is: something from binutils is removing output files on failure. > -

Re: forcedeth problems on 2.6.20-rc6-mm3

2007-02-08 Thread Ayaz Abdulla
David Ford wrote: On 2/5/07, *Andrew Morton* <[EMAIL PROTECTED] > wrote: On Sun, 04 Feb 2007 23:48:33 -0600 Robert Hancock <[EMAIL PROTECTED] > wrote: > Andrew Morton wrote: > > On Sun, 04 Feb 2007 23:13:09 -0600 Robert

Re: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Andrew Morton
On Fri, 9 Feb 2007 07:29:31 +0300 "Ananiev, Leonid I" <[EMAIL PROTECTED]> wrote: > >From Leonid Ananiev > > Fix "Kernel BUG at fs/aio.c:509". Return EIOCBRETRY but not EIO if page > is busy. > > Signed-off-by: Leonid Ananiev <[EMAIL PROTECTED]> > > "Kernel BUG at fs/aio.c:509" >

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Dmitry Torokhov
On Thursday 08 February 2007 19:56, Greg KH wrote: > On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: > > On 2/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > >On Thu, 08 Feb 2007 07:43:18 -0500 > > >Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > > > >> Linux Kernel Mailing

[PATCH] aio: fix kernel bug when page is temporally busy

2007-02-08 Thread Ananiev, Leonid I
>From Leonid Ananiev Fix "Kernel BUG at fs/aio.c:509". Return EIOCBRETRY but not EIO if page is busy. Signed-off-by: Leonid Ananiev <[EMAIL PROTECTED]> "Kernel BUG at fs/aio.c:509" http://marc.theaimsgroup.com/?l=linux-kernel=117031052517746=2 is present in 2.6.20 as well as 2.6.19. The

genirq: Add a set_irq_handler_locked() function

2007-02-08 Thread David Gibson
Thomas, as discussed previously over IRC and private email. Please apply. At present set_irq_handler() and all the existing variants take the desc->lock for the irq in question before adjusting the irq's flow handler. This can cause problems for irq chips for which a given interrupt can be

Re: somebody dropped a (warning) bomb

2007-02-08 Thread D. Hazelton
On Thursday 08 February 2007 19:42, Linus Torvalds wrote: > Most C types don't, and some you can't even tell (do pointers generate > "signed" or "unsigned" comparisons? I'll argue that a compiler that > generates signed comparisons for them is broken, but it tends to be > something you can only

Re: [patch 1/3] fs: add an iovec iterator

2007-02-08 Thread Nick Piggin
On Thu, Feb 08, 2007 at 06:03:50PM -0800, Nate Diller wrote: > On 2/8/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > >On Thu, Feb 08, 2007 at 07:49:53PM +, Christoph Hellwig wrote: > >> On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: > >> > Add an iterator data structure to operate

Re: [PATCH] ATA convert GSI to irq on ia64

2007-02-08 Thread Zhang, Yanmin
On Thu, 2007-02-08 at 20:19 -0500, Jeff Garzik wrote: > Zhang, Yanmin wrote: > > If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the > > fixed irq number. On ia64 platform, such numbers are GSI and should be > > converted > > to irq vector. > > > > Below patch against

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Andrew Morton
On Thu, 8 Feb 2007 21:57:50 -0500 "Parag Warudkar" <[EMAIL PROTECTED]> wrote: > >x86-fix-vdso-mapping-for-aout-executables.patch > >a.out executables are presently non-functional. This patch needs more work. > > I have a patch for x86 ready and tested and I should be able to get > the full

-mm merge plans for 2.6.21

2007-02-08 Thread Parag Warudkar
x86-fix-vdso-mapping-for-aout-executables.patch a.out executables are presently non-functional. This patch needs more work. I have a patch for x86 ready and tested and I should be able to get the full thing (x86, ppc, sh and x86_64) out over the weekend. (This time around I got rid of the

Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

2007-02-08 Thread Milton Miller
On Feb 8, 2007, at 4:51 PM, Carl Love wrote: On Thu, 2007-02-08 at 18:21 +0100, Arnd Bergmann wrote: On Thursday 08 February 2007 15:18, Milton Miller wrote: 1) sample rate setup In the current patch, the user specifies a sample rate as a time interval. The kernel is (a) calling

Strange oops in iret_exc with my own module

2007-02-08 Thread Grzegorz Kulewski
Hi, I written really simple and stupid module (the design wasn't mine). One tester of this module provided me the following oops it caused quite often (on many automated tests): [17179765.492000] BUG: unable to handle kernel NULL pointer dereference at virtual address

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Valdis . Kletnieks
On Fri, 09 Feb 2007 00:20:49 +0100, Roman Zippel said: > > The point is, neither $BASH nor /bin/bash may be set. > > Is that really a problem? I think any system that has bash without > /bin/bash is simply broken. If you're trying to bootstrap a Linux box onto a new platform from some non-Linux

Re: [patch 1/3 take2] smaps: extract pte walker from smaps code

2007-02-08 Thread David Rientjes
On Thu, 8 Feb 2007, Matt Mackall wrote: > I've been looking at a similar refactoring of other code and I think > the way to go is a callback per block-of-PTEs with start and end > pointers. That gets rid of most of the call indirection overhead. > Yes, but only in a limited number of cases

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Jan Engelhardt
On Feb 8 2007 18:53, Christopher R. Hertel wrote: >>> >>> It does seem to me that it is some sort of name resolution issue, but it may >>> have more to do with the multi-homed nature of your setup. >>> >>> Did you try: >>> >>> mount.cifs //CL0/c /mnt >> >> Yes, that one _fails_ with "mount

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Jan Engelhardt
On Feb 8 2007 18:58, Christopher R. Hertel wrote: >Shirish S Pargaonkar wrote: >> >> So >> 1) try tcp connection on 445, >> then if it works send SMB negprot >> 2) else try tcp connection on port 139 >> then if it works send nbss request to *SMBSERVER or to the name >> specified on

Re: [patch 1/3 take2] smaps: extract pte walker from smaps code

2007-02-08 Thread Matt Mackall
On Wed, Feb 07, 2007 at 03:29:34PM +0900, Paul Mundt wrote: > On Tue, Feb 06, 2007 at 10:15:47PM -0800, David Rientjes wrote: > > Extracts the page table entry walker from the smaps-specific code in > > fs/proc/task_mmu.c. This will be used later for clearing the reference > > bits on pages to

Re: [rfc][patch 0/3] a faster buffered write deadlock fix?

2007-02-08 Thread Nick Piggin
On Thu, Feb 08, 2007 at 04:38:01PM -0800, Mark Fasheh wrote: > On Thu, Feb 08, 2007 at 02:07:15PM +0100, Nick Piggin wrote: > > The problem is that the existing aops interface is crap. "correct, fast, > > compatible -- choose any 2" > > Agreed. There's lots of problems with the interface (imho),

Re: [patch 1/3] fs: add an iovec iterator

2007-02-08 Thread Nate Diller
On 2/8/07, Nick Piggin <[EMAIL PROTECTED]> wrote: On Thu, Feb 08, 2007 at 07:49:53PM +, Christoph Hellwig wrote: > On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: > > Add an iterator data structure to operate over an iovec. Add usercopy > > operators needed by

Re: [patch 1/3] fs: add an iovec iterator

2007-02-08 Thread Nick Piggin
On Thu, Feb 08, 2007 at 07:49:53PM +, Christoph Hellwig wrote: > On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: > > Add an iterator data structure to operate over an iovec. Add usercopy > > operators needed by generic_file_buffered_write, and convert that function > > over. > >

Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 2)

2007-02-08 Thread Benjamin Herrenschmidt
> > Fix threaded user page write memory ordering > > Thanks, I did see that, but I'm sure it must have been prompted by a > discussion or another proposed patch from IBM. Maybe I'm wrong > though. Yes, my initial proposal iirc was to smp_wmb() in set_pte() but after a discussion with Linus, we

Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread H. Peter Anvin
Neil Brown wrote: So does this look right (no, I haven't compiled it yet) No, the whole raid6_*_save_t should be removed. I'll try to have a patch for you later. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 2)

2007-02-08 Thread Benjamin Herrenschmidt
> Fix threaded user page write memory ordering > > Make sure we order the writes to a newly created page > with the page table update that potentially exposes the > page to another CPU. > > This is a no-op on any architecture where getting the > page table spinlock will already do the ordering

Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread Neil Brown
On Thursday February 8, [EMAIL PROTECTED] wrote: > Andi Kleen wrote: > > > > It should use kernel_fpu_begin() imho. If someone wants to test > > it in user space again they can add dummy definitions of that > > to their user space header. > > I hadn't seen this thread until now, when Neil

Re: [PATCH] drivers/telephony/ixj: Convert to generic boolean

2007-02-08 Thread Randy Dunlap
On Thu, 8 Feb 2007 22:39:35 +0100 (MET) Richard Knutsson wrote: > Convert: > BOOL -> bool > FALSE -> false > TRUE -> true > > Change a variable ('mContinue') to boolean from char, since it is used > as boolean. > > Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> Looks good to me. Built

Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 2)

2007-02-08 Thread Nick Piggin
On Fri, Feb 09, 2007 at 12:41:51AM +, Hugh Dickins wrote: > On Thu, 8 Feb 2007, Nick Piggin wrote: > > Still no independent confirmation as to whether this is a problem or not. > > I'm trying to convince myself none of your patch is necessary. Probably > shall fail. But how come we've

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Fri, 9 Feb 2007, Andreas Schwab wrote: > Roman Zippel <[EMAIL PROTECTED]> writes: > > > - printf has other side effects, instead stop pretending we support > > something else than bash > > printf is a much better echo, but you need to use it properly as well. > Either use %s to print

Re: [PATCH] Use correct macros in raid code, not raw asm

2007-02-08 Thread H. Peter Anvin
Andi Kleen wrote: The code looks like it's designed to be included from userspace for testing; as it compiles without this include (and has no other includes), I chose not to add it. Linus makes a good point, but someone who actually knows the code should, y'know, test it and stuff... It

Re: [PATCH] ATA convert GSI to irq on ia64

2007-02-08 Thread Jeff Garzik
Zhang, Yanmin wrote: If an ATA drive uses legacy mode, ata driver will choose 14 and 15 as the fixed irq number. On ia64 platform, such numbers are GSI and should be converted to irq vector. Below patch against kernel 2.6.20 fixes it. Signed-off-by: Zhang Yanmin <[EMAIL PROTECTED]> IA64

Re: somebody dropped a (warning) bomb

2007-02-08 Thread David Rientjes
On Thu, 8 Feb 2007, Linus Torvalds wrote: > Even gcc DOES DIFFERENT THINGS! Have you even read the docs? > > By default it is treated as signed int but this may be changed by > the -funsigned-bitfields option. > Yes, I read the 4.1.1 docs: By default, such a bit-field is

[patch] bugfixes and new hardware support for arcnet driver

2007-02-08 Thread Jeff Morrow
The modifications and bug fixes noted below were done by Realtime Control Works and Contemporary Control Systems, Inc, Jan 2005. They were incorporated into the 2.6 kernel by Jeff Morrow of Sierra Analytics, Feb 2007. <[EMAIL PROTECTED]> The changes have been tested on a Contemporary Controls

Re: somebody dropped a (warning) bomb

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, David Rientjes wrote: > > Maybe you should read my first post, we're talking about gcc's behavior > here, not the C standard. Give it up, David. Even gcc DOES DIFFERENT THINGS! Have you even read the docs? By default it is treated as signed int but this may be

Re: [PATCH] ATA convert GSI to irq on ia64

2007-02-08 Thread Zhang, Yanmin
On Thu, 2007-02-08 at 17:17 +0800, Luming Yu wrote: > sorry, it should be > #define ATA_PRIMARY_IRQ(dev) ide_default_irq(0x1F0) > > On 2/8/07, Luming Yu <[EMAIL PROTECTED]> wrote: > > if use ide_default_irq , then I guess the #if defined can be removed. > > #define ATA_PRIMARY_IRQ(dev)

Re: somebody dropped a (warning) bomb

2007-02-08 Thread David Rientjes
On Thu, 8 Feb 2007, Linus Torvalds wrote: > No it's not. > > You just don't understand the C language. > > And if you don't understand the C language, you can't say "that's what the > int says". It says no such thing. > > The C language clearly says that bitfields have implementation-defined

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Andrew Morton
On Fri, 9 Feb 2007 11:55:40 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Andrew Morton writes: > > > Once a subsystem has a subsystem tree (git or quilt) I basically never > > merge anything which belongs to that tree. It's always > > > > originator->mm->subsystemtree->Linus > > > >

Re: somebody dropped a (warning) bomb

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, Linus Torvalds wrote: > > The C language clearly says that bitfields have implementation-defined > types. Btw, this isn't even some "theoretical discussion". LOTS of compilers do unsigned bitfields. It may even be the majority. There may (or may not) be some correlation

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Christopher R. Hertel
Shirish S Pargaonkar wrote: : > This is what Steve had mailed me once, a while ago > > Win9x and Windows ME and OS/2 only listen on port 139 > > WindowsNT 4 (?) and later listen on port 445 and port 139. > > When you connect on the older port 139, you are supposed to send a > RFC1001 (NBSS

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Christopher R. Hertel
Jan Engelhardt wrote: > On Feb 8 2007 18:29, Christopher R. Hertel wrote: >> Jan Engelhardt wrote: >> >> It does seem to me that it is some sort of name resolution issue, but it may >> have more to do with the multi-homed nature of your setup. >> >> Did you try: >> >> mount.cifs //CL0/c /mnt > >

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 12:29:12PM -0500, Dmitry Torokhov wrote: > On 2/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > >On Thu, 08 Feb 2007 07:43:18 -0500 > >Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Linux Kernel Mailing List wrote: > >> > Gitweb: >

Re: [PATCH 2.6.20] r8169.c: support RTL8169SC/8110SC

2007-02-08 Thread Jeff Garzik
Edward Hsu wrote: This patch is for /driver/net/r8169.c to support RTL8169SC/8110SC, which is a new Realtek Gigabit PCI Ethernet Controller. RTL8110SC's PCI DID is 0x8167, while RTL8110S and RTL8110SB share 0x8169. Signed-off-by: Edward Hsu <[EMAIL PROTECTED]>

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Paul Mackerras
Andrew Morton writes: > Once a subsystem has a subsystem tree (git or quilt) I basically never > merge anything which belongs to that tree. It's always > > originator->mm->subsystemtree->Linus > > If the subsystem tree maintainer wants to tell me "I can't be bothered > setting up a git

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 07:41:30AM -0800, Stephen Hemminger wrote: > On Thu, 08 Feb 2007 07:43:18 -0500 > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Linux Kernel Mailing List wrote: > > > Gitweb: > > >

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 07:43:18AM -0500, Jeff Garzik wrote: > Linux Kernel Mailing List wrote: > >Gitweb: > >http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac560278 > >Commit: 43cb76d91ee85f579a69d42bc8efc08bac560278 >

Re: somebody dropped a (warning) bomb

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, David Rientjes wrote: > > Your struct: > > struct dummy { > int flag:1; > } a_variable; > > should expect a_varible.flag to be signed, that's what the int says. No it's not. You just don't understand the C language. And if you don't

Re: [patch 0/3] 2.6.20 fix for PageUptodate memorder problem (try 2)

2007-02-08 Thread Hugh Dickins
On Thu, 8 Feb 2007, Nick Piggin wrote: > Still no independent confirmation as to whether this is a problem or not. I'm trying to convince myself none of your patch is necessary. Probably shall fail. But how come we've survived for years with such an issue? > Updated some comments, added

Re: device_destroy

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 03:51:08PM +, James Simmons wrote: > > While porting over a few class_devices I discovered a problem with > device_destroy. It uses a dev_t which several classes don't use. > Should all classes require a dev_t or should we just pass in the device > itself? As you

Re: Fw: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take3

2007-02-08 Thread KAMEZAWA Hiroyuki
On Thu, 8 Feb 2007 11:28:30 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > > @@ -193,9 +197,11 @@ > > break; > > case MPOL_BIND: > > policy->v.zonelist = bind_zonelist(nodes); > > - if (policy->v.zonelist == NULL) { > > + if

Re: [rfc][patch 0/3] a faster buffered write deadlock fix?

2007-02-08 Thread Mark Fasheh
On Thu, Feb 08, 2007 at 02:07:15PM +0100, Nick Piggin wrote: > The problem is that the existing aops interface is crap. "correct, fast, > compatible -- choose any 2" Agreed. There's lots of problems with the interface (imho), but my biggest two issues are the page lock being held on

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Jan Engelhardt
On Feb 8 2007 18:29, Christopher R. Hertel wrote: >Jan Engelhardt wrote: > >It does seem to me that it is some sort of name resolution issue, but it may >have more to do with the multi-homed nature of your setup. > >Did you try: > > mount.cifs //CL0/c /mnt Yes, that one _fails_ with "mount

Re: [linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Christopher R. Hertel
Jan Engelhardt wrote: > Hi, > > > I tried the various suggestions from the last mails, but nothing of > that worked. --verbose did not return anything useful. It's the kernel > module that returns -EHOSTDOWN. > > ... > > Eventually I found out that this one works: > > mount.cifs

Re: Git backlight subsystem tree

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 11:50:23PM +, Richard Purdie wrote: > Hi Greg, > > On Thu, 2007-02-08 at 13:23 -0800, Greg KH wrote: > > On Thu, Feb 08, 2007 at 06:32:02PM +, James Simmons wrote: > > > I CC Greg to explain. The backlight class didn't go away. The way it is > > > handled is

Re: somebody dropped a (warning) bomb

2007-02-08 Thread David Rientjes
On Thu, 8 Feb 2007, Linus Torvalds wrote: > No, making bitfields unsigned is actually usually a good idea. It allows > you to often generate better code, and it actually tends to be what > programmers _expect_. A lot of people seem to be surprised to hear that a > one-bit bitfield actually

[PATCH 1/2] NET: Multiple queue network device support

2007-02-08 Thread Kok, Auke
From: Peter Waskiewicz Jr <[EMAIL PROTECTED]> Added an API and associated supporting routines for multiqueue network devices. This allows network devices supporting multiple TX queues to configure each queue within the netdevice and manage each queue independantly. Changes to the PRIO Qdisc

[PATCH 2/2] e1000: Implement the new kernel API for multiqueue TX support.

2007-02-08 Thread Kok, Auke
From: Peter Waskiewicz Jr. <[EMAIL PROTECTED]> Several newer e1000 chipsets support multiple RX and TX queues. Most commonly, 82571's and ESB2LAN support 2 rx and 2 rx queues. Signed-off-by: Peter Waskiewicz Jr. <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> ---

[PATCH 0/2 REVIEW] Multiple transmit/receive queue kernel

2007-02-08 Thread Kok, Auke
Hi, The following two patches are submitted for review. Please provide feedback and comments as usual. This set of patches implements a generic API for multiqueue-capable devices to have network stack support to assign multiple flows into each queue on the NIC. It provides an interface for

Re: somebody dropped a (warning) bomb

2007-02-08 Thread Linus Torvalds
On Fri, 9 Feb 2007, J.A. Magallón wrote: > > Thats the point. Mmmm, I think I see it the other way around. I defined > a variable as 'signed' or 'unsigned', because the sign info matters for me. > And gcc warns about using a function on it that will _ignore_ or even > misinterpret that info.

[linux-cifs-client] Re: SMB support still missing?

2007-02-08 Thread Jan Engelhardt
Hi, I tried the various suggestions from the last mails, but nothing of that worked. --verbose did not return anything useful. It's the kernel module that returns -EHOSTDOWN. ... Eventually I found out that this one works: mount.cifs //cl0/c /mnt -o servernetbiosname=CL0 So what

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Andreas Schwab
Roman Zippel <[EMAIL PROTECTED]> writes: > - printf has other side effects, instead stop pretending we support > something else than bash printf is a much better echo, but you need to use it properly as well. Either use %s to print a literal string or %b to let it interpret escape sequences.

Re: somebody dropped a (warning) bomb

2007-02-08 Thread J.A. Magallón
On Thu, 8 Feb 2007 14:03:06 -0800 (PST), Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Thu, 8 Feb 2007, Linus Torvalds wrote: > > > > But THE CALLER CANNOT AND MUST NOT CARE! Because the sign of "char" is > > implementation-defined, so if you call "strcmp()", you are already > >

Re: Linux header change breaks linux-atm userspace build

2007-02-08 Thread David Miller
From: Andrew Walrond <[EMAIL PROTECTED]> Date: Thu, 8 Feb 2007 21:31:25 + > Sometime between 2.6.18.3 and 2.6.20, this change... > > --- /include/linux/atmarp.h 2007-01-10 16:32:05.0 + > +++ pkg/linux/include/linux/atmarp.h2007-02-08 20:02:08.0 + > @@ -34,7

Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

2007-02-08 Thread Maynard Johnson
Milton, Thank you for your comments. Carl will reply to certain parts of your posting where he's more knowledgeable than I. See my replies below. -Maynard Milton Miller wrote: On Feb 6, 2007, at 5:02 PM, Carl Love wrote: This is the first update to the patch previously posted by

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Andrew Morton
On Thu, 8 Feb 2007 18:34:49 -0500 Kyle McMartin <[EMAIL PROTECTED]> wrote: > On Thu, Feb 08, 2007 at 03:07:10PM -0800, Andrew Morton wrote: > > I'm getting fed up of holding onto hundreds of patches against subsystem > > trees, sending them over and over again seeing and nothing happen. I sent

Re: Git backlight subsystem tree

2007-02-08 Thread Richard Purdie
Hi Greg, On Thu, 2007-02-08 at 13:23 -0800, Greg KH wrote: > On Thu, Feb 08, 2007 at 06:32:02PM +, James Simmons wrote: > > I CC Greg to explain. The backlight class didn't go away. The way it is > > handled is different. > > Have a pointer to the patch so I can help explain better? You've

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Andrew Morton
On Fri, 9 Feb 2007 00:29:06 +0100 (MET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Feb 8 2007 15:07, Andrew Morton wrote: > > >scheduled-removal-of-sa_xxx-interrupt-flags-fixups.patch > >scheduled-removal-of-sa_xxx-interrupt-flags-fixups-2.patch >

Re: Git backlight subsystem tree

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 09:54:21PM +, James Simmons wrote: > > > On Thu, Feb 08, 2007 at 06:32:02PM +, James Simmons wrote: > > > On Thu, 8 Feb 2007, Richard Purdie wrote: > > > > > > > On Thu, 2007-02-08 at 15:28 +, James Simmons wrote: > > > > > I have some patches that move the

Re: somebody dropped a (warning) bomb

2007-02-08 Thread Linus Torvalds
On Thu, 8 Feb 2007, David Rientjes wrote: > > And a compiler that makes a_variable.flag unsigned would be brain-dead > because "int" is always signed. No, making bitfields unsigned is actually usually a good idea. It allows you to often generate better code, and it actually tends to be what

Re: finger @finger.kernel.org -> Connection refused

2007-02-08 Thread Justin Piszcz
On Fri, 9 Feb 2007, Jan Engelhardt wrote: It appears to have been dead for awhile now, did I miss something? One of my scripts uses this functionality, which now appears dead/disabled/offline. Can anyone provide an update? kernel.org front page sayz: Aug 21, 2003: Please don't use

Re: finger @finger.kernel.org -> Connection refused

2007-02-08 Thread Jan Engelhardt
> It appears to have been dead for awhile now, did I miss something? > One of my scripts uses this functionality, which now appears > dead/disabled/offline. > > Can anyone provide an update? kernel.org front page sayz: Aug 21, 2003: Please don't use finger.kernel.org for any sort of automatic

Re: [2.6.20] tifm_7xx1/mmc not working

2007-02-08 Thread Alex Dubov
I'm aware that there are some weird problems with a 2.6.20. I'm currently looking into it. Besides, I wonder, are tifm and sdhci play nicely together? And then, we do know that suspend is totally broken in the older versions of the driver. So it may be desirable to make a test with sdhci

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Kyle McMartin
On Thu, Feb 08, 2007 at 03:07:10PM -0800, Andrew Morton wrote: > I'm getting fed up of holding onto hundreds of patches against subsystem > trees, sending them over and over again seeing and nothing happen. I sent 242 > patches out to subsystem maintainers on Monday and look at what's still here.

[PATCH] drivers/isdn/gigaset: new M101 driver (v2)

2007-02-08 Thread Tilman Schmidt
This patch adds the line discipline based driver for the Gigaset M101 wireless RS232 adapter. It also improves the documentation a bit. Signed-off-by: Tilman Schmidt <[EMAIL PROTECTED]> Signed-off-by: Hansjoerg Lipp <[EMAIL PROTECTED]> --- This is the second version, improved thanks to the

Re: finger @finger.kernel.org -> Connection refused

2007-02-08 Thread Kyle McMartin
On Thu, Feb 08, 2007 at 06:27:17PM -0500, Justin Piszcz wrote: > It appears to have been dead for awhile now, did I miss something? > One of my scripts uses this functionality, which now appears > dead/disabled/offline. > Why not use this instead? http://www.kernel.org/kdist/finger_banner - To

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Jan Engelhardt
On Feb 8 2007 15:07, Andrew Morton wrote: >scheduled-removal-of-sa_xxx-interrupt-flags-fixups.patch >scheduled-removal-of-sa_xxx-interrupt-flags-fixups-2.patch >scheduled-removal-of-sa_xxx-interrupt-flags.patch >scheduled-removal-of-sa_xxx-interrupt-flags-ata-fix.patch > > This removes

[PATCH 2.6.20] r8169.c: support RTL8169SC/8110SC

2007-02-08 Thread Edward Hsu
This patch is for /driver/net/r8169.c to support RTL8169SC/8110SC, which is a new Realtek Gigabit PCI Ethernet Controller. RTL8110SC's PCI DID is 0x8167, while RTL8110S and RTL8110SB share 0x8169. Signed-off-by: Edward Hsu <[EMAIL PROTECTED]>

finger @finger.kernel.org -> Connection refused

2007-02-08 Thread Justin Piszcz
It appears to have been dead for awhile now, did I miss something? One of my scripts uses this functionality, which now appears dead/disabled/offline. Can anyone provide an update? Thanks, Justin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 1/2] Video: fb, add true ref_count atomicity

2007-02-08 Thread Denis Oliver Kropp
Jiri Slaby wrote: video/fb, add true ref_count atomicity Some of fb drivers uses atomic_t in bad manner, since there are still some race-prone gaps. Use mutexes to protect open/close code sections with ref_count testing and finally use simple uint. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

Sata_via problems in a Vintage2-AE1

2007-02-08 Thread Leopold Palomo Avellaneda
Dear people, I have a barebone Asus Vintage2-AE1 [1]. This box has a mobo Asus A8V-MQ. The board has: - the Socket 939 for AMD Athlon 64FX/Athlon 64. - North Bridge: VIA K8M800 - South Bridge: VIA VT8251 - VIA Graphics Integrated - IDE 2 x UltraDMA 133 - 4 x Serial ATA ... I'm using the bios

Re: The who needs reviews anyways [PATCH]

2007-02-08 Thread Roman Zippel
Hi, On Thu, 8 Feb 2007, Linus Torvalds wrote: > On Thu, 8 Feb 2007, Roman Zippel wrote: > > > I don't quite understand, the Makefile doesn't care anymore about /bin/sh > > with this patch, the Makefile checks only for $BASH and /bin/bash > > Exactly. > > The point is, neither $BASH nor

Re: -mm merge plans for 2.6.21

2007-02-08 Thread Roland Dreier
> infiniband-work-around-gcc-bug-on-sparc64.patch > ehca-fix-memleak-on-module-unloading.patch > -> roland Sorry, I misunderstood your email. I thought it was just a CC of stuff you were already merging. I will handle these patches. - R. - To unsubscribe from this list: send the line

Re: somebody dropped a (warning) bomb

2007-02-08 Thread David Rientjes
On Thu, 8 Feb 2007, Linus Torvalds wrote: > Same goes for > > struct dummy { > int flag:1; > } a_variable; > > which could make "a_variable.d" be either signed or unsigned. In the > absense of an explicit "signed" or "unsigned" by the programmer, you > really won't

-mm merge plans for 2.6.21

2007-02-08 Thread Andrew Morton
I'm getting fed up of holding onto hundreds of patches against subsystem trees, sending them over and over again seeing and nothing happen. I sent 242 patches out to subsystem maintainers on Monday and look at what's still here. rtc-pcf8563-detect-polarity-of-century-bit-automatically.patch

[PATCH 5/5] sysctl: Hide the sysctl proc inodes from selinux.

2007-02-08 Thread Eric W. Biederman
Since the security checks are applied on each read and write of a sysctl file, just like they are applied when calling sys_sysctl, they are redundant on the standard VFS constructs. Since it is difficult to compute the security labels on the standard VFS constructs we just mark the sysctl inodes

Re: [patch 1/3] fs: add an iovec iterator

2007-02-08 Thread Mark Fasheh
Hi Nick, On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote: > Add an iterator data structure to operate over an iovec. Add usercopy > operators needed by generic_file_buffered_write, and convert that function > over. I really like this iterator structure - it brings together some

  1   2   3   4   5   6   7   >