Re: GPL vs non-GPL device drivers

2007-02-15 Thread Bernd Petrovitsch
On Thu, 2007-02-15 at 18:40 +1100, Nick Piggin wrote: Ben Nizette wrote: [...] Question to the world here: Distros make, as a matter of course, a series of modifications to the Linux Kernel so that their modules or features work. What stops VJ making a patchset which effectively

[2.6 patch] correct CONFIG_GIGASET_M101 Makefile entry

2007-02-15 Thread Adrian Bunk
Advanced Mathematics, lesson 1: 101 != 105 ;-) Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.20-mm1/drivers/isdn/gigaset/Makefile.old 2007-02-15 17:38:23.0 +0100 +++ linux-2.6.20-mm1/drivers/isdn/gigaset/Makefile 2007-02-15 17:38:41.0 +0100 @@ -5,4 +5,4

[2.6 patch] drivers/isdn/gigaset/: build asyncdata.o into the gigaset module

2007-02-15 Thread Adrian Bunk
This patch fixes the following compile error: -- snip -- ... LD drivers/isdn/gigaset/built-in.o drivers/isdn/gigaset/ser_gigaset.o: In function `gigaset_m10x_send_skb': (.text+0xe50): multiple definition of `gigaset_m10x_send_skb' drivers/isdn/gigaset/usb_gigaset.o:(.text+0x0): first

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 14:34:41 + Ralf Baechle [EMAIL PROTECTED] wrote: On Wed, Feb 14, 2007 at 08:39:03PM -0800, Andrew Morton wrote: Can someone please tell us how this magic works? (And it does appear to work). It seems to assuming that the compiler will assume that members of

Re: 2.6.20-mm1

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 15:37:20 +0100 Michal Piotrowski [EMAIL PROTECTED] wrote: Andrew Morton napisa__(a): Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm1/

Re: [PATCH] do_basic_setup: implicit declaration of function ‘init_irq_proc'

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 16:06:23 +0100 (CET) Geert Uytterhoeven [EMAIL PROTECTED] wrote: Add missing #include linux/irq.h, which caused | init/main.c: In function ‘do_basic_setup’: | init/main.c:705: warning: implicit declaration of function ‘init_irq_proc’ Signed-off-by: Geert Uytterhoeven

[GIT PULL] LED updates

2007-02-15 Thread Richard Purdie
Hi Linus, Could you please pull from: git://git.o-hand.com/linux-rpurdie-leds for-linus This adds two new LED drivers (in my capacity as LEDs maintainer). Thanks, Richard drivers/leds/Kconfig | 12 +++ drivers/leds/Makefile |2 drivers/leds/leds-cobalt.c | 43 +++

possible bug in page allocation mechanism

2007-02-15 Thread Tim Cullen
There appears to be a inconsistenancy with reference counts on pages allocated with alloc_pages when order is greater than zero. In buffered_rmqueue when order != 0 then __rmqueue is called. This returns a page pointer that is really a pointer to the first page in a group of pages. Subsequently

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Ralf Baechle
On Thu, Feb 15, 2007 at 01:53:58PM -0800, Andrew Morton wrote: The whole union thing was only needed to get rid of a warning but Marcel's solution does the same thing by attaching the packed keyword to the entire structure instead, so this patch is now using his macros but using __packed

Re: [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20

2007-02-15 Thread Andrew Morton
On 15 Feb 2007 10:28:57 -0500 [EMAIL PROTECTED] (Frank Ch. Eigler) wrote: akpm wrote: [...] And what can I do with these markers? And once I've done it, are there any userspace applications I can use to get the data out in human-usable form? [...] The LTTng user-space programs

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Jeff Garzik
v j wrote: So far I have heard nothing but, if you don't contribute, screw you. All this is fine. Just say so. Make it black and white. Make it It is black and white in copyright law and the GPL. The /whole point/ of the GPL is to funnel contributions back. We happen to think there are solid

Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 09:49:15 -0600 Corey Minyard [EMAIL PROTECTED] wrote: So I see the following options besides what's already there: 1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an IPMI implementation. 2) use CONFIG_X86 to tell if NMI will work, since that's the

Re: [PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-15 Thread James Simmons
I wouldn't say it orphan. I just can't spend 8 hours a day on it. Alot of patches have been flowing into the layer. On Thu, 15 Feb 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Are we ready to do this? I'd love for Tony to return, but he's been missing for awhile now.

e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Len Brown
e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? thanks, -Len Bringing up loopback interface: [ OK ] Bringing up interface eth0: BUG: unable to handle kernel NULL pointer dereference at virtual address printing eip: *pde = 3747c001

Re: [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On 15 Feb 2007 10:28:57 -0500 [EMAIL PROTECTED] (Frank Ch. Eigler) wrote: akpm wrote: [...] And what can I do with these markers? And once I've done it, are there any userspace applications I can use to get the data out in

Re: somebody dropped a (warning) bomb

2007-02-15 Thread Lennart Sorensen
On Thu, Feb 15, 2007 at 07:57:05AM -0800, Linus Torvalds wrote: I agree that it's unnecessary code, and in many ways exactly the same thing. I just happen to believe that casts tend to be a lot more dangerous than extraneous initializations. Casts have this nasty tendency of hiding *other*

Re: kbuild question

2007-02-15 Thread Sam Ravnborg
On Thu, Feb 15, 2007 at 01:18:52PM -0600, Kumar Gala wrote: I was wondering if there was some way to make a Kconfig menu either be just a menu or a choice depending on another bool being set or not. What I'm trying to accomplish is if CONFIG_ONLY_HAVE_ONE is set I want it so you can only

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Roman Zippel
Hi, On Thu, 15 Feb 2007, David Howells wrote: This is really the weak point - it offers no advantage over an equivalent implementation in user space (e.g. in the module tools). So why has to be done in the kernel? Because the init_module() system call is the common point of module

[PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Marc St-Jean
Seventh attempt at the serial driver patch for the PMC-Sierra MSP71xx devices. There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread David Lang
On Thu, 15 Feb 2007, Roman Zippel wrote: On Thu, 15 Feb 2007, David Howells wrote: It is possible to protect /dev/mem and /dev/kmem or make them unavailable and it is possible to protect the kernel's memory whilst it is running (provided you don't have nommu or broken hardware and you don't

Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

2007-02-15 Thread Sergei Shtylyov
Hello. Marc St-Jean wrote: There are three different fixes: 1. Fix for DesignWare APB THRE errata: In brief, this is a non-standard 16550 in that the THRE interrupt will not re-assert itself simply by disabling and re-enabling the THRI bit in the IER, it is only re-enabled if a character is

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Valdis . Kletnieks
On Wed, 14 Feb 2007 22:14:53 PST, Andreas Gruenbacher said: I agree, that's really what should happen. We solve this by marking modules as supported, partner supported, or unsupported, but in an insecure way, so partners and users could try to fake the support status of a module and/or remove

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Valdis . Kletnieks
On Wed, 14 Feb 2007 23:13:45 EST, Dave Jones said: One argument in its favour is aparently Red Hat isn't the only vendor with something like this. I've not investigated it, but I hear rumours that suse has something similar. Having everyone using the same code would be a win for obvious

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Roman Zippel
Hi, On Thu, 15 Feb 2007, David Lang wrote: this issue, and these holes keep comeing up in discussions, why can't these holes be closed? I seem to remember seeing patches that would remove /dev/kmem being sent to the list, but they weren't accepted into the kernel (and I seem to remember

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Adrian Bunk
On Wed, Feb 14, 2007 at 07:09:38PM +, David Howells wrote: ... There are several reasons why these patches are useful, amongst which are: ... (4) to allow other support providers to do likewise, or at least to _detect_ the fact that unsupported modules are loaded; (5) to allow the

Re: [uml-devel] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted

2007-02-15 Thread Jeff Dike
On Wed, Feb 14, 2007 at 09:51:23PM -0800, Andrew Morton wrote: Whatever happens, please ensure that the final fix makes it into -stable as well. Jeff's version of this patch wasn't cc'ed to [EMAIL PROTECTED] Paolo's patch was sent to -stable. His should be used everywhere, and mine should be

[PATCH] UML - Fix 2.6.20 hang

2007-02-15 Thread Jeff Dike
A previous cleanup misused need_poll, which had a fairly broken interface. It implemented a growable array, changing the used elements count itself, but leaving it up to the caller to fill in the actual elements, including the entire array if the array had to be reallocated. This worked because

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Indan Zupancic
Hello, On Wed, February 14, 2007 20:40, David Howells wrote: Linus Torvalds [EMAIL PROTECTED] wrote: (1) A cut-down MPI library derived from GPG with error handling added. Do we really need to add this? I presume you mean the MPI library specifically? If so, then yes. It's necessary

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Adrian Bunk
On Thu, Feb 15, 2007 at 03:55:41PM -0500, [EMAIL PROTECTED] wrote: On Wed, 14 Feb 2007 23:13:45 EST, Dave Jones said: One argument in its favour is aparently Red Hat isn't the only vendor with something like this. I've not investigated it, but I hear rumours that suse has something

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Andreas Gruenbacher
On Thursday 15 February 2007 12:34, [EMAIL PROTECTED] wrote: On Wed, 14 Feb 2007 22:14:53 PST, Andreas Gruenbacher said: I agree, that's really what should happen. We solve this by marking modules as supported, partner supported, or unsupported, but in an insecure way, so partners and users

Re: [PATCH 0/6] MODSIGN: Kernel module signing

2007-02-15 Thread Valdis . Kletnieks
On Thu, 15 Feb 2007 22:32:40 +0100, Adrian Bunk said: There are different opinions whether the complete source code of the GPLv2 includes in such cases public keys, making it questionable whether your example will survive at court in all jurisdictions. It's no less shaky than the whole

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-15 Thread Jan Engelhardt
Hi, On Feb 14 2007 14:57, Andreas Gruenbacher wrote: [2] pipe: pipe:[439336] (or pipe/[439336]) [3] Always make disconnected paths double-slashed: -- pipe: //pipe/[439336] lazily

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-15 Thread Andreas Gruenbacher
On Thursday 15 February 2007 04:53, Jan Engelhardt wrote: What's the point in changing pipefs... you can *never* reach it *anyway*, even if it was a /-style path, since pipefs is a NOMNT filesystem. The point is that we could then get rid of the special case for MS_NOUSER filesystems like

Re: [patch 05/11] syslets: core code

2007-02-15 Thread Michael K. Edwards
On 2/15/07, Linus Torvalds [EMAIL PROTECTED] wrote: Would it make the interface less cool? Yeah. Would it limit it to just a few linked system calls (to avoid memory allocation issues in the kernel)? Yes again. But it would simplify a lot of the interface issues. Only in toy applications.

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Jeff Garzik
Chris Snook wrote: Collaborating with the competition (coopetition) on a common technology platform reduces costs for anyone who chooses to get involved, giving them a collective competitive edge against anyone who doesn't. This is why there is so much industry interest in F/OSS, and mortal

Re: [PATCH] Don't probe for DDC on VBE1.2

2007-02-15 Thread Zwane Mwaikambo
On Thu, 15 Feb 2007, Randy Dunlap wrote: On Thu, 15 Feb 2007 08:29:49 -0800 (PST) Zwane Mwaikambo wrote: VBE1.2 doesn't support function 15h (DDC) resulting in a 'hang' whilst uncompressing kernel with some video cards. Make sure we check VBE version before fiddling around with DDC.

Re: 2.6.20-mm1

2007-02-15 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: That's shm-make-sysv-ipc-shared-memory-use-stacked-files.patch, brought to us by Eric-who-hasnt-read-Documentation/SubmitChecklist. Sorry I thought I had all of the interesting debugging enabled in my kernel build. It must of fallen out someplace. I

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-15 Thread Christoph Lameter
On Thu, 15 Feb 2007, Andrew Morton wrote: I don't immediately see why that code isn't racy: the page can remain in the pagevec for arbitrary amounts of time and someone can come along and mlock it again. But given the ease with which you're hitting this, it may not be a race. As long as the

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Jeff Garzik
Bernd Petrovitsch wrote: On Thu, 2007-02-15 at 18:40 +1100, Nick Piggin wrote: Rhetorical question: what stops me from taking somebody's copyrighted work, stripping the copyrights or falsely claiming to have a license to redistribute it, then selling it? No one. Well, that's not quite true,

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:01:27 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or directory include/linux/jiffies.h:18:5: warning:

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Gene Heskett
On Thursday 15 February 2007, v j wrote: So far I have heard nothing but, if you don't contribute, screw you. All this is fine. Just say so. Make it black and white. Make it perfectly clear what is and isn't legal. If we can't load proprietary modules, then so be it. It will help everybody if this

Re: 2.6.20 mmc: problem with highspeed SD card

2007-02-15 Thread Eugene Ilkov
On 2/15/07, Pierre Ossman [EMAIL PROTECTED] wrote: Pierre Ossman wrote: Eugene Ilkov wrote: PXAMCI: irq 0004 stat 2140 Hang on. PXAMCI is a MMC controller, right? yes, pxa2xx-mci driver Hmm... depending on where you look, you get different timing schematics. The MMCA 4.2

Re: [PATCH] No need to use -traditional for processing asm in i386/kernel/

2007-02-15 Thread Sam Ravnborg
On Thu, Feb 15, 2007 at 01:19:12PM -0800, Jeremy Fitzhardinge wrote: No need to use -traditional for processing asm in i386/kernel/ Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED] Any possibility that you could 'fix' the three remaining uses of -traditional in i386? Sam - To

Re: 2.6.20-mm1

2007-02-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 15 February 2007 14:14, Andrew Morton wrote: - The IDE tree got dropped due to various linkage problems Doh, I guess this is what one gets for not testing modular IDE driver support properly. :( All linkage problems should be fixed now, sorry for that. Bart - To unsubscribe from

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 15 Feb 2007 17:01:27 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or

[PATCH] s3c2410fb: fix un-initialised dev field

2007-02-15 Thread Ben Dooks
The current driver is not setting the dev field in the private data structure, which can lead to an OOPS if the driver tries to report an error. Signed-off-by: Ben Dooks [EMAIL PROTECTED] --- linux-2.6.20/drivers/video/s3c2410fb.c 2007-02-04 18:44:54.0 + +++

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Eric W. Biederman
Len Brown [EMAIL PROTECTED] writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? I'm guessing this is an old bug found by the following bit of debug coded added into since v2.6.20 +#ifdef CONFIG_DEBUG_SHIRQ + if (irqflags IRQF_SHARED) {

Re: [ANNOUNCE] DualFS: File System with Meta-data and Data Separation

2007-02-15 Thread Juan Piernas Canovas
Hi Jörn, On Thu, 15 Feb 2007, [utf-8] Jörn Engel wrote: On Thu, 15 February 2007 19:38:14 +0100, Juan Piernas Canovas wrote: The patch for 2.6.11 is not still stable enough to be released. Be patient ;-) While I don't want to discourage you, this is about the point in development where

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Jeremy Fitzhardinge
Ralf Baechle wrote: Gcc info page says: [...] `packed' The `packed' attribute specifies that a variable or structure field should have the smallest possible alignment--one byte for a variable, and one bit for a field, unless you specify a larger value with the `aligned'

Re: Experimental driver for Ricoh Bay1Controller SD Card readers

2007-02-15 Thread Ivan Babkin
Hi! Apart from that I did the following changes: - implemented suspend/resume support (not tested very much) - named the registers - fixed a bug that caused a major slowdown when modprobed without debug=1 - added writting support (disabled by default, modprobe with write=1) Before you enable

Re: [PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-15 Thread Randy Dunlap
On Thu, 15 Feb 2007 22:26:10 + (GMT) James Simmons wrote: I wouldn't say it orphan. I just can't spend 8 hours a day on it. Alot of patches have been flowing into the layer. So would you like to leave it as Maintained or change it to Odd Fixes? (Maintained = a maintainer) From the

Re: [PATCH 00/05] Linux Kernel Markers - kernel 2.6.20

2007-02-15 Thread Vara Prasad
Andrew Morton wrote: On 15 Feb 2007 10:28:57 -0500 [EMAIL PROTECTED] (Frank Ch. Eigler) wrote: akpm wrote: [...] And what can I do with these markers? And once I've done it, are there any userspace applications I can use to get the data out in human-usable form? [...] The

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Bernd Petrovitsch
On Thu, 2007-02-15 at 17:41 -0500, Jeff Garzik wrote: Bernd Petrovitsch wrote: On Thu, 2007-02-15 at 18:40 +1100, Nick Piggin wrote: Rhetorical question: what stops me from taking somebody's copyrighted work, stripping the copyrights or falsely claiming to have a license to redistribute

Re: 2.6.20-mm1

2007-02-15 Thread Michal Piotrowski
Andrew Morton napisał(a): On Thu, 15 Feb 2007 15:37:20 +0100 Michal Piotrowski [EMAIL PROTECTED] wrote: Andrew Morton napisa__(a): Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ Will appear later at

Re: [PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 13:25:49 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] Are we ready to do this? I'd love for Tony to return, but he's been missing for awhile now. So this give us the following major areas that are marked as Orphan: Firmware loader

Re: [patch] mm: NUMA replicated pagecache

2007-02-15 Thread Lee Schermerhorn
On Thu, 2007-02-15 at 01:38 +0100, Nick Piggin wrote: On Wed, Feb 14, 2007 at 03:32:04PM -0500, Lee Schermerhorn wrote: On Tue, 2007-02-13 at 07:09 +0100, Nick Piggin wrote: Hi, Just tinkering around with this and got something working, so I'll see if anyone else wants to try it.

Re: 2.6.20-mm1

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 22:30:17 +0100 J.A. Magall__n [EMAIL PROTECTED] wrote: On Thu, 15 Feb 2007 05:14:08 -0800, Andrew Morton [EMAIL PROTECTED] wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ Will appear later at

RE: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Ananiev, Leonid I
If EIOCBRETRY then generic_file_aio_write() will be recalled for the same iocb. Only if kick_iocb() is called. It won't be called if i_i_p2_r() was the only thing to return -EIOCBRETRY. It is not need to call kick_iocb() for generic_file_aio_write() calling. It is recalled without any

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Robert Hancock
linux-os (Dick Johnson) wrote: There are a lot of device drivers that will never make it into the mainline kernel because they are for one-of-a-kind devices or boards that companies embed into their products. Nobody would even want a copy of the software to interface with something that they

Re: Modular kernel (2.6.20) and software raid auto detection

2007-02-15 Thread Neil Brown
On Thursday February 15, [EMAIL PROTECTED] wrote: With my ide driver and the md stuff all built into the kernel, my software raid drives and associated /dev/md? devices are detected and created by the kernel. Yep. With the md stuff built in but the ide driver modular and loaded later

Re: 2.6.20-mm1

2007-02-15 Thread J.A. Magallón
On Thu, 15 Feb 2007 15:31:42 -0800, Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 15 Feb 2007 22:30:17 +0100 J.A. Magall__n [EMAIL PROTECTED] wrote: On Thu, 15 Feb 2007 05:14:08 -0800, Andrew Morton [EMAIL PROTECTED] wrote: Temporarily at

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 22:18:39 + Ralf Baechle [EMAIL PROTECTED] wrote: On Thu, Feb 15, 2007 at 01:53:58PM -0800, Andrew Morton wrote: The whole union thing was only needed to get rid of a warning but Marcel's solution does the same thing by attaching the packed keyword to the entire

Re: [PATCH 9/11] Panic delay fix

2007-02-15 Thread Zachary Amsden
Pavel Machek wrote: You know it is ugly. Alan demonstrated it even hurts performance, but being ugly is the main problem. No argument with that. Well, we're ok with dropping it. Actually, reverting the entire set of udelay changes now seems wise. The same bug that happened with i8042

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Bodo Eggert
v j [EMAIL PROTECTED] wrote: So far I have heard nothing but, if you don't contribute, screw you. That's exactly what you tell to the linux community: If they don't contribute to your project *FOR*NOTHING*IN*RETURN*, you'll punish them by - stamping your feet, crying out loud and *paying* for

Re: kbuild question

2007-02-15 Thread Kumar Gala
On Feb 15, 2007, at 4:33 PM, Sam Ravnborg wrote: On Thu, Feb 15, 2007 at 01:18:52PM -0600, Kumar Gala wrote: I was wondering if there was some way to make a Kconfig menu either be just a menu or a choice depending on another bool being set or not. What I'm trying to accomplish is if

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:46:56 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Me too. It's due to the linux-kernel-markers patches. Mathieu, can you take a look please? I will give a deeper look in sparse, but I should say up front that I add this to the root build tree Makefile :

Re: [PATCH] No need to use -traditional for processing asm in i386/kernel/

2007-02-15 Thread Jeremy Fitzhardinge
Sam Ravnborg wrote: On Thu, Feb 15, 2007 at 01:19:12PM -0800, Jeremy Fitzhardinge wrote: No need to use -traditional for processing asm in i386/kernel/ Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED] Any possibility that you could 'fix' the three remaining uses of

Re: Linux 2.6.16.41-rc1

2007-02-15 Thread S.Çağlar Onur
Hi; 15 Şub 2007 Per tarihinde şunları yazmıştınız: Location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git Changes since 2.6.16.40: What about CVE-2006-6333, CVE-2006-5753 and

Re: [PATCH 9/11] Panic delay fix

2007-02-15 Thread Pavel Machek
Hi! You know it is ugly. Alan demonstrated it even hurts performance, but being ugly is the main problem. No argument with that. Well, we're ok with dropping it. Actually, reverting the entire set of udelay changes now seems wise. The same bug Good, thanks.

Re: [-mm patch] pci_iomap_regions error handling fix (was Re: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Fri, 16 Feb 2007 16:41:59 + Frederik Deweerdt [EMAIL PROTECTED] wrote: On Thu, Feb 15, 2007 at 05:14:08AM -0800, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ Hi, It appears that the pcim_iomap_regions() function doesn't get the error

Re: [PATCH 9/11] Panic delay fix

2007-02-15 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: So Rusty, Chris, Jeremy, any objections to killing udelay() and friends in paravirt-ops? It would simplify things a bit. The only thing we lose is a slightly faster boot time in the 100% emulated device case. I'm ok with losing that. Even the PIT fast paths don't use

[PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ [...] +unify-queue_delayed_work-and-queue_delayed_work_on.patch I'm getting oops in delayed_work_timer_fn, since cwq-wq is NULL and accessed there. The patch below fixes the problem for me. -- unify

Re: [ANNOUNCE] DualFS: File System with Meta-data and Data Separation

2007-02-15 Thread Andi Kleen
Also many storage subsystems have some internal parallelism in writing (e.g. a RAID can write on different disks in parallel for a single partition) so i'm not sure your distinction is that useful. But we are talking about a different case. What I have said is that if you use two devices,

Re: [PATCH] aio: fix kernel bug when page is temporally busy

2007-02-15 Thread Zach Brown
On Feb 15, 2007, at 3:32 PM, Ananiev, Leonid I wrote: If EIOCBRETRY then generic_file_aio_write() will be recalled for the same iocb. Only if kick_iocb() is called. It won't be called if i_i_p2_r() was the only thing to return -EIOCBRETRY. It is not need to call kick_iocb() for

Re: Linux 2.6.16.41-rc1

2007-02-15 Thread Adrian Bunk
On Fri, Feb 16, 2007 at 01:49:45AM +0200, S.Çağlar Onur wrote: Hi; 15 Şub 2007 Per tarihinde şunları yazmıştınız: Location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git

Re: [2.6 patch] correct CONFIG_GIGASET_M101 Makefile entry

2007-02-15 Thread Tilman Schmidt
Am 15.02.2007 22:56 schrieb Adrian Bunk: Advanced Mathematics, lesson 1: 101 != 105 Ouch. Sorry. Thanks for catching that one. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Tilman Schmidt [EMAIL PROTECTED] --- --- linux-2.6.20-mm1/drivers/isdn/gigaset/Makefile.old

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Michael K. Edwards
On 2/15/07, Jeff Garzik [EMAIL PROTECTED] wrote: v j wrote: So far I have heard nothing but, if you don't contribute, screw you. All this is fine. Just say so. Make it black and white. Make it It is black and white in copyright law and the GPL. The /whole point/ of the GPL is to funnel

[PATCH] shm: Fix the locking and cleanup error handling in do_shmat.

2007-02-15 Thread Eric W. Biederman
When enhancing do_shmat I forgot to take into account that shm_lock is a spinlock, and was allocating memory with the lock held. This patch fixes that by grabbing a reference to the dentry and mounts of shm_file before we drop the shm_lock and then performing the memory allocations. This is

Re: [PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Jiri Slaby napsal(a): [...] unify queue_delayed_work and queue_delayed_work_on fix Oh sorry, the name should be make queue_delayed_work() friendly to flush_fork() fix Since cwq-wq is unset for other than singlethread_cpu when singlethread workqueue was created, an oops occurs during bootup.

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Greg Trounson
Theodore Tso wrote: On Wed, Feb 14, 2007 at 10:27:10PM -0800, v j wrote: You are right. I have not contributed anything to Linux. Except one small patch to the MTD code. However, I don't think that is the point here. I am perfectly willing to live with the way Linux is today. I am telling you

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Jeremy Fitzhardinge
Andrew Morton wrote: hm. So if I have struct bar { unsigned long b; } __attribute__((packed)); struct foo { unsigned long u; struct bar b; }; then the compiler can see that foo.b.b is well-aligned, regardless of the

Re: [2.6 patch] drivers/isdn/gigaset/: build asyncdata.o into the gigaset module

2007-02-15 Thread Tilman Schmidt
Am 15.02.2007 22:56 schrieb Adrian Bunk: This patch fixes the following compile error: -- snip -- ... LD drivers/isdn/gigaset/built-in.o drivers/isdn/gigaset/ser_gigaset.o: In function `gigaset_m10x_send_skb': (.text+0xe50): multiple definition of `gigaset_m10x_send_skb'

Re: [PATCH] shm: Fix the locking and cleanup error handling in do_shmat.

2007-02-15 Thread Michal Piotrowski
Eric W. Biederman napisał(a): When enhancing do_shmat I forgot to take into account that shm_lock is a spinlock, and was allocating memory with the lock held. This patch fixes that by grabbing a reference to the dentry and mounts of shm_file before we drop the shm_lock and then performing

Re: 2.6.20-mm1

2007-02-15 Thread Andrew Morton
On Fri, 16 Feb 2007 00:24:35 +0100 Michal Piotrowski [EMAIL PROTECTED] wrote: Andrew Morton napisa__(a): On Thu, 15 Feb 2007 15:37:20 +0100 Michal Piotrowski [EMAIL PROTECTED] wrote: Andrew Morton napisa__(a): Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ Will

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Lee Revell
On 2/15/07, Greg Trounson [EMAIL PROTECTED] wrote: Theodore Tso wrote: On Wed, Feb 14, 2007 at 10:27:10PM -0800, v j wrote: You are right. I have not contributed anything to Linux. Except one small patch to the MTD code. However, I don't think that is the point here. I am perfectly willing

Re: [PATCH] shm: Fix the locking and cleanup error handling in do_shmat.

2007-02-15 Thread Michal Piotrowski
Eric W. Biederman napisał(a): When enhancing do_shmat I forgot to take into account that shm_lock is a spinlock, and was allocating memory with the lock held. This patch fixes that by grabbing a reference to the dentry and mounts of shm_file before we drop the shm_lock and then performing

Re: [patch 4/4] ipmi: add new IPMI nmi watchdog handling

2007-02-15 Thread Corey Minyard
Andrew Morton wrote: On Thu, 15 Feb 2007 09:49:15 -0600 Corey Minyard [EMAIL PROTECTED] wrote: So I see the following options besides what's already there: 1) add asm/kdebug.h and DIE_NMI_POST to everything that might have an IPMI implementation. 2) use CONFIG_X86 to tell if NMI will

[PATCH] sparse chokes on arch/i386/kernel/i8253.c

2007-02-15 Thread Mathieu Desnoyers
sparse chokes on arch/i386/kernel/i8253.c Here is a marker fix that puts the correct -i include/linux/marker.h in the top level Makefile so sparse works correctly. The tricky part is to keep the kernel compiling correctly with a kernel build directory different from the kernel source tree too.

Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

2007-02-15 Thread Arnd Bergmann
On Thursday 15 February 2007 22:50, Paul E. McKenney wrote: Is this 1.5ms with interrupts disabled?  This time period is problematic from a realtime perspective if so -- need to be able to preempt. No, interrupts should be enabled here. Still, 1.5ms is probably a little too long without a

Re: [Cbe-oss-dev] [RFC, PATCH] CELL Oprofile SPU profiling updated patch

2007-02-15 Thread Maynard Johnson
Arnd Bergmann wrote: On Thursday 15 February 2007 00:52, Carl Love wrote: --- linux-2.6.20-rc1.orig/arch/powerpc/oprofile/Kconfig 2007-01-18 16:43:14.0 -0600 +++ linux-2.6.20-rc1/arch/powerpc/oprofile/Kconfig 2007-02-13 19:04:46.271028904 -0600 @@ -7,7 +7,8 @@ config

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Scott Preece
On 2/15/07, Stuart MacDonald [EMAIL PROTECTED] wrote: Linus does allow for one exception; drivers written for other OSes that happen to compile for Linux as well. I believe this is the POSIX exception mentioned elsethread. However, from your description of requiring GPL-only symbols, I'm pretty

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Jeff Garzik
Michael K. Edwards wrote: On 2/15/07, Jeff Garzik [EMAIL PROTECTED] wrote: v j wrote: So far I have heard nothing but, if you don't contribute, screw you. All this is fine. Just say so. Make it black and white. Make it It is black and white in copyright law and the GPL. The /whole point/ of

Re: GPL vs non-GPL device drivers

2007-02-15 Thread Greg Trounson
Lee Revell wrote: On 2/15/07, Greg Trounson [EMAIL PROTECTED] wrote: Theodore Tso wrote: On Wed, Feb 14, 2007 at 10:27:10PM -0800, v j wrote: You are right. I have not contributed anything to Linux. Except one small patch to the MTD code. However, I don't think that is the point here. I am

RE: GPL vs non-GPL device drivers

2007-02-15 Thread David Schwartz
I must have missed something, who is trying to coerce people into not exercising the rights the GPL gave them? Anyone who claims that it is unlawful to circumvent the EXPORT_SYMBOL_GPL stuff. Anyone who adds copyright or license enforcement mechansims to GPL'd code and distributes the result.

Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 19:23:47 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: sparse chokes on arch/i386/kernel/i8253.c Here is a marker fix that puts the correct -i include/linux/marker.h in the top level Makefile so sparse works correctly. The tricky part is to keep the kernel compiling

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 15 Feb 2007 17:46:56 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Me too. It's due to the linux-kernel-markers patches. Mathieu, can you take a look please? I will give a deeper look in sparse, but I should say up front that I

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Ralf Baechle
On Thu, Feb 15, 2007 at 03:38:23PM -0800, Andrew Morton wrote: hm. So if I have struct bar { unsigned long b; } __attribute__((packed)); struct foo { unsigned long u; struct bar b; }; then the compiler can see that

Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 05:08:21 -0500 Andres Salomon [EMAIL PROTECTED] wrote: Initial framework for disabling PS/2 protocol extensions. The current protocols can only be disabled if CONFIG_EMBEDDED is selected. No source files are changed, merely build stuff. ugleee. What benefit do we get

Re: [patch 1/3] Input: psmouse - create PS/2 protocol options for Kconfig

2007-02-15 Thread Andres Salomon
Andrew Morton wrote: On Thu, 15 Feb 2007 05:08:21 -0500 Andres Salomon [EMAIL PROTECTED] wrote: Initial framework for disabling PS/2 protocol extensions. The current protocols can only be disabled if CONFIG_EMBEDDED is selected. No source files are changed, merely build stuff. ugleee.

Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 15 Feb 2007 19:23:47 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: sparse chokes on arch/i386/kernel/i8253.c Here is a marker fix that puts the correct -i include/linux/marker.h in the top level Makefile so sparse works correctly.

<    4   5   6   7   8   9   10   11   >