Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Miles Lane
On 7/18/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Tejun Heo wrote: > > Satyam Sharma wrote: > sysfs_find_dirent() -- to check for -EEXIST -- should be called > *before* we create the new dentry for the to-be-created symlink >

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: >> IMO the only reasonable solution is to disallow interrupt forwarding >> with shared irqs. If someone later comes up with a bright idea, we can >> > > Which means you are back to ISA bus devices. Even checking if an IRQ is > currently unshared isn't simple as with hotplug

Re: [PATCH] fs: Add romfs version 2

2007-07-18 Thread Tim Bird
Lindsay Roberts wrote: > Yes, my experience has been that it has been almost chillingly close > to .5k per regular file increase in partition size. I know in > applications in which size is utterly critical this may be slightly > unattractive, but in cases where romfs is chosen for its byte >

RE: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
>> In particular, this requires interrupt handling to be done by the >guest -- >> The host shouldn't load the corresponding device driver or otherwise >access >> the device. Since the host kernel is not aware of the device semantics >it >> cannot acknowledge the interrupt at the device level. >

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> IMO the only reasonable solution is to disallow interrupt forwarding > with shared irqs. If someone later comes up with a bright idea, we can Which means you are back to ISA bus devices. Even checking if an IRQ is currently unshared isn't simple as with hotplug this may change. > implement

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Tejun Heo wrote: > Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [ It's weird to grab a reference on the

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: >> What if we will force the specific device to the end of the list. Once >> IRQ_NONE was returned by the other devices, we will mask the irq, >> forward the irq to the guest, issue a timer for 1msec. Motivation: >> 1msec is long enough for the guest to ack the irq + host unmask

[PATCH v3 2/2] SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel

2007-07-18 Thread Paul Moore
These changes will make NetLabel behave like labeled IPsec where there is an access check for both labeled and unlabeled packets as well as providing the ability to restrict domains to receiving only labeled packets when NetLabel is in use. The changes to the policy are straight forward with the

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-18 Thread Ingo Molnar
* Olaf Kirch <[EMAIL PROTECTED]> wrote: > > also, i'm using netconsole via the command line (both the network > > driver and netconsole is built into the bzImage), maybe that makes a > > difference? > > Possibly - but so far there's nothing in the code that jumped at me. > > Can you try the

[PATCH v3 0/2] The comedy of errors patchset (was: SELinux NetLabel updates)

2007-07-18 Thread Paul Moore
This rev of the patchset solves both the original problem that Michal posted involving backwards compatibility with old SELinux policy as well as the problem Linus posted about the fix not working correctly when CONFIG_NETLABEL was not set. I also tried to fixup the #ifdefs in

[PATCH v3 1/2] NetLabel: enable dynamic activation/deactivation of NetLabel/SELinux enforcement

2007-07-18 Thread Paul Moore
Create a new NetLabel KAPI interface, netlbl_enabled(), which reports on the current runtime status of NetLabel based on the existing configuration. LSMs that make use of NetLabel, i.e. SELinux, can use this new function to determine if they should perform NetLabel access checks. This patch

Re: XFS -git changes and Linux-VServer patch porting

2007-07-18 Thread Josef Sipek
On Wed, Jul 18, 2007 at 03:49:07PM +0200, Radoslaw Szkodzinski wrote: > Linux-VServer patch adds 2 new flags: barrier and iunlink. > With recent changes in -git (filestreams), XFS now lacks di_flags bits > to add these. > iunlink flag adds Copy-on-Write semantics to hard links, while barrier >

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
> What if we will force the specific device to the end of the list. Once > IRQ_NONE was returned by the other devices, we will mask the irq, > forward the irq to the guest, issue a timer for 1msec. Motivation: > 1msec is long enough for the guest to ack the irq + host unmask the irq It makes no

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Tejun Heo wrote: > Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [ It's weird to grab a reference on the target for ourselves (and in fact even allocate

Re: [RFT][PATCH v7] sata_mv: convert to new EH

2007-07-18 Thread dean gaudet
On Wed, 18 Jul 2007, Pasi Kärkkäinen wrote: > What brand/model your sata_mv controller is? Would be nice to know to be > able to get a "known-to-work" one.. http://supermicro.com/products/accessories/addon/AoC-SAT2-MV8.cfm -dean

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 17:18:34 +0200 (CEST) Jan Engelhardt wrote: > Hi, > > > On Jul 16 2007 20:49, Stefan Richter wrote: > > > >It is an error to add visible Kconfig options without help text. Among > >them are the new "menuconfig" options. Jan obviously never uses "make > >oldconfig". > >

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > Readability, fewer LOC, 308 lesser bytes in kernel image and > faster for the common case -- not good enough for you?! Oh, well. Sorry, not agreed on readability. The rest doesn't really matter too much and please stop

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-18 Thread Rene Herman
On 07/18/2007 03:32 PM, William Lee Irwin III wrote: On Tue, Jul 17, 2007 at 09:33:08PM +0200, Andrea Arcangeli wrote: kmalloced 4k naturally aligned object into userland). I wouldn't call it tail packing, it's more a fine-granular pagecache with the already available kmalloc granularities.

[PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread Avi Kivity
Commit 9d9bbd4d247a674deb43565582151acdc22e90d1 makes CONFIG_CMPXCHG64 dependent on CONFIG_HIGHMEM64G, but KVM guest SMP support now also requires CMPXCHG64 while not being tied to PAE. So the effect of that patch is to disable KVM on non-PAE configs. Untangle those dependencies by: - having

Re: Q: a bogus task_running() check in try_to_wake_up() ?

2007-07-18 Thread Oleg Nesterov
On 07/17, Ingo Molnar wrote: > > * Oleg Nesterov <[EMAIL PROTECTED]> wrote: > > > try_to_wake_up: > > > > if (p->se.on_rq) > > goto out_running; > > > > ... > > > > if (unlikely(task_running(rq, p))) > > goto out_activate; > > > > How it possible that

Re: [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Zachary Amsden
Rusty Russell wrote: The main effect is to change the definition of "struct desc_struct" to a union of more complex types. Yay! Someone finally killed it. Every time I tried to kill it, I ended up off in the weeds chasing some bug. diff -r 656f3ff2c9ce arch/i386/kernel/process.c @@

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: >> > sysfs_find_dirent() -- to check for -EEXIST -- should be called >> > *before* we create the new dentry for the to-be-created symlink >> > in the first place. [ It's weird to grab a reference on the target >> > for ourselves (and in fact even allocate the new dirent for

Re: [PATCH 4/10] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE

2007-07-18 Thread Akinobu Mita
> >[...] However, it might break slab. > >If I am not mistaken, slab code initializes multiple objects in > >CPU_UP_PREPARE and relies on the CPU_UP_CANCELLED to destroy the > >objects which successfully got initialized before the some object's > >initialization went bad. > > My testing machine

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-18 Thread Nick Piggin
Nish Aravamudan wrote: Well, before these changes, the only guarantee msleep() could make, just like the only guarantee schedule_timeout() could make, was that it would not return early. The 1-jiffy sleep was always tough to deal with, because of rounding and such. And it's simply exacerbated

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Anthony Liguori
Jeff Dike wrote: On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote: I'm planning on breaking this interface again since the new hypercall API only takes 4 arguments instead of 6. Is anything written anywhere about this hypercall interface? I've posted patches. I'll

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread Arjan van de Ven
On Sat, 2007-07-14 at 12:37 -0400, James Morris wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture. > > Needlessly exported LSM symbols have been unexported, to

Re: [ofa-general] Re: Further 2.6.23 merge plans...

2007-07-18 Thread Roland Dreier
> We actually use the OFED 1.2 version. So, this feature is in use, but not > this > specific implementation. Hmm... how much testing has the implementation being proposed for merging actually had? It might still be OK if the answer is that it hasn't been tested at scale but that the basic

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: >> On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> > Satyam Sharma wrote: >> > > On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> > >> There is a subtle bug in sysfs_create_link() failure path. When >> > >> symlink creation fails because there's already a node with the

RE: [ofa-general] Re: Further 2.6.23 merge plans...

2007-07-18 Thread Sean Hefty
>> With OFED 1.2 version of the code, right? >> >> >Yes. >But maybe they also used the new module - Sean? We actually use the OFED 1.2 version. So, this feature is in use, but not this specific implementation. - Sean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH] CFS: Fix missing digit off in wmult table

2007-07-18 Thread Ingo Molnar
* Roman Zippel <[EMAIL PROTECTED]> wrote: > Don't make such suggestions if you have no idea how insulting they > are. Especially the one deleted insult above where you have the > impertinence to quote it, such tone is more appropriate between lord > and inferior, where the latter have to make

Re: Occational lockups during boot with post 2.6.22 kernels

2007-07-18 Thread Johannes Berg
On Wed, 2007-07-18 at 10:58 -0400, Chuck Ebbert wrote: > On 07/17/2007 08:20 PM, Peter Osterlund wrote: > > Current -git kernels sometimes lock up on my computer during boot. I > > guess it happens about 10-20% of the time. I first saw this maybe a > > week ago, but never with kernels <= 2.6.22. >

Re: PS3 Storage Driver O_DIRECT issue

2007-07-18 Thread Geert Uytterhoeven
On Fri, 13 Jul 2007, Olaf Hering wrote: > This driver (or the generic PS3 code) has appearently problems with > O_DIRECT. > glibc aborts parted because the malloc metadata get corrupted. While it > is reproducible, the place where it crashes changes with every version > of the debug attempt. > I

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > A trivial nit: > > The cleanup ignores the return of sysfs_addrm_finish() -- functions > such as those could and should be void-returning. It doesn't even > need to return an int for success / failure ... I went over it's

Re: [PATCH] posix-timer: fix deletion race

2007-07-18 Thread Oleg Nesterov
On 07/17, Jeremy Katz wrote: > > This is with the patch (and 2.6.22.1 and hrt6): > > [ cut here ] > Kernel BUG at c0125adb [verbose debug info unavailable] > invalid opcode: [#1] > SMP > Modules linked in: > CPU:3 > EIP:0060:[]Not tainted VLI > EFLAGS:

Re: [patch] CFS scheduler, -v19

2007-07-18 Thread Linus Torvalds
On Tue, 17 Jul 2007, Ingo Molnar wrote: > > * Ian Kent <[EMAIL PROTECTED]> wrote: > > > > In several places I have code similar to: > > > > wait.tv_sec = time(NULL) + 1; > > wait.tv_nsec = 0; Ok, that definitely should work. Does the patch below help? > ah! It passes in a low-res time

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: >> Well, I dunno. Probably my taste just sucks. Please feel free to >> submit patches and/or suggest better ideas. > > OK, for example: > > sysfs_find_dirent() -- to check for -EEXIST -- should be called > *before* we create

[RFC] fix slub krealloc()

2007-07-18 Thread Johannes Berg
Commit ef2ad80c7d255ed0449eda947c2d700635b7e0f5 breaks krealloc(NULL, ...) badly, it BUG_ON()s. This patch fixes it but the fix should probably be in mm/util.c because the documentation says that krealloc(NULL, x, gfp) is equivalent to kmalloc(x, gfp) and that's not true any more even after this

Re: [PATCH] CFS: Fix missing digit off in wmult table

2007-07-18 Thread Ingo Molnar
* Roman Zippel <[EMAIL PROTECTED]> wrote: > > _changing_ it is an option within reason, and we've done it a couple > > of times already in the past, and even within CFS (as Peter > > correctly observed) we've been through a couple of iterations > > already. And as i mentioned it before, the

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread H. Peter Anvin
Andi Kleen wrote: > >> Already with these patches I can compile a zImage kernel that is 450kb >> large (890kb decompressed) > > The important part is not how big the vmlinux is, but how much > memory is actually used after boot. > > I expect concentrating some of the dynamic data structures

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Stefan Richter
Jan Engelhardt wrote: > On Jul 16 2007 20:49, Stefan Richter wrote: >> >>It is an error to add visible Kconfig options without help text. Among >>them are the new "menuconfig" options. Jan obviously never uses "make >>oldconfig". > > Untrue. Users of menuconfig/xconfig/gconfig who do not know

Re: [RFC] Deferred interrupt handling.

2007-07-18 Thread Lennart Sorensen
On Wed, Jul 18, 2007 at 12:53:19PM +0300, Or Sagi wrote: > Gentlepeople, > > We're currently working on PCI device pass-through support for KVM. In this > model all physical hardware access to specific devices will be performed by > the VM, and not by the host. > > In particular, this requires

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: >> sysfs_find_dirent() -- to check for -EEXIST -- should be called >> *before* we create the new dentry for the to-be-created symlink >> in the first place. [ It's weird to grab a reference on the target >> for ourselves (and in fact even allocate the new dirent for the >>

i386-show-unhandled-signals-v3

2007-07-18 Thread Masoud Asgharifard Sharbiani
Hello, This patch makes the i386 behave the same way that x86_64 does when a segfault happens. A line gets printed to the kernel log so that tools that need to check for failures can behave more uniformly between debug.show_unhandled_signals sysctl variable to 0 (or by doing echo 0 >

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-18 Thread Greg KH
On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote: > commit ae97fec3701a559929c3529e35417fab133a4d39 > Author: Jeff Garzik <[EMAIL PROTECTED]> > Date: Tue Jul 17 01:08:29 2007 -0400 > > drivers/usb/misc/auerswald: fix status check, remove redundant check > > 1) We should

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: >> Well, I dunno. Probably my taste just sucks. Please feel free to >> submit patches and/or suggest better ideas. > > OK, for example: > > sysfs_find_dirent() -- to check for -EEXIST -- should be called > *before* we create the new dentry for the to-be-created symlink >

setserial -> serial_core / 8250 interaction

2007-07-18 Thread George McCollister
I've recently found (using 2.6.21.4) that configuring a serial ports (ST16654) which use the 8250 driver using setserial results in the UART's FIFOs being disabled (unless you specify autoconfig). The problem is that setserial doesn't fill out xmit_fifo_size when calling TIOCSSERIAL to set the

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Hugh Dickins
On Wed, 18 Jul 2007, Jens Axboe wrote: > > We have these checks scattered, makes sense to put them in > set_page_dirty() instead. This also fixes a bug where __bio_unmap_user() > does set_page_dirty_lock() without checking for a compound page, instead > of adding one more check we move it to

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Geert Uytterhoeven
On Wed, 18 Jul 2007, Jan Engelhardt wrote: > On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > > - Implemented as a block device driver with a dynamic major > > - Disk names (and partitions) are of the format ps3d%c(%u) > > - Uses software

[PATCH] eHEA: Fix bonding support

2007-07-18 Thread Thomas Klein
The driver didn't allow an interface's MAC address to be modified if the respective interface wasn't setup - a failing Hcall was the result. Thus bonding wasn't usable. The fix moves the failing Hcall which was registering a MAC address for the reception of BC packets in firmware from the port up

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: Hi, On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Satyam Sharma wrote: > > On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > >> There is a subtle bug in sysfs_create_link() failure path. When > >> symlink creation fails because there's

[PATCH] NFSv4: handle lack of clientaddr in option string gracefully

2007-07-18 Thread Jeff Layton
If a NFSv4 mount is attempted with string based options, and the option string doesn't contain a clientaddr= option, the kernel will currently oops. Check for this situation and return a proper error. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/nfs/super.c b/fs/nfs/super.c

[PATCH] rtc: update and use the MAX6900 century byte

2007-07-18 Thread Dale Farnsworth
We now read and write the century byte in the max6900 chip. We probably don't need to do so on Linux-only system, but it's necessary when the chip is shared by another OS that uses the century byte. Signed-off-by: Dale Farnsworth <[EMAIL PROTECTED]> --- drivers/rtc/rtc-max6900.c | 96

Re: [PATCH] stacked ifs (was Re: [PATCH 02/12] handle multiple network paths to AoE device)

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 17:01, Greg KH wrote: >> >> > > ugh. Do this: >> > > >> > > do { >> > > if (t == d->htgt) >> > > continue; >> > > if (!(*t)->ifp->nd) >> > > continue; >> > > if ((*t)->nout >= (*t)->maxout) >> > >

Re: [2.6.23 PATCH 07/18] dm io: fix panic on large request

2007-07-18 Thread Chuck Ebbert
On 07/17/2007 09:16 AM, Patrick McHardy wrote: > Alasdair G Kergon wrote: >> From: "Jun'ichi Nomura" <[EMAIL PROTECTED]> >> >> bio_alloc_bioset() will return NULL if 'num_vecs' is too large. >> Use bio_get_nr_vecs() to get estimation of maximum number. >> >> Signed-off-by: "Jun'ichi Nomura"

Re: [Linux-fbdev-devel] [PATCH] fbdev: find mode with highest refresh rate in fb_find_mode()

2007-07-18 Thread Antonino A. Daplas
On Wed, 2007-07-18 at 16:38 +0200, Ondrej Zajicek wrote: > On Wed, Jul 18, 2007 at 10:41:02AM +0200, Michal Januszewski wrote: > > Currently if the refresh rate is not specified fb_find_mode() returns > > the first known video mode with the requested resoluion, which provides > > no guarantees wrt

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Jan Engelhardt
Hi, On Jul 16 2007 20:49, Stefan Richter wrote: > >It is an error to add visible Kconfig options without help text. Among >them are the new "menuconfig" options. Jan obviously never uses "make >oldconfig". Untrue. Users of menuconfig/xconfig/gconfig who do not know what an item is supposed to

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
Hi, On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> There is a subtle bug in sysfs_create_link() failure path. When >> symlink creation fails because there's already a node with the same >> name, the target

Re: System hangs on running kernbench

2007-07-18 Thread Chuck Ebbert
On 07/18/2007 05:41 AM, Dhaval Giani wrote: > On Wed, Jul 18, 2007 at 01:07:00AM -0700, Andrew Morton wrote: >> On Wed, 18 Jul 2007 13:26:48 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: >> >>> I was running kernbench on top of 2.6.22-rc6-mm1 and I got a Hangcheck >>> alert (This is when kernbench

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread Antonino A. Daplas
On Wed, 2007-07-18 at 17:52 +0300, Al Boldi wrote: > Antonino A. Daplas wrote: > > On Wed, 2007-07-18 at 16:45 +0300, Al Boldi wrote: > > > Antonino A. Daplas wrote: > > > > On Wed, 2007-07-18 at 13:42 +0300, Al Boldi wrote: > > > > > Geert Uytterhoeven wrote: > > > > > > On Wed, 18 Jul 2007, Sasa

Re: Occational lockups during boot with post 2.6.22 kernels

2007-07-18 Thread Chuck Ebbert
On 07/17/2007 08:20 PM, Peter Osterlund wrote: > Current -git kernels sometimes lock up on my computer during boot. I > guess it happens about 10-20% of the time. I first saw this maybe a > week ago, but never with kernels <= 2.6.22. > > The last reported info on the console is that named is

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: > On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> There is a subtle bug in sysfs_create_link() failure path. When >> symlink creation fails because there's already a node with the same >> name, the target sysfs_dirent is put twice - once by failure path of >>

Re: Slow Soft-RAID 5 performance

2007-07-18 Thread J.A. Magallón
On Wed, 18 Jul 2007 10:56:11 +0100, Rui Santos <[EMAIL PROTECTED]> wrote: > Hi, > > I'm getting a strange slow performance behavior on a recently installed > Server. Here are the details: > ... > > I can get a write throughput of 60 MB/sec on each HD by issuing the > command 'time `dd

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread Al Boldi
Antonino A. Daplas wrote: > On Wed, 2007-07-18 at 16:45 +0300, Al Boldi wrote: > > Antonino A. Daplas wrote: > > > On Wed, 2007-07-18 at 13:42 +0300, Al Boldi wrote: > > > > Geert Uytterhoeven wrote: > > > > > On Wed, 18 Jul 2007, Sasa Ostrouska wrote: > > > > > > > > Is there any technical reason

Re: System hangs on running kernbench

2007-07-18 Thread Dhaval Giani
Hi Andrew, On Wed, Jul 18, 2007 at 03:11:42PM +0530, Dhaval Giani wrote: > On Wed, Jul 18, 2007 at 01:07:00AM -0700, Andrew Morton wrote: > > On Wed, 18 Jul 2007 13:26:48 +0530 Dhaval Giani <[EMAIL PROTECTED]> wrote: > > > In the meantime I will go and check if it was there in 2.6.22-rc4-mm2 >

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
Hi Tejun, Thanks for tracking this down and fixing it. On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: There is a subtle bug in sysfs_create_link() failure path. When symlink creation fails because there's already a node with the same name, the target sysfs_dirent is put twice - once by

Re: 2.6.22 - Suspend and Weird Load Averages

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 16:50, Rafael J. Wysocki wrote: > On Wednesday, 18 July 2007 15:51, Parag Warudkar wrote: > > > > For the first time since 1997 I have a machine (Mac Mini) running a > > stock kernel which I am suspending/resuming for 2 days now without any > > problems. Amongst the

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-18 Thread Olaf Kirch
On Wednesday 18 July 2007 14:48, Ingo Molnar wrote: > something i noticed: netconsole output seems to trickle through though, > but very, very slowly (a packet once every 4 seconds or so). TCP/IP is > not functional. > > also, i'm using netconsole via the command line (both the network driver

Re: 2.6.22 - Suspend and Weird Load Averages

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 15:51, Parag Warudkar wrote: > > For the first time since 1997 I have a machine (Mac Mini) running a > stock kernel which I am suspending/resuming for 2 days now without any > problems. Amongst the various hardware and kernel versions that I've > used so far this

Re: Hibernation considerations

2007-07-18 Thread Rafael J. Wysocki
On Wednesday, 18 July 2007 16:29, Alan Stern wrote: > On Tue, 17 Jul 2007 [EMAIL PROTECTED] wrote: > > > On Tue, 17 Jul 2007, Alan Stern wrote: > > > > > On Tue, 17 Jul 2007 [EMAIL PROTECTED] wrote: > > > > > >>> But what about the freezer? The original reason for using kexec was to > > >>>

Re: [PATCH] fbdev: find mode with highest refresh rate in fb_find_mode()

2007-07-18 Thread Ondrej Zajicek
On Wed, Jul 18, 2007 at 10:41:02AM +0200, Michal Januszewski wrote: > Currently if the refresh rate is not specified fb_find_mode() returns > the first known video mode with the requested resoluion, which provides > no guarantees wrt the refresh rate. Change this so that the mode with > the

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-18 Thread Jan Engelhardt
On Jul 16 2007 18:15, Geert Uytterhoeven wrote: > >Add a Disk Storage Driver for the PS3: > - Implemented as a block device driver with a dynamic major > - Disk names (and partitions) are of the format ps3d%c(%u) > - Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor >

Re: [PATCH 2/2] net/core: some functions' definition order adjustment for readability

2007-07-18 Thread rae l
On 7/18/07, Patrick McHardy <[EMAIL PROTECTED]> wrote: This could be done in the patch moving it .. anyways, What? Denis Cheng wrote: > +#ifdef CONFIG_PROC_FS > +static void *dev_mc_seq_start(struct seq_file *seq, loff_t *pos) If you're interested in doing more work, it would be nice to

[2.6.22.1] spurious (?) message "BUG: lock held at task exit time"

2007-07-18 Thread Tilman Schmidt
When testing the serial Gigaset driver with kernel release 2.6.22.1 I get a kernel BUG message: = [ BUG: lock held at task exit time! ] - gigasetm101d/5970 is exiting with locks still held! 1 lock held by gigasetm101d/5970:

Re: Hibernation considerations

2007-07-18 Thread Alan Stern
On Tue, 17 Jul 2007 [EMAIL PROTECTED] wrote: > On Tue, 17 Jul 2007, Alan Stern wrote: > > > On Tue, 17 Jul 2007 [EMAIL PROTECTED] wrote: > > > >>> But what about the freezer? The original reason for using kexec was to > >>> avoid the need for the freezer. With no freezer, while the original >

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Miles Lane
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote: There is a subtle bug in sysfs_create_link() failure path. When symlink creation fails because there's already a node with the same name, the target sysfs_dirent is put twice - once by failure path of sysfs_create_link() and once more when the

Re: block/bsg.c

2007-07-18 Thread James Bottomley
On Wed, 2007-07-18 at 08:54 -0500, James Bottomley wrote: > You're welcome ... although there's still a problem for modular builds. > This is what my /sys/class/bsg looks like: Sorry, lets see if I can get the paste to work this time: [EMAIL PROTECTED]> ls /sys/class/bsg/ 0:0:1:0/ sdb/ > So

Re: [PATCH RFC] extent mapped page cache

2007-07-18 Thread Chris Mason
On Thu, 12 Jul 2007 00:00:28 -0700 Daniel Phillips <[EMAIL PROTECTED]> wrote: > On Tuesday 10 July 2007 14:03, Chris Mason wrote: > > This patch aims to demonstrate one way to replace buffer heads with > > a few extent trees... > > Hi Chris, > > Quite terse commentary on algorithms and data

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread Antonino A. Daplas
On Wed, 2007-07-18 at 16:45 +0300, Al Boldi wrote: > Antonino A. Daplas wrote: > > On Wed, 2007-07-18 at 13:42 +0300, Al Boldi wrote: > > > Geert Uytterhoeven wrote: > > > > On Wed, 18 Jul 2007, Sasa Ostrouska wrote: > > > > > > Is there any technical reason why vesafb shouldn't support non-BIOS >

Re: other potential candidates for removal?

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Jesper Juhl wrote: > On 18/07/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > >a while back, i threw together this wiki page: > > > > http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed > > > > feel free to comment. > > > Some comments on that list : > > }

[PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Jens Axboe
Hi, We have these checks scattered, makes sense to put them in set_page_dirty() instead. This also fixes a bug where __bio_unmap_user() does set_page_dirty_lock() without checking for a compound page, instead of adding one more check we move it to set_page_dirty(). Signed-off-by: Jens Axboe

Re: [PATCH] CFS: Fix missing digit off in wmult table

2007-07-18 Thread Roman Zippel
Hi, On Wed, 18 Jul 2007, Ingo Molnar wrote: > _changing_ it is an option within reason, and we've done it a couple of > times already in the past, and even within CFS (as Peter correctly > observed) we've been through a couple of iterations already. And as i > mentioned it before, the outer

Re: block/bsg.c

2007-07-18 Thread James Bottomley
On Wed, 2007-07-18 at 02:43 +0200, Bartlomiej Zolnierkiewicz wrote: > [ James, please remeber to cc: linux-ide on IDE patches, thanks. ] Blame Andrew ... I assumed he'd be reporting the problem to the relevant lists, so I just did a reply all ... > On Wednesday 18 July 2007, Jeff Garzik wrote: >

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Kumar Gala
On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: [EMAIL PROTECTED] We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file included

Re: [PATCH] Mark sparc and sparc64 as not having virt_to_bus

2007-07-18 Thread Mark Fortescue
Hi All, Currently, sun4c (and sun4m) do NOT support the FDC driver as a module. I did look at it but decided there were better issues to resolve at the time. A fix for this issue would either envolve a lot of work moving the low level assembly interrupt handler from arch/sparc/kernel/entry.S

Re: Determine version of kernel that produced vmcore

2007-07-18 Thread Ken'ichi Ohmichi
Hi, 2007/07/16 18:06:33 +0530, Vivek Goyal <[EMAIL PROTECTED]> wrote: >On Mon, Jul 16, 2007 at 02:28:54PM +0200, Bernhard Walle wrote: >> * Vivek Goyal <[EMAIL PROTECTED]> [2007-07-16 14:25]: >> > >> > Ok. Now there seems to be two ways for accessing such info. >> > - Through global variables

RE: Slow Soft-RAID 5 performance

2007-07-18 Thread koan
How did you create the ext3 filesystem? Did you use the appropriate --stride option as noted here: http://tldp.org/HOWTO/Software-RAID-HOWTO-5.html (#5.11) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] CFS: Fix missing digit off in wmult table

2007-07-18 Thread Roman Zippel
Hi, On Wed, 18 Jul 2007, Peter Zijlstra wrote: > The only expectation is that a process with a lower nice level gets more > time. Any other expectation is a bug. Yes, users are buggy, they expect a lot of stupid things... Is this really reason enough to break this? What exactly is the damage

Re: [PATCH] sysfs: make sysfs_init_inode() static

2007-07-18 Thread Jean Delvare
On Wed, 18 Jul 2007 14:30:28 +0900, Tejun Heo wrote: > With sysfs_fill_super() converted to use sysfs_get_inode(), there is > no user of sysfs_init_inode() outside of fs/sysfs/inode.c. Make it > static. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Looks good. Acked-by: Jean Delvare <[EMAIL

Re: other potential candidates for removal?

2007-07-18 Thread Jesper Juhl
On 18/07/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: a while back, i threw together this wiki page: http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed feel free to comment. Some comments on that list : } PCMCIA IOCTL support } } Currently listed in the removal file as

Re: [PATCH] sysfs: fix sysfs root inode nlink accounting

2007-07-18 Thread Jean Delvare
Hi Tejun, On Wed, 18 Jul 2007 14:29:06 +0900, Tejun Heo wrote: > While making sysfs indoes hashed, sysfs root inode was left out. Now > that nlink accounting depends on the inode being on the hash, sysfs > root inode nlink isn't adjusted properly. > > Put sysfs root inode on the inode hash by

Re: block/bsg.c

2007-07-18 Thread James Bottomley
On Wed, 2007-07-18 at 09:20 +0900, FUJITA Tomonori wrote: > From: James Bottomley <[EMAIL PROTECTED]> > Subject: Re: block/bsg.c > Date: Tue, 17 Jul 2007 13:53:54 -0500 > > > On Tue, 2007-07-17 at 12:19 +0200, Jens Axboe wrote: > > > > > Since Linus is happily snoring by now, could you test and

2.6.22 - Suspend and Weird Load Averages

2007-07-18 Thread Parag Warudkar
For the first time since 1997 I have a machine (Mac Mini) running a stock kernel which I am suspending/resuming for 2 days now without any problems. Amongst the various hardware and kernel versions that I've used so far this combination is the first to suspend/resume without issues! But one

Re: [patch] CFS scheduler, -v19

2007-07-18 Thread Bill Davidsen
Ingo Molnar wrote: * Ian Kent <[EMAIL PROTECTED]> wrote: ah! It passes in a low-res time source into a high-res time interface (pthread_cond_timedwait()). Could you change the time(NULL) + 1 to time(NULL) + 2, or change it to: gettimeofday(, NULL); wait.tv_sec++; does

XFS -git changes and Linux-VServer patch porting

2007-07-18 Thread Radoslaw Szkodzinski
Linux-VServer patch adds 2 new flags: barrier and iunlink. With recent changes in -git (filestreams), XFS now lacks di_flags bits to add these. iunlink flag adds Copy-on-Write semantics to hard links, while barrier flag signifies a filesystem barrier no virtual context can pass. I'd like to know

Re: [PATCH] CFS: Fix missing digit off in wmult table

2007-07-18 Thread Ingo Molnar
* Roman Zippel <[EMAIL PROTECTED]> wrote: > > By breaking the UNIX model of nice levels. Not an option in my book. > > Breaking user expectations of nice levels is? _changing_ it is an option within reason, and we've done it a couple of times already in the past, and even within CFS (as Peter

Re: other potential candidates for removal?

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Clemens Koller wrote: > Robert P. J. Day schrieb: > >a while back, i threw together this wiki page: > > > > http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed > > > > feel free to comment. > > Won't miss anything there. > However, removal of kernel_threads() needs

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread Al Boldi
Antonino A. Daplas wrote: > On Wed, 2007-07-18 at 13:42 +0300, Al Boldi wrote: > > Geert Uytterhoeven wrote: > > > On Wed, 18 Jul 2007, Sasa Ostrouska wrote: > > > > Is there any technical reason why vesafb shouldn't support non-BIOS > > modes? > > vesafb can only use modes included by the vendor

[GIT PULL] ext4 update

2007-07-18 Thread Theodore Ts'o
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus It contains the following feature enhancements, including support for the new fallocate() system call. These have been in -mm for a while, consensus reached for the fallocate() interface

Re: other potential candidates for removal?

2007-07-18 Thread Clemens Koller
Robert P. J. Day schrieb: a while back, i threw together this wiki page: http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed feel free to comment. Won't miss anything there. However, removal of kernel_threads() needs some updated drivers... Regards, -- Clemens Koller

Re: i386: pata_cs5520 does not work

2007-07-18 Thread Alan Cox
> > I'll take a look at this next week. Can you send me a dmesg of the > > working case and an lspci -vvxxx > > Thanks. attached 2 dmesgs(2.6.21 with pata_cs5520, 2.6.22 with IDE) and > output of lspci. Nothing obviously wrong. What happens if you find the line if (!iomap[0] || !iomap[1] ||

<    1   2   3   4   5   6   7   8   9   10   >